)]}'
{"trove/common/strategies/cluster/experimental/mongodb/taskmanager.py":[{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"a591215e95efca4a711592bf4acd9dbdb432434d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def get_key(self, member):"},{"line_number":99,"context_line":"        return self.get_guest(member).get_key()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def create_cluster(self, context, cluster_id, root_password):"},{"line_number":102,"context_line":"        LOG.debug(\"begin create_cluster for id: %s\" % cluster_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        def _create_cluster():"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_017b13f6","line":101,"updated":"2015-08-31 12:55:19.000000000","message":"This needs to be updated in the caller.","commit_id":"d88a4a662065ed6e5c6ea260b40985fd1092fe41"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"303ca5f3c14ffa9cc7195c362a9ea83bd8d4ade5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def get_key(self, member):"},{"line_number":99,"context_line":"        return self.get_guest(member).get_key()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def create_cluster(self, context, cluster_id, root_password):"},{"line_number":102,"context_line":"        LOG.debug(\"begin create_cluster for id: %s\" % cluster_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        def _create_cluster():"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_ff4d4ac4","line":101,"in_reply_to":"da20952f_017b13f6","updated":"2015-08-31 16:49:06.000000000","message":"Actually, since mongo doesn\u0027t support root enablement this should just be removed.","commit_id":"d88a4a662065ed6e5c6ea260b40985fd1092fe41"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"dd9419107816bd0610608466c345bc8a5f48cd80","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def get_key(self, member):"},{"line_number":99,"context_line":"        return self.get_guest(member).get_key()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def create_cluster(self, context, cluster_id, root_password):"},{"line_number":102,"context_line":"        LOG.debug(\"begin create_cluster for id: %s\" % cluster_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        def _create_cluster():"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_79ef111e","line":101,"in_reply_to":"da20952f_3fa7410c","updated":"2015-08-31 19:18:13.000000000","message":"We could pass through extended properties a bit deeper. I think that at some point we want to pull out the properties we care about, like root_password, and make those proper function arguments. Where that point is though, I\u0027m not sure.","commit_id":"d88a4a662065ed6e5c6ea260b40985fd1092fe41"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"93c7ef16814622632500e60aae1edce6d4490d6b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def get_key(self, member):"},{"line_number":99,"context_line":"        return self.get_guest(member).get_key()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def create_cluster(self, context, cluster_id, root_password):"},{"line_number":102,"context_line":"        LOG.debug(\"begin create_cluster for id: %s\" % cluster_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        def _create_cluster():"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_680e588d","line":101,"in_reply_to":"da20952f_79a711bd","updated":"2015-08-31 20:16:35.000000000","message":"Ok - have a look at the incoming patchset.","commit_id":"d88a4a662065ed6e5c6ea260b40985fd1092fe41"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"77e6ac1b5cc7c6ea4c5b0338de7f8a0a548c5f53","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def get_key(self, member):"},{"line_number":99,"context_line":"        return self.get_guest(member).get_key()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def create_cluster(self, context, cluster_id, root_password):"},{"line_number":102,"context_line":"        LOG.debug(\"begin create_cluster for id: %s\" % cluster_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        def _create_cluster():"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_79a711bd","line":101,"in_reply_to":"da20952f_79ef111e","updated":"2015-08-31 19:24:14.000000000","message":"That point should be where the datastore-specific guest/taskmanager calls are. The call from api to taskmanager create_cluster is not there yet.","commit_id":"d88a4a662065ed6e5c6ea260b40985fd1092fe41"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"2065bfe6f8f86e5078d36d41685e96e6df5b1bea","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def get_key(self, member):"},{"line_number":99,"context_line":"        return self.get_guest(member).get_key()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def create_cluster(self, context, cluster_id, root_password):"},{"line_number":102,"context_line":"        LOG.debug(\"begin create_cluster for id: %s\" % cluster_id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        def _create_cluster():"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_3fa7410c","line":101,"in_reply_to":"da20952f_ff4d4ac4","updated":"2015-08-31 16:58:20.000000000","message":"Jonathan - this is cast from the base taskmanager class, so the signature needs to match. The caller (in mongodb/api.py) needs to pass some value that will just be ignored.","commit_id":"d88a4a662065ed6e5c6ea260b40985fd1092fe41"}]}