)]}'
{"trove/common/strategies/cluster/experimental/pxc/api.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d256ed54d8dcef48373d043e666c2719a80164af","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        num_instances \u003d len(instances)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Check at least number of instances with config cluster_member_count"},{"line_number":63,"context_line":"        if num_instances \u003c pxc_conf.cluster_member_count:"},{"line_number":64,"context_line":"            raise exception.ClusterNumInstancesNotGreater("},{"line_number":65,"context_line":"                num_instances\u003dpxc_conf.cluster_member_count)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_846ae7b3","line":63,"updated":"2015-09-23 20:05:50.000000000","message":"Shouldn\u0027t this be \u003c\u003d?","commit_id":"653036bf8fe05d8348f45e5eecdea03bc889950e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"619265f957369ede9b577ed074eecf4f9e0f90c2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        num_instances \u003d len(instances)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Check at least number of instances with config cluster_member_count"},{"line_number":63,"context_line":"        if num_instances \u003c pxc_conf.cluster_member_count:"},{"line_number":64,"context_line":"            raise exception.ClusterNumInstancesNotGreater("},{"line_number":65,"context_line":"                num_instances\u003dpxc_conf.cluster_member_count)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_df23c1bb","line":63,"in_reply_to":"ba15a1d1_845427c6","updated":"2015-09-24 01:12:37.000000000","message":"true that, thanks","commit_id":"653036bf8fe05d8348f45e5eecdea03bc889950e"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"530d79a4e4222297090eef5b6125947af2f539b7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        num_instances \u003d len(instances)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Check at least number of instances with config cluster_member_count"},{"line_number":63,"context_line":"        if num_instances \u003c pxc_conf.cluster_member_count:"},{"line_number":64,"context_line":"            raise exception.ClusterNumInstancesNotGreater("},{"line_number":65,"context_line":"                num_instances\u003dpxc_conf.cluster_member_count)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_845427c6","line":63,"in_reply_to":"ba15a1d1_846ae7b3","updated":"2015-09-23 20:09:18.000000000","message":"Just \u003c is correct in the case of an error because when num_instances is equal it is fine.","commit_id":"653036bf8fe05d8348f45e5eecdea03bc889950e"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"530d79a4e4222297090eef5b6125947af2f539b7","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Check at least number of instances with config cluster_member_count"},{"line_number":63,"context_line":"        if num_instances \u003c pxc_conf.cluster_member_count:"},{"line_number":64,"context_line":"            raise exception.ClusterNumInstancesNotGreater("},{"line_number":65,"context_line":"                num_instances\u003dpxc_conf.cluster_member_count)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Checking flavors"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_045257de","line":64,"range":{"start_line":64,"start_character":28,"end_line":64,"end_character":57},"updated":"2015-09-23 20:09:18.000000000","message":"Should this be named ClusterNumInstancesNotGreaterorEqual?","commit_id":"653036bf8fe05d8348f45e5eecdea03bc889950e"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"25e7f0d9e8127cd0ee71365846564099d98e31fd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # Check at least number of instances with config cluster_member_count"},{"line_number":63,"context_line":"        if num_instances \u003c pxc_conf.cluster_member_count:"},{"line_number":64,"context_line":"            raise exception.ClusterNumInstancesNotGreater("},{"line_number":65,"context_line":"                num_instances\u003dpxc_conf.cluster_member_count)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Checking flavors"},{"line_number":68,"context_line":"        flavor_ids \u003d [instance[\u0027flavor_id\u0027] for instance in instances]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_1953a318","line":65,"range":{"start_line":65,"start_character":39,"end_line":65,"end_character":59},"updated":"2015-09-23 18:20:33.000000000","message":"Should this be changed to min_cluster_member_count then ?","commit_id":"653036bf8fe05d8348f45e5eecdea03bc889950e"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"aee383eb11df8d9501dd1966c66062abb1b972f3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # Check at least number of instances with config cluster_member_count"},{"line_number":63,"context_line":"        if num_instances \u003c pxc_conf.cluster_member_count:"},{"line_number":64,"context_line":"            raise exception.ClusterNumInstancesNotGreater("},{"line_number":65,"context_line":"                num_instances\u003dpxc_conf.cluster_member_count)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Checking flavors"},{"line_number":68,"context_line":"        flavor_ids \u003d [instance[\u0027flavor_id\u0027] for instance in instances]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_59befbae","line":65,"range":{"start_line":65,"start_character":39,"end_line":65,"end_character":59},"in_reply_to":"ba15a1d1_1953a318","updated":"2015-09-23 18:36:05.000000000","message":"Yeah min_cluster_member_count is definitely easier to understand from the standpoint of a config file. Otherwise it won\u0027t be obvious that you can go greater than that count.","commit_id":"653036bf8fe05d8348f45e5eecdea03bc889950e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d256ed54d8dcef48373d043e666c2719a80164af","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # Check at least number of instances with config cluster_member_count"},{"line_number":63,"context_line":"        if num_instances \u003c pxc_conf.cluster_member_count:"},{"line_number":64,"context_line":"            raise exception.ClusterNumInstancesNotGreater("},{"line_number":65,"context_line":"                num_instances\u003dpxc_conf.cluster_member_count)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Checking flavors"},{"line_number":68,"context_line":"        flavor_ids \u003d [instance[\u0027flavor_id\u0027] for instance in instances]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_64ad53e8","line":65,"in_reply_to":"ba15a1d1_59befbae","updated":"2015-09-23 20:05:50.000000000","message":"Agree with this","commit_id":"653036bf8fe05d8348f45e5eecdea03bc889950e"}]}