)]}'
{"trove/common/exception.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"e44cd4a798a4b497dcd3152b99ba30164c9673e9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"class DatastoreFlavorAssociationNotFound(NotFound):"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    message \u003d _(\"Flavor %(flavor_id)s is not supported for datastore \""},{"line_number":125,"context_line":"                \"%(datastore)s version %(version_id)s\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class DatastoreFlavorAssociationAlreadyExists(TroveError):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_b15beef5","line":125,"range":{"start_line":125,"start_character":41,"end_line":125,"end_character":51},"updated":"2015-09-22 15:01:23.000000000","message":"If we\u0027re changing this, wouldn\u0027t it make sense to have the variables named the same?","commit_id":"29cdee3d026266aab437b5007bbb301e63c83c1c"}],"trove/datastore/models.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"c5e1ff97a93d75ddb790101c8eacd17accff53a2","unresolved":false,"context_lines":[{"line_number":568,"context_line":"                db_record.save()"},{"line_number":569,"context_line":"                return"},{"line_number":570,"context_line":"            else:"},{"line_number":571,"context_line":"                raise exception_class("},{"line_number":572,"context_line":"                    datastore\u003ddatastore_name,"},{"line_number":573,"context_line":"                    datastore_version\u003ddatastore_version_name,"},{"line_number":574,"context_line":"                    flavor_id\u003dvalue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_b9d686c1","line":571,"updated":"2015-09-22 10:30:26.000000000","message":"This whole construct of an exception_class as a parameter is nice and all but the construct seems to break down when the two classes have different parameters and the code launching the exception (such as here) is tailored to one class. For example, it makes no sense for the _add method to generate the exception \"mapping not found\" and it makes no sense for the _delete method to generate the exception \"mapping already exists\".","commit_id":"29cdee3d026266aab437b5007bbb301e63c83c1c"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"c5e1ff97a93d75ddb790101c8eacd17accff53a2","unresolved":false,"context_lines":[{"line_number":593,"context_line":"                    datastore_version_id\u003ddatastore_version_id,"},{"line_number":594,"context_line":"                    flavor_id\u003dvalue)"},{"line_number":595,"context_line":"        except exception.ModelNotFoundError:"},{"line_number":596,"context_line":"            raise exception_class(datastore_version_id\u003ddatastore_version_id,"},{"line_number":597,"context_line":"                                  flavor_id\u003dvalue)"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_d9fd7a6f","line":596,"updated":"2015-09-22 10:30:26.000000000","message":"Aren\u0027t you short a parameter here?","commit_id":"29cdee3d026266aab437b5007bbb301e63c83c1c"}]}