)]}'
{"trove/tests/unittests/guestagent/test_backups.py":[{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"4ca6d4e463b71012b4b00e1907c5144a1f4295b2","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @mock.patch.object(MongoDBApp, \u0027_init_overrides_dir\u0027)"},{"line_number":339,"context_line":"    def test_backup_encrypted_mongodump_command(self, _):"},{"line_number":340,"context_line":"        backupBase.BackupRunner.is_zipped \u003d True"},{"line_number":341,"context_line":"        backupBase.BackupRunner.is_encrypted \u003d True"},{"line_number":342,"context_line":"        backupBase.BackupRunner.encrypt_key \u003d CRYPTO_KEY"},{"line_number":343,"context_line":"        RunnerClass \u003d utils.import_class(BACKUP_MONGODUMP_CLS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_16dabf78","line":340,"range":{"start_line":340,"start_character":6,"end_line":340,"end_character":48},"updated":"2015-09-28 17:33:21.000000000","message":"Why not put this line in the setup? Then you do not need to duplicate it on every test. Then remove it on every test that is currently calling this. This will make it easier to write tests for this class in the future because right now someone would have to know that you have to set is_zipped to True.","commit_id":"af2bdb37affc6de47b6df0f3cb0431d15203d888"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d12846d830f2d4cce5d0a39cbd0e2fa3bbfe390d","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @mock.patch.object(MongoDBApp, \u0027_init_overrides_dir\u0027)"},{"line_number":339,"context_line":"    def test_backup_encrypted_mongodump_command(self, _):"},{"line_number":340,"context_line":"        backupBase.BackupRunner.is_zipped \u003d True"},{"line_number":341,"context_line":"        backupBase.BackupRunner.is_encrypted \u003d True"},{"line_number":342,"context_line":"        backupBase.BackupRunner.encrypt_key \u003d CRYPTO_KEY"},{"line_number":343,"context_line":"        RunnerClass \u003d utils.import_class(BACKUP_MONGODUMP_CLS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_db79c3c9","line":340,"in_reply_to":"9a1a9d01_16dabf78","updated":"2015-09-28 23:23:27.000000000","message":"Same concern. This property should be always be True.","commit_id":"af2bdb37affc6de47b6df0f3cb0431d15203d888"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"f63876b1ad34690f3d6b6ea148a000a361a78b33","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @mock.patch.object(MongoDBApp, \u0027_init_overrides_dir\u0027)"},{"line_number":339,"context_line":"    def test_backup_encrypted_mongodump_command(self, _):"},{"line_number":340,"context_line":"        backupBase.BackupRunner.is_zipped \u003d True"},{"line_number":341,"context_line":"        backupBase.BackupRunner.is_encrypted \u003d True"},{"line_number":342,"context_line":"        backupBase.BackupRunner.encrypt_key \u003d CRYPTO_KEY"},{"line_number":343,"context_line":"        RunnerClass \u003d utils.import_class(BACKUP_MONGODUMP_CLS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_80a12596","line":340,"in_reply_to":"9a1a9d01_2ccfddb4","updated":"2015-10-10 21:58:50.000000000","message":"Agreed - Latest patch set moves all the is_zipped\u003dtrue and is_encrypted\u003dtrue assignments into setup().","commit_id":"af2bdb37affc6de47b6df0f3cb0431d15203d888"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"5c2095ae8e3d08d1e01360795604acd0ed0175c0","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @mock.patch.object(MongoDBApp, \u0027_init_overrides_dir\u0027)"},{"line_number":339,"context_line":"    def test_backup_encrypted_mongodump_command(self, _):"},{"line_number":340,"context_line":"        backupBase.BackupRunner.is_zipped \u003d True"},{"line_number":341,"context_line":"        backupBase.BackupRunner.is_encrypted \u003d True"},{"line_number":342,"context_line":"        backupBase.BackupRunner.encrypt_key \u003d CRYPTO_KEY"},{"line_number":343,"context_line":"        RunnerClass \u003d utils.import_class(BACKUP_MONGODUMP_CLS)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_2ccfddb4","line":340,"in_reply_to":"9a1a9d01_db79c3c9","updated":"2015-10-01 17:24:35.000000000","message":"Agree","commit_id":"af2bdb37affc6de47b6df0f3cb0431d15203d888"}]}