)]}'
{"trove/common/instance.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"63739724a1e3d2c013658eb086f77c02832828db","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    DELETED \u003d ServiceStatus(0x05, \u0027deleted\u0027, \u0027DELETED\u0027)"},{"line_number":99,"context_line":"    FAILED_TIMEOUT_GUESTAGENT \u003d ServiceStatus(0x18, \u0027guestagent error\u0027,"},{"line_number":100,"context_line":"                                              \u0027ERROR\u0027)"},{"line_number":101,"context_line":"    INSTANCE_READY \u003d ServiceStatus(0x19, \u0027instance ready\u0027, \u0027BUILD\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Dissuade further additions at run-time."},{"line_number":104,"context_line":"ServiceStatus.__init__ \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_d32d5047","line":101,"updated":"2015-10-30 06:56:14.000000000","message":"I\u0027m not sure i like the term READY in this context. But i right now i dont have any better suggestion.","commit_id":"1faa4d427d5fec782e740a2095dc6629bb8a33d7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d91e6c50323bb75cae9ad56bd1fe6c6bce84a54f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    DELETED \u003d ServiceStatus(0x05, \u0027deleted\u0027, \u0027DELETED\u0027)"},{"line_number":99,"context_line":"    FAILED_TIMEOUT_GUESTAGENT \u003d ServiceStatus(0x18, \u0027guestagent error\u0027,"},{"line_number":100,"context_line":"                                              \u0027ERROR\u0027)"},{"line_number":101,"context_line":"    INSTANCE_READY \u003d ServiceStatus(0x19, \u0027instance ready\u0027, \u0027BUILD\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Dissuade further additions at run-time."},{"line_number":104,"context_line":"ServiceStatus.__init__ \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_d37a30f1","line":101,"updated":"2015-10-30 06:46:02.000000000","message":"If all you are doing is changing the name, that\u0027s fine. I don\u0027t know whether the name is good or bad but as long as you are not changing the meaning or semantics, I\u0027m fine with it.","commit_id":"1faa4d427d5fec782e740a2095dc6629bb8a33d7"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c45ee8a76d6114d0a2876746bd57131293fc719c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    DELETED \u003d ServiceStatus(0x05, \u0027deleted\u0027, \u0027DELETED\u0027)"},{"line_number":99,"context_line":"    FAILED_TIMEOUT_GUESTAGENT \u003d ServiceStatus(0x18, \u0027guestagent error\u0027,"},{"line_number":100,"context_line":"                                              \u0027ERROR\u0027)"},{"line_number":101,"context_line":"    INSTANCE_READY \u003d ServiceStatus(0x19, \u0027instance ready\u0027, \u0027BUILD\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Dissuade further additions at run-time."},{"line_number":104,"context_line":"ServiceStatus.__init__ \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_4c7f3e66","line":101,"in_reply_to":"1a26ad4f_d32d5047","updated":"2015-10-31 19:58:17.000000000","message":"The only place this should be visible is in the code (I never really grocked how BUILD_PENDING meant that prepare was done and the only thing left was to \u0027stitch\u0027 multiple instances together).\n\nThat said, I\u0027m open to a different name (but keep in mind this is only seen in the code - the displayed value is still \u0027BUILD\u0027).","commit_id":"1faa4d427d5fec782e740a2095dc6629bb8a33d7"}],"trove/guestagent/datastore/manager.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"49ec3e3a6fa46f29a7e2292c7349b200ea93bced","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        post_processing \u003d True if cluster_config else False"},{"line_number":129,"context_line":"        try:"},{"line_number":130,"context_line":"            LOG.debug(\u0027Calling pre_prepare.\u0027)"},{"line_number":131,"context_line":"            self.pre_prepare(context, packages, databases, memory_mb,"},{"line_number":132,"context_line":"                             users, device_path, mount_point, backup_info,"},{"line_number":133,"context_line":"                             config_contents, root_password, overrides,"},{"line_number":134,"context_line":"                             cluster_config, snapshot)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_7ee1c599","line":131,"range":{"start_line":131,"start_character":17,"end_line":131,"end_character":28},"updated":"2015-10-29 03:47:57.000000000","message":"doesnt seem like pre_prepare is necessary when there is already a do_prepare.","commit_id":"bdc0783b61aca78438e06e96376344afb453ec3a"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"fcfb7d03e52967ebefd97d78d25ee4c76ef6434f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        post_processing \u003d True if cluster_config else False"},{"line_number":129,"context_line":"        try:"},{"line_number":130,"context_line":"            LOG.debug(\u0027Calling pre_prepare.\u0027)"},{"line_number":131,"context_line":"            self.pre_prepare(context, packages, databases, memory_mb,"},{"line_number":132,"context_line":"                             users, device_path, mount_point, backup_info,"},{"line_number":133,"context_line":"                             config_contents, root_password, overrides,"},{"line_number":134,"context_line":"                             cluster_config, snapshot)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_aadcf7e4","line":131,"range":{"start_line":131,"start_character":17,"end_line":131,"end_character":28},"in_reply_to":"1a26ad4f_7ee1c599","updated":"2015-10-29 06:32:36.000000000","message":"Done","commit_id":"bdc0783b61aca78438e06e96376344afb453ec3a"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"49ec3e3a6fa46f29a7e2292c7349b200ea93bced","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            LOG.info(_(\"Ending datastore prepare for \u0027%s\u0027.\") % self.manager)"},{"line_number":146,"context_line":"            self.status.end_install(error_occurred\u003dself.prepare_error,"},{"line_number":147,"context_line":"                                    post_processing\u003dpost_processing)"},{"line_number":148,"context_line":"        LOG.info(_(\u0027Completed setup of datastore successfully.\u0027))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            if self.prepare_adds_databases and databases:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_be699d27","line":148,"updated":"2015-10-29 03:47:57.000000000","message":"Let us know that this is the point that the instance goes \"ACTIVE\"","commit_id":"bdc0783b61aca78438e06e96376344afb453ec3a"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"fcfb7d03e52967ebefd97d78d25ee4c76ef6434f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            LOG.info(_(\"Ending datastore prepare for \u0027%s\u0027.\") % self.manager)"},{"line_number":146,"context_line":"            self.status.end_install(error_occurred\u003dself.prepare_error,"},{"line_number":147,"context_line":"                                    post_processing\u003dpost_processing)"},{"line_number":148,"context_line":"        LOG.info(_(\u0027Completed setup of datastore successfully.\u0027))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            if self.prepare_adds_databases and databases:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_cad7f3bd","line":148,"in_reply_to":"1a26ad4f_be699d27","updated":"2015-10-29 06:32:36.000000000","message":"Done","commit_id":"bdc0783b61aca78438e06e96376344afb453ec3a"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"49ec3e3a6fa46f29a7e2292c7349b200ea93bced","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        LOG.info(_(\u0027Completed setup of datastore successfully.\u0027))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            if self.prepare_adds_databases and databases:"},{"line_number":152,"context_line":"                LOG.debug(\u0027Calling add databases.\u0027)"},{"line_number":153,"context_line":"                self.create_database(context, databases)"},{"line_number":154,"context_line":"            if self.prepare_adds_users and users:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_be851dae","line":151,"updated":"2015-10-29 03:47:57.000000000","message":"remove property check for databases and users.","commit_id":"bdc0783b61aca78438e06e96376344afb453ec3a"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"fcfb7d03e52967ebefd97d78d25ee4c76ef6434f","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        LOG.info(_(\u0027Completed setup of datastore successfully.\u0027))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            if self.prepare_adds_databases and databases:"},{"line_number":152,"context_line":"                LOG.debug(\u0027Calling add databases.\u0027)"},{"line_number":153,"context_line":"                self.create_database(context, databases)"},{"line_number":154,"context_line":"            if self.prepare_adds_users and users:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_6ae6dfb5","line":151,"in_reply_to":"1a26ad4f_be851dae","updated":"2015-10-29 06:32:36.000000000","message":"Done","commit_id":"bdc0783b61aca78438e06e96376344afb453ec3a"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d91e6c50323bb75cae9ad56bd1fe6c6bce84a54f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Tesora, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_0e571fcf","line":1,"updated":"2015-10-30 06:46:02.000000000","message":"2015 ;)","commit_id":"1faa4d427d5fec782e740a2095dc6629bb8a33d7"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c45ee8a76d6114d0a2876746bd57131293fc719c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Tesora, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_ccb4ae36","line":1,"in_reply_to":"1a26ad4f_0e571fcf","updated":"2015-10-31 19:58:17.000000000","message":"Yeah, I don\u0027t want to hold up the changeset for this, but that\u0027s probably a copy-paste issue. :(  I\u0027ll fix it in the dependent changeset. :D","commit_id":"1faa4d427d5fec782e740a2095dc6629bb8a33d7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d91e6c50323bb75cae9ad56bd1fe6c6bce84a54f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def manager(self):"},{"line_number":52,"context_line":"        \"\"\"This returns the name of the manager.\"\"\""},{"line_number":53,"context_line":"        if not self.__manager:"},{"line_number":54,"context_line":"            self.__manager \u003d CONF.datastore_manager or self.__manager_name"},{"line_number":55,"context_line":"        return self.__manager"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_ee93c34d","line":54,"updated":"2015-10-30 06:46:02.000000000","message":"shouldn\u0027t this be\n\nCONF.datastore_manager or self.__manager_name or \u0027mysql\u0027\n\nAlso, I\u0027m curious about this because you seem to prefer CONF.datastore_manager to self.__manager_name.","commit_id":"1faa4d427d5fec782e740a2095dc6629bb8a33d7"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c45ee8a76d6114d0a2876746bd57131293fc719c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def manager(self):"},{"line_number":52,"context_line":"        \"\"\"This returns the name of the manager.\"\"\""},{"line_number":53,"context_line":"        if not self.__manager:"},{"line_number":54,"context_line":"            self.__manager \u003d CONF.datastore_manager or self.__manager_name"},{"line_number":55,"context_line":"        return self.__manager"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_ecb16a48","line":54,"in_reply_to":"1a26ad4f_ee93c34d","updated":"2015-10-31 19:58:17.000000000","message":"self.__manager_name is set from the constructor (so it will always exist) and in the case of mysql derivatives, it\u0027s passed in as \u0027mysql\u0027\n\nAs for why CONF.datastore_manager is preferred, that\u0027s how all the managers were set up, so I continued with it.  If we in the future determine it\u0027s better a different way, at least there\u0027s only one place to change the code now. ;)","commit_id":"1faa4d427d5fec782e740a2095dc6629bb8a33d7"}]}