)]}'
{"trove/common/utils.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"af12f6835d38fbe80136d3aec32b9eee6e1f14fa","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                         ]))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def pagination_limit(limit, default_limit):"},{"line_number":58,"context_line":"    if limit \u003e default_limit:"},{"line_number":59,"context_line":"        limit \u003d default_limit"},{"line_number":60,"context_line":"    return default_limit"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_64927859","line":57,"updated":"2015-10-15 03:16:44.000000000","message":"what are these limits? numbers? if so, couldn\u0027t we just use \u0027min(...)\u0027 instead of introducing a new function?","commit_id":"e0374875db88d05585caffd9ae08ad29c7e629d2"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"af12f6835d38fbe80136d3aec32b9eee6e1f14fa","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def pagination_limit(limit, default_limit):"},{"line_number":58,"context_line":"    if limit \u003e default_limit:"},{"line_number":59,"context_line":"        limit \u003d default_limit"},{"line_number":60,"context_line":"    return default_limit"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_44d09c1f","line":59,"updated":"2015-10-15 03:16:44.000000000","message":"Local assignment?","commit_id":"e0374875db88d05585caffd9ae08ad29c7e629d2"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3222f1ae19edb4e0761d20b5d52b71e63cf864ea","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                         ]))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def pagination_limit(context_limit, default_limit):"},{"line_number":58,"context_line":"    limit \u003d int(specific_limit or default_limit)"},{"line_number":59,"context_line":"    return min(limit, default_limit)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_2bead2db","line":57,"range":{"start_line":57,"start_character":21,"end_line":57,"end_character":34},"updated":"2015-10-16 03:44:28.000000000","message":"Maybe just call this \u0027limit\u0027","commit_id":"d86c70dda88cd4d6f380eea5611b162a076bf706"},{"author":{"_account_id":17360,"name":"Ishita Mandhan","email":"imandha@us.ibm.com","username":"imandhan"},"change_message_id":"b9cde01207bd4e7b973f4ed417d3cff329b976fd","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                         ]))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def pagination_limit(context_limit, default_limit):"},{"line_number":58,"context_line":"    limit \u003d int(specific_limit or default_limit)"},{"line_number":59,"context_line":"    return min(limit, default_limit)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_096a7dee","line":57,"in_reply_to":"5a2ca52d_2bead2db","updated":"2015-10-16 06:48:56.000000000","message":"Done","commit_id":"d86c70dda88cd4d6f380eea5611b162a076bf706"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3222f1ae19edb4e0761d20b5d52b71e63cf864ea","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def pagination_limit(context_limit, default_limit):"},{"line_number":58,"context_line":"    limit \u003d int(specific_limit or default_limit)"},{"line_number":59,"context_line":"    return min(limit, default_limit)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_4be70e11","line":58,"range":{"start_line":58,"start_character":16,"end_line":58,"end_character":30},"updated":"2015-10-16 03:44:28.000000000","message":"This must be a type ... I believe this should be \u0027context_limit\u0027 (or if you take my suggestion, just \u0027limit\u0027)","commit_id":"d86c70dda88cd4d6f380eea5611b162a076bf706"},{"author":{"_account_id":17360,"name":"Ishita Mandhan","email":"imandha@us.ibm.com","username":"imandhan"},"change_message_id":"b9cde01207bd4e7b973f4ed417d3cff329b976fd","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def pagination_limit(context_limit, default_limit):"},{"line_number":58,"context_line":"    limit \u003d int(specific_limit or default_limit)"},{"line_number":59,"context_line":"    return min(limit, default_limit)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_a96a69eb","line":58,"in_reply_to":"5a2ca52d_4be70e11","updated":"2015-10-16 06:48:56.000000000","message":"Done","commit_id":"d86c70dda88cd4d6f380eea5611b162a076bf706"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"71e5b4b56acd7f5594965d0e4cb9a1051315961a","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def pagination_limit(context_limit, default_limit):"},{"line_number":58,"context_line":"    limit \u003d int(specific_limit or default_limit)"},{"line_number":59,"context_line":"    return min(limit, default_limit)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_eb47fab9","line":58,"range":{"start_line":58,"start_character":16,"end_line":58,"end_character":30},"in_reply_to":"5a2ca52d_4be70e11","updated":"2015-10-16 03:45:51.000000000","message":"s/type/typo/  ;)","commit_id":"d86c70dda88cd4d6f380eea5611b162a076bf706"},{"author":{"_account_id":17360,"name":"Ishita Mandhan","email":"imandha@us.ibm.com","username":"imandhan"},"change_message_id":"b9cde01207bd4e7b973f4ed417d3cff329b976fd","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def pagination_limit(context_limit, default_limit):"},{"line_number":58,"context_line":"    limit \u003d int(specific_limit or default_limit)"},{"line_number":59,"context_line":"    return min(limit, default_limit)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_6979b1c7","line":58,"in_reply_to":"5a2ca52d_eb47fab9","updated":"2015-10-16 06:48:56.000000000","message":"Done","commit_id":"d86c70dda88cd4d6f380eea5611b162a076bf706"}],"trove/tests/unittests/common/test_utils.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1d547f189a063219641c2a2deb37c56b9cc3faac","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.assertEqual([\u0027a\u0027, \u0027b\u0027], utils.unpack_singleton([\u0027a\u0027, \u0027b\u0027]))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_pagination_limit(self):"},{"line_number":80,"context_line":"        self.assertEqual(5, utils.pagination_limit(5,9))"},{"line_number":81,"context_line":"        self.assertEqual(5, utils.pagination_limit(9,5))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_cc0b3323","line":80,"range":{"start_line":80,"start_character":53,"end_line":80,"end_character":54},"updated":"2015-10-16 06:57:15.000000000","message":"Darn pep8 - missing a space here!","commit_id":"dffe3c8a1305d2bb932f9f4b52907a347ca30f5c"},{"author":{"_account_id":17360,"name":"Ishita Mandhan","email":"imandha@us.ibm.com","username":"imandhan"},"change_message_id":"0d74b6518784d940a097dfc7cced2609922d376a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.assertEqual([\u0027a\u0027, \u0027b\u0027], utils.unpack_singleton([\u0027a\u0027, \u0027b\u0027]))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_pagination_limit(self):"},{"line_number":80,"context_line":"        self.assertEqual(5, utils.pagination_limit(5,9))"},{"line_number":81,"context_line":"        self.assertEqual(5, utils.pagination_limit(9,5))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_cc88fdc7","line":80,"in_reply_to":"5a2ca52d_cc0b3323","updated":"2015-10-16 15:13:05.000000000","message":"Done","commit_id":"dffe3c8a1305d2bb932f9f4b52907a347ca30f5c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1d547f189a063219641c2a2deb37c56b9cc3faac","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_pagination_limit(self):"},{"line_number":80,"context_line":"        self.assertEqual(5, utils.pagination_limit(5,9))"},{"line_number":81,"context_line":"        self.assertEqual(5, utils.pagination_limit(9,5))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_ec270fb4","line":81,"range":{"start_line":81,"start_character":53,"end_line":81,"end_character":54},"updated":"2015-10-16 06:57:15.000000000","message":"ditto","commit_id":"dffe3c8a1305d2bb932f9f4b52907a347ca30f5c"},{"author":{"_account_id":17360,"name":"Ishita Mandhan","email":"imandha@us.ibm.com","username":"imandhan"},"change_message_id":"0d74b6518784d940a097dfc7cced2609922d376a","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_pagination_limit(self):"},{"line_number":80,"context_line":"        self.assertEqual(5, utils.pagination_limit(5,9))"},{"line_number":81,"context_line":"        self.assertEqual(5, utils.pagination_limit(9,5))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_6c91a9f0","line":81,"in_reply_to":"5a2ca52d_ec270fb4","updated":"2015-10-16 15:13:05.000000000","message":"Done","commit_id":"dffe3c8a1305d2bb932f9f4b52907a347ca30f5c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c5a36d4af20c3ca90220ac76bcf22e36b0047ede","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a2ca52d_2ffad943","line":82,"updated":"2015-10-16 07:50:41.000000000","message":"Since you have to spin a new patchset, why not add some more tests?  The method is supposed to handle a missing value in the first field, as well as values that can be converted to an int.  For example:\n\n  self.assertEqual(5, utils.pagination_limit(None, 5))\n  self.assertEqual(5, utils.pagination_limit(\"\", 5))\n  self.assertEqual(2, utils.pagination_limit(\"2\", 5))\n  self.assertEqual(5, utils.pagination_limit(\"9\", 5))","commit_id":"dffe3c8a1305d2bb932f9f4b52907a347ca30f5c"}]}
