)]}'
{"trove/cluster/service.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3e72cabc6712ef2ca91862f6c9fb741932da6b3b","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def show(self, req, tenant_id, id):"},{"line_number":84,"context_line":"        \"\"\"Return a single cluster.\"\"\""},{"line_number":85,"context_line":"        LOG.debug(\"Showing a Cluster for Tenant \u0027%s\u0027\" % tenant_id)"},{"line_number":86,"context_line":"        LOG.info(_(\"req : \u0027%(req)s\u0027\\n\\nid : \u0027%(id)s\u0027\\n\\n\") %"},{"line_number":87,"context_line":"                 {\"req\": req, \"id\": id})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_e9151d49","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":60},"updated":"2015-11-09 17:01:04.000000000","message":"Aren\u0027t these backwards?  The message is printed out in debug form, and the data in info?","commit_id":"72c6f4d3c0e8b2993a9f03294ac6af5a455f78be"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6c367848c5c57fe8b400273541ffcca83f2fa19c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def show(self, req, tenant_id, id):"},{"line_number":84,"context_line":"        \"\"\"Return a single cluster.\"\"\""},{"line_number":85,"context_line":"        LOG.debug(\"Showing a Cluster for Tenant \u0027%s\u0027\" % tenant_id)"},{"line_number":86,"context_line":"        LOG.info(_(\"req : \u0027%(req)s\u0027\\n\\nid : \u0027%(id)s\u0027\\n\\n\") %"},{"line_number":87,"context_line":"                 {\"req\": req, \"id\": id})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_116d1698","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":60},"in_reply_to":"da85f559_e9151d49","updated":"2015-11-10 01:39:36.000000000","message":"yup!","commit_id":"72c6f4d3c0e8b2993a9f03294ac6af5a455f78be"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3e72cabc6712ef2ca91862f6c9fb741932da6b3b","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def show_instance(self, req, tenant_id, cluster_id, instance_id):"},{"line_number":94,"context_line":"        \"\"\"Return a single instance belonging to a cluster.\"\"\""},{"line_number":95,"context_line":"        LOG.debug(\"Showing an Instance in a Cluster for Tenant \u0027%s\u0027\""},{"line_number":96,"context_line":"                  % tenant_id)"},{"line_number":97,"context_line":"        LOG.info(_(\"req : \u0027%(req)s\u0027\\n\\n\""},{"line_number":98,"context_line":"                   \"cluster_id : \u0027%(cluster_id)s\u0027\\n\\n\""},{"line_number":99,"context_line":"                   \"instance_id : \u0027%(instance_id)s;\\n\\n\") %"},{"line_number":100,"context_line":"                 {\"req\": req,"},{"line_number":101,"context_line":"                  \"cluster_id\": cluster_id,"},{"line_number":102,"context_line":"                  \"instance_id\": instance_id})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":105,"context_line":"        cluster \u003d models.Cluster.load(context, cluster_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_a908752e","line":102,"range":{"start_line":95,"start_character":0,"end_line":102,"end_character":46},"updated":"2015-11-09 17:01:04.000000000","message":"ditto (for most of the file)","commit_id":"72c6f4d3c0e8b2993a9f03294ac6af5a455f78be"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"af838e84ab6354143558bb9c39bd19fec8c46662","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        LOG.debug(\"Committing Action Against Cluster for \""},{"line_number":55,"context_line":"                  \"Tenant \u0027%s\u0027\" % tenant_id)"},{"line_number":56,"context_line":"        LOG.debug(_(\"req : \u0027%(req)s\u0027\\n\\nid : \u0027%(id)s\u0027\\n\\n\") %"},{"line_number":57,"context_line":"                  {\"req\": req, \"id\": id})"},{"line_number":58,"context_line":"        if not body:"},{"line_number":59,"context_line":"            raise exception.BadRequest(_(\"Invalid request body.\"))"},{"line_number":60,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_ca47a2ba","line":57,"updated":"2015-11-10 21:11:20.000000000","message":"Debug messages shouldn\u0027t be i18n\u0027d, plus wouldn\u0027t it be safer to join these into one message so they don\u0027t get split in the log?","commit_id":"34ba561eea13ec10d33043ea55f313cf20cb771c"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"af838e84ab6354143558bb9c39bd19fec8c46662","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \"\"\"Return a single cluster.\"\"\""},{"line_number":85,"context_line":"        LOG.debug(\"Showing a Cluster for Tenant \u0027%s\u0027\" % tenant_id)"},{"line_number":86,"context_line":"        LOG.debug(_(\"req : \u0027%(req)s\u0027\\n\\nid : \u0027%(id)s\u0027\\n\\n\") %"},{"line_number":87,"context_line":"                  {\"req\": req, \"id\": id})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":90,"context_line":"        cluster \u003d models.Cluster.load(context, id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_8a143aa0","line":87,"updated":"2015-11-10 21:11:20.000000000","message":"As above and below...","commit_id":"34ba561eea13ec10d33043ea55f313cf20cb771c"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"03e1c8854e33a9742b4f8e176669aa33ab062bda","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        LOG.debug((\"Creating a Cluster for Tenant \u0027%s\u0027\\n\""},{"line_number":141,"context_line":"                   \"req : \u0027%(req)s\u0027\\n\\nbody : \u0027%(body)s\u0027\\n\\n\") %"},{"line_number":142,"context_line":"                  {\"tenant_id\": tenant_id, \"req\": req, \"body\": body})"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":145,"context_line":"        name \u003d body[\u0027cluster\u0027][\u0027name\u0027]"},{"line_number":146,"context_line":"        datastore_args \u003d body[\u0027cluster\u0027].get(\u0027datastore\u0027, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_d4015b39","line":143,"updated":"2015-11-11 19:08:21.000000000","message":"The tenant_id key parameter is not defined in the log message","commit_id":"8224bc8bed97a07518d60fd6e400d6400a92a712"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"39e890b3fd0a3f79159cb3bf3e61a397bbc5d64b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        LOG.debug((\"Creating a Cluster for Tenant \u0027%s\u0027\\n\""},{"line_number":141,"context_line":"                   \"req : \u0027%(req)s\u0027\\n\\nbody : \u0027%(body)s\u0027\\n\\n\") %"},{"line_number":142,"context_line":"                  {\"tenant_id\": tenant_id, \"req\": req, \"body\": body})"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":145,"context_line":"        name \u003d body[\u0027cluster\u0027][\u0027name\u0027]"},{"line_number":146,"context_line":"        datastore_args \u003d body[\u0027cluster\u0027].get(\u0027datastore\u0027, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_4e53876b","line":143,"in_reply_to":"da85f559_d4015b39","updated":"2015-11-12 00:26:53.000000000","message":"Good Catch","commit_id":"8224bc8bed97a07518d60fd6e400d6400a92a712"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"ba9d864088675d8f70cd40b8203d80467503c75f","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    def create(self, req, body, tenant_id):"},{"line_number":140,"context_line":"        LOG.debug((\"Creating a Cluster for Tenant \u0027%(tenant_id)s\u0027\\n\""},{"line_number":141,"context_line":"                   \"req : \u0027%(req)s\u0027\\n\\nbody : \u0027%(body)s\u0027\\n\\n\") %"},{"line_number":142,"context_line":"                  {\"tenant_id\": tenant_id, \"req\": req, \"body\": body})"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":145,"context_line":"        name \u003d body[\u0027cluster\u0027][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_a7afe628","line":142,"updated":"2016-01-23 00:19:01.000000000","message":"+0 - There\u0027s not going to be any messages in the log for creating/deleting/showing etc. of clusters unless you run in debug mode.  Is that what we want?","commit_id":"fb22dcfaaf39a979fc159663067e7986024d59a7"}],"trove/conductor/manager.py":[{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"9e3254ac11b265ba498fe37431206e561ca8316e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if sent is None:"},{"line_number":48,"context_line":"            LOG.error(_(\"[Instance %s] sent field not present. Cannot \""},{"line_number":49,"context_line":"                        \"compare.\") % instance_id)"},{"line_number":50,"context_line":"            return False"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_8b4d0940","line":48,"updated":"2015-12-07 22:59:04.000000000","message":"This should use _LE() and , not %\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages","commit_id":"6490336ce0d5a550f64d06f4f885b012e2f61c0b"}],"trove/extensions/mgmt/clusters/service.py":[{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"9e3254ac11b265ba498fe37431206e561ca8316e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    @admin_context"},{"line_number":57,"context_line":"    def show(self, req, tenant_id, id):"},{"line_number":58,"context_line":"        \"\"\"Return a single cluster.\"\"\""},{"line_number":59,"context_line":"        LOG.info(_(\"Showing cluster for tenant \u0027%(tenant_id)s\u0027.\\n\""},{"line_number":60,"context_line":"                   \"req : \u0027%(req)s\u0027\\n\""},{"line_number":61,"context_line":"                   \"id : \u0027%(id)s\u0027\") % {"},{"line_number":62,"context_line":"                       \"tenant_id\": tenant_id, \"req\": req, \"id\": id})"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_8bdf4968","line":59,"updated":"2015-12-07 22:59:04.000000000","message":"This should use _LI()\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"6490336ce0d5a550f64d06f4f885b012e2f61c0b"}],"trove/extensions/mgmt/upgrade/service.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"af838e84ab6354143558bb9c39bd19fec8c46662","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @admin_context"},{"line_number":35,"context_line":"    def create(self, req, body, tenant_id, instance_id):"},{"line_number":36,"context_line":"        LOG.info(_(\"Sending upgrade notifications\\nreq : \u0027%s\u0027\\n\\n\") % req)"},{"line_number":37,"context_line":"        LOG.debug(_(\"Admin tenant_id: %s\") % tenant_id)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        context \u003d req.environ.get(wsgi.CONTEXT_KEY)"},{"line_number":40,"context_line":"        upgrade \u003d body[\u0027upgrade\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_0ade0add","line":37,"updated":"2015-11-10 21:11:20.000000000","message":"No i18n, and why not just add the tenant to the info msg?","commit_id":"34ba561eea13ec10d33043ea55f313cf20cb771c"}],"trove/extensions/mysql/service.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"8b47e06d18768b387eef9e080333f17b6a8d96f7","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def create(self, req, body, tenant_id, instance_id):"},{"line_number":268,"context_line":"        \"\"\"Creates a set of schemas.\"\"\""},{"line_number":269,"context_line":"        LOG.info(_(\"Creating schemafor instance \u0027%(id)s\u0027\\n\""},{"line_number":270,"context_line":"                   \"req : \u0027%(req)s\u0027\\n\\n\""},{"line_number":271,"context_line":"                   \"body: \u0027%(body)s\u0027\\n\u0027n\") %"},{"line_number":272,"context_line":"                 {\"id\": instance_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_e07c07b7","line":269,"updated":"2015-11-10 22:34:32.000000000","message":"need a space between schema and for","commit_id":"34ba561eea13ec10d33043ea55f313cf20cb771c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"ba9d864088675d8f70cd40b8203d80467503c75f","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def create(self, req, body, tenant_id, instance_id):"},{"line_number":268,"context_line":"        \"\"\"Creates a set of schemas.\"\"\""},{"line_number":269,"context_line":"        LOG.info(_(\"Creating schemafor instance \u0027%(id)s\u0027\\n\""},{"line_number":270,"context_line":"                   \"req : \u0027%(req)s\u0027\\n\\n\""},{"line_number":271,"context_line":"                   \"body: \u0027%(body)s\u0027\\n\u0027n\") %"},{"line_number":272,"context_line":"                 {\"id\": instance_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_071a727d","line":269,"updated":"2016-01-23 00:19:01.000000000","message":"Missing a space in schemafor ...","commit_id":"fb22dcfaaf39a979fc159663067e7986024d59a7"}],"trove/guestagent/datastore/experimental/couchbase/service.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"03e1c8854e33a9742b4f8e176669aa33ab062bda","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if self.status.is_running:"},{"line_number":206,"context_line":"            LOG.error(_(\"Cannot start Couchbase with configuration changes. \""},{"line_number":207,"context_line":"                        \"Couchbase state \u003d\u003d %s.\") % self.status)"},{"line_number":208,"context_line":"            raise RuntimeError(\"Couchbase is not stopped.\")"},{"line_number":209,"context_line":"        self._write_config(config_contents)"},{"line_number":210,"context_line":"        self.start_db(True)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_cdc30a88","line":208,"updated":"2015-11-11 19:08:21.000000000","message":"do we want to want to mark this for translation while we are on it?","commit_id":"8224bc8bed97a07518d60fd6e400d6400a92a712"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6de069d7ffde4c9093dd8daccc7ced355a041c88","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if self.status.is_running:"},{"line_number":206,"context_line":"            LOG.error(_(\"Cannot start Couchbase with configuration changes. \""},{"line_number":207,"context_line":"                        \"Couchbase state \u003d\u003d %s.\") % self.status)"},{"line_number":208,"context_line":"            raise RuntimeError(\"Couchbase is not stopped.\")"},{"line_number":209,"context_line":"        self._write_config(config_contents)"},{"line_number":210,"context_line":"        self.start_db(True)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_29adc19a","line":208,"in_reply_to":"da85f559_cdc30a88","updated":"2015-11-12 12:50:36.000000000","message":"Really?\n\nI just did a quick grep on the pattern\n\namrith@amrith-work:/opt/stack/trove$ grep -r \u0027RuntimeError(\\\"\u0027 . | wc -l\n\n228\n\namrith@amrith-work:/opt/stack/trove$\n\nYou want me to change all 228 of them?\n\nThe number of errors which have been i18n\u0027ed, zero!","commit_id":"8224bc8bed97a07518d60fd6e400d6400a92a712"}],"trove/guestagent/strategies/restore/experimental/couchbase_impl.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"03e1c8854e33a9742b4f8e176669aa33ab062bda","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                                   timeout\u003d300)"},{"line_number":199,"context_line":"        except exception.ProcessExecutionError as p:"},{"line_number":200,"context_line":"            LOG.error(p)"},{"line_number":201,"context_line":"            raise base.RestoreError(\"Couchbase restore failed.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_2d3976a4","line":201,"updated":"2015-11-11 19:08:21.000000000","message":"translate this?","commit_id":"8224bc8bed97a07518d60fd6e400d6400a92a712"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6de069d7ffde4c9093dd8daccc7ced355a041c88","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                                   timeout\u003d300)"},{"line_number":199,"context_line":"        except exception.ProcessExecutionError as p:"},{"line_number":200,"context_line":"            LOG.error(p)"},{"line_number":201,"context_line":"            raise base.RestoreError(\"Couchbase restore failed.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_8fc38d37","line":201,"in_reply_to":"da85f559_2d3976a4","updated":"2015-11-12 12:50:36.000000000","message":"See earlier comment.","commit_id":"8224bc8bed97a07518d60fd6e400d6400a92a712"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"ba9d864088675d8f70cd40b8203d80467503c75f","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                        # cbrestore fails or hangs at times:"},{"line_number":192,"context_line":"                        # http://www.couchbase.com/issues/browse/MB-10832"},{"line_number":193,"context_line":"                        # Retrying typically works"},{"line_number":194,"context_line":"                        LOG.error(p)"},{"line_number":195,"context_line":"                        LOG.error(_(\"cbrestore failed. Retrying...\"))"},{"line_number":196,"context_line":"                        utils.execute_with_timeout(restore_cmd,"},{"line_number":197,"context_line":"                                                   shell\u003dTrue,"},{"line_number":198,"context_line":"                                                   timeout\u003d300)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_622f9c88","line":195,"range":{"start_line":194,"start_character":0,"end_line":195,"end_character":69},"updated":"2016-01-23 00:19:01.000000000","message":"+0 - This could be replaced with:\n\n  LOG.exception(_(\"cbrestore failed. Retrying...\"))","commit_id":"fb22dcfaaf39a979fc159663067e7986024d59a7"}],"trove/taskmanager/models.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"af838e84ab6354143558bb9c39bd19fec8c46662","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        return volume_info"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    def _log_and_raise(self, exc, message, task_status):"},{"line_number":795,"context_line":"        LOG.error(\"%(message)s\\n%(exc)s\\n%(trace)s\" %"},{"line_number":796,"context_line":"                  {\"message\": message,"},{"line_number":797,"context_line":"                   \"exc\": exc,"},{"line_number":798,"context_line":"                   \"trace\": traceback.format_exc()})"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_4a9df208","line":795,"updated":"2015-11-10 21:11:20.000000000","message":"i18n? There is no english text here, but a translator may want to change the order of the components.","commit_id":"34ba561eea13ec10d33043ea55f313cf20cb771c"}]}