)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"60c5c53f26d54593625b848de408ba8c6974748a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"   gain root access to an instance without marking is as \u0027root-enabled\u0027"},{"line_number":58,"context_line":"   A similar defect exists in other datastores (MySQL) too:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"     1. Create an instance."},{"line_number":61,"context_line":"     2. Enable root."},{"line_number":62,"context_line":"     3. Use your root access to change the password of the built-in"},{"line_number":63,"context_line":"        \u0027postgres\u0027 account (Trove will still work because it uses the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_01417639","line":60,"updated":"2015-11-13 12:25:05.000000000","message":"If I understand correctly, this is bug 1472655 and a fix for this has been proposed in https://review.openstack.org/#/c/199635/.\n\nIs that correct?","commit_id":"2998aa9d3c33043fd140b5c2b39f182a90782eb5"}],"trove/guestagent/datastore/experimental/postgresql/manager.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"60c5c53f26d54593625b848de408ba8c6974748a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if root_password and not backup_info:"},{"line_number":76,"context_line":"            self.enable_root(context, root_password)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _secure(self, context):"},{"line_number":79,"context_line":"        # Create a new administrative user for Trove and also"},{"line_number":80,"context_line":"        # disable the built-in superuser."},{"line_number":81,"context_line":"        self.create_database(context, [{\u0027_name\u0027: self.ADMIN_USER}])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_e18c7281","line":78,"updated":"2015-11-13 12:25:05.000000000","message":"with the new class manager, would it make sense to make secure() a base class method?","commit_id":"2998aa9d3c33043fd140b5c2b39f182a90782eb5"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"55bc66c4601e98ec4e56c5ff1512f888045b7a90","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if root_password and not backup_info:"},{"line_number":76,"context_line":"            self.enable_root(context, root_password)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _secure(self, context):"},{"line_number":79,"context_line":"        # Create a new administrative user for Trove and also"},{"line_number":80,"context_line":"        # disable the built-in superuser."},{"line_number":81,"context_line":"        self.create_database(context, [{\u0027_name\u0027: self.ADMIN_USER}])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_365b5289","line":78,"in_reply_to":"da85f559_e18c7281","updated":"2015-11-18 01:42:56.000000000","message":"I don\u0027t think so. Although many datastores have some form of a \u0027secure\u0027 method, the point at which it gets called during prepare varies. Also, some datastores may need to execute (a part of) the secure call during restore while others not.\n\nI think it is too datastore specific to move it up in the class hierarchy. Having said that, it could very well be reused by some derivative of Postgres.","commit_id":"2998aa9d3c33043fd140b5c2b39f182a90782eb5"}]}