)]}'
{"trove/common/cfg.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b476cab58e0e8fa9039da3bcd83085c0b6f4dd24","unresolved":false,"context_lines":[{"line_number":1245,"context_line":"    If it is not available, retrieve it from the DEFAULT section."},{"line_number":1246,"context_line":"    \"\"\""},{"line_number":1247,"context_line":""},{"line_number":1248,"context_line":"    # TODO(pmalik): The manager could normally be loaded from CONF, but that"},{"line_number":1249,"context_line":"    # does not work with unittests that apparently run with it either"},{"line_number":1250,"context_line":"    # not defined at all or set to \u0027mysql\u0027. That\u0027s why it is being passed in."},{"line_number":1251,"context_line":"    # The default value has to be set to \u0027mysql\u0027 to satisfy fake int-tests"},{"line_number":1252,"context_line":"    # that assume MySQL but do not define the manager either."},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"    try:"},{"line_number":1255,"context_line":"        return CONF.get(manager).get(property_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_ac9bba71","line":1252,"range":{"start_line":1248,"start_character":0,"end_line":1252,"end_character":61},"updated":"2015-11-13 14:16:32.000000000","message":"Shouldn\u0027t we at least check?  Just because the tests don\u0027t set the conf value, doesn\u0027t mean that it\u0027s not set in the actual code (which is where it should make a difference).  It can still default to \u0027mysql\u0027 if nothing else is found.","commit_id":"a426ee8547cce9f008bb9dee734ab65d068a8e0c"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"b80a07555c9ed3df8c75bb48387ebf943be40a5e","unresolved":false,"context_lines":[{"line_number":1245,"context_line":"    If it is not available, retrieve it from the DEFAULT section."},{"line_number":1246,"context_line":"    \"\"\""},{"line_number":1247,"context_line":""},{"line_number":1248,"context_line":"    # TODO(pmalik): The manager could normally be loaded from CONF, but that"},{"line_number":1249,"context_line":"    # does not work with unittests that apparently run with it either"},{"line_number":1250,"context_line":"    # not defined at all or set to \u0027mysql\u0027. That\u0027s why it is being passed in."},{"line_number":1251,"context_line":"    # The default value has to be set to \u0027mysql\u0027 to satisfy fake int-tests"},{"line_number":1252,"context_line":"    # that assume MySQL but do not define the manager either."},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"    try:"},{"line_number":1255,"context_line":"        return CONF.get(manager).get(property_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_5b78c2f8","line":1252,"range":{"start_line":1248,"start_character":0,"end_line":1252,"end_character":61},"in_reply_to":"da85f559_ac9bba71","updated":"2015-11-13 15:50:56.000000000","message":"I am open for discussion on this point.\n\nI tried to avoid the \u0027silent\u0027 fallback to mysql by making it clear that \u0027mysql\u0027 is going to be used if not specified otherwise. The caller is then responsible for requesting the correct datastore (they can pass in the \u0027CONF.datastore_manager\u0027) - that\u0027s what they do now.\n\nIf we try to load it here and it happens to be undefined the code silently falls back to \u0027mysql\u0027 although that\u0027s very likely not desired.","commit_id":"a426ee8547cce9f008bb9dee734ab65d068a8e0c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"31b810e8a738a4eba32f19c80f0a293e70f0b155","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"    # not defined at all or set to \u0027mysql\u0027. That\u0027s why it is being passed in."},{"line_number":1251,"context_line":"    # The default value has to be set to \u0027mysql\u0027 to satisfy fake int-tests"},{"line_number":1252,"context_line":"    # that assume MySQL but do not define the manager either."},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"    try:"},{"line_number":1255,"context_line":"        return CONF.get(manager).get(property_name)"},{"line_number":1256,"context_line":"    except NoSuchOptError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_00b61ddc","line":1253,"updated":"2015-11-15 18:02:20.000000000","message":"Wouldn\u0027t it be better to have a line like this? :\n\n  _manager \u003d manager or CONF.datastore_manager or \u0027mysql\u0027\n\nand have manager\u003dNone the default?  The way it is now, if you don\u0027t specify \u0027manager\u0027 you get the mysql one, even if CONF.datastore_manager is set.  (I don\u0027t think we should optimize for test scenarios ... ;) )","commit_id":"438632ba8f4ddc0b9855ea9b80d33b56be88cc16"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"4e38cc3a0726c71cefde4de84b31de28a34e36f3","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"    # not defined at all or set to \u0027mysql\u0027. That\u0027s why it is being passed in."},{"line_number":1251,"context_line":"    # The default value has to be set to \u0027mysql\u0027 to satisfy fake int-tests"},{"line_number":1252,"context_line":"    # that assume MySQL but do not define the manager either."},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"    try:"},{"line_number":1255,"context_line":"        return CONF.get(manager).get(property_name)"},{"line_number":1256,"context_line":"    except NoSuchOptError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_e0746efe","line":1253,"in_reply_to":"da85f559_00b61ddc","updated":"2015-11-16 20:41:48.000000000","message":"See the comment from Nov 13 10:50 AM","commit_id":"438632ba8f4ddc0b9855ea9b80d33b56be88cc16"}]}