)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"b4e8efb312f5a6939aec6e71d53993dab0ff8ef1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Amrith Kumar \u003camrith@tesora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-16 10:47:31 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Time to get rid of any last vestiges of slave_of"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit https://review.openstack.org/#/c/245738/ eliminated slave_of in"},{"line_number":10,"context_line":"the python-troveclient. The controller has long understood how to deal"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_d83889d5","line":7,"updated":"2015-12-21 20:10:25.000000000","message":"this is not true if you are not changing the variable names as well because there are still vestiges of slave_of in the code.","commit_id":"061bebe9c006114c43a8b74d927aa499655d6321"}],"trove/instance/service.py":[{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"944dd6942436ea883780d77ab280ec4cba0b1fe6","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        availability_zone \u003d body[\u0027instance\u0027].get(\u0027availability_zone\u0027)"},{"line_number":233,"context_line":"        nics \u003d body[\u0027instance\u0027].get(\u0027nics\u0027)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        slave_of_id \u003d body[\u0027instance\u0027].get(\u0027replica_of\u0027)"},{"line_number":236,"context_line":"        replica_count \u003d body[\u0027instance\u0027].get(\u0027replica_count\u0027)"},{"line_number":237,"context_line":"        instance \u003d models.Instance.create(context, name, flavor_id,"},{"line_number":238,"context_line":"                                          image_id, databases, users,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_78d82a54","line":235,"updated":"2015-11-17 01:05:51.000000000","message":"since the idea is to remove slave_of i think it best to rename the variable here to replica_of_id.","commit_id":"061bebe9c006114c43a8b74d927aa499655d6321"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"4c4cc1e4ecd520b54fc19159c01171913718f606","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        availability_zone \u003d body[\u0027instance\u0027].get(\u0027availability_zone\u0027)"},{"line_number":233,"context_line":"        nics \u003d body[\u0027instance\u0027].get(\u0027nics\u0027)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        slave_of_id \u003d body[\u0027instance\u0027].get(\u0027replica_of\u0027)"},{"line_number":236,"context_line":"        replica_count \u003d body[\u0027instance\u0027].get(\u0027replica_count\u0027)"},{"line_number":237,"context_line":"        instance \u003d models.Instance.create(context, name, flavor_id,"},{"line_number":238,"context_line":"                                          image_id, databases, users,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_3c39a1d7","line":235,"in_reply_to":"7a740942_48040717","updated":"2015-12-08 12:05:39.000000000","message":"That was my point Ronald. But we talked about in IRC and decided that we should do an extra work to remove all evidences of slave on the code all together.","commit_id":"061bebe9c006114c43a8b74d927aa499655d6321"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"3b4cdf020fead8768649154a671fd7f39d34a7c4","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        availability_zone \u003d body[\u0027instance\u0027].get(\u0027availability_zone\u0027)"},{"line_number":233,"context_line":"        nics \u003d body[\u0027instance\u0027].get(\u0027nics\u0027)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        slave_of_id \u003d body[\u0027instance\u0027].get(\u0027replica_of\u0027)"},{"line_number":236,"context_line":"        replica_count \u003d body[\u0027instance\u0027].get(\u0027replica_count\u0027)"},{"line_number":237,"context_line":"        instance \u003d models.Instance.create(context, name, flavor_id,"},{"line_number":238,"context_line":"                                          image_id, databases, users,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_48040717","line":235,"in_reply_to":"ba8a016a_251b9d82","updated":"2015-12-07 22:44:02.000000000","message":"While I agree changing the variable name does not change functionality (and hence why do it?), but if you looked at this code for the first time (as I am), I would question why is a variable called slave_of when it refers to replica_of. That is legacy confusion we could do without.\n\nIn this file it is defined and referenced only once.","commit_id":"061bebe9c006114c43a8b74d927aa499655d6321"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f72ec3d054908a0d3351701e03d8f0835f218378","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        availability_zone \u003d body[\u0027instance\u0027].get(\u0027availability_zone\u0027)"},{"line_number":233,"context_line":"        nics \u003d body[\u0027instance\u0027].get(\u0027nics\u0027)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        slave_of_id \u003d body[\u0027instance\u0027].get(\u0027replica_of\u0027)"},{"line_number":236,"context_line":"        replica_count \u003d body[\u0027instance\u0027].get(\u0027replica_count\u0027)"},{"line_number":237,"context_line":"        instance \u003d models.Instance.create(context, name, flavor_id,"},{"line_number":238,"context_line":"                                          image_id, databases, users,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_f8e59737","line":235,"in_reply_to":"ba8a016a_78d82a54","updated":"2015-11-19 19:14:16.000000000","message":"Sorry, I\u0027m not going to do that because there are numerous places where we have slave_of and things and changing it to replica_of is a pointless change (not functionally a change).","commit_id":"061bebe9c006114c43a8b74d927aa499655d6321"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6346951229bff3ec6c647011d7f5f1dae1e0b489","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        availability_zone \u003d body[\u0027instance\u0027].get(\u0027availability_zone\u0027)"},{"line_number":233,"context_line":"        nics \u003d body[\u0027instance\u0027].get(\u0027nics\u0027)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        slave_of_id \u003d body[\u0027instance\u0027].get(\u0027replica_of\u0027)"},{"line_number":236,"context_line":"        replica_count \u003d body[\u0027instance\u0027].get(\u0027replica_count\u0027)"},{"line_number":237,"context_line":"        instance \u003d models.Instance.create(context, name, flavor_id,"},{"line_number":238,"context_line":"                                          image_id, databases, users,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_251b9d82","line":235,"in_reply_to":"ba8a016a_f8e59737","updated":"2015-11-20 00:59:03.000000000","message":"Whereas the name of the variable doesn\u0027t impact on the functionality, I think it\u0027s a valid point and that it should be done (in this change or in a follow up patch). Having clear variable names helps people to understand what they are reading. It will be certainly misleading for someone that missed this convo to read \"slave_of_id\" and get a \"replica_of\" in the other side.","commit_id":"061bebe9c006114c43a8b74d927aa499655d6321"}],"trove/tests/api/replication.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"6c9e2d2596ade3cc11a781935c1577cdb283d194","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        instance_info.name + \"_slave\","},{"line_number":81,"context_line":"        instance_info.dbaas_flavor_href,"},{"line_number":82,"context_line":"        instance_info.volume,"},{"line_number":83,"context_line":"        replica_of\u003dinstance_info.id)"},{"line_number":84,"context_line":"    assert_equal(200, instance_info.dbaas.last_http_code)"},{"line_number":85,"context_line":"    assert_equal(\"BUILD\", result.status)"},{"line_number":86,"context_line":"    return result.id"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_0d820e01","line":83,"updated":"2015-12-30 19:28:00.000000000","message":"I don\u0027t think this has to be a named arg. Just pass it in as a positional arg. That should remove the dependency on the name.","commit_id":"b6bb69a22e7087655fc48b9ab1c0289c5217c91d"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"529e93c51172b98da12381bd2f3a4fa12a0eb538","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        instance_info.name + \"_slave\","},{"line_number":81,"context_line":"        instance_info.dbaas_flavor_href,"},{"line_number":82,"context_line":"        instance_info.volume,"},{"line_number":83,"context_line":"        replica_of\u003dinstance_info.id)"},{"line_number":84,"context_line":"    assert_equal(200, instance_info.dbaas.last_http_code)"},{"line_number":85,"context_line":"    assert_equal(\"BUILD\", result.status)"},{"line_number":86,"context_line":"    return result.id"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_251ef30c","line":83,"in_reply_to":"fa69d971_0d820e01","updated":"2015-12-31 14:26:26.000000000","message":"This is calling the troveclient.v1.instances.Instances.create(). replica_of is NOT the 4th parameter of that function. The name is needed.","commit_id":"b6bb69a22e7087655fc48b9ab1c0289c5217c91d"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"6c9e2d2596ade3cc11a781935c1577cdb283d194","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                      instance_info.name + \"_slave\","},{"line_number":116,"context_line":"                      instance_info.dbaas_flavor_href,"},{"line_number":117,"context_line":"                      instance_info.volume,"},{"line_number":118,"context_line":"                      replica_of\u003d\"Missing replica source\")"},{"line_number":119,"context_line":"        assert_equal(404, instance_info.dbaas.last_http_code)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @test"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_2d87d210","line":118,"updated":"2015-12-30 19:28:00.000000000","message":"ditto","commit_id":"b6bb69a22e7087655fc48b9ab1c0289c5217c91d"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"529e93c51172b98da12381bd2f3a4fa12a0eb538","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                      instance_info.name + \"_slave\","},{"line_number":116,"context_line":"                      instance_info.dbaas_flavor_href,"},{"line_number":117,"context_line":"                      instance_info.volume,"},{"line_number":118,"context_line":"                      replica_of\u003d\"Missing replica source\")"},{"line_number":119,"context_line":"        assert_equal(404, instance_info.dbaas.last_http_code)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @test"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_05cf2f80","line":118,"in_reply_to":"fa69d971_2d87d210","updated":"2015-12-31 14:26:26.000000000","message":"ditto","commit_id":"b6bb69a22e7087655fc48b9ab1c0289c5217c91d"}]}
