)]}'
{"trove/taskmanager/models.py":[{"author":{"_account_id":12150,"name":"Bhaskar Duvvuri","email":"bhaskara.duvvuri@intl.att.com","username":"bhaskar.duvvuri"},"change_message_id":"e4407e84209d03c950b527c1f8016fa9f453c552","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    def create_instance(self, flavor, image_id, databases, users,"},{"line_number":334,"context_line":"                        datastore_manager, packages, volume_size,"},{"line_number":335,"context_line":"                        backup_id, availability_zone, root_password, nics,"},{"line_number":336,"context_line":"                        overrides, cluster_config, snapshot, volume_type):"},{"line_number":337,"context_line":"        # It is the caller\u0027s responsibility to ensure that"},{"line_number":338,"context_line":"        # FreshInstanceTasks.wait_for_instance is called after"},{"line_number":339,"context_line":"        # create_instance to ensure that the proper usage event gets sent"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_73fed66c","line":336,"range":{"start_line":336,"start_character":51,"end_line":336,"end_character":59},"updated":"2015-11-23 18:40:36.000000000","message":"I think it is always a good practice have snapshot\u003dNone","commit_id":"0a0680f4d8c1551d24ea9d20aa57d99e9883bbd8"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"283a176f4527b951a37e0617c6d48c9e13473386","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    def create_instance(self, flavor, image_id, databases, users,"},{"line_number":334,"context_line":"                        datastore_manager, packages, volume_size,"},{"line_number":335,"context_line":"                        backup_id, availability_zone, root_password, nics,"},{"line_number":336,"context_line":"                        overrides, cluster_config, snapshot, volume_type):"},{"line_number":337,"context_line":"        # It is the caller\u0027s responsibility to ensure that"},{"line_number":338,"context_line":"        # FreshInstanceTasks.wait_for_instance is called after"},{"line_number":339,"context_line":"        # create_instance to ensure that the proper usage event gets sent"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_0e21604d","line":336,"range":{"start_line":336,"start_character":51,"end_line":336,"end_character":59},"in_reply_to":"ba8a016a_73fed66c","updated":"2015-11-23 19:06:43.000000000","message":"Well, the taskmanager API already defaults these parameters to \u0027None\u0027.\nIf we keep this one optional everything after it has to be optional as well. We would have to add any new parameters before it (or make them optional), but that could easily break calls that rely on the parameter order... :-/","commit_id":"0a0680f4d8c1551d24ea9d20aa57d99e9883bbd8"}]}