)]}'
{"trove/db/sqlalchemy/session.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"5d784ba931755ed2808db639b2af8e2b81e92373","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_ \u003d i18n._"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def configure_db(options, models_mapper\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_c64b8258","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":10},"updated":"2015-11-16 21:55:21.000000000","message":"This could probably be left where it was ;)","commit_id":"5d9eeac205ad9e545a172e3c69b36c1d343dc343"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"a8a09baa25f17232a267eb660228fcc51c7f51de","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_ \u003d i18n._"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def configure_db(options, models_mapper\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_0fae4f85","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":10},"in_reply_to":"ba8a016a_c64b8258","updated":"2015-11-17 16:37:30.000000000","message":"done","commit_id":"5d9eeac205ad9e545a172e3c69b36c1d343dc343"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"6a958a26266a2cd2df5bed8a945fbc34ed1959d1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        mappers.map(get_engine(), models)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def _create_facade(options):"},{"line_number":76,"context_line":"    global _LOCK, _FACADE"},{"line_number":77,"context_line":"    if _FACADE is None:"},{"line_number":78,"context_line":"        with _LOCK:"},{"line_number":79,"context_line":"            if _FACADE is None:"},{"line_number":80,"context_line":"                conf \u003d CONF.database"},{"line_number":81,"context_line":"                # handle the deprecated config option \u0027query_log\u0027"},{"line_number":82,"context_line":"                if conf.query_log:"},{"line_number":83,"context_line":"                    if conf.connection_debug \u003c 50:"},{"line_number":84,"context_line":"                        conf[\u0027connection_debug\u0027] \u003d 50"},{"line_number":85,"context_line":"                    LOG.warning(_(\u0027Configuration option \"query_log\" has been \u0027"},{"line_number":86,"context_line":"                                  \u0027depracated. Use \"connection_debug\" \u0027"},{"line_number":87,"context_line":"                                  \u0027instead. Setting connection_debug \u003d \u0027"},{"line_number":88,"context_line":"                                  \u0027%(debug_level)s instead.\u0027)"},{"line_number":89,"context_line":"                                % conf.get(\u0027connection_debug\u0027))"},{"line_number":90,"context_line":"                database_opts \u003d dict(CONF.database)"},{"line_number":91,"context_line":"                database_opts.pop(\u0027query_log\u0027)"},{"line_number":92,"context_line":"                _FACADE \u003d session.EngineFacade("},{"line_number":93,"context_line":"                    options[\u0027database\u0027][\u0027connection\u0027],"},{"line_number":94,"context_line":"                    **database_opts"},{"line_number":95,"context_line":"                )"},{"line_number":96,"context_line":"    return _FACADE"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _check_facade():"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_039f0eb5","line":96,"range":{"start_line":75,"start_character":0,"end_line":96,"end_character":18},"updated":"2015-11-17 15:28:11.000000000","message":"This looks like boiler-plate code (and it is ;) ).  Could you put in a comment that has a link to the spec that\u0027s in flight to add this to the oslo.db library?\n\n  # Refactor this once oslo.db spec is implemented:\n  # https://specs.openstack.org/openstack/oslo-specs/specs/kilo/\n  #     make-enginefacade-a-facade.html\n\nAlso put a comment on why you\u0027re pop\u0027ing query_log (and go a head and mark the option deprecated in cfg.py so we can get rid of it in a cycle or two).  Thx!","commit_id":"5d9eeac205ad9e545a172e3c69b36c1d343dc343"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"a8a09baa25f17232a267eb660228fcc51c7f51de","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        mappers.map(get_engine(), models)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def _create_facade(options):"},{"line_number":76,"context_line":"    global _LOCK, _FACADE"},{"line_number":77,"context_line":"    if _FACADE is None:"},{"line_number":78,"context_line":"        with _LOCK:"},{"line_number":79,"context_line":"            if _FACADE is None:"},{"line_number":80,"context_line":"                conf \u003d CONF.database"},{"line_number":81,"context_line":"                # handle the deprecated config option \u0027query_log\u0027"},{"line_number":82,"context_line":"                if conf.query_log:"},{"line_number":83,"context_line":"                    if conf.connection_debug \u003c 50:"},{"line_number":84,"context_line":"                        conf[\u0027connection_debug\u0027] \u003d 50"},{"line_number":85,"context_line":"                    LOG.warning(_(\u0027Configuration option \"query_log\" has been \u0027"},{"line_number":86,"context_line":"                                  \u0027depracated. Use \"connection_debug\" \u0027"},{"line_number":87,"context_line":"                                  \u0027instead. Setting connection_debug \u003d \u0027"},{"line_number":88,"context_line":"                                  \u0027%(debug_level)s instead.\u0027)"},{"line_number":89,"context_line":"                                % conf.get(\u0027connection_debug\u0027))"},{"line_number":90,"context_line":"                database_opts \u003d dict(CONF.database)"},{"line_number":91,"context_line":"                database_opts.pop(\u0027query_log\u0027)"},{"line_number":92,"context_line":"                _FACADE \u003d session.EngineFacade("},{"line_number":93,"context_line":"                    options[\u0027database\u0027][\u0027connection\u0027],"},{"line_number":94,"context_line":"                    **database_opts"},{"line_number":95,"context_line":"                )"},{"line_number":96,"context_line":"    return _FACADE"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _check_facade():"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_af0f0387","line":96,"range":{"start_line":75,"start_character":0,"end_line":96,"end_character":18},"in_reply_to":"ba8a016a_039f0eb5","updated":"2015-11-17 16:37:30.000000000","message":"Done. Option marked as deprecated_for_removal in first patchset.","commit_id":"5d9eeac205ad9e545a172e3c69b36c1d343dc343"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"1490f93dffe47270a38ff6895548db090c47af2d","unresolved":false,"context_lines":[{"line_number":140,"context_line":"def drop_db(options):"},{"line_number":141,"context_line":"    if options:"},{"line_number":142,"context_line":"        _create_facade(options)"},{"line_number":143,"context_line":"    engine \u003d get_engine()"},{"line_number":144,"context_line":"    meta \u003d MetaData()"},{"line_number":145,"context_line":"    meta.bind \u003d engine"},{"line_number":146,"context_line":"    meta.reflect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_983ec4d8","line":143,"updated":"2015-12-07 21:26:27.000000000","message":"Calling a getter and assigning it to a variable that is never used is confusing.  Is this necessary?  If so, just have it call _check_facade() (with get_engine if necessary).","commit_id":"bb7390612f0a562fb1e1430af1d3f87af03a1d39"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"8072b4d1af8013a9772fc8a37fe2e5b7226016fb","unresolved":false,"context_lines":[{"line_number":140,"context_line":"def drop_db(options):"},{"line_number":141,"context_line":"    if options:"},{"line_number":142,"context_line":"        _create_facade(options)"},{"line_number":143,"context_line":"    engine \u003d get_engine()"},{"line_number":144,"context_line":"    meta \u003d MetaData()"},{"line_number":145,"context_line":"    meta.bind \u003d engine"},{"line_number":146,"context_line":"    meta.reflect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_621482e8","line":143,"in_reply_to":"7a740942_983ec4d8","updated":"2015-12-11 20:17:39.000000000","message":"It is used on line 145.","commit_id":"bb7390612f0a562fb1e1430af1d3f87af03a1d39"}],"trove/tests/fakes/guestagent.py":[{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"d1ae3ed740ef1e866da18b18dd84dc8c8d6ab40e","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                status.status \u003d rd_instance.ServiceStatuses.RUNNING"},{"line_number":237,"context_line":"            status.save()"},{"line_number":238,"context_line":"            AgentHeartBeat.create(instance_id\u003dself.id)"},{"line_number":239,"context_line":"        eventlet.spawn_after(10.0, update_db)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _set_task_status(self, new_status\u003d\u0027RUNNING\u0027):"},{"line_number":242,"context_line":"        from trove.instance.models import InstanceServiceStatus"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_5bed2b8a","line":239,"updated":"2015-11-16 21:05:03.000000000","message":"This sleep timer is increased because oslo_db uses a sleep(0) in a pretty common codepath. The effect of the constant sleeps is lots of eventlet switching - which eats up these timers quickly. This was causing timing problems in some of the fake tests, specifically backups and instance creates were completing too quickly","commit_id":"5d9eeac205ad9e545a172e3c69b36c1d343dc343"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"d1ae3ed740ef1e866da18b18dd84dc8c8d6ab40e","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            backup.checksum \u003d \u0027fake-md5-sum\u0027"},{"line_number":318,"context_line":"            backup.size \u003d BACKUP_SIZE"},{"line_number":319,"context_line":"            backup.save()"},{"line_number":320,"context_line":"        eventlet.spawn_after(10.0, finish_create_backup)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def mount_volume(self, device_path\u003dNone, mount_point\u003dNone):"},{"line_number":323,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1b000334","line":320,"updated":"2015-11-16 21:05:03.000000000","message":"ditto","commit_id":"5d9eeac205ad9e545a172e3c69b36c1d343dc343"}]}
