)]}'
{"trove/common/cfg.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2836e7ce99299f1b5e086fe59a2d700c547e08ff","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"    cfg.IntOpt(\u0027guest_log_long_query_time\u0027, default\u003d0,"},{"line_number":1023,"context_line":"               help\u003d\"The time in milliseconds that a statement must take in \""},{"line_number":1024,"context_line":"                    \"in order to be logged in the \u0027general\u0027 log.  A value of \""},{"line_number":1025,"context_line":"                    \"\u00270\u0027 logs all statements, while \u0027-1\u0027 turns off \""},{"line_number":1026,"context_line":"                    \"statement logging.\"),"},{"line_number":1027,"context_line":"]"},{"line_number":1028,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9a68dd71_ae5d7116","line":1025,"updated":"2016-01-23 16:18:27.000000000","message":"default to all, eh?","commit_id":"de96274940dbe8eb1ee4fac050636620fd5454c1"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"41b39990671e8ca60db23f7ae9eb1a297b8e616c","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"    cfg.IntOpt(\u0027guest_log_long_query_time\u0027, default\u003d0,"},{"line_number":1023,"context_line":"               help\u003d\"The time in milliseconds that a statement must take in \""},{"line_number":1024,"context_line":"                    \"in order to be logged in the \u0027general\u0027 log.  A value of \""},{"line_number":1025,"context_line":"                    \"\u00270\u0027 logs all statements, while \u0027-1\u0027 turns off \""},{"line_number":1026,"context_line":"                    \"statement logging.\"),"},{"line_number":1027,"context_line":"]"},{"line_number":1028,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9a68dd71_ae67b1b5","line":1025,"in_reply_to":"9a68dd71_ae5d7116","updated":"2016-01-23 16:26:47.000000000","message":"Since the exposed log is the equivalent of the MySQL \u0027general\u0027 log and \u0027slow_query_log\u0027 combined, I chose to implement it as \u0027general\u0027 by default (hence this value set to \u00270\u0027).  The other option would be to just have a \u0027slow_query_log\u0027 and have this value set to something higher.  I figured \u00276 of one ...\u0027","commit_id":"de96274940dbe8eb1ee4fac050636620fd5454c1"}],"trove/guestagent/datastore/manager.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2836e7ce99299f1b5e086fe59a2d700c547e08ff","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        \"\"\"These are log files that should be available on every Trove"},{"line_number":161,"context_line":"        instance.  By definition, these should be of type LogType.SYS"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        log_dir \u003d CONF.get(\u0027log_dir\u0027, \u0027/var/log/trove/\u0027)"},{"line_number":164,"context_line":"        log_file \u003d CONF.get(\u0027log_file\u0027, \u0027trove-guestagent.log\u0027)"},{"line_number":165,"context_line":"        guestagent_log \u003d guestagent_utils.build_file_path(log_dir, log_file)"},{"line_number":166,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a68dd71_eec36987","line":163,"updated":"2016-01-23 16:18:27.000000000","message":"that\u0027s odd, I don\u0027t see log_dir in trove/common/cfg.py. Am I missing something?\n\nAlso, this is an odd way to specify a default; wouldn\u0027t you just set it in the definition?","commit_id":"de96274940dbe8eb1ee4fac050636620fd5454c1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6bc42d658abfd4484cfc42500d2ebcd963e27fb6","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        \"\"\"These are log files that should be available on every Trove"},{"line_number":161,"context_line":"        instance.  By definition, these should be of type LogType.SYS"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        log_dir \u003d CONF.get(\u0027log_dir\u0027, \u0027/var/log/trove/\u0027)"},{"line_number":164,"context_line":"        log_file \u003d CONF.get(\u0027log_file\u0027, \u0027trove-guestagent.log\u0027)"},{"line_number":165,"context_line":"        guestagent_log \u003d guestagent_utils.build_file_path(log_dir, log_file)"},{"line_number":166,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a68dd71_4e0715ca","line":163,"in_reply_to":"9a68dd71_eec36987","updated":"2016-01-23 16:21:59.000000000","message":"sorry, doug just told me these come from oslo.log","commit_id":"de96274940dbe8eb1ee4fac050636620fd5454c1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2836e7ce99299f1b5e086fe59a2d700c547e08ff","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        instance.  By definition, these should be of type LogType.SYS"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        log_dir \u003d CONF.get(\u0027log_dir\u0027, \u0027/var/log/trove/\u0027)"},{"line_number":164,"context_line":"        log_file \u003d CONF.get(\u0027log_file\u0027, \u0027trove-guestagent.log\u0027)"},{"line_number":165,"context_line":"        guestagent_log \u003d guestagent_utils.build_file_path(log_dir, log_file)"},{"line_number":166,"context_line":"        return {"},{"line_number":167,"context_line":"            self.GUEST_LOG_DEFS_GUEST_LABEL: {"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a68dd71_8ebc2d07","line":164,"updated":"2016-01-23 16:18:27.000000000","message":"ditto","commit_id":"de96274940dbe8eb1ee4fac050636620fd5454c1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6bc42d658abfd4484cfc42500d2ebcd963e27fb6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        instance.  By definition, these should be of type LogType.SYS"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        log_dir \u003d CONF.get(\u0027log_dir\u0027, \u0027/var/log/trove/\u0027)"},{"line_number":164,"context_line":"        log_file \u003d CONF.get(\u0027log_file\u0027, \u0027trove-guestagent.log\u0027)"},{"line_number":165,"context_line":"        guestagent_log \u003d guestagent_utils.build_file_path(log_dir, log_file)"},{"line_number":166,"context_line":"        return {"},{"line_number":167,"context_line":"            self.GUEST_LOG_DEFS_GUEST_LABEL: {"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a68dd71_6e0c59ed","line":164,"in_reply_to":"9a68dd71_8ebc2d07","updated":"2016-01-23 16:21:59.000000000","message":"sorry, doug just told me these come from oslo.log","commit_id":"de96274940dbe8eb1ee4fac050636620fd5454c1"}],"trove/tests/int_tests.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"8383263a5a25ae7ce830c28696428bef899fcfec","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from trove.tests.api import databases"},{"line_number":20,"context_line":"from trove.tests.api import datastores"},{"line_number":21,"context_line":"from trove.tests.api import flavors"},{"line_number":22,"context_line":"# from trove.tests.api import guest_log"},{"line_number":23,"context_line":"from trove.tests.api import instances"},{"line_number":24,"context_line":"from trove.tests.api import instances_actions"},{"line_number":25,"context_line":"from trove.tests.api.mgmt import accounts"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a68dd71_b6a10896","line":22,"updated":"2016-01-25 21:48:18.000000000","message":"is this needed?","commit_id":"de96274940dbe8eb1ee4fac050636620fd5454c1"}]}