)]}'
{"trove/common/strategies/cluster/experimental/mongodb/taskmanager.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"46bb8f060c5a5ba77ae6e379d3608d5f910615bd","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        return False"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def _add_query_routers(self, query_routers, config_server_ips,"},{"line_number":349,"context_line":"                           admin_password\u003dNone):"},{"line_number":350,"context_line":"        \"\"\"Configure the given query routers for the cluster."},{"line_number":351,"context_line":"        If this is a new_cluster an admin user will be created with a randomly"},{"line_number":352,"context_line":"        generated password, else the password needs to be retrieved from"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_ede8c7e4","line":349,"updated":"2016-03-14 19:42:09.000000000","message":"FWIW, I believe it\u0027s a bit obscure that the lack of admin password means a new admin needs to be created. Since this is a private method, I think it\u0027s not as critical. However, I would recommend documenting this behavior in the docstring below.","commit_id":"0fe4ca067a3dff575c02987d9c0eba44a5fae945"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"ee8a553f9451cf74085c7fb8d7f4d7fc751242f3","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        return False"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def _add_query_routers(self, query_routers, config_server_ips,"},{"line_number":349,"context_line":"                           admin_password\u003dNone):"},{"line_number":350,"context_line":"        \"\"\"Configure the given query routers for the cluster."},{"line_number":351,"context_line":"        If this is a new_cluster an admin user will be created with a randomly"},{"line_number":352,"context_line":"        generated password, else the password needs to be retrieved from"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_4e301f57","line":349,"in_reply_to":"3afc51ec_ede8c7e4","updated":"2016-03-15 21:33:04.000000000","message":"I think from the doc string that is there this is implied because its a new cluster. If its growing an existing cluster we get the existing password and use it by passing the value in here. I think its clear to me but maybe thats because i have a good understanding of this datastore and others that i\u0027ve worked on around clustering.","commit_id":"0fe4ca067a3dff575c02987d9c0eba44a5fae945"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2961139971722f045a9b5c9d6bf265d0b69d8521","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    def _add_query_routers(self, query_routers, config_server_ips,"},{"line_number":349,"context_line":"                           admin_password\u003dNone):"},{"line_number":350,"context_line":"        \"\"\"Configure the given query routers for the cluster."},{"line_number":351,"context_line":"        If this is a new_cluster an admin user will be created with a randomly"},{"line_number":352,"context_line":"        generated password, else the password needs to be retrieved from"},{"line_number":353,"context_line":"        and existing query router."},{"line_number":354,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_177d31e7","line":351,"range":{"start_line":351,"start_character":21,"end_line":351,"end_character":32},"updated":"2016-03-17 11:18:22.000000000","message":"Craig, I agree part of this is implied. However, as far as I can tell, the docstring doesn\u0027t mention that when the `admin_password` is None, a new admin will be created.\n\nI\u0027d honestly prefer not having these things implied and the `new_cluster` reference should be updated.\n\nIt\u0027d be cool if we could have the params being added to this docstring in this same patch since we\u0027re updating it already.","commit_id":"0fe4ca067a3dff575c02987d9c0eba44a5fae945"}]}