)]}'
{"trove/common/strategies/cluster/experimental/pxc/api.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"c637c678bcf6023bf198744c43c85a420a42d72c","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        return PXCCluster(context, db_info, datastore, datastore_version)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def shrink(self, instances):"},{"line_number":208,"context_line":"        \"\"\"Removes instances from a cluster.\"\"\""},{"line_number":209,"context_line":"        LOG.debug(\"Shrinking cluster %s.\" % self.id)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_67d29702","line":207,"updated":"2015-12-17 21:36:43.000000000","message":"Make the parameter be instance_ids for clarity","commit_id":"f05526747f8990509dfacdbc8ff1f833cb7c02d6"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"c637c678bcf6023bf198744c43c85a420a42d72c","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        \"\"\"Removes instances from a cluster.\"\"\""},{"line_number":209,"context_line":"        LOG.debug(\"Shrinking cluster %s.\" % self.id)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        context \u003d self.context"},{"line_number":212,"context_line":"        db_info \u003d self.db_info"},{"line_number":213,"context_line":"        datastore \u003d self.ds"},{"line_number":214,"context_line":"        datastore_version \u003d self.ds_version"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_47451bb1","line":211,"updated":"2015-12-17 21:36:43.000000000","message":"Is this really necessary?  You\u0027re only using it in 2 of the 3 cases below.","commit_id":"f05526747f8990509dfacdbc8ff1f833cb7c02d6"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"c637c678bcf6023bf198744c43c85a420a42d72c","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        context \u003d self.context"},{"line_number":212,"context_line":"        db_info \u003d self.db_info"},{"line_number":213,"context_line":"        datastore \u003d self.ds"},{"line_number":214,"context_line":"        datastore_version \u003d self.ds_version"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        self.validate_cluster_available()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_e763e718","line":213,"updated":"2015-12-17 21:36:43.000000000","message":"This is only used once below.  Is it really clarifying anything by redefining it?","commit_id":"f05526747f8990509dfacdbc8ff1f833cb7c02d6"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"c637c678bcf6023bf198744c43c85a420a42d72c","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        datastore_version \u003d self.ds_version"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        self.validate_cluster_available()"},{"line_number":217,"context_line":"        cluster_info \u003d self.db_info"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        removal_instances \u003d [Instance.load(self.context, inst_id)"},{"line_number":220,"context_line":"                             for inst_id in instances]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_47e19b99","line":217,"updated":"2015-12-17 21:36:43.000000000","message":"Why have both db_info and cluster_info if they\u0027re the same thing?  Pick one and use it consistently.","commit_id":"f05526747f8990509dfacdbc8ff1f833cb7c02d6"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"658c03e13ad665bc6296db824a727d6ebbad06f3","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        datastore_version \u003d self.ds_version"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        self.validate_cluster_available()"},{"line_number":217,"context_line":"        cluster_info \u003d self.db_info"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        removal_instances \u003d [Instance.load(self.context, inst_id)"},{"line_number":220,"context_line":"                             for inst_id in instances]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_cd4a1455","line":217,"in_reply_to":"3a7e1126_47e19b99","updated":"2015-12-21 16:57:23.000000000","message":"i was using these local variables to shorten the variables to use below but i think i went a little over board and it doesnt look like it helps the length much.\nRemoving these.","commit_id":"f05526747f8990509dfacdbc8ff1f833cb7c02d6"}],"trove/tests/api/pxc.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"a707156074de32b9ca8899d5b96460cc948aa4a6","unresolved":false,"context_lines":[{"line_number":361,"context_line":"    def test_grow_cluster_communication(self):"},{"line_number":362,"context_line":"        self._test_cluster_communication(db_name\u003d\"clustergrowdb\")"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    @test(depends_on\u003d[test_grow_cluster_communication])"},{"line_number":365,"context_line":"    def test_cluster_shrink(self):"},{"line_number":366,"context_line":"        cluster \u003d self.rd_client.clusters.get(self.cluster)"},{"line_number":367,"context_line":"        self.removed_instance_id \u003d cluster.instances[0][\u0027id\u0027]"},{"line_number":368,"context_line":"        valid_request_body \u003d ["},{"line_number":369,"context_line":"            {"},{"line_number":370,"context_line":"                \"id\": self.removed_instance_id"},{"line_number":371,"context_line":"            },"},{"line_number":372,"context_line":"        ]"},{"line_number":373,"context_line":"        self.cluster \u003d self.rd_client.clusters.shrink("},{"line_number":374,"context_line":"            self.cluster,"},{"line_number":375,"context_line":"            instances\u003dvalid_request_body)"},{"line_number":376,"context_line":"        asserts.assert_equal(202, self.rd_client.last_http_code)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @test(depends_on\u003d[test_cluster_shrink])"},{"line_number":379,"context_line":"    def test_wait_until_cluster_shrink_is_active(self):"},{"line_number":380,"context_line":"        self.test_wait_until_cluster_is_active()"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    @test(depends_on\u003d[test_wait_until_cluster_shrink_is_active])"},{"line_number":383,"context_line":"    def test_cluster_verify_shrink(self):"},{"line_number":384,"context_line":"        cluster \u003d self.rd_client.clusters.get(self.cluster)"},{"line_number":385,"context_line":"        instances \u003d cluster.instances"},{"line_number":386,"context_line":"        asserts.assert_true(len(instances) \u003c len(self.cluster.instances))"},{"line_number":387,"context_line":"        instance_ids \u003d [inst[\u0027id\u0027] for inst in instances]"},{"line_number":388,"context_line":"        asserts.assert_true(not(self.removed_instance_id in instance_ids))"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    @test(depends_on\u003d[test_cluster_verify_shrink])"},{"line_number":391,"context_line":"    def test_shrink_cluster_has_existing_database(self):"},{"line_number":392,"context_line":"        self._check_cluster_has_database(\u0027clustercreatedb\u0027)"},{"line_number":393,"context_line":"        self._check_cluster_has_database(\u0027clustergrowdb\u0027)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    @test(depends_on\u003d[test_shrink_cluster_has_existing_database])"},{"line_number":396,"context_line":"    def test_shrink_cluster_communication(self):"},{"line_number":397,"context_line":"        self._test_cluster_communication(db_name\u003d\"clustershrinkdb\")"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    @test(depends_on\u003d[test_wait_until_cluster_is_active],"},{"line_number":400,"context_line":"          runs_after\u003d[test_shrink_cluster_communication])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_f0dfa3d3","line":397,"range":{"start_line":364,"start_character":0,"end_line":397,"end_character":67},"updated":"2015-12-21 17:30:47.000000000","message":"This again just duplicates the logic already implemented by https://review.openstack.org/#/c/244176/\n\nIf you want to get data-operations tests running for PXC in the above patch set just add a pxc helper (which can be just a pure extension of the MySQL helper).","commit_id":"24acbcc399592ad866372590486314681c60593e"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"026590695abb9c3a295fd7cdd458943bb59f5bda","unresolved":false,"context_lines":[{"line_number":361,"context_line":"    def test_grow_cluster_communication(self):"},{"line_number":362,"context_line":"        self._test_cluster_communication(db_name\u003d\"clustergrowdb\")"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    @test(depends_on\u003d[test_grow_cluster_communication])"},{"line_number":365,"context_line":"    def test_cluster_shrink(self):"},{"line_number":366,"context_line":"        cluster \u003d self.rd_client.clusters.get(self.cluster)"},{"line_number":367,"context_line":"        self.removed_instance_id \u003d cluster.instances[0][\u0027id\u0027]"},{"line_number":368,"context_line":"        valid_request_body \u003d ["},{"line_number":369,"context_line":"            {"},{"line_number":370,"context_line":"                \"id\": self.removed_instance_id"},{"line_number":371,"context_line":"            },"},{"line_number":372,"context_line":"        ]"},{"line_number":373,"context_line":"        self.cluster \u003d self.rd_client.clusters.shrink("},{"line_number":374,"context_line":"            self.cluster,"},{"line_number":375,"context_line":"            instances\u003dvalid_request_body)"},{"line_number":376,"context_line":"        asserts.assert_equal(202, self.rd_client.last_http_code)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @test(depends_on\u003d[test_cluster_shrink])"},{"line_number":379,"context_line":"    def test_wait_until_cluster_shrink_is_active(self):"},{"line_number":380,"context_line":"        self.test_wait_until_cluster_is_active()"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    @test(depends_on\u003d[test_wait_until_cluster_shrink_is_active])"},{"line_number":383,"context_line":"    def test_cluster_verify_shrink(self):"},{"line_number":384,"context_line":"        cluster \u003d self.rd_client.clusters.get(self.cluster)"},{"line_number":385,"context_line":"        instances \u003d cluster.instances"},{"line_number":386,"context_line":"        asserts.assert_true(len(instances) \u003c len(self.cluster.instances))"},{"line_number":387,"context_line":"        instance_ids \u003d [inst[\u0027id\u0027] for inst in instances]"},{"line_number":388,"context_line":"        asserts.assert_true(not(self.removed_instance_id in instance_ids))"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    @test(depends_on\u003d[test_cluster_verify_shrink])"},{"line_number":391,"context_line":"    def test_shrink_cluster_has_existing_database(self):"},{"line_number":392,"context_line":"        self._check_cluster_has_database(\u0027clustercreatedb\u0027)"},{"line_number":393,"context_line":"        self._check_cluster_has_database(\u0027clustergrowdb\u0027)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    @test(depends_on\u003d[test_shrink_cluster_has_existing_database])"},{"line_number":396,"context_line":"    def test_shrink_cluster_communication(self):"},{"line_number":397,"context_line":"        self._test_cluster_communication(db_name\u003d\"clustershrinkdb\")"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    @test(depends_on\u003d[test_wait_until_cluster_is_active],"},{"line_number":400,"context_line":"          runs_after\u003d[test_shrink_cluster_communication])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_4659218d","line":397,"range":{"start_line":364,"start_character":0,"end_line":397,"end_character":67},"in_reply_to":"3a7e1126_f0dfa3d3","updated":"2015-12-21 18:09:51.000000000","message":"ah ok that sounds good to move it all to the scenarios since its not being run in the gate now. I\u0027ll get this moved.","commit_id":"24acbcc399592ad866372590486314681c60593e"}]}
