)]}'
{"trove/guestagent/datastore/manager.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"ee26cfd530f355a4fca67e8ea52372b4bdcca298","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                          ex.message)"},{"line_number":187,"context_line":"            raise"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _apply_overrides_on_prepare(self, context, overrides):"},{"line_number":190,"context_line":"        self.update_overrides(context, overrides)"},{"line_number":191,"context_line":"        self.restart(context)"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba63e191_7a30fe01","line":189,"updated":"2016-01-19 18:51:09.000000000","message":"You mention in the commit message that you expect that this method may be overridden.  That being the case, this method should not start with an underscore.","commit_id":"8d3b11195d5974115f4e8ceb743bb0f2e2cdcb39"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"600c7276bf943cc35b70a492661cbd53328d0844","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            self.do_prepare(context, packages, databases, memory_mb,"},{"line_number":135,"context_line":"                            users, device_path, mount_point, backup_info,"},{"line_number":136,"context_line":"                            config_contents, root_password, overrides,"},{"line_number":137,"context_line":"                            cluster_config, snapshot)"},{"line_number":138,"context_line":"            if overrides:"},{"line_number":139,"context_line":"                LOG.info(_(\"Applying user-specified configuration \""},{"line_number":140,"context_line":"                           \"(called from \u0027prepare\u0027).\"))"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_244fc6be","line":137,"updated":"2016-01-21 16:13:23.000000000","message":"We really don\u0027t need to pass \u0027overrides\u0027 in the do_prepare function call, do we?","commit_id":"3791ddc497c3199e536a3d2d69a486d9c77eb3de"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"296bab62bed2effff291d9ed465417c37510aaf8","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            self.do_prepare(context, packages, databases, memory_mb,"},{"line_number":135,"context_line":"                            users, device_path, mount_point, backup_info,"},{"line_number":136,"context_line":"                            config_contents, root_password, overrides,"},{"line_number":137,"context_line":"                            cluster_config, snapshot)"},{"line_number":138,"context_line":"            if overrides:"},{"line_number":139,"context_line":"                LOG.info(_(\"Applying user-specified configuration \""},{"line_number":140,"context_line":"                           \"(called from \u0027prepare\u0027).\"))"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_713c8ce2","line":137,"in_reply_to":"9a68dd71_244fc6be","updated":"2016-01-21 21:54:54.000000000","message":"You are right, I would however keep it in the signature at least for the time being just in case some datastore needs it. Also it\u0027s good for completeness, other properties are passed in.","commit_id":"3791ddc497c3199e536a3d2d69a486d9c77eb3de"}],"trove/tests/unittests/guestagent/test_manager.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"ee26cfd530f355a4fca67e8ea52372b4bdcca298","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from trove.tests.unittests import trove_testtools"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class MockManager(manager.Manager):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"},{"line_number":31,"context_line":"        super(MockManager, self).__init__(\u0027mysql\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba63e191_6d636add","line":28,"updated":"2016-01-19 18:51:09.000000000","message":"Small nit, but since I\u0027m -1ing anyways: Could you call this ManagerMock or something - MockManager suggests a manager that manages Mocks, but it\u0027s really Mocking a Manager.","commit_id":"8d3b11195d5974115f4e8ceb743bb0f2e2cdcb39"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"c329f2d6c3ac8dcc82fe90efa954beff8ef03fb8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from trove.tests.unittests import trove_testtools"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class MockedManager(manager.Manager):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"},{"line_number":31,"context_line":"        super(MockedManager, self).__init__(\u0027mysql\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_c6af1793","line":28,"updated":"2016-01-20 14:46:41.000000000","message":"Why not go with Morgan\u0027s suggestion of ManagerMock? All other variable names for mock objects are xxx_mock. Again, this sounds like it is a manager of mocked objects.","commit_id":"3791ddc497c3199e536a3d2d69a486d9c77eb3de"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"296bab62bed2effff291d9ed465417c37510aaf8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from trove.tests.unittests import trove_testtools"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class MockedManager(manager.Manager):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"},{"line_number":31,"context_line":"        super(MockedManager, self).__init__(\u0027mysql\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_34436244","line":28,"in_reply_to":"9a68dd71_c6af1793","updated":"2016-01-21 21:54:54.000000000","message":"I think this is more in line with other names used in tests like \"FakeSwiftConnection\". Also this object is not really a \u0027mock\u0027, but rather a \u0027mocked\u0027 manager.","commit_id":"3791ddc497c3199e536a3d2d69a486d9c77eb3de"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3f09837f604872e143d23edac84e28db7683df86","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from trove.tests.unittests import trove_testtools"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class MockedManager(manager.Manager):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(MockedManager, self).__init__(\u0027mysql\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a68dd71_deba53c0","line":36,"range":{"start_line":36,"start_character":10,"end_line":36,"end_character":12},"updated":"2016-01-26 23:45:30.000000000","message":"(in response to the comments on patchset 10\u002611):\nActually, all mock (or fake) classes are prefixed with \u0027Mock\u0027 (or \u0027Fake\u0027) as a quick grep will show.  I think MockManager is a better name and consistent with other mock object classes (like, for example, MockStorage, which isn\u0027t a storage for mocks or FakeCatalog, which isn\u0027t a catalog of fakes ;) ).","commit_id":"5038e8fdcca7fad6a464f82b0e5745c83e7dbe52"}]}