)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"a1966db3efb8b6a3e85b4f6214fcb51226fc8bf1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Restore redis error with \"cannot access `/var/lib/redis/dump.rdb\u0027: No such file or directory\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I install my redis guestagent image in ubuntu 12.04. When i restore an instance, there has an error in guestagent log."},{"line_number":10,"context_line":"I think the dump.rdb is as like the redis\u0027s snapshot, but the restore instance is a new image, so there do not has a dump.rdb."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixes Bug1528244"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_ac9eb160","line":9,"updated":"2015-12-21 15:07:16.000000000","message":"Please keep lines as long as 79 columns,\nread the commit message guide \nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"2bfa6ffa4a6488768f91dfac3e3720e133fc3989"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"a1966db3efb8b6a3e85b4f6214fcb51226fc8bf1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"I install my redis guestagent image in ubuntu 12.04. When i restore an instance, there has an error in guestagent log."},{"line_number":10,"context_line":"I think the dump.rdb is as like the redis\u0027s snapshot, but the restore instance is a new image, so there do not has a dump.rdb."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixes Bug1528244"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I422d68343867638c0ea6272266a21c6e73349de7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_ec7fd912","line":12,"updated":"2015-12-21 15:07:16.000000000","message":"Here should be in the format Fixes Bug: #1528244","commit_id":"2bfa6ffa4a6488768f91dfac3e3720e133fc3989"}],"trove/guestagent/strategies/restore/experimental/redis_impl.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"819a8098546f9525d28f82b0b4ec67eb0df11145","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.app.stop_db()"},{"line_number":48,"context_line":"        LOG.info(_(\"Cleaning out restore location: %s.\"),"},{"line_number":49,"context_line":"                 self.restore_location)"},{"line_number":50,"context_line":"        if os.path.exists(self.restore_location):"},{"line_number":51,"context_line":"            operating_system.chmod(self.restore_location, FileMode.SET_FULL,"},{"line_number":52,"context_line":"                                   as_root\u003dTrue)"},{"line_number":53,"context_line":"            utils.clean_out(self.restore_location)"},{"line_number":54,"context_line":"        # IF AOF is set, we need to turn it off temporarily"},{"line_number":55,"context_line":"        if self.aof_set:"},{"line_number":56,"context_line":"            self.app.configuration_manager.apply_system_override("}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_9b5dc5eb","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":50},"updated":"2015-12-23 16:18:23.000000000","message":"Morgan is right - this code assumes a directory and for Redis it\u0027s just a file (I must have copied the wrong code when writing this :( ).  How about something like:\n\n        LOG.info(_(\"Removing old persistence file: %s.\"),\n                 self.restore_location)\n        operating_system.remove(self.restore_location, force\u003dTrue)\n        dir \u003d os.path.dirname(self.restore_location)\n        operating_system.create_directory(dir, as_root\u003dTrue)\n        operating_system.chmod(dir, FileMode.SET_FULL, as_root\u003dTrue)\n\nNote: I haven\u0027t tested this - I\u0027ll try and do that tomorrow","commit_id":"0dd787f9726ceb5046e362b6297cf8b94b194e30"}]}
