)]}'
{"trove/guestagent/datastore/manager.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"0b67cf9109786ab7c0a991731614e9b030bd7dc9","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                    LOG.info(_(\u0027Root enabled successfully.\u0027))"},{"line_number":174,"context_line":"            except Exception as ex:"},{"line_number":175,"context_line":"                LOG.exception(_(\"An error occurred creating databases/users: \""},{"line_number":176,"context_line":"                                \"%s\") % ex.message)"},{"line_number":177,"context_line":"                raise"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_af9cb96a","line":176,"updated":"2016-01-09 13:27:26.000000000","message":"We should probably make this error message more generic now.","commit_id":"4d35f89ca4f102fd0e73f01cf9b76ce22983d2a2"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"be2925da9e30e165dd79ea675a8ea35e6b0cfd1f","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            # that may already have root enabled in which case we keep it"},{"line_number":177,"context_line":"            # unchanged."},{"line_number":178,"context_line":"            #"},{"line_number":179,"context_line":"            # TODO(pmalik): If restoring a backup we should report root status"},{"line_number":180,"context_line":"            # here as well. In order to do that we would need to know the"},{"line_number":181,"context_line":"            # root\u0027s name. This task will be simplified once we have proper"},{"line_number":182,"context_line":"            # user models in place"},{"line_number":183,"context_line":"            # ( see: https://review.openstack.org/#/c/236082/ )."},{"line_number":184,"context_line":"            if root_password and not backup_info:"},{"line_number":185,"context_line":"                try:"},{"line_number":186,"context_line":"                    LOG.info(_(\"Enabling root user (with password).\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_686b11ba","line":183,"range":{"start_line":179,"start_character":0,"end_line":183,"end_character":64},"updated":"2016-01-10 15:20:51.000000000","message":"We have 102 \u0027TODO\u0027 designations in the Trove code right now, most of which are several years old, and I\u0027m thinking that this isn\u0027t the place to put these.  If they\u0027re bugs that need to be fixed, we should use launchpad so we can track/triage and/or discuss them.  Putting them in the source code pretty much means we\u0027ll never deal with them (IMO).  I\u0027ll bring this up in our next meeting.","commit_id":"a1f252830d1a9f2dbe4e0da3c13bdba0fc0042ca"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"ad495e51e4736ea21e2dae9bdf3b6e5e02b369b9","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            # unchanged."},{"line_number":178,"context_line":"            if root_password and not backup_info:"},{"line_number":179,"context_line":"                try:"},{"line_number":180,"context_line":"                    LOG.info(_(\"Enabling root user (with password).\"))"},{"line_number":181,"context_line":"                    self._enable_root_on_prepare(context, root_password)"},{"line_number":182,"context_line":"                    LOG.info(_(\u0027Root enabled successfully.\u0027))"},{"line_number":183,"context_line":"                except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_11c6be16","line":180,"updated":"2016-01-16 12:48:13.000000000","message":"wow, seems excessive but looking at the rest of the module, it is consistent.","commit_id":"2cf87024501e235922034d52e3a000e0be01a76f"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"e3ec935d877f06684c0b07b0f314af4065147f07","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            if root_password and not backup_info:"},{"line_number":304,"context_line":"                try:"},{"line_number":305,"context_line":"                    LOG.info(_(\"Enabling root user (with password).\"))"},{"line_number":306,"context_line":"                    self.enable_root_on_prepare(context, root_password)"},{"line_number":307,"context_line":"                    LOG.info(_(\u0027Root enabled successfully.\u0027))"},{"line_number":308,"context_line":"                except Exception as ex:"},{"line_number":309,"context_line":"                    LOG.exception(_(\"An error occurred enabling root user: \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_d248318a","line":306,"range":{"start_line":306,"start_character":25,"end_line":306,"end_character":47},"updated":"2016-01-27 14:24:07.000000000","message":"Do we really need another hook here?  enable_root_on_prepare just calls enable_root_with_password - maybe we should cut out the middleman.","commit_id":"d75e6b56bf037a6ab7849ddaa732432d62de4194"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"6c3bc9287e9cd56c5a56501bf9ef68823216cebf","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            if root_password and not backup_info:"},{"line_number":304,"context_line":"                try:"},{"line_number":305,"context_line":"                    LOG.info(_(\"Enabling root user (with password).\"))"},{"line_number":306,"context_line":"                    self.enable_root_on_prepare(context, root_password)"},{"line_number":307,"context_line":"                    LOG.info(_(\u0027Root enabled successfully.\u0027))"},{"line_number":308,"context_line":"                except Exception as ex:"},{"line_number":309,"context_line":"                    LOG.exception(_(\"An error occurred enabling root user: \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_d45b3353","line":306,"range":{"start_line":306,"start_character":25,"end_line":306,"end_character":47},"in_reply_to":"7a5de9d1_1bb9fee9","updated":"2016-01-27 17:24:25.000000000","message":"I understand that, however maybe this should be added if it\u0027s needed (I suspect it won\u0027t however, so there will now be an unnecessary call in the code).  I\u0027ll take off the -1, but I\u0027m curious what others think.","commit_id":"d75e6b56bf037a6ab7849ddaa732432d62de4194"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"a960aafb471121735f977fee6e9f5346e59e9a25","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            if root_password and not backup_info:"},{"line_number":304,"context_line":"                try:"},{"line_number":305,"context_line":"                    LOG.info(_(\"Enabling root user (with password).\"))"},{"line_number":306,"context_line":"                    self.enable_root_on_prepare(context, root_password)"},{"line_number":307,"context_line":"                    LOG.info(_(\u0027Root enabled successfully.\u0027))"},{"line_number":308,"context_line":"                except Exception as ex:"},{"line_number":309,"context_line":"                    LOG.exception(_(\"An error occurred enabling root user: \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_a5967f92","line":306,"range":{"start_line":306,"start_character":25,"end_line":306,"end_character":47},"in_reply_to":"7a5de9d1_254daf72","updated":"2016-01-27 18:14:46.000000000","message":"* not sure if it is intended, if so, we should probably add a no-op implementation for it in this patch set...","commit_id":"d75e6b56bf037a6ab7849ddaa732432d62de4194"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"c9acf3b6d90968ed1b8689586de7e54974106c71","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            if root_password and not backup_info:"},{"line_number":304,"context_line":"                try:"},{"line_number":305,"context_line":"                    LOG.info(_(\"Enabling root user (with password).\"))"},{"line_number":306,"context_line":"                    self.enable_root_on_prepare(context, root_password)"},{"line_number":307,"context_line":"                    LOG.info(_(\u0027Root enabled successfully.\u0027))"},{"line_number":308,"context_line":"                except Exception as ex:"},{"line_number":309,"context_line":"                    LOG.exception(_(\"An error occurred enabling root user: \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_1bb9fee9","line":306,"range":{"start_line":306,"start_character":25,"end_line":306,"end_character":47},"in_reply_to":"7a5de9d1_d248318a","updated":"2016-01-27 16:28:13.000000000","message":"It\u0027s there for added flexibility. I just did not want to assume that the implementation of \u0027enable_root_with_password\u0027 would always be the same as that of \u0027enable_root_on_prepare\u0027.\n\nPutting it in its own method also allows datastores to \u0027skip/disable\u0027 this behavior, while keeping the other root calls intact, by simply overriding it with no-op.","commit_id":"d75e6b56bf037a6ab7849ddaa732432d62de4194"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"96434caaecee5700e3ad830ea8c567ca3627ff77","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            if root_password and not backup_info:"},{"line_number":304,"context_line":"                try:"},{"line_number":305,"context_line":"                    LOG.info(_(\"Enabling root user (with password).\"))"},{"line_number":306,"context_line":"                    self.enable_root_on_prepare(context, root_password)"},{"line_number":307,"context_line":"                    LOG.info(_(\u0027Root enabled successfully.\u0027))"},{"line_number":308,"context_line":"                except Exception as ex:"},{"line_number":309,"context_line":"                    LOG.exception(_(\"An error occurred enabling root user: \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_ef7bf879","line":306,"range":{"start_line":306,"start_character":25,"end_line":306,"end_character":47},"in_reply_to":"7a5de9d1_d45b3353","updated":"2016-01-27 17:28:58.000000000","message":"By the same token, we could have added create_user_on_prepare and create_database_on_prepare above.  Seems to me a bit overkill.","commit_id":"d75e6b56bf037a6ab7849ddaa732432d62de4194"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"8c6bf231f597a848da24f7f60c85ac3973315cee","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            if root_password and not backup_info:"},{"line_number":304,"context_line":"                try:"},{"line_number":305,"context_line":"                    LOG.info(_(\"Enabling root user (with password).\"))"},{"line_number":306,"context_line":"                    self.enable_root_on_prepare(context, root_password)"},{"line_number":307,"context_line":"                    LOG.info(_(\u0027Root enabled successfully.\u0027))"},{"line_number":308,"context_line":"                except Exception as ex:"},{"line_number":309,"context_line":"                    LOG.exception(_(\"An error occurred enabling root user: \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_254daf72","line":306,"range":{"start_line":306,"start_character":25,"end_line":306,"end_character":47},"in_reply_to":"7a5de9d1_d45b3353","updated":"2016-01-27 18:12:36.000000000","message":"Well, one example would be Vertica which calls \u0027enable_root_with_password\u0027 from it\u0027s clustering strategy (cluster-wide root-enable) but does not implement root-enable on prepare...","commit_id":"d75e6b56bf037a6ab7849ddaa732432d62de4194"}]}