)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"39c832916e85b7179a7b0a94c69890b465cf00c5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# iniset_conditional() - Sets the value in the inifile, but only if it\u0027s"},{"line_number":83,"context_line":"# actually got a value"},{"line_number":84,"context_line":"function iniset_conditional {"},{"line_number":85,"context_line":"    local FILE\u003d$1"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5a18252c_2b15443f","line":82,"updated":"2016-04-14 15:27:14.000000000","message":"I\u0027d be much happier if this went to devstack/inc/ini-config which is really where it should be ...","commit_id":"af34b9ae06430602f2df1319333f5dbdf9e89f83"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e36aa497de1463047ee3cbb07395188663576dee","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    iniset $TROVE_CONF DEFAULT trove_api_workers \"$API_WORKERS\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    # Set common configuration values"},{"line_number":119,"context_line":"    iniset_conditional $TROVE_CONF DEFAULT max_accepted_volume_size $TROVE_MAX_ACCEPTED_VOLUME_SIZE"},{"line_number":120,"context_line":"    iniset_conditional $TROVE_CONF DEFAULT max_instances_per_tenant $TROVE_MAX_INSTANCES_PER_TENANT"},{"line_number":121,"context_line":"    iniset_conditional $TROVE_CONF DEFAULT max_volumes_per_tenant $TROVE_MAX_VOLUMES_PER_TENANT"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"1a122d0e_f658d558","line":119,"updated":"2016-04-16 15:14:02.000000000","message":"well, if you want to make that change, you may also want to make this block conditional on tr-api service ...","commit_id":"7222a12034e181a67b479a84d40d309266a1f0f6"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"0760758b78f74fc6e1693e5c50c4f9cc3002ef78","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    iniset $TROVE_CONF DEFAULT trove_api_workers \"$API_WORKERS\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    # Set common configuration values"},{"line_number":119,"context_line":"    iniset_conditional $TROVE_CONF DEFAULT max_accepted_volume_size $TROVE_MAX_ACCEPTED_VOLUME_SIZE"},{"line_number":120,"context_line":"    iniset_conditional $TROVE_CONF DEFAULT max_instances_per_tenant $TROVE_MAX_INSTANCES_PER_TENANT"},{"line_number":121,"context_line":"    iniset_conditional $TROVE_CONF DEFAULT max_volumes_per_tenant $TROVE_MAX_VOLUMES_PER_TENANT"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"1a122d0e_d5b6ebf7","line":119,"in_reply_to":"1a122d0e_f658d558","updated":"2016-04-20 06:31:52.000000000","message":"Done","commit_id":"7222a12034e181a67b479a84d40d309266a1f0f6"}],"devstack/settings":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4d9859bdc0c8b729bbb2e277798b7808b9bf2a8c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"TROVE_DATASTORE_VERSION\u003d${TROVE_DATASTORE_VERSION:-\"5.6\"}"},{"line_number":24,"context_line":"TROVE_DATASTORE_PACKAGE\u003d${TROVE_DATASTORE_PACKAGE:-\"mysql-server-5.6\"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Set up configuration values"},{"line_number":27,"context_line":"TROVE_MAX_ACCEPTED_VOLUME_SIZE\u003d${TROVE_MAX_ACCEPTED_VOLUME_SIZE:-10}"},{"line_number":28,"context_line":"TROVE_MAX_INSTANCES_PER_USER\u003d${TROVE_MAX_INSTANCES_PER_USER:-10}"},{"line_number":29,"context_line":"TROVE_MAX_VOLUMES_PER_USER\u003d${TROVE_MAX_VOLUMES_PER_USER:-10}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1af94dfe_a07186aa","line":26,"updated":"2016-03-17 15:49:46.000000000","message":"Any reason why we need to set default values here rather than relying on Trove\u0027s default values?","commit_id":"1309b99164bfb7a56b468f8ef2b90f37dfea15a0"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cc7436bc6e04c060827726655c1d55f8007559f5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"TROVE_DATASTORE_VERSION\u003d${TROVE_DATASTORE_VERSION:-\"5.6\"}"},{"line_number":24,"context_line":"TROVE_DATASTORE_PACKAGE\u003d${TROVE_DATASTORE_PACKAGE:-\"mysql-server-5.6\"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Set up configuration values"},{"line_number":27,"context_line":"TROVE_MAX_ACCEPTED_VOLUME_SIZE\u003d${TROVE_MAX_ACCEPTED_VOLUME_SIZE:-10}"},{"line_number":28,"context_line":"TROVE_MAX_INSTANCES_PER_USER\u003d${TROVE_MAX_INSTANCES_PER_USER:-10}"},{"line_number":29,"context_line":"TROVE_MAX_VOLUMES_PER_USER\u003d${TROVE_MAX_VOLUMES_PER_USER:-10}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba0121b8_4d284b9a","line":26,"in_reply_to":"1af94dfe_a07186aa","updated":"2016-04-01 15:24:42.000000000","message":"Are you implying that we shouldn\u0027t make this configurable?  If we don\u0027t put in defaults here the code will break if the variables aren\u0027t defined (and the average devstack user probably won\u0027t define these variables).","commit_id":"1309b99164bfb7a56b468f8ef2b90f37dfea15a0"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4d9859bdc0c8b729bbb2e277798b7808b9bf2a8c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"TROVE_MAX_VOLUMES_PER_USER\u003d${TROVE_MAX_VOLUMES_PER_USER:-10}"},{"line_number":30,"context_line":"TROVE_AGENT_CALL_HIGH_TIMEOUT\u003d${TROVE_AGENT_CALL_HIGH_TIMEOUT:-300}"},{"line_number":31,"context_line":"TROVE_RESIZE_TIME_OUT\u003d${TROVE_RESIZE_TIME_OUT:-900}"},{"line_number":32,"context_line":"TROVE_USAGE_TIMEOUT\u003d${TROVE_USAGE_TIMEOUT:-1500}"},{"line_number":33,"context_line":"TROVE_STATE_CHANGE_WAIT_TIME\u003d${TROVE_STATE_CHANGE_WAIT_TIME:-180}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Set up the host gateway"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1af94dfe_20c4565d","line":32,"updated":"2016-03-17 15:49:46.000000000","message":"For example, the common `usage_timeout` option defaults to 900[0] (although it\u0027s 600 in the sample config file, perhaps needs to be updated?).\n\nIf there\u0027s no specific reason to do this, I\u0027d rather use the defaults in the config file. Perhaps we should update those default values?\n\n[0] http://git.openstack.org/cgit/openstack/trove/tree/trove/common/cfg.py#n393","commit_id":"1309b99164bfb7a56b468f8ef2b90f37dfea15a0"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cc7436bc6e04c060827726655c1d55f8007559f5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"TROVE_MAX_VOLUMES_PER_USER\u003d${TROVE_MAX_VOLUMES_PER_USER:-10}"},{"line_number":30,"context_line":"TROVE_AGENT_CALL_HIGH_TIMEOUT\u003d${TROVE_AGENT_CALL_HIGH_TIMEOUT:-300}"},{"line_number":31,"context_line":"TROVE_RESIZE_TIME_OUT\u003d${TROVE_RESIZE_TIME_OUT:-900}"},{"line_number":32,"context_line":"TROVE_USAGE_TIMEOUT\u003d${TROVE_USAGE_TIMEOUT:-1500}"},{"line_number":33,"context_line":"TROVE_STATE_CHANGE_WAIT_TIME\u003d${TROVE_STATE_CHANGE_WAIT_TIME:-180}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Set up the host gateway"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba0121b8_58d487ea","line":32,"in_reply_to":"1af94dfe_20c4565d","updated":"2016-04-01 15:24:42.000000000","message":"I can change the values here to match the config file, but they\u0027ll go out of sync pretty quickly (no-one will remember to update this file if the default changes). We need a \u0027default\u0027 value here (see my comment above) but we\u0027ll never use them, since they\u0027re being set in redstack for trove development.","commit_id":"1309b99164bfb7a56b468f8ef2b90f37dfea15a0"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"212d68ef91e572883d62ba899d8e7fed77d526bf","unresolved":false,"context_lines":[{"line_number":29,"context_line":"TROVE_MAX_VOLUMES_PER_USER\u003d${TROVE_MAX_VOLUMES_PER_USER:-10}"},{"line_number":30,"context_line":"TROVE_AGENT_CALL_HIGH_TIMEOUT\u003d${TROVE_AGENT_CALL_HIGH_TIMEOUT:-300}"},{"line_number":31,"context_line":"TROVE_RESIZE_TIME_OUT\u003d${TROVE_RESIZE_TIME_OUT:-900}"},{"line_number":32,"context_line":"TROVE_USAGE_TIMEOUT\u003d${TROVE_USAGE_TIMEOUT:-1500}"},{"line_number":33,"context_line":"TROVE_STATE_CHANGE_WAIT_TIME\u003d${TROVE_STATE_CHANGE_WAIT_TIME:-180}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Set up the host gateway"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba0121b8_3b16ea4b","line":32,"in_reply_to":"ba0121b8_58d487ea","updated":"2016-04-01 16:26:35.000000000","message":"You can check if these variables are set and change the config files in the script. It\u0027s a bit more code but, at least, we\u0027ll avoid them going out of sync. Creating a \"_change_config_if_var_set\" function should be simple enough. I wonder if iniset is already smart enough to do that.\n\nOtherwise, as much as I hate the fact they\u0027ll go out of sync, I think we should use the current Trove defaults here. Although, I would prefer doing what I mentioned above.","commit_id":"1309b99164bfb7a56b468f8ef2b90f37dfea15a0"}]}