)]}'
{"trove/tests/unittests/backup/test_backupagent.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"280ca0abf87f929dc74d51103e02898b6e5dc000","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            backup_id\u003dbackup_info[\u0027id\u0027],"},{"line_number":330,"context_line":"            sent\u003dANY,"},{"line_number":331,"context_line":"            size\u003dANY,"},{"line_number":332,"context_line":"            checksum\u003dANY,"},{"line_number":333,"context_line":"            location\u003dANY,"},{"line_number":334,"context_line":"            note\u003dANY,"},{"line_number":335,"context_line":"            success\u003dANY,"},{"line_number":336,"context_line":"            backup_type\u003dMockBackup.backup_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_a2fa1841","line":333,"range":{"start_line":332,"start_character":12,"end_line":333,"end_character":25},"updated":"2016-02-17 15:54:41.000000000","message":"Cannot you also assert the concrete values from \u0027backup_info\u0027 here?","commit_id":"a00ea7f7cfcbee9055e5593071e46ef1eaaaec1c"},{"author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"change_message_id":"70bd758e6695589b4a6a4e3c132ba4af96deab5f","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            backup_id\u003dbackup_info[\u0027id\u0027],"},{"line_number":330,"context_line":"            sent\u003dANY,"},{"line_number":331,"context_line":"            size\u003dANY,"},{"line_number":332,"context_line":"            checksum\u003dANY,"},{"line_number":333,"context_line":"            location\u003dANY,"},{"line_number":334,"context_line":"            note\u003dANY,"},{"line_number":335,"context_line":"            success\u003dANY,"},{"line_number":336,"context_line":"            backup_type\u003dMockBackup.backup_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_0a5676cd","line":333,"range":{"start_line":332,"start_character":12,"end_line":333,"end_character":25},"in_reply_to":"dae33548_a2fa1841","updated":"2016-02-17 17:04:01.000000000","message":"They come from MockSwift and MockStats not from \u0027backup_info\u0027, so I did  not use them. What\u0027s more, they won\u0027t be used in method execute_backup(). So I think we should delete \u0027checksum\u0027 and \u0027location\u0027 from all backup_info to avoid misunderstanding. And I will add the concrete values directly.","commit_id":"a00ea7f7cfcbee9055e5593071e46ef1eaaaec1c"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"280ca0abf87f929dc74d51103e02898b6e5dc000","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        agent.execute_backup(context\u003dNone, backup_info\u003dbackup_info,"},{"line_number":318,"context_line":"                             runner\u003dMockBackup)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        conductor_api.API.update_backup.assert_any_call("},{"line_number":321,"context_line":"            ANY,"},{"line_number":322,"context_line":"            backup_id\u003dbackup_info[\u0027id\u0027],"},{"line_number":323,"context_line":"            sent\u003dANY,"},{"line_number":324,"context_line":"            size\u003dANY,"},{"line_number":325,"context_line":"            state\u003dBackupState.BUILDING)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        conductor_api.API.update_backup.assert_any_call("},{"line_number":328,"context_line":"            ANY,"},{"line_number":329,"context_line":"            backup_id\u003dbackup_info[\u0027id\u0027],"},{"line_number":330,"context_line":"            sent\u003dANY,"},{"line_number":331,"context_line":"            size\u003dANY,"},{"line_number":332,"context_line":"            checksum\u003dANY,"},{"line_number":333,"context_line":"            location\u003dANY,"},{"line_number":334,"context_line":"            note\u003dANY,"},{"line_number":335,"context_line":"            success\u003dANY,"},{"line_number":336,"context_line":"            backup_type\u003dMockBackup.backup_type,"},{"line_number":337,"context_line":"            state\u003dBackupState.COMPLETED)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    @patch.object(conductor_api.API, \u0027get_client\u0027, Mock(return_value\u003dMock()))"},{"line_number":340,"context_line":"    @patch.object(conductor_api.API, \u0027update_backup\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_e27a60f0","line":337,"range":{"start_line":320,"start_character":8,"end_line":337,"end_character":40},"updated":"2016-02-17 15:54:41.000000000","message":"You can actually assert exactly this call sequence:\n\nmock.assert_has_calls([call(\u003cargs\u003e), call(\u003cargs\u003e)])\n\nYou will need to import \u0027call\u0027 from mock.","commit_id":"a00ea7f7cfcbee9055e5593071e46ef1eaaaec1c"},{"author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"change_message_id":"70bd758e6695589b4a6a4e3c132ba4af96deab5f","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        agent.execute_backup(context\u003dNone, backup_info\u003dbackup_info,"},{"line_number":318,"context_line":"                             runner\u003dMockBackup)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        conductor_api.API.update_backup.assert_any_call("},{"line_number":321,"context_line":"            ANY,"},{"line_number":322,"context_line":"            backup_id\u003dbackup_info[\u0027id\u0027],"},{"line_number":323,"context_line":"            sent\u003dANY,"},{"line_number":324,"context_line":"            size\u003dANY,"},{"line_number":325,"context_line":"            state\u003dBackupState.BUILDING)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        conductor_api.API.update_backup.assert_any_call("},{"line_number":328,"context_line":"            ANY,"},{"line_number":329,"context_line":"            backup_id\u003dbackup_info[\u0027id\u0027],"},{"line_number":330,"context_line":"            sent\u003dANY,"},{"line_number":331,"context_line":"            size\u003dANY,"},{"line_number":332,"context_line":"            checksum\u003dANY,"},{"line_number":333,"context_line":"            location\u003dANY,"},{"line_number":334,"context_line":"            note\u003dANY,"},{"line_number":335,"context_line":"            success\u003dANY,"},{"line_number":336,"context_line":"            backup_type\u003dMockBackup.backup_type,"},{"line_number":337,"context_line":"            state\u003dBackupState.COMPLETED)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    @patch.object(conductor_api.API, \u0027get_client\u0027, Mock(return_value\u003dMock()))"},{"line_number":340,"context_line":"    @patch.object(conductor_api.API, \u0027update_backup\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_8a4c46c9","line":337,"range":{"start_line":320,"start_character":8,"end_line":337,"end_character":40},"in_reply_to":"dae33548_e27a60f0","updated":"2016-02-17 17:04:01.000000000","message":"I will take your advice, it also make more clear messages in case of failure. Thanks :- )","commit_id":"a00ea7f7cfcbee9055e5593071e46ef1eaaaec1c"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"280ca0abf87f929dc74d51103e02898b6e5dc000","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                backup_id\u003dbackup_info[\u0027id\u0027],"},{"line_number":387,"context_line":"                sent\u003dANY,"},{"line_number":388,"context_line":"                size\u003dANY,"},{"line_number":389,"context_line":"                checksum\u003dANY,"},{"line_number":390,"context_line":"                location\u003dANY,"},{"line_number":391,"context_line":"                note\u003dANY,"},{"line_number":392,"context_line":"                success\u003dANY,"},{"line_number":393,"context_line":"                backup_type\u003dMockLossyBackup.backup_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_a2a85821","line":390,"range":{"start_line":389,"start_character":16,"end_line":390,"end_character":29},"updated":"2016-02-17 15:54:41.000000000","message":"ditto","commit_id":"a00ea7f7cfcbee9055e5593071e46ef1eaaaec1c"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"280ca0abf87f929dc74d51103e02898b6e5dc000","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                              context\u003dNone, backup_info\u003dbackup_info,"},{"line_number":375,"context_line":"                              runner\u003dMockLossyBackup)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"            conductor_api.API.update_backup.assert_any_call("},{"line_number":378,"context_line":"                ANY,"},{"line_number":379,"context_line":"                backup_id\u003dbackup_info[\u0027id\u0027],"},{"line_number":380,"context_line":"                sent\u003dANY,"},{"line_number":381,"context_line":"                size\u003dANY,"},{"line_number":382,"context_line":"                state\u003dBackupState.BUILDING)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            conductor_api.API.update_backup.assert_any_call("},{"line_number":385,"context_line":"                ANY,"},{"line_number":386,"context_line":"                backup_id\u003dbackup_info[\u0027id\u0027],"},{"line_number":387,"context_line":"                sent\u003dANY,"},{"line_number":388,"context_line":"                size\u003dANY,"},{"line_number":389,"context_line":"                checksum\u003dANY,"},{"line_number":390,"context_line":"                location\u003dANY,"},{"line_number":391,"context_line":"                note\u003dANY,"},{"line_number":392,"context_line":"                success\u003dANY,"},{"line_number":393,"context_line":"                backup_type\u003dMockLossyBackup.backup_type,"},{"line_number":394,"context_line":"                state\u003dBackupState.FAILED)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    def test_execute_restore(self):"},{"line_number":397,"context_line":"        \"\"\"This test should ensure backup agent"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_426cec34","line":394,"range":{"start_line":377,"start_character":12,"end_line":394,"end_character":41},"updated":"2016-02-17 15:54:41.000000000","message":"ditto","commit_id":"a00ea7f7cfcbee9055e5593071e46ef1eaaaec1c"}]}