)]}'
{"trove/guestagent/common/configuration.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"fa69f9102a4b5522bab8633e383053c81e60f09a","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \"\"\""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    @abc.abstractmethod"},{"line_number":248,"context_line":"    def get(self, group_name, change_id\u003dNone):"},{"line_number":249,"context_line":"        \"\"\"Return the contents of a given configuration override"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        :param group_name        The group the override belongs to."}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_f54e7a39","line":248,"range":{"start_line":248,"start_character":30,"end_line":248,"end_character":44},"updated":"2016-03-03 18:51:41.000000000","message":"change_id should be a positional/required arg.","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"}],"trove/guestagent/datastore/experimental/vertica/manager.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"fa69f9102a4b5522bab8633e383053c81e60f09a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            raise"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":123,"context_line":"        LOG.debug(\"Updating overrides.\")"},{"line_number":124,"context_line":"        if remove:"},{"line_number":125,"context_line":"            self.app.remove_overrides()"},{"line_number":126,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_f5b2fa4a","line":123,"updated":"2016-03-03 18:51:41.000000000","message":"I don\u0027t think this is necessary. A very similar message gets already logged in the API layer. Well, but for the sake of consistency with the rest of the file...","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"c4fdc76a3f63a8261d6103b8641df25ec121dc84","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            raise"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":123,"context_line":"        LOG.debug(\"Updating overrides.\")"},{"line_number":124,"context_line":"        if remove:"},{"line_number":125,"context_line":"            self.app.remove_overrides()"},{"line_number":126,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_b0599d37","line":123,"in_reply_to":"7af24918_f5b2fa4a","updated":"2016-03-03 20:08:49.000000000","message":"Done","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"fa69f9102a4b5522bab8633e383053c81e60f09a","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def apply_overrides(self, context, overrides):"},{"line_number":130,"context_line":"        if overrides:"},{"line_number":131,"context_line":"            LOG.debug(\"Applying overrides: \" + str(overrides))"},{"line_number":132,"context_line":"            self.app.apply_overrides(overrides)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_15b4c632","line":131,"updated":"2016-03-03 18:51:41.000000000","message":"ditto","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"c4fdc76a3f63a8261d6103b8641df25ec121dc84","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def apply_overrides(self, context, overrides):"},{"line_number":130,"context_line":"        if overrides:"},{"line_number":131,"context_line":"            LOG.debug(\"Applying overrides: \" + str(overrides))"},{"line_number":132,"context_line":"            self.app.apply_overrides(overrides)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_1045f144","line":131,"in_reply_to":"7af24918_15b4c632","updated":"2016-03-03 20:08:49.000000000","message":"Done","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"aab7984a770b5c8c483daf834d90095c8eb5ff61","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            self.app.add_udls()"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            if config_contents:"},{"line_number":69,"context_line":"                self.app.configuration_manager.save_configuration("},{"line_number":70,"context_line":"                    config_contents)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        elif cluster_config[\u0027instance_type\u0027] not in [\"member\", \"master\"]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_6540b536","line":69,"updated":"2016-03-04 19:39:16.000000000","message":"This could potentially reference the local property \u0027self.configuration_manager\u0027.","commit_id":"993ecb8670a247c138f639098f26e8dfda0720c4"}],"trove/guestagent/datastore/experimental/vertica/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"373016bcd4a5dc9972688583da2f320b6ee6ed36","unresolved":false,"context_lines":[{"line_number":44,"context_line":"MOUNT_POINT \u003d CONF.vertica.mount_point"},{"line_number":45,"context_line":"# We will use a fake configuration file for the options managed through"},{"line_number":46,"context_line":"# configuration groups that we apply directly with ALTER DB ... SET ..."},{"line_number":47,"context_line":"FAKE_CFG \u003d os.path.join(MOUNT_POINT, \"vertica.cfg.fake\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class VerticaAppStatus(service.BaseDbStatus):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_efb2294b","line":47,"updated":"2016-03-03 18:14:59.000000000","message":"I\u0027m confused about this FAKE_CFG construct.","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"47492c958f9dfca7d77adbc2d0967a18ebe4d9c6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"MOUNT_POINT \u003d CONF.vertica.mount_point"},{"line_number":45,"context_line":"# We will use a fake configuration file for the options managed through"},{"line_number":46,"context_line":"# configuration groups that we apply directly with ALTER DB ... SET ..."},{"line_number":47,"context_line":"FAKE_CFG \u003d os.path.join(MOUNT_POINT, \"vertica.cfg.fake\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class VerticaAppStatus(service.BaseDbStatus):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_8f14454d","line":47,"in_reply_to":"7af24918_efb2294b","updated":"2016-03-03 18:29:45.000000000","message":"Vertica recommends against the use of a config file in favour of using their ALTER DB ... SET \u003ccfg\u003e mechanism which propagates the change to the cluster -- imagine the difficulty in keeping these files in sync for clusters of 100s of nodes, which Vertica is intended to support.\n\nBut since the current implementation of the configuration manager expects to manage an actual file, with a set of overrides, after talking with Petr we determined it would be easiest to just make it believe it was managing a \u0027fake\u0027 file, and then add the appropriate hook to apply the changes to the database using ALTER DB (notice that apply/remove overrides below make calls to ALTER DB to add/remove the settings)","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"fa69f9102a4b5522bab8633e383053c81e60f09a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def __init__(self, status):"},{"line_number":73,"context_line":"        self.state_change_wait_time \u003d CONF.state_change_wait_time"},{"line_number":74,"context_line":"        self.status \u003d status"},{"line_number":75,"context_line":"        revision_dir \u003d self._init_overrides_dir()"},{"line_number":76,"context_line":"        if not operating_system.exists(FAKE_CFG):"},{"line_number":77,"context_line":"            operating_system.write_file(FAKE_CFG, \u0027\u0027, as_root\u003dTrue)"},{"line_number":78,"context_line":"            operating_system.chown(FAKE_CFG, system.VERTICA_ADMIN,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_5a183dd3","line":75,"updated":"2016-03-03 18:51:41.000000000","message":"I believe the config manager will (lazily) initialize the overrides directory for you. You no longer need to initialize it in the guest. Just build the path here.","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"c4fdc76a3f63a8261d6103b8641df25ec121dc84","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def __init__(self, status):"},{"line_number":73,"context_line":"        self.state_change_wait_time \u003d CONF.state_change_wait_time"},{"line_number":74,"context_line":"        self.status \u003d status"},{"line_number":75,"context_line":"        revision_dir \u003d self._init_overrides_dir()"},{"line_number":76,"context_line":"        if not operating_system.exists(FAKE_CFG):"},{"line_number":77,"context_line":"            operating_system.write_file(FAKE_CFG, \u0027\u0027, as_root\u003dTrue)"},{"line_number":78,"context_line":"            operating_system.chown(FAKE_CFG, system.VERTICA_ADMIN,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_90ec612b","line":75,"in_reply_to":"7af24918_5a183dd3","updated":"2016-03-03 20:08:49.000000000","message":"Done","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"fa69f9102a4b5522bab8633e383053c81e60f09a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.configuration_manager.remove_user_override()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def apply_overrides(self, overrides):"},{"line_number":116,"context_line":"        self._apply_config(overrides)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _reset_config(self, config):"},{"line_number":119,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_fa8ca9db","line":116,"updated":"2016-03-03 18:51:41.000000000","message":"I think you still need to call self.configuration_manager.apply_user_override(overrides) here to make the config mgr \u0027remember\u0027 the changes.","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"c4fdc76a3f63a8261d6103b8641df25ec121dc84","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.configuration_manager.remove_user_override()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def apply_overrides(self, overrides):"},{"line_number":116,"context_line":"        self._apply_config(overrides)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _reset_config(self, config):"},{"line_number":119,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_d040a909","line":116,"in_reply_to":"7af24918_fa8ca9db","updated":"2016-03-03 20:08:49.000000000","message":"Done","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"81b80063c77f6f42aa92516bf9b528d2277c6a2c","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":96,"context_line":"        if overrides:"},{"line_number":97,"context_line":"            self.configuration_manager.apply_user_override(overrides)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def remove_overrides(self):"},{"line_number":100,"context_line":"        config \u003d self.configuration_manager.get_user_override()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_c13c0632","line":97,"updated":"2016-03-07 17:05:07.000000000","message":"_apply_config is not called - non-dynamic/startup properties won\u0027t get applied.","commit_id":"993ecb8670a247c138f639098f26e8dfda0720c4"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"aab7984a770b5c8c483daf834d90095c8eb5ff61","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.configuration_manager.remove_user_override()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def apply_overrides(self, overrides):"},{"line_number":105,"context_line":"        self.configuration_manager.apply_user_override(overrides)"},{"line_number":106,"context_line":"        self._apply_config(overrides)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _reset_config(self, config):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_d32fd6a5","line":105,"updated":"2016-03-04 19:39:16.000000000","message":"I\u0027d probably move this below \u0027_apply_config\u0027 like we have it in \u0027remove_overrides\u0027.\nSince this is used to merely record the state it should happen only if \u0027_apply_config\u0027 succeeds...","commit_id":"993ecb8670a247c138f639098f26e8dfda0720c4"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"82e40bb7ad7f869e490affdfed18b6f48e3d321c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            self.apply_overrides(overrides)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def remove_overrides(self):"},{"line_number":100,"context_line":"        config \u003d self.configuration_manager.get_user_override()"},{"line_number":101,"context_line":"        self._reset_config(config)"},{"line_number":102,"context_line":"        self.configuration_manager.remove_user_override()"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_e0155ae5","line":100,"updated":"2016-03-15 07:40:14.000000000","message":"This is how I tested this scenario:\n- First created a configuration-group foo with {\"ActivePartitionCount\":2, \"PinProcessors\":2}\n- Created an instance with this configuration group\n- configuration-patch kept failing because it failed while trying to apply PinProcessors (reasons mentioned below)\n- so I did configuration-update to add a parameter that didnt require restart {\"MergeOutCache\":1} and that seemed to work\n- so next I tried to do a configuration-detach and that failed. It looked like it was not using the updated configuration group with only the \u0027MergeOutCache\u0027 because it was trying to reset PinProcessor and failed.","commit_id":"51e5f915ebce2077c03fc2ba4f1ca23e119aba3c"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ddeed1cf6ef5618c9713d91bf7b14105c5a15ee4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            self.apply_overrides(overrides)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def remove_overrides(self):"},{"line_number":100,"context_line":"        config \u003d self.configuration_manager.get_user_override()"},{"line_number":101,"context_line":"        self._reset_config(config)"},{"line_number":102,"context_line":"        self.configuration_manager.remove_user_override()"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_fbc6ab66","line":100,"in_reply_to":"3afc51ec_e0155ae5","updated":"2016-03-15 08:13:46.000000000","message":"Needed to add couple of corrections as to how I tested it:\n\nThis is how I tested this scenario:\n\n  - First I created a vertica instance with no configuration group\n  - Then I created a configuration-group foo with {\"ActivePartitionCount\":2, \"PinProcessors\":2}\n  - Tried to apply the configuration group to the existing vertica instance and it failed (reason mentioned below on line 128)\n  - Then created an instance with this configuration group, which also failed\n  - Tried configuration-patch to add another parameter that didnt require restart but it kept failing while trying to apply PinProcessors\n  - so I did configuration-update to add a parameter that didnt require restart {\"MergeOutCache\":1} and that seemed to work\n  - so next I tried to do a configuration-detach and that failed. It looked like it was not using the updated configuration group with only the \u0027MergeOutCache\u0027 because it was trying to reset PinProcessor and failed.","commit_id":"51e5f915ebce2077c03fc2ba4f1ca23e119aba3c"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"82e40bb7ad7f869e490affdfed18b6f48e3d321c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            for k, v in config.iteritems():"},{"line_number":112,"context_line":"                alter_db_cmd \u003d system.ALTER_DB_RESET_CFG % (DB_NAME, str(k))"},{"line_number":113,"context_line":"                out, err \u003d system.exec_vsql_command(db_password, alter_db_cmd)"},{"line_number":114,"context_line":"                if err:"},{"line_number":115,"context_line":"                    LOG.error(err)"},{"line_number":116,"context_line":"                    raise RuntimeError(_(\"Failed to remove config %s\") % k)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_404fee6a","line":114,"updated":"2016-03-15 07:40:14.000000000","message":"Alex, when the configuration group contains a parameter which requires restart, the variable \u0027err\u0027 contains a warning message which states that the change applied requires a restart. Because of the next line, it always errors out hence.","commit_id":"51e5f915ebce2077c03fc2ba4f1ca23e119aba3c"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"82e40bb7ad7f869e490affdfed18b6f48e3d321c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            db_password \u003d self._get_database_password()"},{"line_number":126,"context_line":"            for k, v in config.iteritems():"},{"line_number":127,"context_line":"                alter_db_cmd \u003d system.ALTER_DB_CFG % (DB_NAME, str(k), str(v))"},{"line_number":128,"context_line":"                out, err \u003d system.exec_vsql_command(db_password, alter_db_cmd)"},{"line_number":129,"context_line":"                if err:"},{"line_number":130,"context_line":"                    LOG.error(err)"},{"line_number":131,"context_line":"                    raise RuntimeError(_(\"Failed to apply config %s\") % k)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_202d8295","line":128,"updated":"2016-03-15 07:40:14.000000000","message":"ditto","commit_id":"51e5f915ebce2077c03fc2ba4f1ca23e119aba3c"}],"trove/tests/scenario/helpers/vertica_helper.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"fa69f9102a4b5522bab8633e383053c81e60f09a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                {\u0027name\u0027: \u0027user3\u0027, \u0027password\u0027: \u0027password1\u0027,"},{"line_number":34,"context_line":"                 \u0027databases\u0027: [{\u0027name\u0027: \u0027db1\u0027}, {\u0027name\u0027: \u0027db2\u0027}]}]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def add_actual_data(self, *args, **kwargs):"},{"line_number":37,"context_line":"        raise SkipTest(\"Adding data to Vertica is not implemented\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def verify_actual_data(self, *args, **kwargs):"},{"line_number":40,"context_line":"        raise SkipTest(\"Verifying data in Vertica is not implemented\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def remove_actual_data(self, *args, **kwargs):"},{"line_number":43,"context_line":"        raise SkipTest(\"Removing data from Vertica is not implemented\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_dynamic_group(self):"},{"line_number":46,"context_line":"        return {\u0027ActivePartitionCount\u0027: 3}"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_75026a0b","line":43,"range":{"start_line":36,"start_character":4,"end_line":43,"end_character":71},"updated":"2016-03-03 18:51:41.000000000","message":"So, Vertica won\u0027t work with the base SQL client?","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"f2d7df037be31f3e8702ec064dcefaef2cf85a75","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                {\u0027name\u0027: \u0027user3\u0027, \u0027password\u0027: \u0027password1\u0027,"},{"line_number":34,"context_line":"                 \u0027databases\u0027: [{\u0027name\u0027: \u0027db1\u0027}, {\u0027name\u0027: \u0027db2\u0027}]}]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def add_actual_data(self, *args, **kwargs):"},{"line_number":37,"context_line":"        raise SkipTest(\"Adding data to Vertica is not implemented\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def verify_actual_data(self, *args, **kwargs):"},{"line_number":40,"context_line":"        raise SkipTest(\"Verifying data in Vertica is not implemented\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def remove_actual_data(self, *args, **kwargs):"},{"line_number":43,"context_line":"        raise SkipTest(\"Removing data from Vertica is not implemented\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_dynamic_group(self):"},{"line_number":46,"context_line":"        return {\u0027ActivePartitionCount\u0027: 3}"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_329aad6e","line":43,"range":{"start_line":36,"start_character":4,"end_line":43,"end_character":71},"in_reply_to":"7af24918_30158de4","updated":"2016-03-03 21:54:48.000000000","message":"Doesn\u0027t work -- looks like there\u0027s no dialect for Vertica in sqlalchemy . \n\nhttp://docs.sqlalchemy.org/en/latest/dialects/","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"c4fdc76a3f63a8261d6103b8641df25ec121dc84","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                {\u0027name\u0027: \u0027user3\u0027, \u0027password\u0027: \u0027password1\u0027,"},{"line_number":34,"context_line":"                 \u0027databases\u0027: [{\u0027name\u0027: \u0027db1\u0027}, {\u0027name\u0027: \u0027db2\u0027}]}]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def add_actual_data(self, *args, **kwargs):"},{"line_number":37,"context_line":"        raise SkipTest(\"Adding data to Vertica is not implemented\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def verify_actual_data(self, *args, **kwargs):"},{"line_number":40,"context_line":"        raise SkipTest(\"Verifying data in Vertica is not implemented\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def remove_actual_data(self, *args, **kwargs):"},{"line_number":43,"context_line":"        raise SkipTest(\"Removing data from Vertica is not implemented\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_dynamic_group(self):"},{"line_number":46,"context_line":"        return {\u0027ActivePartitionCount\u0027: 3}"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_30158de4","line":43,"range":{"start_line":36,"start_character":4,"end_line":43,"end_character":71},"in_reply_to":"7af24918_75026a0b","updated":"2016-03-03 20:08:49.000000000","message":"Actually this is a good point - I never tried it. I think i copied the pgsql helper forgot to remove this. I will try it after i retest the latest changes to this patchset","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"be384ddbaeb3095fe222939179a0b5babc8ea26b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from trove.tests.scenario.helpers.sql_helper import SqlHelper"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class VerticaHelper(SqlHelper):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, expected_override_name):"},{"line_number":24,"context_line":"        super(VerticaHelper, self).__init__(expected_override_name, \u0027vertica\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_7a3cbc2f","line":21,"range":{"start_line":21,"start_character":29,"end_line":21,"end_character":31},"updated":"2016-03-14 19:23:05.000000000","message":"why isnt this a subclass of TestHelper instead","commit_id":"51e5f915ebce2077c03fc2ba4f1ca23e119aba3c"}],"trove/tests/unittests/guestagent/test_vertica_manager.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"fa69f9102a4b5522bab8633e383053c81e60f09a","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def test_prepare_member(self, mock_set_status):"},{"line_number":242,"context_line":"        self._prepare_method(\"test-instance-3\", \"member\")"},{"line_number":243,"context_line":"        mock_set_status.assert_called_with("},{"line_number":244,"context_line":"            rd_instance.ServiceStatuses.INSTANCE_READY, force\u003dTrue)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def test_rpc_ping(self):"},{"line_number":247,"context_line":"        output \u003d self.manager.rpc_ping(self.context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_1546864e","line":244,"updated":"2016-03-03 18:51:41.000000000","message":"Why did we remove the \u0027test_reset_configuration\u0027 testcase?","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"},{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"c4fdc76a3f63a8261d6103b8641df25ec121dc84","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def test_prepare_member(self, mock_set_status):"},{"line_number":242,"context_line":"        self._prepare_method(\"test-instance-3\", \"member\")"},{"line_number":243,"context_line":"        mock_set_status.assert_called_with("},{"line_number":244,"context_line":"            rd_instance.ServiceStatuses.INSTANCE_READY, force\u003dTrue)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def test_rpc_ping(self):"},{"line_number":247,"context_line":"        output \u003d self.manager.rpc_ping(self.context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_1099717c","line":244,"in_reply_to":"7af24918_1546864e","updated":"2016-03-03 20:08:49.000000000","message":"self.manager.reset_configuration is just a call to the base manager code, it\u0027s no longer a vertica-specific test","commit_id":"e5e0d926e6fb955e5a1357d2f0afab6c9aae1278"}]}