)]}'
{"trove/tests/unittests/guestagent/test_backups.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"ac256c25ca2451758b054d160a6da6baeac455b9","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        self.assertNotIn(\".enc\", bkp.manifest)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @patch(\u0027trove.guestagent.datastore.experimental.cassandra.service.LOG\u0027)"},{"line_number":492,"context_line":"    def test_backup_encrypted_but_not_zipped_nodetoolsnapshot_command(self, _):"},{"line_number":493,"context_line":"        bkp \u003d self._build_backup_runner(True, False)"},{"line_number":494,"context_line":"        bkp._run_pre_backup()"},{"line_number":495,"context_line":"        self.assertIsNotNone(bkp)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_5e21cdfb","line":492,"range":{"start_line":492,"start_character":76,"end_line":492,"end_character":77},"updated":"2016-02-25 20:25:03.000000000","message":"you called it mock_logging below - wouldn\u0027t that be more consistent with your original changeset?  See https://review.openstack.org/#/c/219544 and https://github.com/openstack/trove/blob/master/trove/tests/unittests/guestagent/test_agent_heartbeats_models.py#L108","commit_id":"e951cd743a3c612567a3e14ac0fd571ba26e8b28"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"325faa48110befd65bafb35840fd03d8589a221e","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        self.assertNotIn(\".enc\", bkp.manifest)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @patch(\u0027trove.guestagent.datastore.experimental.cassandra.service.LOG\u0027)"},{"line_number":492,"context_line":"    def test_backup_encrypted_but_not_zipped_nodetoolsnapshot_command(self, _):"},{"line_number":493,"context_line":"        bkp \u003d self._build_backup_runner(True, False)"},{"line_number":494,"context_line":"        bkp._run_pre_backup()"},{"line_number":495,"context_line":"        self.assertIsNotNone(bkp)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_922c1dad","line":492,"range":{"start_line":492,"start_character":76,"end_line":492,"end_character":77},"in_reply_to":"bae84128_5e21cdfb","updated":"2016-02-25 21:01:53.000000000","message":"You are correct, I can\u0027t have to \"I don\u0027t care variables\". And in the old change set, I used mock_logging when there was a thought to check invocation counts and things. But given multi-threadedness of the tests, installing a mock meant that it would receive logged messages for potentially multiple concurrent tests and therefore could not be safely used to validate call counts and things. So the old change set ended up with mock_logging which should, probably have been _ to begin with.","commit_id":"e951cd743a3c612567a3e14ac0fd571ba26e8b28"}]}