)]}'
{"trove/cmd/guest.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"6883dec06e43589d23c0a925b2e6318199cdc08a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    debug_utils.setup()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    from trove.guestagent import dbaas"},{"line_number":41,"context_line":"    manager \u003d dbaas.datastore_registry().get(CONF.datastore_manager)"},{"line_number":42,"context_line":"    if not manager:"},{"line_number":43,"context_line":"        msg \u003d (\"Manager class not registered for datastore manager %s\" %"},{"line_number":44,"context_line":"               CONF.datastore_manager)"},{"line_number":45,"context_line":"        raise RuntimeError(msg)"},{"line_number":46,"context_line":"    if manager \u003d\u003d cfg.get_configuration_property(\u0027datastore_registry_ext\u0027):"},{"line_number":47,"context_line":"        print (\"WARNING: datastore_registry_ext is deprecated.\")"},{"line_number":48,"context_line":"        manager \u003d cfg.get_configuration_property(\u0027guestagent_manager\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_10839b05","line":45,"range":{"start_line":41,"start_character":2,"end_line":45,"end_character":31},"updated":"2016-03-02 14:39:20.000000000","message":"Delete this code (unless you can think of some way to user datastore_registry but override it with the datastore specific guestagent_manager IF SPECIFIED, but I don\u0027t think that is possible)","commit_id":"a039461842eb627b4c65fe3b12debefbda6096d4"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"6883dec06e43589d23c0a925b2e6318199cdc08a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               CONF.datastore_manager)"},{"line_number":45,"context_line":"        raise RuntimeError(msg)"},{"line_number":46,"context_line":"    if manager \u003d\u003d cfg.get_configuration_property(\u0027datastore_registry_ext\u0027):"},{"line_number":47,"context_line":"        print (\"WARNING: datastore_registry_ext is deprecated.\")"},{"line_number":48,"context_line":"        manager \u003d cfg.get_configuration_property(\u0027guestagent_manager\u0027,"},{"line_number":49,"context_line":"                                                 manager\u003dCONF"},{"line_number":50,"context_line":"                                                 .datastore_manager)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_f09c2f5f","line":47,"updated":"2016-03-02 14:39:20.000000000","message":"Use LOG.warning rather than print","commit_id":"a039461842eb627b4c65fe3b12debefbda6096d4"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"6883dec06e43589d23c0a925b2e6318199cdc08a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        print (\"WARNING: datastore_registry_ext is deprecated.\")"},{"line_number":48,"context_line":"        manager \u003d cfg.get_configuration_property(\u0027guestagent_manager\u0027,"},{"line_number":49,"context_line":"                                                 manager\u003dCONF"},{"line_number":50,"context_line":"                                                 .datastore_manager)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # rpc module must be loaded after decision about thread monkeypatching"},{"line_number":53,"context_line":"    # because if thread module is not monkeypatched we can\u0027t use eventlet"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_f086efd9","line":50,"updated":"2016-03-02 14:39:20.000000000","message":"There is no DEFAULT section value here, so just use:\nmanager \u003d CONF.get(CONF.datastore_manager).guestagent_manager\n(and it should not be inside the \u0027if\u0027 statement)","commit_id":"a039461842eb627b4c65fe3b12debefbda6096d4"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"fe0d08d991878678632a512638a3044821dda345","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":"    debug_utils.setup()"},{"line_number":39,"context_line":"    manager \u003d CONF.get(CONF.datastore_manager).guestagent_manager"},{"line_number":40,"context_line":"    if manager \u003d\u003d cfg.get_configuration_property(\u0027datastore_registry_ext\u0027):"},{"line_number":41,"context_line":"        LOG.warning(\"datastore_registry_ext is deprecated.\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # rpc module must be loaded after decision about thread monkeypatching"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_faade59b","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":17},"updated":"2016-03-23 15:56:15.000000000","message":"A string will never be equal to a dict","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    debug_utils.setup()"},{"line_number":39,"context_line":"    manager \u003d CONF.get(CONF.datastore_manager).guestagent_manager"},{"line_number":40,"context_line":"    if manager \u003d\u003d cfg.get_configuration_property(\u0027datastore_registry_ext\u0027):"},{"line_number":41,"context_line":"        LOG.warning(\"datastore_registry_ext is deprecated.\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # rpc module must be loaded after decision about thread monkeypatching"},{"line_number":44,"context_line":"    # because if thread module is not monkeypatched we can\u0027t use eventlet"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_4d75abf7","line":41,"updated":"2016-03-21 18:52:13.000000000","message":"It is still deprecated even if cfg.get_configuration_property(\u0027datastore_registry_ext\u0027) is set and not the same as manager ;)","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4895834a192c673e086a0f7195b68b523b0accf6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    debug_utils.setup()"},{"line_number":39,"context_line":"    manager \u003d CONF.get(CONF.datastore_manager).guestagent_manager"},{"line_number":40,"context_line":"    if manager \u003d\u003d cfg.get_configuration_property(\u0027datastore_registry_ext\u0027):"},{"line_number":41,"context_line":"        LOG.warning(\"datastore_registry_ext is deprecated.\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # rpc module must be loaded after decision about thread monkeypatching"},{"line_number":44,"context_line":"    # because if thread module is not monkeypatched we can\u0027t use eventlet"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_7bb8e9e5","line":41,"in_reply_to":"fa0719c6_4d75abf7","updated":"2016-03-22 21:31:56.000000000","message":"is this if statement with a warning necessary if you set the deprecation flag in the defined config?","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"790900a48d5fd7433ed84709978569c003d3f923","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    if cfg.get_configuration_property(\u0027datastore_registry_ext\u0027):"},{"line_number":40,"context_line":"        LOG.warning(\"datastore_registry_ext is deprecated.\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    manager \u003d CONF.get(CONF.datastore_manager).guestagent_manager"},{"line_number":43,"context_line":"    # rpc module must be loaded after decision about thread monkeypatching"},{"line_number":44,"context_line":"    # because if thread module is not monkeypatched we can\u0027t use eventlet"},{"line_number":45,"context_line":"    # executor from oslo_messaging library."}],"source_content_type":"text/x-python","patch_set":16,"id":"5a18252c_f5320f5d","line":42,"updated":"2016-04-14 15:05:52.000000000","message":"shouldn\u0027t you be checking here for manager being not None?","commit_id":"b093eb7d8db57d78f9a97ac929735b5fba72f81f"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"942a39d63f1c249238cf53865ec4637d65568406","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    logging.setup(CONF, None)"},{"line_number":37,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":"    debug_utils.setup()"},{"line_number":39,"context_line":"    if cfg.get_configuration_property(\u0027datastore_registry_ext\u0027):"},{"line_number":40,"context_line":"        LOG.warning(\"datastore_registry_ext is deprecated.\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    manager \u003d CONF.get(CONF.datastore_manager).guestagent_manager"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_a9ee6a1f","line":39,"updated":"2016-06-13 17:19:26.000000000","message":"isn\u0027t datastore_registry_ext always going to be empty since the old code were it is set was removed from dbaas.py","commit_id":"554df4af0f3ccab88f4a2bc99ce8edc5cfbf9ad7"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"72c0219045ecd6f46ea8d169a701f262291fefbc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    logging.setup(CONF, None)"},{"line_number":37,"context_line":"    LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":"    debug_utils.setup()"},{"line_number":39,"context_line":"    if cfg.get_configuration_property(\u0027datastore_registry_ext\u0027):"},{"line_number":40,"context_line":"        LOG.warning(\"datastore_registry_ext is deprecated.\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    manager \u003d CONF.get(CONF.datastore_manager).guestagent_manager"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_cc82e451","line":39,"in_reply_to":"7aa08908_a9ee6a1f","updated":"2016-06-13 17:48:14.000000000","message":"Yeah I don\u0027t know why we would want to log this warning if by marking it as deprecated it already logs a warning. This is here because it was a suggestion in a previous comment but like you mentioned I just recently removed the defaults so this will always be empty. I will remove this next patch.","commit_id":"554df4af0f3ccab88f4a2bc99ce8edc5cfbf9ad7"}],"trove/common/cfg.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"6883dec06e43589d23c0a925b2e6318199cdc08a","unresolved":false,"context_lines":[{"line_number":361,"context_line":"    cfg.DictOpt(\u0027datastore_registry_ext\u0027, default\u003ddict(),"},{"line_number":362,"context_line":"                help\u003d\u0027Extension for default datastore managers. \u0027"},{"line_number":363,"context_line":"                     \u0027Allows the use of custom managers for each of \u0027"},{"line_number":364,"context_line":"                     \u0027the datastores supported by Trove.\u0027),"},{"line_number":365,"context_line":"    cfg.StrOpt(\u0027template_path\u0027, default\u003d\u0027/etc/trove/templates/\u0027,"},{"line_number":366,"context_line":"               help\u003d\u0027Path which leads to datastore templates.\u0027),"},{"line_number":367,"context_line":"    cfg.BoolOpt(\u0027sql_query_logging\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_50cfe37e","line":364,"updated":"2016-03-02 14:39:20.000000000","message":"Add parameters: deprecated_for_removal\u003dTrue,depricated_reason\u003d\"Use guestagent_manager option for each datastore to configure guest manager.\"","commit_id":"a039461842eb627b4c65fe3b12debefbda6096d4"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4895834a192c673e086a0f7195b68b523b0accf6","unresolved":false,"context_lines":[{"line_number":553,"context_line":"                    \u0027in order to be logged in the slow_query log.\u0027),"},{"line_number":554,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":555,"context_line":"               default\u003d\u0027trove.guestagent.datastore.mysql.manager.Manager\u0027,"},{"line_number":556,"context_line":"               help\u003d\u0027The manager to use for mysql datastore.\u0027),"},{"line_number":557,"context_line":"]"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"# Percona"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_1b1c4d11","line":556,"range":{"start_line":556,"start_character":40,"end_line":556,"end_character":49},"updated":"2016-03-22 21:31:56.000000000","message":"for the MySQL","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4895834a192c673e086a0f7195b68b523b0accf6","unresolved":false,"context_lines":[{"line_number":635,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":636,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.percona\u0027"},{"line_number":637,"context_line":"                       \u0027.manager.Manager\u0027,"},{"line_number":638,"context_line":"               help\u003d\u0027The manager to use for percona datastore\u0027),"},{"line_number":639,"context_line":"]"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"# Percona XtraDB Cluster"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_3b30319e","line":638,"range":{"start_line":638,"start_character":40,"end_line":638,"end_character":51},"updated":"2016-03-22 21:31:56.000000000","message":"for the Percona","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":721,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":722,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.pxc.manager\u0027"},{"line_number":723,"context_line":"                       \u0027.Manager\u0027,"},{"line_number":724,"context_line":"               help\u003d\u0027The manager to use for pxc datastore\u0027),"},{"line_number":725,"context_line":"]"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_6df22fd4","line":724,"updated":"2016-03-21 18:52:13.000000000","message":"Please use Percona XtraDB Cluster here (not pxc).","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":797,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":798,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.redis.\u0027"},{"line_number":799,"context_line":"                       \u0027manager.Manager\u0027,"},{"line_number":800,"context_line":"               help\u003d\u0027The manager to use for redis datastore\u0027),"},{"line_number":801,"context_line":"]"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"# Cassandra"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_4dc64b68","line":800,"updated":"2016-03-21 18:52:13.000000000","message":"Please fix capitalization, \"Redis\", this should be \"for the Redis datastore\"","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":874,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":875,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.cassandra\u0027"},{"line_number":876,"context_line":"                       \u0027.manager.Manager\u0027,"},{"line_number":877,"context_line":"               help\u003d\u0027The manager to use for cassandra datastore\u0027),"},{"line_number":878,"context_line":"]"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"# Couchbase"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_cdb09bf7","line":877,"updated":"2016-03-21 18:52:13.000000000","message":"the Cassandra","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":936,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":937,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.couchbase\u0027"},{"line_number":938,"context_line":"                       \u0027.manager.Manager\u0027,"},{"line_number":939,"context_line":"               help\u003d\u0027The manager to use for couchbase datastore\u0027),"},{"line_number":940,"context_line":"]"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"# MongoDB"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_0d93b35c","line":939,"updated":"2016-03-21 18:52:13.000000000","message":"the Couchbase","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":1028,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.mongodb\u0027"},{"line_number":1029,"context_line":"                       \u0027.manager.Manager\u0027,"},{"line_number":1030,"context_line":"               help\u003d\u0027The manager to use for mongodb datastore\u0027),"},{"line_number":1031,"context_line":"]"},{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"# PostgreSQL"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_ad88c723","line":1030,"updated":"2016-03-21 18:52:13.000000000","message":"the MongoDB","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":1086,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.postgresql\u0027"},{"line_number":1087,"context_line":"                       \u0027.manager.Manager\u0027,"},{"line_number":1088,"context_line":"               help\u003d\u0027The manager to use for postgresql datastore\u0027),"},{"line_number":1089,"context_line":"]"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"# Apache CouchDB"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_2d7dd71c","line":1088,"updated":"2016-03-21 18:52:13.000000000","message":"the PostgreSQL (I see some others that could be fixed as well)","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":1146,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.couchdb\u0027"},{"line_number":1147,"context_line":"                       \u0027.manager.Manager\u0027,"},{"line_number":1148,"context_line":"               help\u003d\u0027The manager to use for couchdb datastore\u0027),"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"]"},{"line_number":1151,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_0d7a9324","line":1148,"updated":"2016-03-21 18:52:13.000000000","message":"the CouchDB","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":1215,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.vertica\u0027"},{"line_number":1216,"context_line":"                       \u0027.manager.Manager\u0027,"},{"line_number":1217,"context_line":"               help\u003d\u0027The manager to use for vertica datastore\u0027),"},{"line_number":1218,"context_line":"]"},{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"# DB2"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_4d748b34","line":1217,"updated":"2016-03-21 18:52:13.000000000","message":"the Vertica","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":1273,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.db2\u0027"},{"line_number":1274,"context_line":"                       \u0027.manager.Manager\u0027,"},{"line_number":1275,"context_line":"               help\u003d\u0027The manager to use for db2 datastore\u0027),"},{"line_number":1276,"context_line":"]"},{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"# MariaDB"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_ad8f2722","line":1275,"updated":"2016-03-21 18:52:13.000000000","message":"the DB2","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b3ff8c6f5bfa53027517fa31dcd45bb0f3b57c37","unresolved":false,"context_lines":[{"line_number":1369,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":1370,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.mariadb\u0027"},{"line_number":1371,"context_line":"                       \u0027.manager.Manager\u0027,"},{"line_number":1372,"context_line":"               help\u003d\u0027The manager to use for mariadb datastore\u0027),"},{"line_number":1373,"context_line":"]"},{"line_number":1374,"context_line":""},{"line_number":1375,"context_line":"# RPC version groups"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_8d94e337","line":1372,"updated":"2016-03-21 18:52:13.000000000","message":"the MariaDB","commit_id":"904e8de937e96785d6b69c196ffbcd0de57e4645"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"942a39d63f1c249238cf53865ec4637d65568406","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                     \u0027the datastores supported by Trove.\u0027,"},{"line_number":368,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":369,"context_line":"                deprecated_reason\u003d\u0027Use guestagent_manager option for each \u0027"},{"line_number":370,"context_line":"                                  \u0027datastore to configure guest manager.\u0027),"},{"line_number":371,"context_line":"    cfg.StrOpt(\u0027template_path\u0027, default\u003d\u0027/etc/trove/templates/\u0027,"},{"line_number":372,"context_line":"               help\u003d\u0027Path which leads to datastore templates.\u0027),"},{"line_number":373,"context_line":"    cfg.BoolOpt(\u0027sql_query_logging\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_fc05d5c1","line":370,"updated":"2016-06-13 17:19:26.000000000","message":"don\u0027t you need to specify deprecated_name","commit_id":"554df4af0f3ccab88f4a2bc99ce8edc5cfbf9ad7"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"72c0219045ecd6f46ea8d169a701f262291fefbc","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                     \u0027the datastores supported by Trove.\u0027,"},{"line_number":368,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":369,"context_line":"                deprecated_reason\u003d\u0027Use guestagent_manager option for each \u0027"},{"line_number":370,"context_line":"                                  \u0027datastore to configure guest manager.\u0027),"},{"line_number":371,"context_line":"    cfg.StrOpt(\u0027template_path\u0027, default\u003d\u0027/etc/trove/templates/\u0027,"},{"line_number":372,"context_line":"               help\u003d\u0027Path which leads to datastore templates.\u0027),"},{"line_number":373,"context_line":"    cfg.BoolOpt(\u0027sql_query_logging\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_295c3a4a","line":370,"in_reply_to":"7aa08908_fc05d5c1","updated":"2016-06-13 17:48:14.000000000","message":"I think you\u0027re right about deprecated_name plus we need deprecated_group but not in this location. They should go where the newly added datastore specific options are.","commit_id":"554df4af0f3ccab88f4a2bc99ce8edc5cfbf9ad7"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"942a39d63f1c249238cf53865ec4637d65568406","unresolved":false,"context_lines":[{"line_number":642,"context_line":"    cfg.StrOpt(\u0027guestagent_manager\u0027,"},{"line_number":643,"context_line":"               default\u003d\u0027trove.guestagent.datastore.experimental.percona\u0027"},{"line_number":644,"context_line":"                       \u0027.manager.Manager\u0027,"},{"line_number":645,"context_line":"               help\u003d\u0027The manager to use for the Percona datastore\u0027),"},{"line_number":646,"context_line":"]"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"# Percona XtraDB Cluster"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_d131e2a3","line":645,"updated":"2016-06-13 17:19:26.000000000","message":"all help messages need to end with a .","commit_id":"554df4af0f3ccab88f4a2bc99ce8edc5cfbf9ad7"}],"trove/guestagent/dbaas.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6ca25e471966aca5ed84243d27aff56f89613a18","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":"defaults \u003d {"},{"line_number":37,"context_line":"    \u0027mysql\u0027:"},{"line_number":38,"context_line":"    cfg.get_configuuration_property(\u0027guestagent_manager\u0027, manager\u003d\u0027mysql\u0027,"},{"line_number":39,"context_line":"    \u0027percona\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_17d90a22","line":36,"updated":"2016-03-01 19:44:09.000000000","message":"if you went this route, wouldn\u0027t it be more reasonable to make a list of datastores and construct this list by chaining?\n\nI say this because all the words lead to tye kind of typo you have here with \"get_configuuration_property\".\n\nAt runtime, this won\u0027t work, by the way ;)\n\nSo you should also propose tests to exercise this newly added code as a bug can be found here by visual inspection.","commit_id":"ba897711dbe0b45956c53b81ddea1791c7c04c86"}]}