)]}'
{"requirements.txt":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"eb61fc662d05137aa347df3cbf4e944c0824d713","unresolved":false,"context_lines":[{"line_number":44,"context_line":"oslo.log\u003e\u003d1.14.0 # Apache-2.0"},{"line_number":45,"context_line":"oslo.db\u003e\u003d4.1.0 # Apache-2.0"},{"line_number":46,"context_line":"enum34;python_version\u003d\u003d\u00272.7\u0027 or python_version\u003d\u003d\u00272.6\u0027 or python_version\u003d\u003d\u00273.3\u0027 # BSD"},{"line_number":47,"context_line":"xmltodict\u003e\u003d0.10.1  # MIT"}],"source_content_type":"text/plain","patch_set":11,"id":"5a18252c_77471fbc","line":47,"updated":"2016-04-14 16:36:34.000000000","message":"I\u0027ve pushed https://review.openstack.org/305975  to get this added to g-r","commit_id":"fc8e97a7eebb780070899f09b0aef9dc0eb728bb"}],"trove/common/cfg.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"783b4f7b95b7585942cde95db2fb9bcde0fba5b9","unresolved":false,"context_lines":[{"line_number":835,"context_line":"    cfg.ListOpt(\u0027ignore_dbs\u0027, default\u003d[\u0027system\u0027, \u0027system_auth\u0027,"},{"line_number":836,"context_line":"                                       \u0027system_traces\u0027],"},{"line_number":837,"context_line":"                help\u003d\u0027Databases to exclude when listing databases.\u0027),"},{"line_number":838,"context_line":"    cfg.StrOpt(\u0027guest_log_exposed_logs\u0027, choices\u003d\u0027system,guest\u0027,"},{"line_number":839,"context_line":"               default\u003d\u0027system\u0027,"},{"line_number":840,"context_line":"               help\u003d\u0027List of Guest Logs to expose for publishing.\u0027),"},{"line_number":841,"context_line":"    cfg.StrOpt(\u0027system_log_level\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a18252c_57b94314","line":838,"updated":"2016-04-14 16:35:28.000000000","message":"should guest even be exposed? it will, for example pose a security leak if it is not sanitized.","commit_id":"fc8e97a7eebb780070899f09b0aef9dc0eb728bb"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"a43fe8c4ffa68bfb5f4426f51d2344ef2626cc11","unresolved":false,"context_lines":[{"line_number":835,"context_line":"    cfg.ListOpt(\u0027ignore_dbs\u0027, default\u003d[\u0027system\u0027, \u0027system_auth\u0027,"},{"line_number":836,"context_line":"                                       \u0027system_traces\u0027],"},{"line_number":837,"context_line":"                help\u003d\u0027Databases to exclude when listing databases.\u0027),"},{"line_number":838,"context_line":"    cfg.StrOpt(\u0027guest_log_exposed_logs\u0027, choices\u003d\u0027system,guest\u0027,"},{"line_number":839,"context_line":"               default\u003d\u0027system\u0027,"},{"line_number":840,"context_line":"               help\u003d\u0027List of Guest Logs to expose for publishing.\u0027),"},{"line_number":841,"context_line":"    cfg.StrOpt(\u0027system_log_level\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_bd1ac86c","line":838,"in_reply_to":"5a18252c_57b94314","updated":"2016-04-15 19:01:31.000000000","message":"This is just a validation rule. Other guests do not define it and therefore allow any valid and/or invalid input (including \u0027guest\u0027). The way this is now is consistent with existing implementations (i.e. allowing the guest log to be exposed).\n\nIf we choose to disallow exposing the guest log (for non-admin users) we should do it for all datastores, but that would probably be for a different patch set.","commit_id":"fc8e97a7eebb780070899f09b0aef9dc0eb728bb"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"79f3a2a9ce4968145a490faeb3035dbc864e4391","unresolved":false,"context_lines":[{"line_number":835,"context_line":"    cfg.ListOpt(\u0027ignore_dbs\u0027, default\u003d[\u0027system\u0027, \u0027system_auth\u0027,"},{"line_number":836,"context_line":"                                       \u0027system_traces\u0027],"},{"line_number":837,"context_line":"                help\u003d\u0027Databases to exclude when listing databases.\u0027),"},{"line_number":838,"context_line":"    cfg.StrOpt(\u0027guest_log_exposed_logs\u0027, choices\u003d\u0027system,guest\u0027,"},{"line_number":839,"context_line":"               default\u003d\u0027system\u0027,"},{"line_number":840,"context_line":"               help\u003d\u0027List of Guest Logs to expose for publishing.\u0027),"},{"line_number":841,"context_line":"    cfg.StrOpt(\u0027system_log_level\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_af21b5fd","line":838,"range":{"start_line":838,"start_character":41,"end_line":838,"end_character":63},"updated":"2016-05-07 18:38:53.000000000","message":"This validation rule will fail in certain situations.  For example if you put in the taskmanager conf file:\n\n  [cassandra]\n  guest_log_exposed_logs \u003d guest,system\n\nAlthough a valid selection - the server will fail to start:\n\n  2016-05-07 18:34:53.193 TRACE root ConfigFileValueError: Value for option guest_log_exposed_logs is not valid: Valid values are [s, y, s, t, e, m, ,, g, u, e, s, t], but\nfound \u0027guest,system\u0027","commit_id":"4205b0bbae60d9a7414e2c0eed3d3a8c1924f00d"}],"trove/guestagent/datastore/experimental/cassandra/manager.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"70b3bdb92b8ca3744119a429c7f46e41042f2529","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            }"},{"line_number":78,"context_line":"        }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def guest_log_enable(self, context, log_name, disable):"},{"line_number":81,"context_line":"        if disable:"},{"line_number":82,"context_line":"            self.app.set_logging_level(\u0027OFF\u0027)"},{"line_number":83,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9abb7d3a_6267d6b7","line":80,"updated":"2016-06-03 11:51:45.000000000","message":"the method you override logs some nice debug messages. this one doesn\u0027t appear to. no biggie","commit_id":"42da27a70d45cc39ffc9cd057e03e140bb2d11d6"}],"trove/guestagent/datastore/experimental/cassandra/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"70b3bdb92b8ca3744119a429c7f46e41042f2529","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @property"},{"line_number":137,"context_line":"    def cassandra_log_dir(self):"},{"line_number":138,"context_line":"        return \"/var/log/cassandra\""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @property"},{"line_number":141,"context_line":"    def cassandra_logback(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9abb7d3a_821aba15","line":138,"updated":"2016-06-03 11:51:45.000000000","message":"this really should be a config parameter.","commit_id":"42da27a70d45cc39ffc9cd057e03e140bb2d11d6"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"a18063c838503e6106b13eedb7aff0d47ed0f88b","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @property"},{"line_number":137,"context_line":"    def cassandra_log_dir(self):"},{"line_number":138,"context_line":"        return \"/var/log/cassandra\""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @property"},{"line_number":141,"context_line":"    def cassandra_logback(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9abb7d3a_a901956c","line":138,"in_reply_to":"9abb7d3a_821aba15","updated":"2016-06-03 15:10:30.000000000","message":"Neither MySQL nor Postgresql expose this via the config. The reason is that it is not configurable. It is fixed by the elements. It cannot be set to anything other than what is in the image or the guestagent breaks.\nIf anything it (and all the other paths and names) should be probably retrieved from the image metadata, but we don\u0027t have a mechanism for that yet.","commit_id":"42da27a70d45cc39ffc9cd057e03e140bb2d11d6"}],"trove/tests/scenario/helpers/cassandra_helper.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"783b4f7b95b7585942cde95db2fb9bcde0fba5b9","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        return [{\u0027sstable_preemptive_open_interval_in_mb\u0027: -1},"},{"line_number":150,"context_line":"                {\u0027sstable_preemptive_open_interval_in_mb\u0027: \u0027string_value\u0027}]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_exposed_user_log_names(self):"},{"line_number":153,"context_line":"        return [\u0027system\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a18252c_d7df1338","line":152,"updated":"2016-04-14 16:35:28.000000000","message":"hmm, what about guest? at least cfg seemed to think that could be provided.","commit_id":"fc8e97a7eebb780070899f09b0aef9dc0eb728bb"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"ebea08e4f63e7119911c46b6c6c02e59205be58c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        return [{\u0027sstable_preemptive_open_interval_in_mb\u0027: -1},"},{"line_number":150,"context_line":"                {\u0027sstable_preemptive_open_interval_in_mb\u0027: \u0027string_value\u0027}]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_exposed_user_log_names(self):"},{"line_number":153,"context_line":"        return [\u0027system\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a18252c_83b27392","line":152,"in_reply_to":"5a18252c_d7df1338","updated":"2016-04-14 19:42:11.000000000","message":"guest is a SYS log, not a USER log","commit_id":"fc8e97a7eebb780070899f09b0aef9dc0eb728bb"}]}