)]}'
{"trove/common/strategies/cluster/experimental/mongodb/api.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8abc5537c29a94b4ac62879313111ef0ebb5b7bc","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                          default_name_tag, key\u003dNone):"},{"line_number":404,"context_line":"        \"\"\"Loop through the instances and create them in this cluster.\"\"\""},{"line_number":405,"context_line":"        cluster_config[\u0027id\u0027] \u003d self.id"},{"line_number":406,"context_line":"        if CONF.get(datastore_version.manager).cluster_secure:"},{"line_number":407,"context_line":"            if not key:"},{"line_number":408,"context_line":"                key \u003d self.get_guest(self.arbitrary_query_router).get_key()"},{"line_number":409,"context_line":"            cluster_config[\u0027key\u0027] \u003d key"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_b939c2d9","line":406,"range":{"start_line":406,"start_character":20,"end_line":406,"end_character":45},"updated":"2016-03-17 15:11:55.000000000","message":"Tests are reporting that this variable doesn\u0027t exist ...","commit_id":"2049650e4cf342eef17f197538fd099a274b3589"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"8ba8b16e7ea2be87caa4ee7d18ce5800ea2de603","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                          default_name_tag, key\u003dNone):"},{"line_number":404,"context_line":"        \"\"\"Loop through the instances and create them in this cluster.\"\"\""},{"line_number":405,"context_line":"        cluster_config[\u0027id\u0027] \u003d self.id"},{"line_number":406,"context_line":"        if CONF.get(datastore_version.manager).cluster_secure:"},{"line_number":407,"context_line":"            if not key:"},{"line_number":408,"context_line":"                key \u003d self.get_guest(self.arbitrary_query_router).get_key()"},{"line_number":409,"context_line":"            cluster_config[\u0027key\u0027] \u003d key"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_39a2d2fd","line":406,"range":{"start_line":406,"start_character":20,"end_line":406,"end_character":45},"in_reply_to":"1af94dfe_b939c2d9","updated":"2016-03-17 15:12:52.000000000","message":"Fixed","commit_id":"2049650e4cf342eef17f197538fd099a274b3589"}],"trove/guestagent/datastore/experimental/mongodb/service.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"4f2956175889f9490007b0191f6dc3056ba9155f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # See: https://jira.mongodb.org/browse/SERVER-20075"},{"line_number":124,"context_line":"        self._initialize_writable_run_dir()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # todo mvandijk: enable authorization."},{"line_number":127,"context_line":"        # \u0027security.authorization\u0027: True"},{"line_number":128,"context_line":"        self.configuration_manager.apply_system_override("},{"line_number":129,"context_line":"            {\u0027processManagement.fork\u0027: False,"},{"line_number":130,"context_line":"             \u0027processManagement.pidFilePath\u0027: system.MONGO_PID_FILE,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_5cadd286","line":127,"range":{"start_line":126,"start_character":8,"end_line":127,"end_character":40},"updated":"2016-03-03 21:26:40.000000000","message":"This should now go.\n\nBTW, is this going to happen in \u0027apply_initial_guestagent_configuration\u0027 (i.e. for single instances and clusters) or \u0027secure\u0027 (i.e. for single instances only)","commit_id":"1715583c6c99f194ea2f23471e5c21c2991c26ef"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"23cf6445fb7de6fad471ba37a144911d52919c54","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # See: https://jira.mongodb.org/browse/SERVER-20075"},{"line_number":124,"context_line":"        self._initialize_writable_run_dir()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # todo mvandijk: enable authorization."},{"line_number":127,"context_line":"        # \u0027security.authorization\u0027: True"},{"line_number":128,"context_line":"        self.configuration_manager.apply_system_override("},{"line_number":129,"context_line":"            {\u0027processManagement.fork\u0027: False,"},{"line_number":130,"context_line":"             \u0027processManagement.pidFilePath\u0027: system.MONGO_PID_FILE,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_f224c50d","line":127,"range":{"start_line":126,"start_character":8,"end_line":127,"end_character":40},"in_reply_to":"7af24918_5cadd286","updated":"2016-03-03 22:36:40.000000000","message":"Done. And \"authorization\" will be only in secure, whereas \"keyFile\" is in _configure_cluster_security.","commit_id":"1715583c6c99f194ea2f23471e5c21c2991c26ef"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"4f2956175889f9490007b0191f6dc3056ba9155f","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # Store the cluster member authentication key."},{"line_number":220,"context_line":"        self.store_key(key_value)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        # TODO(mvandijk): enable cluster security once Trove features are in"},{"line_number":223,"context_line":"        self.configuration_manager.apply_system_override("},{"line_number":224,"context_line":"            {\u0027security.clusterAuthMode\u0027: \u0027keyFile\u0027,"},{"line_number":225,"context_line":"             \u0027security.keyFile\u0027: self.get_key_file()}, CNF_CLUSTER)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_dcaa8284","line":222,"range":{"start_line":222,"start_character":8,"end_line":222,"end_character":76},"updated":"2016-03-03 21:26:40.000000000","message":"Shouldn\u0027t this go now?","commit_id":"1715583c6c99f194ea2f23471e5c21c2991c26ef"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"23cf6445fb7de6fad471ba37a144911d52919c54","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # Store the cluster member authentication key."},{"line_number":220,"context_line":"        self.store_key(key_value)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        # TODO(mvandijk): enable cluster security once Trove features are in"},{"line_number":223,"context_line":"        self.configuration_manager.apply_system_override("},{"line_number":224,"context_line":"            {\u0027security.clusterAuthMode\u0027: \u0027keyFile\u0027,"},{"line_number":225,"context_line":"             \u0027security.keyFile\u0027: self.get_key_file()}, CNF_CLUSTER)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_f7acb48d","line":222,"range":{"start_line":222,"start_character":8,"end_line":222,"end_character":76},"in_reply_to":"7af24918_dcaa8284","updated":"2016-03-03 22:36:40.000000000","message":"Done.","commit_id":"1715583c6c99f194ea2f23471e5c21c2991c26ef"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c7a417a551591f12ee81d222e0ccd2f86b68c10b","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    def _configure_cluster_security(self, key_value):"},{"line_number":215,"context_line":"        \"\"\"Force cluster key-file-based authentication."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        This will enabled RBAC."},{"line_number":218,"context_line":"        \"\"\""},{"line_number":219,"context_line":"        # Store the cluster member authentication key."},{"line_number":220,"context_line":"        self.store_key(key_value)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_333b413a","line":217,"range":{"start_line":217,"start_character":26,"end_line":217,"end_character":30},"updated":"2016-03-16 18:53:09.000000000","message":"Typically you put the description of the acronym on the first use (here), but it\u0027s below so people can figure it out.","commit_id":"2049650e4cf342eef17f197538fd099a274b3589"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c7a417a551591f12ee81d222e0ccd2f86b68c10b","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                                 \"The service is still running.\"))"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        try:"},{"line_number":393,"context_line":"            self.configuration_manager.apply_system_override("},{"line_number":394,"context_line":"                {\u0027security.authorization\u0027: \u0027enabled\u0027})"},{"line_number":395,"context_line":"            self._set_localhost_auth_bypass(True)"},{"line_number":396,"context_line":"            self.start_db(update_db\u003dFalse)"},{"line_number":397,"context_line":"            password \u003d utils.generate_random_password()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_932175fe","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":54},"updated":"2016-03-16 18:53:09.000000000","message":"Shouldn\u0027t this be controlled by the conf flag?","commit_id":"2049650e4cf342eef17f197538fd099a274b3589"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"5b49e6b9b78c9afc2da9d8d61ade3de011460a38","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                                 \"The service is still running.\"))"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        try:"},{"line_number":393,"context_line":"            self.configuration_manager.apply_system_override("},{"line_number":394,"context_line":"                {\u0027security.authorization\u0027: \u0027enabled\u0027})"},{"line_number":395,"context_line":"            self._set_localhost_auth_bypass(True)"},{"line_number":396,"context_line":"            self.start_db(update_db\u003dFalse)"},{"line_number":397,"context_line":"            password \u003d utils.generate_random_password()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_3d8dcb7b","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":54},"in_reply_to":"1af94dfe_932175fe","updated":"2016-03-16 19:34:30.000000000","message":"Could be, but this way it just gets enabled, and then if they have toggled it with a config group then it gets disabled during the apply (which happens later, in the base datastore manager). I don\u0027t see any harm in doing it this way.","commit_id":"2049650e4cf342eef17f197538fd099a274b3589"}]}
