)]}'
{"etc/trove/trove.conf.sample":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d52cf52b82a6eb36edb430e161a61a7f9d5c08e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5aef4532_cf10d202","updated":"2016-03-11 02:09:16.000000000","message":"You\u0027ve updated one sample file; yet I notice that you\u0027ve updated the guest as well, and it has its own sample file.","commit_id":"c77dc56eb85aba37d757abb1808632eb58a9893c"}],"trove/cmd/guest.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d52cf52b82a6eb36edb430e161a61a7f9d5c08e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5aef4532_af2e2640","updated":"2016-03-11 02:09:16.000000000","message":"This is the update to the guest that leads me to wonder whether you should update the guest sample file as well.","commit_id":"c77dc56eb85aba37d757abb1808632eb58a9893c"}],"trove/cmd/manage.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d52cf52b82a6eb36edb430e161a61a7f9d5c08e5","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                            \u0027a given datastore and datastore version.\u0027)"},{"line_number":216,"context_line":"    cfg.custom_parser(\u0027action\u0027, actions)"},{"line_number":217,"context_line":"    cfg.parse_args(sys.argv)"},{"line_number":218,"context_line":"    cfg.set_config_defaults()"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    try:"},{"line_number":221,"context_line":"        logging.setup(CONF, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_2fea16db","line":218,"updated":"2016-03-11 02:09:16.000000000","message":"I don\u0027t understand why you update manage.py. This is a CLI that (as best as I know) neither exposes a WSGI server, nor makes any REST calls; rather it just writes stuff into the local infrastructure database.\n\nSo, this change puzzles me. I don\u0027t think it can go wrong but, what does it do?","commit_id":"c77dc56eb85aba37d757abb1808632eb58a9893c"}],"trove/common/cfg.py":[{"author":{"_account_id":14823,"name":"Pete MacKinnon","email":"pmackinn@redhat.com","username":"pmackinn"},"change_message_id":"0f322845e3854b3550e2b130d111168b5144ff39","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"    \"\"\"This method updates all configuration default values.\"\"\""},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":"    # CORS Middleware Defaults"},{"line_number":1406,"context_line":"    # TODO(krotscheck): Update with https://review.openstack.org/#/c/285368/"},{"line_number":1407,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1408,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1409,"context_line":"                                    \u0027X-Identity-Status\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_8e561e28","line":1406,"range":{"start_line":1406,"start_character":10,"end_line":1406,"end_character":11},"updated":"2016-03-09 19:26:00.000000000","message":"Usage of TODO noted","commit_id":"c77dc56eb85aba37d757abb1808632eb58a9893c"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"33c2ebccf9a2fcfe735af57b86f1d02058bb98d2","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"    \"\"\"This method updates all configuration default values.\"\"\""},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":"    # CORS Middleware Defaults"},{"line_number":1406,"context_line":"    # TODO(krotscheck): Update with https://review.openstack.org/#/c/285368/"},{"line_number":1407,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1408,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1409,"context_line":"                                    \u0027X-Identity-Status\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_67dc7046","line":1406,"range":{"start_line":1406,"start_character":10,"end_line":1406,"end_character":11},"in_reply_to":"5aef4532_8e561e28","updated":"2016-03-10 12:15:34.000000000","message":"Yeah, not optimal, but I\u0027ll likely patchbomb openstack once mitaka ships.","commit_id":"c77dc56eb85aba37d757abb1808632eb58a9893c"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d52cf52b82a6eb36edb430e161a61a7f9d5c08e5","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"    # CORS Middleware Defaults"},{"line_number":1406,"context_line":"    # TODO(krotscheck): Update with https://review.openstack.org/#/c/285368/"},{"line_number":1407,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1408,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1409,"context_line":"                                    \u0027X-Identity-Status\u0027,"},{"line_number":1410,"context_line":"                                    \u0027X-Roles\u0027,"},{"line_number":1411,"context_line":"                                    \u0027X-Service-Catalog\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_0f7aba23","line":1408,"updated":"2016-03-11 02:09:16.000000000","message":"You setup your defaults here in a very different way from other config options here. I wonder whether you could establish these configuration options the way the others are created? Or is it the case that the options are defined elsewhere and you are just setting defaults here?\n\nFurther, ff I understand this correctly (and this is an assumption), you are only setting defaults for some of the things that you have listed in the samples file. Why is that?","commit_id":"c77dc56eb85aba37d757abb1808632eb58a9893c"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"bd22430785dff8cb41e6ff7b323aa6fd65a4ff05","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"    # CORS Middleware Defaults"},{"line_number":1406,"context_line":"    # TODO(krotscheck): Update with https://review.openstack.org/#/c/285368/"},{"line_number":1407,"context_line":"    cfg.set_defaults(cors.CORS_OPTS,"},{"line_number":1408,"context_line":"                     allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":1409,"context_line":"                                    \u0027X-Identity-Status\u0027,"},{"line_number":1410,"context_line":"                                    \u0027X-Roles\u0027,"},{"line_number":1411,"context_line":"                                    \u0027X-Service-Catalog\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_035f2d73","line":1408,"in_reply_to":"5aef4532_0f7aba23","updated":"2016-03-11 13:30:35.000000000","message":"cors.CORS_OPTS is already defined in oslo_middleware.cors - this method overrides the default values declared there, because those defaults aren\u0027t useful to trove... it doesn\u0027t actually register these config values (That\u0027s done when the middleware is started in paste.ini) In short, this method is \"Hey, if the CORS middleware happens to be loaded, go use these defaults instead of the default ones in the library\".\n\nI\u0027m registering headers and methods in use by the trove api - I\u0027m not registering new defaults for allowed_origin, because I can\u0027t predict what that might be in a deployment.\n\nThere\u0027s a second block in the example file called [cors.subdomain] - this is actually a demonstration domain, because you can have an arbitrary number of them. [cors.foo], [cors.bar], etc. and CORS_OPTS backs them all (more or less). That\u0027s why I\u0027m only updating the values once.","commit_id":"c77dc56eb85aba37d757abb1808632eb58a9893c"}]}