)]}'
{"trove/common/stream_codecs.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1ee2578bda337cf0fa9849dddb94fb71c24ef8ce","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            return False"},{"line_number":471,"context_line":"        except ValueError:"},{"line_number":472,"context_line":"            pass"},{"line_number":473,"context_line":"        if self._big_ints and re.match(r\u0027\\d+[kKmMgG]\u0027, value):"},{"line_number":474,"context_line":"            return False"},{"line_number":475,"context_line":"        return True"},{"line_number":476,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_db59f036","line":473,"updated":"2016-07-31 11:14:28.000000000","message":"We are realistically at the point where you should add TtPp to this list.","commit_id":"a0f17931d60745e388cdd93bf8f4728616619f93"}],"trove/guestagent/datastore/experimental/postgresql/service/access.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3aa72ae23be7583d6e7d515dbc56a537da72663a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from trove.common import cfg"},{"line_number":19,"context_line":"from trove.common import exception"},{"line_number":20,"context_line":"from trove.common.i18n import _"},{"line_number":21,"context_line":"from trove.guestagent.datastore.experimental.postgresql import pgutil"},{"line_number":22,"context_line":"from trove.guestagent.db import models"}],"source_content_type":"text/x-python","patch_set":41,"id":"fa7ab95a_2b349ef9","line":19,"updated":"2016-09-01 00:51:17.000000000","message":"good catch!","commit_id":"7974ceb8875793073efa430f0ecd6c475ea39c2d"}],"trove/guestagent/db/models.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3aa72ae23be7583d6e7d515dbc56a537da72663a","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"    \"\"\"Represents the PostgreSQL default superuser.\"\"\""},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def __init__(self, password\u003dNone, *args, **kwargs):"},{"line_number":1056,"context_line":"        if password is None:"},{"line_number":1057,"context_line":"            password \u003d utils.generate_random_password()"},{"line_number":1058,"context_line":"        super(PostgreSQLRootUser, self).__init__(\"postgres\", password\u003dpassword,"},{"line_number":1059,"context_line":"                                                 *args, **kwargs)"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"fa7ab95a_0b18ba83","line":1057,"range":{"start_line":1056,"start_character":6,"end_line":1057,"end_character":55},"updated":"2016-09-01 00:51:17.000000000","message":"but it was so pythonic :)","commit_id":"7974ceb8875793073efa430f0ecd6c475ea39c2d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"025470ec2e3cb3bbead52c15eeb54d78d4550c7b","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"    \"\"\"Represents the PostgreSQL default superuser.\"\"\""},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def __init__(self, password\u003dNone, *args, **kwargs):"},{"line_number":1056,"context_line":"        if password is None:"},{"line_number":1057,"context_line":"            password \u003d utils.generate_random_password()"},{"line_number":1058,"context_line":"        super(PostgreSQLRootUser, self).__init__(\"postgres\", password\u003dpassword,"},{"line_number":1059,"context_line":"                                                 *args, **kwargs)"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"ba84c18e_007386b2","line":1057,"range":{"start_line":1056,"start_character":6,"end_line":1057,"end_character":55},"in_reply_to":"fa7ab95a_0b18ba83","updated":"2016-09-02 18:39:54.000000000","message":"Actually the original statement was wrong.  It would have to be:\n\n  password \u003d password if *password* not None else ...\n\nsince \u0027if not None\u0027 always evaluates to true.  The newer form is much easier to read. :)","commit_id":"7974ceb8875793073efa430f0ecd6c475ea39c2d"}],"trove/guestagent/strategies/replication/experimental/postgresql_impl.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3aa72ae23be7583d6e7d515dbc56a537da72663a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Tesora, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":41,"id":"fa7ab95a_6b15c647","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2016-09-01 00:51:17.000000000","message":"wow","commit_id":"7974ceb8875793073efa430f0ecd6c475ea39c2d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3aa72ae23be7583d6e7d515dbc56a537da72663a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        operating_system.remove(tmp_hba, as_root\u003dTrue)"},{"line_number":173,"context_line":"        pgutil.psql(\"SELECT pg_reload_conf()\")"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def enable_as_slave(self, service, snapshot, slave_config):"},{"line_number":176,"context_line":"        \"\"\"Adds appropriate config options to postgresql.conf, and writes out"},{"line_number":177,"context_line":"        the recovery.conf file used to set up replication"},{"line_number":178,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":41,"id":"fa7ab95a_660c1b3c","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":23},"updated":"2016-09-01 00:51:17.000000000","message":"I\u0027m not thrilled about the choice of name but given how long this patch has been around, I\u0027m going to shut up.","commit_id":"7974ceb8875793073efa430f0ecd6c475ea39c2d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"025470ec2e3cb3bbead52c15eeb54d78d4550c7b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        operating_system.remove(tmp_hba, as_root\u003dTrue)"},{"line_number":173,"context_line":"        pgutil.psql(\"SELECT pg_reload_conf()\")"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def enable_as_slave(self, service, snapshot, slave_config):"},{"line_number":176,"context_line":"        \"\"\"Adds appropriate config options to postgresql.conf, and writes out"},{"line_number":177,"context_line":"        the recovery.conf file used to set up replication"},{"line_number":178,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":41,"id":"da7fb54a_4daf7ce3","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":23},"in_reply_to":"fa7ab95a_660c1b3c","updated":"2016-09-02 18:39:54.000000000","message":"I think this is part of the framework - changing this name might be a PITA and probably not worth it. :/","commit_id":"7974ceb8875793073efa430f0ecd6c475ea39c2d"}]}