)]}'
{"trove/common/cfg.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"eb0a10a2e10f369a3b940df87f7a0d576ed6be35","unresolved":false,"context_lines":[{"line_number":404,"context_line":"    cfg.StrOpt(\u0027module_aes_cbc_key\u0027, default\u003d\u0027module_aes_cbc_key\u0027,"},{"line_number":405,"context_line":"               help\u003d\u0027OpenSSL aes_cbc key for module encryption.\u0027),"},{"line_number":406,"context_line":"    cfg.StrOpt(\u0027module_types\u0027, default\u003d\u0027ping\u0027,"},{"line_number":407,"context_line":"               help\u003d\u0027A list of module types supported. A module type \u0027"},{"line_number":408,"context_line":"                    \u0027corresponds to the name of a ModuleDriver.\u0027),"},{"line_number":409,"context_line":"    cfg.StrOpt(\u0027guest_log_container_name\u0027,"},{"line_number":410,"context_line":"               default\u003d\u0027database_logs\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_51a22daf","line":407,"range":{"start_line":407,"start_character":21,"end_line":407,"end_character":27},"updated":"2016-03-14 23:01:35.000000000","message":"this is a list option? or a string? this help text differs from what is defined.","commit_id":"8cf897457232b463969c592b748bfc2b15bf7ae6"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4cac291b3a7ebedd17540a87a5a2835bd64644c4","unresolved":false,"context_lines":[{"line_number":404,"context_line":"    cfg.StrOpt(\u0027module_aes_cbc_key\u0027, default\u003d\u0027module_aes_cbc_key\u0027,"},{"line_number":405,"context_line":"               help\u003d\u0027OpenSSL aes_cbc key for module encryption.\u0027),"},{"line_number":406,"context_line":"    cfg.StrOpt(\u0027module_types\u0027, default\u003d\u0027ping\u0027,"},{"line_number":407,"context_line":"               help\u003d\u0027A list of module types supported. A module type \u0027"},{"line_number":408,"context_line":"                    \u0027corresponds to the name of a ModuleDriver.\u0027),"},{"line_number":409,"context_line":"    cfg.StrOpt(\u0027guest_log_container_name\u0027,"},{"line_number":410,"context_line":"               default\u003d\u0027database_logs\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_8eaa3e6f","line":407,"range":{"start_line":407,"start_character":21,"end_line":407,"end_character":27},"in_reply_to":"1af94dfe_95b9b431","updated":"2016-03-15 15:19:10.000000000","message":"i think it makes more sense to be a ListOpt if thats the case. Otherwise i think someone will come along and change this later and it will be more difficult for upgrades later.","commit_id":"8cf897457232b463969c592b748bfc2b15bf7ae6"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3b10bb516bbdd05a260edf6ade916f5ebed55b1b","unresolved":false,"context_lines":[{"line_number":404,"context_line":"    cfg.StrOpt(\u0027module_aes_cbc_key\u0027, default\u003d\u0027module_aes_cbc_key\u0027,"},{"line_number":405,"context_line":"               help\u003d\u0027OpenSSL aes_cbc key for module encryption.\u0027),"},{"line_number":406,"context_line":"    cfg.StrOpt(\u0027module_types\u0027, default\u003d\u0027ping\u0027,"},{"line_number":407,"context_line":"               help\u003d\u0027A list of module types supported. A module type \u0027"},{"line_number":408,"context_line":"                    \u0027corresponds to the name of a ModuleDriver.\u0027),"},{"line_number":409,"context_line":"    cfg.StrOpt(\u0027guest_log_container_name\u0027,"},{"line_number":410,"context_line":"               default\u003d\u0027database_logs\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_95b9b431","line":407,"range":{"start_line":407,"start_character":21,"end_line":407,"end_character":27},"in_reply_to":"3afc51ec_51a22daf","updated":"2016-03-15 14:01:46.000000000","message":"It\u0027s a comma or space separated list of types.  I can change it to a ListOpt if you think that\u0027s better.","commit_id":"8cf897457232b463969c592b748bfc2b15bf7ae6"}],"trove/guestagent/common/operating_system.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"74c5bd42f92fe402864d4209b00942cee10798ac","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        with open(path, \u0027rb\u0027) as fp:"},{"line_number":63,"context_line":"            if decode:"},{"line_number":64,"context_line":"                return codec.deserialize(fp.read())"},{"line_number":65,"context_line":"            return codec.serialize(fp.read())"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    raise exception.UnprocessableEntity(_(\"File does not exist: %s\") % path)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_74255c07","line":65,"updated":"2016-03-09 23:08:02.000000000","message":"I am not sure about this. It seems like lots of extra logic which is very likely not going to work as expected with codecs other than Base64.\n\nShould these encode/decode flags be really on the Base64 codec instead?\n\nSomething like:\n  operating_system.write_file(foo, Base64Codec(reverse\u003dTrue))","commit_id":"fab2e907648c4baa059b9e56973a735befc34eaf"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"53e93591f660a467961fb335fc20726d93ae6993","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        with open(path, \u0027rb\u0027) as fp:"},{"line_number":63,"context_line":"            if decode:"},{"line_number":64,"context_line":"                return codec.deserialize(fp.read())"},{"line_number":65,"context_line":"            return codec.serialize(fp.read())"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    raise exception.UnprocessableEntity(_(\"File does not exist: %s\") % path)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_f89ad112","line":65,"in_reply_to":"5aef4532_74255c07","updated":"2016-03-10 16:44:54.000000000","message":"After more discussion, I agree that the codec has now became more generic and having the flags on the read/write methods makes sense.","commit_id":"fab2e907648c4baa059b9e56973a735befc34eaf"}],"trove/guestagent/module/driver_manager.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"eb0a10a2e10f369a3b940df87f7a0d576ed6be35","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        LOG.info(_(\u0027Loaded module driver: %s\u0027), driver_type)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if driver_type in self._drivers:"},{"line_number":87,"context_line":"            raise exception.Error(\"Found duplicate driver: %s\" % driver_type)"},{"line_number":88,"context_line":"        self._drivers[driver_type] \u003d driver"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def get_driver(self, driver_type):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_11af0582","line":87,"range":{"start_line":87,"start_character":34,"end_line":87,"end_character":62},"updated":"2016-03-14 23:01:35.000000000","message":"_() ?","commit_id":"8cf897457232b463969c592b748bfc2b15bf7ae6"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3b10bb516bbdd05a260edf6ade916f5ebed55b1b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        LOG.info(_(\u0027Loaded module driver: %s\u0027), driver_type)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if driver_type in self._drivers:"},{"line_number":87,"context_line":"            raise exception.Error(\"Found duplicate driver: %s\" % driver_type)"},{"line_number":88,"context_line":"        self._drivers[driver_type] \u003d driver"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def get_driver(self, driver_type):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_d504dcc7","line":87,"range":{"start_line":87,"start_character":34,"end_line":87,"end_character":62},"in_reply_to":"3afc51ec_11af0582","updated":"2016-03-15 14:01:46.000000000","message":"Right, will fix.","commit_id":"8cf897457232b463969c592b748bfc2b15bf7ae6"}],"trove/guestagent/module/drivers/module_driver.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"eb0a10a2e10f369a3b940df87f7a0d576ed6be35","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_name(self):"},{"line_number":45,"context_line":"        \"\"\"Same as the type. Here just for consistency\"\"\""},{"line_number":46,"context_line":"        return self.get_type()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @abc.abstractmethod"},{"line_number":49,"context_line":"    def get_description(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_910dd592","line":46,"updated":"2016-03-14 23:01:35.000000000","message":"having the default here call get_type() and having get_type() call get_name() could accidentally lead to stack overflow recursion. maybe get_type() could be implemented as  `type(self).__name__` or just a pass instead?","commit_id":"8cf897457232b463969c592b748bfc2b15bf7ae6"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3b10bb516bbdd05a260edf6ade916f5ebed55b1b","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_name(self):"},{"line_number":45,"context_line":"        \"\"\"Same as the type. Here just for consistency\"\"\""},{"line_number":46,"context_line":"        return self.get_type()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @abc.abstractmethod"},{"line_number":49,"context_line":"    def get_description(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_b5baf0be","line":46,"in_reply_to":"3afc51ec_910dd592","updated":"2016-03-15 14:01:46.000000000","message":"I think I meant to have get_type above just be a \u0027pass\u0027 in the base class (since it\u0027s abstract).  Must have got lost somewhere along the way.  I\u0027ll fix it.","commit_id":"8cf897457232b463969c592b748bfc2b15bf7ae6"}],"trove/guestagent/module/drivers/ping_driver.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"58d9932cb6506dc4817a477f9ad0bf4deb00dc36","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return \"Ping Guestagent Module Driver\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_updated(self):"},{"line_number":47,"context_line":"        return date(2016, 3, 4)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def apply(self, name, datastore, ds_version, data_file):"},{"line_number":50,"context_line":"        success \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_4d7e25af","line":47,"updated":"2016-03-14 16:58:13.000000000","message":"Is there a better way to do this?","commit_id":"8cf897457232b463969c592b748bfc2b15bf7ae6"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"e6642f906367191745f7f7bb85719f6ac2e6f404","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return \"Ping Guestagent Module Driver\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_updated(self):"},{"line_number":47,"context_line":"        return date(2016, 3, 4)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def apply(self, name, datastore, ds_version, data_file):"},{"line_number":50,"context_line":"        success \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_d81cae15","line":47,"in_reply_to":"3afc51ec_4d7e25af","updated":"2016-03-14 17:51:18.000000000","message":"I saw this in other plugin implementations (but I don\u0027t think it\u0027s even printed out at the moment here, so I\u0027m not sold on it).  I figured it might be useful to know how \u0027old\u0027 the driver was at some point, but short of hard-coding the date - as is done here - I didn\u0027t know how to update the value (git doesn\u0027t support expanding keywords, and apparently never will - see http://www.gelato.unsw.edu.au/archives/git/0610/28891.html )","commit_id":"8cf897457232b463969c592b748bfc2b15bf7ae6"}],"trove/guestagent/module/module_manager.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"88f9c357da570f3ccbbee3da18e6e34b721960aa","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @classmethod"},{"line_number":88,"context_line":"    def build_module_dir(cls, module_type, module_id):"},{"line_number":89,"context_line":"        sub_dir \u003d \"%s/%s\" % (module_type, module_id)"},{"line_number":90,"context_line":"        module_dir \u003d guestagent_utils.build_file_path("},{"line_number":91,"context_line":"            cls.MODULE_BASE_DIR, sub_dir)"},{"line_number":92,"context_line":"        if not operating_system.exists(module_dir, is_directory\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b169ccfb","line":89,"range":{"start_line":89,"start_character":18,"end_line":89,"end_character":25},"updated":"2016-03-09 16:44:42.000000000","message":"I think it\u0027s generally better to use \u0027os.path.join(*paths)\u0027 for building paths like this in a platform independent way.\n\nguestagent_utils.build_file_path(...) can build paths too, but only from a single path and a basename. It was implemented to support multiple extensions (like \u0027foo.tar.gz\u0027) instead.","commit_id":"1cf95138ad16f66459ffff507c19c55279d2f01b"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"8851e9621f4540da330016b49d99a3cf93f5c10d","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @classmethod"},{"line_number":88,"context_line":"    def build_module_dir(cls, module_type, module_id):"},{"line_number":89,"context_line":"        sub_dir \u003d \"%s/%s\" % (module_type, module_id)"},{"line_number":90,"context_line":"        module_dir \u003d guestagent_utils.build_file_path("},{"line_number":91,"context_line":"            cls.MODULE_BASE_DIR, sub_dir)"},{"line_number":92,"context_line":"        if not operating_system.exists(module_dir, is_directory\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_d49c46c2","line":89,"range":{"start_line":89,"start_character":18,"end_line":89,"end_character":25},"in_reply_to":"5aef4532_b169ccfb","updated":"2016-03-09 16:46:35.000000000","message":"Maybe we could have a guestagent_utils.build_directory_path(...)","commit_id":"1cf95138ad16f66459ffff507c19c55279d2f01b"}]}
