)]}'
{"trove/instance/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"63a3a1797c02940340d58ce5c1a36ab8cf1e9f2e","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        availability_zone \u003d body[\u0027instance\u0027].get(\u0027availability_zone\u0027)"},{"line_number":261,"context_line":"        nics \u003d body[\u0027instance\u0027].get(\u0027nics\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        slave_of_id \u003d body[\u0027instance\u0027].get(\u0027replica_of\u0027,"},{"line_number":264,"context_line":"                                           # also check for older name"},{"line_number":265,"context_line":"                                           body[\u0027instance\u0027].get(\u0027slave_of\u0027))"},{"line_number":266,"context_line":"        replica_count \u003d body[\u0027instance\u0027].get(\u0027replica_count\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_6e958985","line":263,"updated":"2016-03-09 22:04:22.000000000","message":"I\u0027d only suggest that this hunk of code emit a LOG.?? indicating that slave_of was received and that it is deprecated. Yes, that message only goes to the log, not to the requestor but that\u0027s the best I can imagine us doing with a REST API.","commit_id":"cc1898581435ff4b07512a8b9b2e364d7f925094"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ecc83acd840b7dbf68c3f4b30501be9c2286ff92","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        slave_of_id \u003d body[\u0027instance\u0027].get(\u0027replica_of\u0027,"},{"line_number":264,"context_line":"                                           # also check for older name"},{"line_number":265,"context_line":"                                           body[\u0027instance\u0027].get(\u0027slave_of\u0027))"},{"line_number":266,"context_line":"        replica_count \u003d body[\u0027instance\u0027].get(\u0027replica_count\u0027)"},{"line_number":267,"context_line":"        instance \u003d models.Instance.create(context, name, flavor_id,"},{"line_number":268,"context_line":"                                          image_id, databases, users,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_fe9666ee","line":265,"updated":"2016-03-10 00:38:24.000000000","message":"is it the understanding that we remove slave_of reference here once 2.1.1 version of troveclient is out.","commit_id":"cc1898581435ff4b07512a8b9b2e364d7f925094"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"b39f46a607b3918640c74f99ceb364dbcb4135d3","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        slave_of_id \u003d body[\u0027instance\u0027].get(\u0027replica_of\u0027,"},{"line_number":264,"context_line":"                                           # also check for older name"},{"line_number":265,"context_line":"                                           body[\u0027instance\u0027].get(\u0027slave_of\u0027))"},{"line_number":266,"context_line":"        replica_count \u003d body[\u0027instance\u0027].get(\u0027replica_count\u0027)"},{"line_number":267,"context_line":"        instance \u003d models.Instance.create(context, name, flavor_id,"},{"line_number":268,"context_line":"                                          image_id, databases, users,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_122047f6","line":265,"in_reply_to":"5aef4532_fe9666ee","updated":"2016-03-10 14:10:11.000000000","message":"Please ignore the above comment. I should have included this comment yesterday evening itself. I was confused because the changes in the client said that slave_of was being removed in the api for mitaka. The above changes make sense in the context that it needs to be backward compatible as well.","commit_id":"cc1898581435ff4b07512a8b9b2e364d7f925094"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ecc83acd840b7dbf68c3f4b30501be9c2286ff92","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        args \u003d {}"},{"line_number":349,"context_line":"        args[\u0027detach_replica\u0027] \u003d (\u0027replica_of\u0027 in body[\u0027instance\u0027] or"},{"line_number":350,"context_line":"                                  \u0027slave_of\u0027 in body[\u0027instance\u0027])"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        if \u0027name\u0027 in body[\u0027instance\u0027]:"},{"line_number":353,"context_line":"            args[\u0027name\u0027] \u003d body[\u0027instance\u0027][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_1e47d277","line":350,"updated":"2016-03-10 00:38:24.000000000","message":"based on the changes in: https://review.openstack.org/#/c/290048/3/troveclient/v1/instances.py, slave_of wont be set.","commit_id":"cc1898581435ff4b07512a8b9b2e364d7f925094"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"b39f46a607b3918640c74f99ceb364dbcb4135d3","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        args \u003d {}"},{"line_number":349,"context_line":"        args[\u0027detach_replica\u0027] \u003d (\u0027replica_of\u0027 in body[\u0027instance\u0027] or"},{"line_number":350,"context_line":"                                  \u0027slave_of\u0027 in body[\u0027instance\u0027])"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        if \u0027name\u0027 in body[\u0027instance\u0027]:"},{"line_number":353,"context_line":"            args[\u0027name\u0027] \u003d body[\u0027instance\u0027][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_9259f790","line":350,"in_reply_to":"5aef4532_1e47d277","updated":"2016-03-10 14:10:11.000000000","message":"Please ignore my previous comments","commit_id":"cc1898581435ff4b07512a8b9b2e364d7f925094"}],"trove/tests/api/instances.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"323cc6fb1f29d5ec877441ac4dcbc42595fca227","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"            self.instance[\u0027volume\u0027], allowed_attrs,"},{"line_number":1584,"context_line":"            msg\u003d\"Volume\")"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"    def slave_of(self):"},{"line_number":1587,"context_line":"        if \u0027replica_of\u0027 not in self.instance:"},{"line_number":1588,"context_line":"            self.fail(\"\u0027replica_of\u0027 not found in instance.\")"},{"line_number":1589,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_73f8d6c3","line":1586,"range":{"start_line":1586,"start_character":8,"end_line":1586,"end_character":13},"updated":"2016-03-09 21:47:57.000000000","message":"this is test code - doesn\u0027t need to be reverted","commit_id":"99770ef715de23c06f56e0a82a535d506f72cfa5"}],"trove/tests/api/replication.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"323cc6fb1f29d5ec877441ac4dcbc42595fca227","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        nics\u003dinstance_info.nics,"},{"line_number":94,"context_line":"        datastore\u003dinstance_info.dbaas_datastore,"},{"line_number":95,"context_line":"        datastore_version\u003dinstance_info.dbaas_datastore_version,"},{"line_number":96,"context_line":"        slave_of\u003dinstance_info.id)"},{"line_number":97,"context_line":"    assert_equal(200, instance_info.dbaas.last_http_code)"},{"line_number":98,"context_line":"    assert_equal(\"BUILD\", result.status)"},{"line_number":99,"context_line":"    return result.id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b367feb5","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":16},"updated":"2016-03-09 21:47:57.000000000","message":"since are trying to deprecate the slave_of in the python API, let\u0027s use the new \u0027replica_of\u0027 here","commit_id":"99770ef715de23c06f56e0a82a535d506f72cfa5"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"323cc6fb1f29d5ec877441ac4dcbc42595fca227","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    new_slave \u003d instance_info.dbaas.instances.get(slave.id)"},{"line_number":104,"context_line":"    assert_equal(200, instance_info.dbaas.last_http_code)"},{"line_number":105,"context_line":"    ns_dict \u003d new_slave._info"},{"line_number":106,"context_line":"    CheckInstance(ns_dict).slave_of()"},{"line_number":107,"context_line":"    assert_equal(master.id, ns_dict[\u0027replica_of\u0027][\u0027id\u0027])"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_1307d2ca","line":106,"range":{"start_line":106,"start_character":27,"end_line":106,"end_character":32},"updated":"2016-03-09 21:47:57.000000000","message":"ditto","commit_id":"99770ef715de23c06f56e0a82a535d506f72cfa5"}]}
