)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"91c63b166436200ae0628be0bc29204a78367edb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address change in Route v2.3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Routes v2.3 which just came out included a change (see the LP bug"},{"line_number":10,"context_line":"referenced below) that caused py27 to fail."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8738d4dcac2cc37b727767ba614fab4339758e22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba0121b8_319cf7bf","line":9,"updated":"2016-03-29 21:50:37.000000000","message":"When possible, commit messages should be self-contained: it simplifies reviewer work and avoids devs to open their browser when they use git log/blame.\n\nIt doesn\u0027t cost much to explain Routes\u003d\u003d2.3 breaking change","commit_id":"c0a7ff7b1667f44e6d3f24df8cb4f30f4ae8d144"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"c8f8cc24b2e943f2a4bd582a3a843d1896214292","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address change in Route v2.3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Routes v2.3 which just came out included a change (see the LP bug"},{"line_number":10,"context_line":"referenced below) that caused py27 to fail."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8738d4dcac2cc37b727767ba614fab4339758e22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba0121b8_5bc5458c","line":9,"in_reply_to":"ba0121b8_319cf7bf","updated":"2016-03-30 00:43:22.000000000","message":"Thanks Cedric, done!","commit_id":"c0a7ff7b1667f44e6d3f24df8cb4f30f4ae8d144"}],"trove/common/extensions.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"6ceeb3a494db284795fc473d7c6d5c3e0495bc1f","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        for action, method in resource_ext.collection_actions.iteritems():"},{"line_number":308,"context_line":"            parent \u003d resource_ext.parent"},{"line_number":309,"context_line":"            conditions \u003d dict(method\u003d[method])"},{"line_number":310,"context_line":"            path \u003d \"/%s/%s\" % (resource_ext.collection, action)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"            path_prefix \u003d \"\""},{"line_number":313,"context_line":"            if parent:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_aa5291db","line":310,"updated":"2016-03-28 21:10:02.000000000","message":"routename \u003d \"%s_%s\" % (resource_ext.collection, action)","commit_id":"dea2d3183b69d5bac071aadb1b910fddbdb5b3da"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ed3ef3936c6f849b14ecd3c7e242caf8e87c44aa","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        for action, method in resource_ext.collection_actions.iteritems():"},{"line_number":308,"context_line":"            parent \u003d resource_ext.parent"},{"line_number":309,"context_line":"            conditions \u003d dict(method\u003d[method])"},{"line_number":310,"context_line":"            path \u003d \"/%s/%s\" % (resource_ext.collection, action)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"            path_prefix \u003d \"\""},{"line_number":313,"context_line":"            if parent:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_0dbc776b","line":310,"in_reply_to":"ba0121b8_aa5291db","updated":"2016-03-28 21:53:49.000000000","message":"Sorry, why are you changing this variable name? path is being used in L321 and L322, so we would need to rename that as well. Also, the format (/%s/%s) doesn\u0027t affect in the new version, so I don\u0027t see the point of changing this.","commit_id":"dea2d3183b69d5bac071aadb1b910fddbdb5b3da"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"9a26efbbd583635d36f5f3b2aa199d304c2f0fe2","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                                  action\u003daction,"},{"line_number":319,"context_line":"                                  path_prefix\u003dpath_prefix,"},{"line_number":320,"context_line":"                                  conditions\u003dconditions) as submap:"},{"line_number":321,"context_line":"                submap.connect(\"\", path)"},{"line_number":322,"context_line":"                submap.connect(\"\", \"%s.:(format)\" % path)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_64026f40","line":321,"range":{"start_line":321,"start_character":31,"end_line":321,"end_character":33},"updated":"2016-03-28 20:55:03.000000000","message":"what is this empty string param? an artificial name of the mapped connection?","commit_id":"dea2d3183b69d5bac071aadb1b910fddbdb5b3da"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"6ceeb3a494db284795fc473d7c6d5c3e0495bc1f","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                                  action\u003daction,"},{"line_number":319,"context_line":"                                  path_prefix\u003dpath_prefix,"},{"line_number":320,"context_line":"                                  conditions\u003dconditions) as submap:"},{"line_number":321,"context_line":"                submap.connect(\"\", path)"},{"line_number":322,"context_line":"                submap.connect(\"\", \"%s.:(format)\" % path)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_6a6fd992","line":321,"range":{"start_line":321,"start_character":31,"end_line":321,"end_character":33},"in_reply_to":"ba0121b8_64026f40","updated":"2016-03-28 21:10:02.000000000","message":"submap.connect(routename, path)","commit_id":"dea2d3183b69d5bac071aadb1b910fddbdb5b3da"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ed3ef3936c6f849b14ecd3c7e242caf8e87c44aa","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                                  action\u003daction,"},{"line_number":319,"context_line":"                                  path_prefix\u003dpath_prefix,"},{"line_number":320,"context_line":"                                  conditions\u003dconditions) as submap:"},{"line_number":321,"context_line":"                submap.connect(\"\", path)"},{"line_number":322,"context_line":"                submap.connect(\"\", \"%s.:(format)\" % path)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_cdaa7f19","line":321,"range":{"start_line":321,"start_character":31,"end_line":321,"end_character":33},"in_reply_to":"ba0121b8_6a6fd992","updated":"2016-03-28 21:53:49.000000000","message":"Seems amrith decided to use the empty string here because in L168 in https://github.com/bbangert/routes/commit/0a417004be7e2d950bdcd629ccf24cf9f56ef817 the code expects to unpack two values. Passing an empty string here fallbacks to how things were before the upgrade.","commit_id":"dea2d3183b69d5bac071aadb1b910fddbdb5b3da"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"6ceeb3a494db284795fc473d7c6d5c3e0495bc1f","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                                  path_prefix\u003dpath_prefix,"},{"line_number":320,"context_line":"                                  conditions\u003dconditions) as submap:"},{"line_number":321,"context_line":"                submap.connect(\"\", path)"},{"line_number":322,"context_line":"                submap.connect(\"\", \"%s.:(format)\" % path)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)"},{"line_number":325,"context_line":"    def __call__(self, req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_8af98dcb","line":322,"updated":"2016-03-28 21:10:02.000000000","message":"submap.connect(routename+\"_format\", \"%s.:(format)\" % path)","commit_id":"dea2d3183b69d5bac071aadb1b910fddbdb5b3da"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ed3ef3936c6f849b14ecd3c7e242caf8e87c44aa","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                                  path_prefix\u003dpath_prefix,"},{"line_number":320,"context_line":"                                  conditions\u003dconditions) as submap:"},{"line_number":321,"context_line":"                submap.connect(\"\", path)"},{"line_number":322,"context_line":"                submap.connect(\"\", \"%s.:(format)\" % path)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)"},{"line_number":325,"context_line":"    def __call__(self, req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_4d6dcf03","line":322,"in_reply_to":"ba0121b8_8af98dcb","updated":"2016-03-28 21:53:49.000000000","message":"Same here, I don\u0027t see the point of changing how we encode the routes. Not in this change at least. It\u0027s not necessary to fix the bug.","commit_id":"dea2d3183b69d5bac071aadb1b910fddbdb5b3da"}]}