)]}'
{"trove/common/cfg.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"14be0a8c1d84cd3cf0eaf823ac6e824dd3836315","unresolved":false,"context_lines":[{"line_number":1448,"context_line":"                                    \u0027POST\u0027,"},{"line_number":1449,"context_line":"                                    \u0027DELETE\u0027,"},{"line_number":1450,"context_line":"                                    \u0027PATCH\u0027]"},{"line_number":1451,"context_line":"                     )"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_2bb13f90","side":"PARENT","line":1451,"updated":"2016-04-11 18:17:22.000000000","message":"Looks like you accidentally removed a parentheses here.","commit_id":"589c2a78a8979bc045d55a24dc29aee4698e9f0d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"14be0a8c1d84cd3cf0eaf823ac6e824dd3836315","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"              help\u003d\u0027Maximum time (in seconds) to wait for a server resize.\u0027),"},{"line_number":1397,"context_line":"    cfg.IntOpt(\u0027revert_time_out\u0027, default\u003d60 * 10,"},{"line_number":1398,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for a server resize \u0027"},{"line_number":1399,"context_line":"                   \u0027revert.\u0027),"},{"line_number":1400,"context_line":"    cfg.IntOpt(\u0027heat_time_out\u0027, default\u003d60,"},{"line_number":1401,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for a Heat request to \u0027"},{"line_number":1402,"context_line":"                   \u0027complete.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_cb724be5","line":1399,"range":{"start_line":1399,"start_character":19,"end_line":1399,"end_character":21},"updated":"2016-04-11 18:17:22.000000000","message":"The apostrophes here need to line up. It looks like this is all over the place for the new multi-line help messages.","commit_id":"d8dc18a0154bbc9591b80ca97027215a27bd6fee"}],"trove/taskmanager/models.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"d81b657e58ae824061b5b761c14bfeda428fb0f6","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":75,"context_line":"CONF \u003d cfg.CONF"},{"line_number":76,"context_line":"VOLUME_TIME_OUT \u003d cfg.get_configuration_property(\u0027volume_time_out\u0027)  # seconds."},{"line_number":77,"context_line":"DNS_TIME_OUT \u003d cfg.get_configuration_property(\u0027dns_time_out\u0027)  # seconds."},{"line_number":78,"context_line":"RESIZE_TIME_OUT \u003d cfg.get_configuration_property(\u0027resize_time_out\u0027)  # seconds."},{"line_number":79,"context_line":"REVERT_TIME_OUT \u003d cfg.get_configuration_property(\u0027revert_time_out\u0027)  # seconds."},{"line_number":80,"context_line":"HEAT_TIME_OUT \u003d cfg.get_configuration_property(\u0027heat_time_out\u0027)  # seconds."},{"line_number":81,"context_line":"USAGE_SLEEP_TIME \u003d cfg.get_configuration_property(\u0027usage_sleep_time\u0027)  # secnds"},{"line_number":82,"context_line":"HEAT_STACK_SUCCESSFUL_STATUSES \u003d [(\u0027CREATE\u0027, \u0027CREATE_COMPLETE\u0027)]"},{"line_number":83,"context_line":"HEAT_RESOURCE_SUCCESSFUL_STATE \u003d \u0027CREATE_COMPLETE\u0027"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_58155447","line":81,"range":{"start_line":76,"start_character":0,"end_line":81,"end_character":79},"updated":"2016-04-22 19:57:10.000000000","message":"This would be out-of-scope of this patch.\nI just wonder whether storing the config properties in class variables like this suffers conceptually the same issue as Bug: 1571076\n\nI am almost willing to bet it does... :/\n\nI think it\u0027s probably generally safer to always access properties at the time when they are used (or cache them in the __init__).","commit_id":"124f0c707db39a0142d6f6dd769bb2d5524197ad"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"389e4d077087ef086f6616837622742a0e388e8c","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"                         sleep_time\u003d2,"},{"line_number":1506,"context_line":"                         time_out\u003dcfg.get_configuration_property("},{"line_number":1507,"context_line":"                             \u0027volume_time_out\u0027))"},{"line_number":1508,"context_line":"#  time_out\u003dCONF.volume_time_out)"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"        LOG.debug(\"Successfully detached volume %(vol_id)s from instance \""},{"line_number":1511,"context_line":"                  \"%(id)s\" % {\u0027vol_id\u0027: self.instance.volume_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_9877ec3a","line":1508,"range":{"start_line":1508,"start_character":0,"end_line":1508,"end_character":33},"updated":"2016-04-22 19:45:21.000000000","message":"I think these comments are unnecessary. The code is sufficiently self-documenting.","commit_id":"124f0c707db39a0142d6f6dd769bb2d5524197ad"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"389e4d077087ef086f6616837622742a0e388e8c","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"                         sleep_time\u003d2,"},{"line_number":1529,"context_line":"                         time_out\u003dcfg.get_configuration_property("},{"line_number":1530,"context_line":"                             \u0027volume_time_out\u0027))"},{"line_number":1531,"context_line":"#  time_out\u003dCONF.volume_time_out)"},{"line_number":1532,"context_line":""},{"line_number":1533,"context_line":"        LOG.debug(\"Successfully attached volume %(vol_id)s to instance \""},{"line_number":1534,"context_line":"                  \"%(id)s\" % {\u0027vol_id\u0027: self.instance.volume_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f876e03c","line":1531,"range":{"start_line":1531,"start_character":0,"end_line":1531,"end_character":1},"updated":"2016-04-22 19:45:21.000000000","message":"ditto","commit_id":"124f0c707db39a0142d6f6dd769bb2d5524197ad"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"389e4d077087ef086f6616837622742a0e388e8c","unresolved":false,"context_lines":[{"line_number":1587,"context_line":"                             sleep_time\u003d2,"},{"line_number":1588,"context_line":"                             time_out\u003dcfg.get_configuration_property("},{"line_number":1589,"context_line":"                                 \u0027volume_time_out\u0027))"},{"line_number":1590,"context_line":"#  time_out\u003dCONF.volume_time_out)"},{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":"            self.instance.update_db(volume_size\u003dself.new_size)"},{"line_number":1593,"context_line":"        except PollTimeOut:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_d8716446","line":1590,"range":{"start_line":1590,"start_character":0,"end_line":1590,"end_character":1},"updated":"2016-04-22 19:45:21.000000000","message":"ditto","commit_id":"124f0c707db39a0142d6f6dd769bb2d5524197ad"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"edb4338c8d38c6bb4ed96d9483834380d8b2e85b","unresolved":false,"context_lines":[{"line_number":1801,"context_line":"            self.instance.refresh_compute_server_info()"},{"line_number":1802,"context_line":"            return not self.instance.server_status_matches([\u0027RESIZE\u0027])"},{"line_number":1803,"context_line":""},{"line_number":1804,"context_line":"        LOG.debug(\"cfg.get_configuration_property(\u0027resize_time_out\u0027) \u003d %s\" %"},{"line_number":1805,"context_line":"                  cfg.get_configuration_property(\u0027resize_time_out\u0027))"},{"line_number":1806,"context_line":""},{"line_number":1807,"context_line":"        utils.poll_until("}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_c350f634","line":1804,"updated":"2016-05-10 15:04:41.000000000","message":"Is this just left over or supposed to stay?","commit_id":"c6187135d0620b317b28eb352cfed40b6e92622b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"12c1950cb6babc9ccee8931a00cfab7739375406","unresolved":false,"context_lines":[{"line_number":1801,"context_line":"            self.instance.refresh_compute_server_info()"},{"line_number":1802,"context_line":"            return not self.instance.server_status_matches([\u0027RESIZE\u0027])"},{"line_number":1803,"context_line":""},{"line_number":1804,"context_line":"        LOG.debug(\"cfg.get_configuration_property(\u0027resize_time_out\u0027) \u003d %s\" %"},{"line_number":1805,"context_line":"                  cfg.get_configuration_property(\u0027resize_time_out\u0027))"},{"line_number":1806,"context_line":""},{"line_number":1807,"context_line":"        utils.poll_until("}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_46cd3484","line":1804,"in_reply_to":"dab17558_c350f634","updated":"2016-05-10 15:12:15.000000000","message":"Petr, they are not intended to stay. William will be submitting a change set where he will remove these.\n\nI had these in here to debug and so that he could see what I did to debug.","commit_id":"c6187135d0620b317b28eb352cfed40b6e92622b"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"edb4338c8d38c6bb4ed96d9483834380d8b2e85b","unresolved":false,"context_lines":[{"line_number":1815,"context_line":"            self.instance.refresh_compute_server_info()"},{"line_number":1816,"context_line":"            return self.instance.server_status_matches([\u0027ACTIVE\u0027])"},{"line_number":1817,"context_line":""},{"line_number":1818,"context_line":"        LOG.debug(\"cfg.get_configuration_property(\u0027revert_time_out\u0027) \u003d %s\" %"},{"line_number":1819,"context_line":"                  cfg.get_configuration_property(\u0027revert_time_out\u0027))"},{"line_number":1820,"context_line":""},{"line_number":1821,"context_line":"        utils.poll_until("}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_c33756fd","line":1818,"updated":"2016-05-10 15:04:41.000000000","message":"ditto","commit_id":"c6187135d0620b317b28eb352cfed40b6e92622b"}]}