)]}'
{"trove/guestagent/datastore/experimental/cassandra/manager.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"88b34826a8e04b761ea0dd7a6e56b0fcdd481747","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @property"},{"line_number":47,"context_line":"    def app(self):"},{"line_number":48,"context_line":"        if self._app is None:"},{"line_number":49,"context_line":"            self._app \u003d self.build_app()"},{"line_number":50,"context_line":"        return self._app"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def build_app(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"dab17558_ac7b9a28","line":49,"updated":"2016-05-12 20:02:19.000000000","message":"I understand the concept here of having only a single instance. But given that, why have this build_app()? Why not just make this:\n\nself._app \u003d service.CassandraApp()","commit_id":"728df1640f0db27fc541ad368341c98c1e77ef2c"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"608861c091015f888a3fd75156e1fb520285b862","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @property"},{"line_number":47,"context_line":"    def app(self):"},{"line_number":48,"context_line":"        if self._app is None:"},{"line_number":49,"context_line":"            self._app \u003d self.build_app()"},{"line_number":50,"context_line":"        return self._app"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def build_app(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"dab17558_713e268c","line":49,"in_reply_to":"dab17558_ac7b9a28","updated":"2016-05-16 18:36:03.000000000","message":"This is to help with derived managers - they can simply override \u0027build_app()\u0027 to build the right object and do not need to worry about this lazy-initialization logic.\n\n* We should really convert it to the \u0027common\u0027 module (which takes proper objects in the init) and \u0027derived\u0027 modules (which just build their internals and pass them into the base) similar to MySQL. It\u0027s on my list.","commit_id":"728df1640f0db27fc541ad368341c98c1e77ef2c"}]}