)]}'
{"trove/common/strategies/cluster/experimental/galera_common/api.py":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"7ce7340721b81b28ef3e766d4bc718720b67b3da","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        for instance in instances:"},{"line_number":103,"context_line":"            nics \u003d instance.get(\u0027nics\u0027, None)"},{"line_number":104,"context_line":"            if nics:"},{"line_number":105,"context_line":"                instance_nics.append(nics[0].get(\u0027net-id\u0027))"},{"line_number":106,"context_line":"        LOG.debug(\"what is instance_nics: %s\" % instance_nics)"},{"line_number":107,"context_line":"        if len(set(instance_nics)) !\u003d 1:"},{"line_number":108,"context_line":"            raise exception.ClusterNetworksNotEqual()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_dd6dff33","line":105,"updated":"2016-04-15 22:32:48.000000000","message":"What happens if one of the other \"nic\" parameters is used? From the help: where net-id\u003dnetwork_id, v4-fixed-\n                                  ip\u003dIPv4r_fixed_address, port-id\u003dport_id)\nThe code below (line 113) seems to assume a net uuid is passed. That is likely problematic in general.","commit_id":"4e062d0b68f06bb8a1762293b261271bbaee2545"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"8f086670d072eaca2ce900ed38f1b69913e20e8b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        for instance in instances:"},{"line_number":103,"context_line":"            nics \u003d instance.get(\u0027nics\u0027, None)"},{"line_number":104,"context_line":"            if nics:"},{"line_number":105,"context_line":"                instance_nics.append(nics[0].get(\u0027net-id\u0027))"},{"line_number":106,"context_line":"        LOG.debug(\"what is instance_nics: %s\" % instance_nics)"},{"line_number":107,"context_line":"        if len(set(instance_nics)) !\u003d 1:"},{"line_number":108,"context_line":"            raise exception.ClusterNetworksNotEqual()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f23bb8e9","line":105,"in_reply_to":"1a122d0e_c5ca3d4f","updated":"2016-04-17 16:56:41.000000000","message":"when the original nic parameter was added this was one of the long objections that we had; well I guess we now pay the technical-debt ...\n\nI\u0027m inclined to let this one go and log a bug for it. Getting this known issue fixed seems more important to me. But that\u0027s my opinion. What do others feel?","commit_id":"4e062d0b68f06bb8a1762293b261271bbaee2545"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"2583f4ad9d44526c382f0e453c7752540202671a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        for instance in instances:"},{"line_number":103,"context_line":"            nics \u003d instance.get(\u0027nics\u0027, None)"},{"line_number":104,"context_line":"            if nics:"},{"line_number":105,"context_line":"                instance_nics.append(nics[0].get(\u0027net-id\u0027))"},{"line_number":106,"context_line":"        LOG.debug(\"what is instance_nics: %s\" % instance_nics)"},{"line_number":107,"context_line":"        if len(set(instance_nics)) !\u003d 1:"},{"line_number":108,"context_line":"            raise exception.ClusterNetworksNotEqual()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c5ca3d4f","line":105,"in_reply_to":"1a122d0e_dd6dff33","updated":"2016-04-17 05:58:27.000000000","message":"you are right i looked at what the regular instance create does here and it looks like there is no validation on the nics. i\u0027m not familiar with neutron enough to determine how to validate each of these types. Could someone with more knowledge on neutron add that validation?","commit_id":"4e062d0b68f06bb8a1762293b261271bbaee2545"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"7ce7340721b81b28ef3e766d4bc718720b67b3da","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            nics \u003d instance.get(\u0027nics\u0027, None)"},{"line_number":104,"context_line":"            if nics:"},{"line_number":105,"context_line":"                instance_nics.append(nics[0].get(\u0027net-id\u0027))"},{"line_number":106,"context_line":"        LOG.debug(\"what is instance_nics: %s\" % instance_nics)"},{"line_number":107,"context_line":"        if len(set(instance_nics)) !\u003d 1:"},{"line_number":108,"context_line":"            raise exception.ClusterNetworksNotEqual()"},{"line_number":109,"context_line":"        instance_nic \u003d instance_nics[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_9d5a6782","line":106,"updated":"2016-04-15 22:32:48.000000000","message":"I would suggest rewording this - how about:\n\"Cluster will be created using NIC:...\"","commit_id":"4e062d0b68f06bb8a1762293b261271bbaee2545"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"060d56cf4997a74a2f8499b3b3b14d6394c02472","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            nics \u003d instance.get(\u0027nics\u0027, None)"},{"line_number":104,"context_line":"            if nics:"},{"line_number":105,"context_line":"                instance_nics.append(nics[0].get(\u0027net-id\u0027))"},{"line_number":106,"context_line":"        LOG.debug(\"what is instance_nics: %s\" % instance_nics)"},{"line_number":107,"context_line":"        if len(set(instance_nics)) !\u003d 1:"},{"line_number":108,"context_line":"            raise exception.ClusterNetworksNotEqual()"},{"line_number":109,"context_line":"        instance_nic \u003d instance_nics[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_e573f94b","line":106,"in_reply_to":"1a122d0e_20304756","updated":"2016-04-17 05:42:38.000000000","message":"oh i was just using this as debug i can remove this.","commit_id":"4e062d0b68f06bb8a1762293b261271bbaee2545"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"dbd2a4de4437832490973fa9177adca73a1f8208","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            nics \u003d instance.get(\u0027nics\u0027, None)"},{"line_number":104,"context_line":"            if nics:"},{"line_number":105,"context_line":"                instance_nics.append(nics[0].get(\u0027net-id\u0027))"},{"line_number":106,"context_line":"        LOG.debug(\"what is instance_nics: %s\" % instance_nics)"},{"line_number":107,"context_line":"        if len(set(instance_nics)) !\u003d 1:"},{"line_number":108,"context_line":"            raise exception.ClusterNetworksNotEqual()"},{"line_number":109,"context_line":"        instance_nic \u003d instance_nics[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_20304756","line":106,"in_reply_to":"1a122d0e_9d5a6782","updated":"2016-04-16 11:16:49.000000000","message":"or maybe this was a debugging message during writing the code and we can lose it before commit?","commit_id":"4e062d0b68f06bb8a1762293b261271bbaee2545"}]}