)]}'
{"trove/common/cfg.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1c11eb01c6db44cf05e9a7c7bce3b966b5d29946","unresolved":false,"context_lines":[{"line_number":1151,"context_line":"                help\u003d\u0027Enable clusters to be created and managed.\u0027),"},{"line_number":1152,"context_line":"    cfg.IntOpt(\u0027min_cluster_member_count\u0027, default\u003d3,"},{"line_number":1153,"context_line":"               help\u003d\u0027Minimum number of members in Vertica cluster.\u0027),"},{"line_number":1154,"context_line":"    cfg.IntOpt(\u0027cluster_member_count\u0027, default\u003d3,"},{"line_number":1155,"context_line":"               help\u003d\u0027Number of members in Vertica cluster.\u0027,"},{"line_number":1156,"context_line":"               deprecated_name\u003d\u0027cluster_member_count\u0027),"},{"line_number":1157,"context_line":"    cfg.StrOpt(\u0027api_strategy\u0027,"},{"line_number":1158,"context_line":"               default\u003d\u0027trove.common.strategies.cluster.experimental.vertica.\u0027"},{"line_number":1159,"context_line":"                       \u0027api.VerticaAPIStrategy\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_742c4f99","line":1156,"range":{"start_line":1154,"start_character":0,"end_line":1156,"end_character":54},"updated":"2016-04-26 19:39:13.000000000","message":"This is confusing - the name of the opt is the same as the deprecated name ... not sure what that means.  I\u0027m thinking that the deprecation tag should be on the above option and this option removed.","commit_id":"d4f8174898837428dcc6acbaaf18c9cbd687de82"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"6f70f607a0f13cda556138e85291178a58269d9d","unresolved":false,"context_lines":[{"line_number":1151,"context_line":"                help\u003d\u0027Enable clusters to be created and managed.\u0027),"},{"line_number":1152,"context_line":"    cfg.IntOpt(\u0027min_cluster_member_count\u0027, default\u003d3,"},{"line_number":1153,"context_line":"               help\u003d\u0027Minimum number of members in Vertica cluster.\u0027),"},{"line_number":1154,"context_line":"    cfg.IntOpt(\u0027cluster_member_count\u0027, default\u003d3,"},{"line_number":1155,"context_line":"               help\u003d\u0027Number of members in Vertica cluster.\u0027,"},{"line_number":1156,"context_line":"               deprecated_name\u003d\u0027cluster_member_count\u0027),"},{"line_number":1157,"context_line":"    cfg.StrOpt(\u0027api_strategy\u0027,"},{"line_number":1158,"context_line":"               default\u003d\u0027trove.common.strategies.cluster.experimental.vertica.\u0027"},{"line_number":1159,"context_line":"                       \u0027api.VerticaAPIStrategy\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_14b19b47","line":1156,"range":{"start_line":1154,"start_character":0,"end_line":1156,"end_character":54},"in_reply_to":"1a122d0e_742c4f99","updated":"2016-04-26 19:40:55.000000000","message":"Right, I agree. The deprecated_name works as an alias for the new name.","commit_id":"d4f8174898837428dcc6acbaaf18c9cbd687de82"}],"trove/common/strategies/cluster/experimental/vertica/api.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2c195ea69e572d7f7ac013fdcec6f9fab36b8a2f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        num_existing \u003d len(existing)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":81,"context_line":"        if new_cluster \\"},{"line_number":82,"context_line":"                and num_instances !\u003d vertica_conf.min_cluster_member_count:"},{"line_number":83,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":84,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_92d13b5a","line":81,"updated":"2016-04-26 21:01:45.000000000","message":"this line is not pythonic.\n\nIf you are so inclined, please fix it.","commit_id":"7c373aff48000d724fc6b6d820dd3aa8e115b686"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"3f67b2c3c7b69ed1dce5677d252ec72e96fe0b46","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        num_existing \u003d len(existing)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":81,"context_line":"        if new_cluster \\"},{"line_number":82,"context_line":"                and num_instances !\u003d vertica_conf.min_cluster_member_count:"},{"line_number":83,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":84,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_52d96321","line":81,"in_reply_to":"1a122d0e_92d13b5a","updated":"2016-04-26 21:15:45.000000000","message":"thank you for pointing that out - I was too concentrated on the variable renaming that I didn\u0027t notice the backslash shouldn\u0027t be there.  Updated to enclose the long if-statement in parenthesis instead.  Will commit as soon as local tox test is successful","commit_id":"7c373aff48000d724fc6b6d820dd3aa8e115b686"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8131007a20e023e0215d9afbaa09f8260774f80a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        num_existing \u003d len(existing)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":81,"context_line":"        if (new_cluster and"},{"line_number":82,"context_line":"                num_instances !\u003d vertica_conf.min_cluster_member_count):"},{"line_number":83,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":84,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_565c974a","line":82,"range":{"start_line":81,"start_character":12,"end_line":82,"end_character":70},"updated":"2016-04-27 22:55:02.000000000","message":"Is this logic still true?  It seems odd that we\u0027re making sure that the number of instances is exactly equal to the \u0027min\u0027 amount.  I would have guessed it would be:\n\n  num_instances \u003c vertica_conf.min_cluster_member_count\n\nIf the logic is correct, maybe we should have created a new conf variable for PXC instead of changing the current one.","commit_id":"77c0b8108af9fc99a572e0a3328343cfeb315f54"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4b25670a16075c01d1313aa44a5e54b51373e441","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":81,"context_line":"        if (new_cluster and"},{"line_number":82,"context_line":"                num_instances !\u003d vertica_conf.min_cluster_member_count):"},{"line_number":83,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":84,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_683750ff","line":82,"updated":"2016-04-26 23:15:35.000000000","message":"yeah, pep8 wont like this :)","commit_id":"77c0b8108af9fc99a572e0a3328343cfeb315f54"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b0a8349811dd924dc3af4fefe71f6705d7aa70c0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        num_existing \u003d len(existing)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":81,"context_line":"        if (new_cluster and"},{"line_number":82,"context_line":"                num_instances !\u003d vertica_conf.min_cluster_member_count):"},{"line_number":83,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":84,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_d5dfdd66","line":82,"range":{"start_line":81,"start_character":12,"end_line":82,"end_character":70},"in_reply_to":"1a122d0e_2c91b547","updated":"2016-04-28 20:43:20.000000000","message":"Well, that\u0027s a question for the vertica people - does it require \u0027sets\u0027 of a specific number, or just a minimum number in a set?","commit_id":"77c0b8108af9fc99a572e0a3328343cfeb315f54"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"ff3cc2993244cfe1459c7caf3e92c696080ccc86","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        num_existing \u003d len(existing)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":81,"context_line":"        if (new_cluster and"},{"line_number":82,"context_line":"                num_instances !\u003d vertica_conf.min_cluster_member_count):"},{"line_number":83,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":84,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_342713cb","line":82,"range":{"start_line":81,"start_character":12,"end_line":82,"end_character":70},"in_reply_to":"1a122d0e_3283c204","updated":"2016-04-29 21:15:37.000000000","message":"my thought is that this was merely changing the name of the variable but the sense of the parameter in the code certainly seems to be that it is not the minimum but rather the actual number","commit_id":"77c0b8108af9fc99a572e0a3328343cfeb315f54"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e1b4f67116c4e56589096b0953224c883217f97a","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":81,"context_line":"        if (new_cluster and"},{"line_number":82,"context_line":"                num_instances !\u003d vertica_conf.min_cluster_member_count):"},{"line_number":83,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":84,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_a77eb6e1","line":82,"in_reply_to":"1a122d0e_48041417","updated":"2016-04-27 03:18:23.000000000","message":"no, it was for this line. I could\u0027ve sworn that this was not indented right.","commit_id":"77c0b8108af9fc99a572e0a3328343cfeb315f54"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"85dad2b263358917c2a994927964244c7159db88","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        num_existing \u003d len(existing)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":81,"context_line":"        if (new_cluster and"},{"line_number":82,"context_line":"                num_instances !\u003d vertica_conf.min_cluster_member_count):"},{"line_number":83,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":84,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_2c91b547","line":82,"range":{"start_line":81,"start_character":12,"end_line":82,"end_character":70},"in_reply_to":"1a122d0e_565c974a","updated":"2016-04-28 16:31:04.000000000","message":"Hi Peter, Petr M, and Amrith,  \n\nis everyone in concurrence that I change the not equal (!\u003d) to less than (\u003c) for the if statement highlighted?","commit_id":"77c0b8108af9fc99a572e0a3328343cfeb315f54"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"5b2d7733ed3c1de3fbba153343f652140b01adbf","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":81,"context_line":"        if (new_cluster and"},{"line_number":82,"context_line":"                num_instances !\u003d vertica_conf.min_cluster_member_count):"},{"line_number":83,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":84,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_48041417","line":82,"in_reply_to":"1a122d0e_683750ff","updated":"2016-04-26 23:21:32.000000000","message":"Oops this is good, I hope?  I know you clicked on -1 by mistake :)  I suppose your comment was for the previous one with the backslash?","commit_id":"77c0b8108af9fc99a572e0a3328343cfeb315f54"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"f219e10905fda0cafc076666e071ef64a31a3c5a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        num_existing \u003d len(existing)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":81,"context_line":"        if (new_cluster and"},{"line_number":82,"context_line":"                num_instances !\u003d vertica_conf.min_cluster_member_count):"},{"line_number":83,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":84,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_3283c204","line":82,"range":{"start_line":81,"start_character":12,"end_line":82,"end_character":70},"in_reply_to":"1a122d0e_d5dfdd66","updated":"2016-04-29 00:13:55.000000000","message":"Hi Peter, thank you for clarification.  I hope the vertica guys would be able to see and respond to our inquiry here.","commit_id":"77c0b8108af9fc99a572e0a3328343cfeb315f54"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"a894104cc9daddcca7d182d9d7c922a66756a7a8","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        num_instances \u003d len(instances)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Matching number of instances with configured min_cluster_member_count"},{"line_number":156,"context_line":"        if num_instances !\u003d vertica_conf.min_cluster_member_count:"},{"line_number":157,"context_line":"            raise exception.ClusterNumInstancesNotSupported("},{"line_number":158,"context_line":"                num_instances\u003dvertica_conf.min_cluster_member_count)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_b7150e41","line":156,"range":{"start_line":156,"start_character":0,"end_line":156,"end_character":66},"updated":"2016-04-28 16:42:19.000000000","message":"Hi all, \n\nIf line #82 is changed, I suppose I also need to pattern the same change to this line as well?","commit_id":"77c0b8108af9fc99a572e0a3328343cfeb315f54"}]}