)]}'
{"trove/common/cfg.py":[{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"9d6520d3b517d2a4f9091fc5f0c3d34e2899434d","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"    If it is not available, retrieve it from the DEFAULT section."},{"line_number":1413,"context_line":"    \"\"\""},{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"    # Fake-integration tests do not define \u0027CONF.datastore_manager\u0027. *MySQL* options will"},{"line_number":1416,"context_line":"    # be loaded. This should never occur in a production environment."},{"line_number":1417,"context_line":"    datastore_manager \u003d CONF.datastore_manager"},{"line_number":1418,"context_line":"    if not datastore_manager:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_4aca4750","line":1415,"updated":"2016-05-05 12:52:49.000000000","message":"Line here is too long","commit_id":"bd8a5e06fa28237c70b030ae502e03187a8d5b2a"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"9d6520d3b517d2a4f9091fc5f0c3d34e2899434d","unresolved":false,"context_lines":[{"line_number":1418,"context_line":"    if not datastore_manager:"},{"line_number":1419,"context_line":"        datastore_manager \u003d \u0027mysql\u0027"},{"line_number":1420,"context_line":"        LOG.warning(_(\"Manager name (\u0027datastore_manager\u0027) not defined, \""},{"line_number":1421,"context_line":"                      \"using\u0027%s\u0027 options instead.\") % datastore_manager)"},{"line_number":1422,"context_line":""},{"line_number":1423,"context_line":"    try:"},{"line_number":1424,"context_line":"        return CONF.get(datastore_manager).get(property_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_2ac70b46","line":1421,"updated":"2016-05-05 12:52:49.000000000","message":"Put a space here after using","commit_id":"bd8a5e06fa28237c70b030ae502e03187a8d5b2a"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"5abfa2af5bdf55c539cfb2f9fa7e5272e5fdede4","unresolved":false,"context_lines":[{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"    # Fake-integration tests do not define \u0027CONF.datastore_manager\u0027."},{"line_number":1416,"context_line":"    # *MySQL* options will"},{"line_number":1417,"context_line":"    # be loaded. This should never occur in a production environment."},{"line_number":1418,"context_line":"    datastore_manager \u003d CONF.datastore_manager"},{"line_number":1419,"context_line":"    if not datastore_manager:"},{"line_number":1420,"context_line":"        datastore_manager \u003d \u0027mysql\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_bc175aec","line":1417,"updated":"2016-05-06 12:02:08.000000000","message":"It wou be a lot better to have the \"be loaded\" part on the line before, breaking on the .","commit_id":"e26c0268f5e3175ba19461f6b3257fb668626332"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"058a627ac96db12c9a4cfee95e11505beedf9f7a","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"    # *MySQL* options will"},{"line_number":1417,"context_line":"    # be loaded. This should never occur in a production environment."},{"line_number":1418,"context_line":"    datastore_manager \u003d CONF.datastore_manager"},{"line_number":1419,"context_line":"    if not datastore_manager:"},{"line_number":1420,"context_line":"        datastore_manager \u003d \u0027mysql\u0027"},{"line_number":1421,"context_line":"        LOG.warning(_(\"Manager name (\u0027datastore_manager\u0027) not defined, \""},{"line_number":1422,"context_line":"                      \"using \u0027%s\u0027 options instead.\") % datastore_manager)"},{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"    try:"},{"line_number":1425,"context_line":"        return CONF.get(datastore_manager).get(property_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_00f3620b","line":1422,"range":{"start_line":1419,"start_character":0,"end_line":1422,"end_character":73},"updated":"2016-05-13 13:57:23.000000000","message":"so, I\u0027m not sure we should do this ... I\u0027d rather we remove this block of code and generate an error instead.\n\nIs there *REALLY* some code path that could cause this?\n\nIt appears to me that this is a band-aid over a non-wound.","commit_id":"e26c0268f5e3175ba19461f6b3257fb668626332"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"8141587982e10896cf17d1b178cf04799374f2ac","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"    # *MySQL* options will"},{"line_number":1417,"context_line":"    # be loaded. This should never occur in a production environment."},{"line_number":1418,"context_line":"    datastore_manager \u003d CONF.datastore_manager"},{"line_number":1419,"context_line":"    if not datastore_manager:"},{"line_number":1420,"context_line":"        datastore_manager \u003d \u0027mysql\u0027"},{"line_number":1421,"context_line":"        LOG.warning(_(\"Manager name (\u0027datastore_manager\u0027) not defined, \""},{"line_number":1422,"context_line":"                      \"using \u0027%s\u0027 options instead.\") % datastore_manager)"},{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"    try:"},{"line_number":1425,"context_line":"        return CONF.get(datastore_manager).get(property_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_4c5001d5","line":1422,"range":{"start_line":1419,"start_character":0,"end_line":1422,"end_character":73},"in_reply_to":"dab17558_00f3620b","updated":"2016-05-13 14:57:13.000000000","message":"Well, \u0027fake tests\u0027... They do not have the manager set (I don\u0027t think they have any property set, they just pick up the defaults from cfg.py).\n\nI am nut sure how big task would fixing these be. We can make the message an error though.","commit_id":"e26c0268f5e3175ba19461f6b3257fb668626332"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"34143e3514341c13e13dfd3d88bfb6dfe449fde6","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"    # *MySQL* options will"},{"line_number":1417,"context_line":"    # be loaded. This should never occur in a production environment."},{"line_number":1418,"context_line":"    datastore_manager \u003d CONF.datastore_manager"},{"line_number":1419,"context_line":"    if not datastore_manager:"},{"line_number":1420,"context_line":"        datastore_manager \u003d \u0027mysql\u0027"},{"line_number":1421,"context_line":"        LOG.warning(_(\"Manager name (\u0027datastore_manager\u0027) not defined, \""},{"line_number":1422,"context_line":"                      \"using \u0027%s\u0027 options instead.\") % datastore_manager)"},{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"    try:"},{"line_number":1425,"context_line":"        return CONF.get(datastore_manager).get(property_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_c0a315b0","line":1422,"range":{"start_line":1419,"start_character":0,"end_line":1422,"end_character":73},"in_reply_to":"dab17558_4c5001d5","updated":"2016-05-13 15:15:19.000000000","message":"So fake mode tests fake a configuration (trove/tests/config.py). Why not just set datastore_manager there?","commit_id":"e26c0268f5e3175ba19461f6b3257fb668626332"}]}
