)]}'
{"trove/tests/int_tests.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"946e92e3e7b8da316d6b9895f2d217bafc6020ec","unresolved":false,"context_lines":[{"line_number":156,"context_line":"instance_actions_groups \u003d list(instance_create_groups)"},{"line_number":157,"context_line":"instance_actions_groups.extend([instance_actions_group.GROUP])"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"instance_module_groups \u003d list(instance_create_groups)"},{"line_number":160,"context_line":"instance_module_groups.extend([module_group.GROUP_INSTANCE_MODULE])"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"module_groups \u003d list(instance_create_groups)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_0a1b39cb","side":"PARENT","line":159,"updated":"2016-04-26 17:57:43.000000000","message":"Why are we removing these?","commit_id":"a3b3fcbd7dd01b51dbaea12993c177e6ca6a1b5a"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"44ae16af31db9b519fd0dceca3b6ff5be4d585c1","unresolved":false,"context_lines":[{"line_number":156,"context_line":"instance_actions_groups \u003d list(instance_create_groups)"},{"line_number":157,"context_line":"instance_actions_groups.extend([instance_actions_group.GROUP])"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"instance_module_groups \u003d list(instance_create_groups)"},{"line_number":160,"context_line":"instance_module_groups.extend([module_group.GROUP_INSTANCE_MODULE])"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"module_groups \u003d list(instance_create_groups)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_a15fcbe3","side":"PARENT","line":159,"in_reply_to":"1a122d0e_0a1b39cb","updated":"2016-04-26 19:16:07.000000000","message":"Because it doesn\u0027t make sense.  It\u0027s the same as \u0027module\u0027","commit_id":"a3b3fcbd7dd01b51dbaea12993c177e6ca6a1b5a"}],"trove/tests/scenario/helpers/mysql_helper.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"946e92e3e7b8da316d6b9895f2d217bafc6020ec","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                {\u0027name\u0027: \u0027db2\u0027}, {\"name\": \u0027db3\u0027}]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_valid_user_definitions(self):"},{"line_number":36,"context_line":"        return [{\u0027name\u0027: \u0027a_user1\u0027, \u0027password\u0027: \u0027password1\u0027, \u0027databases\u0027: [],"},{"line_number":37,"context_line":"                 \u0027host\u0027: \u0027127.0.0.1\u0027},"},{"line_number":38,"context_line":"                {\u0027name\u0027: \u0027a_user2\u0027, \u0027password\u0027: \u0027password1\u0027,"},{"line_number":39,"context_line":"                 \u0027databases\u0027: [{\u0027name\u0027: \u0027db1\u0027}], \u0027host\u0027: \u00270.0.0.0\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_24562e2a","line":36,"updated":"2016-04-26 17:57:43.000000000","message":"Just a little background note on this.\n\nThis is a workaround around a bug caused by us performing the ignore_user (ignore_dbs) filter both in the guestagent and the API layer.\nIt may create pages with missing users* if the two filter lists do not match (case on the gate). Note that we cannot simply make the two lists match because the user could then delete \u0027root\u0027 via Trove (which would in turn allow the user to bypass the root check on restore).\n\n* Assuming page size \u003d 2, the guest returns [\u0027user_1\u0027, \u0027root\u0027] and the API then filter is to just [\u0027user_1\u0027] (the expected result would be [\u0027user_1\u0027, \u0027user_2\u0027]).\n\nThis workaround avoids this issue by placing any system users to the end of the list.\n\nThe filter should be performed at one spot only (API). The guestagent should not do any additional filtering (maybe except shielding its own \u0027os_admin\u0027 user).","commit_id":"ee3f9be1f46c300132285a0c910a536814c71c48"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"44ae16af31db9b519fd0dceca3b6ff5be4d585c1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                {\u0027name\u0027: \u0027db2\u0027}, {\"name\": \u0027db3\u0027}]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_valid_user_definitions(self):"},{"line_number":36,"context_line":"        return [{\u0027name\u0027: \u0027a_user1\u0027, \u0027password\u0027: \u0027password1\u0027, \u0027databases\u0027: [],"},{"line_number":37,"context_line":"                 \u0027host\u0027: \u0027127.0.0.1\u0027},"},{"line_number":38,"context_line":"                {\u0027name\u0027: \u0027a_user2\u0027, \u0027password\u0027: \u0027password1\u0027,"},{"line_number":39,"context_line":"                 \u0027databases\u0027: [{\u0027name\u0027: \u0027db1\u0027}], \u0027host\u0027: \u00270.0.0.0\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_e1238356","line":36,"in_reply_to":"1a122d0e_24562e2a","updated":"2016-04-26 19:16:07.000000000","message":"Right - the other choice would be to disable this test, which I didn\u0027t want to do.","commit_id":"ee3f9be1f46c300132285a0c910a536814c71c48"}],"trove/tests/scenario/runners/instance_create_runners.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"946e92e3e7b8da316d6b9895f2d217bafc6020ec","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # Update the shared instance info."},{"line_number":51,"context_line":"        self.instance_info.id \u003d instance_info.id"},{"line_number":52,"context_line":"        self.instance_info.namne \u003d instance_info.name"},{"line_number":53,"context_line":"        self.instance_info.databases \u003d instance_info.databases"},{"line_number":54,"context_line":"        self.instance_info.users \u003d instance_info.users"},{"line_number":55,"context_line":"        self.instance_info.dbaas_datastore \u003d instance_info.dbaas_datastore"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_4ae371d9","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":32},"updated":"2016-04-26 17:57:43.000000000","message":"(-1) This does not sound right.","commit_id":"ee3f9be1f46c300132285a0c910a536814c71c48"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"44ae16af31db9b519fd0dceca3b6ff5be4d585c1","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # Update the shared instance info."},{"line_number":51,"context_line":"        self.instance_info.id \u003d instance_info.id"},{"line_number":52,"context_line":"        self.instance_info.namne \u003d instance_info.name"},{"line_number":53,"context_line":"        self.instance_info.databases \u003d instance_info.databases"},{"line_number":54,"context_line":"        self.instance_info.users \u003d instance_info.users"},{"line_number":55,"context_line":"        self.instance_info.dbaas_datastore \u003d instance_info.dbaas_datastore"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_411517e3","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":32},"in_reply_to":"1a122d0e_4ae371d9","updated":"2016-04-26 19:16:07.000000000","message":"Done","commit_id":"ee3f9be1f46c300132285a0c910a536814c71c48"}]}