)]}'
{"reddwarf/taskmanager/models.py":[{"author":{"_account_id":2559,"name":"Joe Cruz","email":"jcruz7@gmail.com","username":"jcruz7"},"change_message_id":"7b9631de4b9c3d88d8b76c8947dcdd641351fb1f","unresolved":false,"context_lines":[{"line_number":703,"context_line":"    def _initiate_nova_action(self):"},{"line_number":704,"context_line":"        self.instance.server.resize(self.new_flavor_id)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    def _revert_nova_action(self):"},{"line_number":707,"context_line":"        LOG.debug(\"Instance %s calling Compute revert resize...\""},{"line_number":708,"context_line":"                  % self.instance.id)"},{"line_number":709,"context_line":"        LOG.debug(\"Repairing conf file.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FdGY%3D","line":706,"updated":"2013-06-03 16:00:28.000000000","message":"For a second I questioned why not modifying ResizeActionBase._rever_nova_action but its because repairing conf files are only relevant for ResizeActions and not MigrationActions right?","commit_id":"50f66533c489cf20d3d79ede1db484dd9ca50d67"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"2386c65cb0f90397f09894d89082aebda9b93384","unresolved":false,"context_lines":[{"line_number":703,"context_line":"    def _initiate_nova_action(self):"},{"line_number":704,"context_line":"        self.instance.server.resize(self.new_flavor_id)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    def _revert_nova_action(self):"},{"line_number":707,"context_line":"        LOG.debug(\"Instance %s calling Compute revert resize...\""},{"line_number":708,"context_line":"                  % self.instance.id)"},{"line_number":709,"context_line":"        LOG.debug(\"Repairing conf file.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F49c%3D","line":706,"in_reply_to":"AAAAPH%2F%2FdGY%3D","updated":"2013-06-06 17:21:42.000000000","message":"Yeah, migrates without resizes don\u0027t change their conf files","commit_id":"50f66533c489cf20d3d79ede1db484dd9ca50d67"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"0dfd80bd350f0f4a676627239d553879d5ff0554","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        LOG.debug(\"Instance %s calling Compute revert resize...\""},{"line_number":708,"context_line":"                  % self.instance.id)"},{"line_number":709,"context_line":"        LOG.debug(\"Repairing conf file.\")"},{"line_number":710,"context_line":"        self.instance.guest.change_conf_file(self.old_memory_size)"},{"line_number":711,"context_line":"        LOG.debug(\"Reverting resize.\")"},{"line_number":712,"context_line":"        super(ResizeAction, self)._revert_nova_action()"},{"line_number":713,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2Fu0o%3D","line":710,"updated":"2013-06-11 19:01:55.000000000","message":"There is the possibility that the guest isn\u0027t actually running after the resize, which would cause this to fail?","commit_id":"0bf8c367b2ab34565c79aae1fde03a5a3370745e"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"unresolved":false,"context_lines":[{"line_number":707,"context_line":"        LOG.debug(\"Instance %s calling Compute revert resize...\""},{"line_number":708,"context_line":"                  % self.instance.id)"},{"line_number":709,"context_line":"        LOG.debug(\"Repairing conf file.\")"},{"line_number":710,"context_line":"        self.instance.guest.change_conf_file(self.old_memory_size)"},{"line_number":711,"context_line":"        LOG.debug(\"Reverting resize.\")"},{"line_number":712,"context_line":"        super(ResizeAction, self)._revert_nova_action()"},{"line_number":713,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2Fufg%3D","line":710,"in_reply_to":"AAAAPX%2F%2Fu0o%3D","updated":"2013-06-11 20:41:55.000000000","message":"That\u0027s a good point.\nMy thinking is we want to fix the conf before the original instance starts up so it has the right file. It\u0027s a bit more involved to make sure that the instance has the right config after reverting, since mysql will try to start, independent of the GA, and potentially with the wrong config, so we\u0027d have to make the GA stop mysql (if it can start before mysql overruns memory), fix the conf, restart mysql, and manage to do it all before declaring the instance ACTIVE again.\nI think in that case there\u0027s enough going on that you\u0027d want to investigate anyway. If we do work out an elegant way to do that, I\u0027d like to do it in addition to this fix.","commit_id":"0bf8c367b2ab34565c79aae1fde03a5a3370745e"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"unresolved":false,"context_lines":[{"line_number":707,"context_line":"        LOG.debug(\"Instance %s calling Compute revert resize...\""},{"line_number":708,"context_line":"                  % self.instance.id)"},{"line_number":709,"context_line":"        LOG.debug(\"Repairing conf file.\")"},{"line_number":710,"context_line":"        self.instance.guest.change_conf_file(self.old_memory_size)"},{"line_number":711,"context_line":"        LOG.debug(\"Reverting resize.\")"},{"line_number":712,"context_line":"        super(ResizeAction, self)._revert_nova_action()"},{"line_number":713,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2FpHA%3D","line":710,"in_reply_to":"AAAAPX%2F%2Fufg%3D","updated":"2013-06-13 16:43:51.000000000","message":"One issue is if the instance is totally dead, this call will time out and raise an exception. We\u0027d like the other code to run though so there should be a try/except around this. If an exception occurs it should just be logged.","commit_id":"0bf8c367b2ab34565c79aae1fde03a5a3370745e"}],"trove/taskmanager/models.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"unresolved":false,"context_lines":[{"line_number":711,"context_line":"            config \u003d {\u0027memory_mb\u0027: self.old_memory_size}"},{"line_number":712,"context_line":"            self.instance.guest.reset_configuration(config)"},{"line_number":713,"context_line":"        except GuestTimeout as gt:"},{"line_number":714,"context_line":"            LOG.error(\"Error sending reset_configuration call! %s\" % gt)"},{"line_number":715,"context_line":"        LOG.debug(\"Reverting resize.\")"},{"line_number":716,"context_line":"        super(ResizeAction, self)._revert_nova_action()"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FpIU%3D","line":714,"updated":"2013-06-26 04:06:33.000000000","message":"I think it could be cleaner here with just a log.exception instead. Then you don\u0027t need to name the guestTimeout either.","commit_id":"f647eb2e4c5b50fb3f2921a995dee5a27c398ab7"}]}