)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6b8c2ba1cf23b9bc1a9f1e7cebccc5fff761d818","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to move on with the implementation of Cinder snapshots as Trove"},{"line_number":10,"context_line":"backups we need to define the internal API changes that will take place."},{"line_number":11,"context_line":"This patch addresses these changes adding the necessary entry points on"},{"line_number":12,"context_line":"the guest agent API and adding some needed configuration options."},{"line_number":13,"context_line":"Once we agree with the API structure we can move on with the actual code"},{"line_number":14,"context_line":"patches."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_1283c157","line":11,"range":{"start_line":11,"start_character":27,"end_line":11,"end_character":41},"updated":"2016-06-06 21:34:25.000000000","message":"...changes by adding...","commit_id":"691117c654209d9fbca5e7e6b08986fea0a1d4ab"}],"trove/common/cfg.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"709ad31ae6339f00700e370273106de1703aadd7","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    cfg.IntOpt(\u0027agent_call_high_timeout\u0027, default\u003d60 * 5,"},{"line_number":142,"context_line":"               help\u003d\"Maximum time (in seconds) to wait for Guest Agent \u0027slow\u0027 \""},{"line_number":143,"context_line":"                    \"requests (such as restarting the database).\"),"},{"line_number":144,"context_line":"    cfg.IntOpt(\u0027agent_filesystem_quiesce_timeout\u0027, default\u003d5,"},{"line_number":145,"context_line":"               help\u003d\"Maximum time (in seconds) to wait for Guest Agent to \""},{"line_number":146,"context_line":"                    \"quiesce the Filesystem\"),"},{"line_number":147,"context_line":"    cfg.IntOpt(\u0027agent_db_quiesce_timeout\u0027, default\u003d10,"},{"line_number":148,"context_line":"               help\u003d\"Maximum time (in seconds) to wait for Guest Agent to \""},{"line_number":149,"context_line":"                    \"quiesce the database\"),"},{"line_number":150,"context_line":"    cfg.IntOpt(\u0027agent_replication_snapshot_timeout\u0027, default\u003d36000,"},{"line_number":151,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for taking a Guest \u0027"},{"line_number":152,"context_line":"                    \u0027Agent replication snapshot.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_c2b49536","line":149,"range":{"start_line":144,"start_character":0,"end_line":149,"end_character":44},"updated":"2016-05-25 18:47:44.000000000","message":"I don\u0027t believe that these should be global options but rather they should be datastore specific options.","commit_id":"defe3cff37bd4afe23f201dd9012db6b4bb21c4b"},{"author":{"_account_id":8932,"name":"Telles Mota Vidal Nóbrega","email":"tellesnobrega@gmail.com","username":"tellesnobrega"},"change_message_id":"fe003930bb1e50a43a35afbc110534832399716a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    cfg.IntOpt(\u0027agent_call_high_timeout\u0027, default\u003d60 * 5,"},{"line_number":142,"context_line":"               help\u003d\"Maximum time (in seconds) to wait for Guest Agent \u0027slow\u0027 \""},{"line_number":143,"context_line":"                    \"requests (such as restarting the database).\"),"},{"line_number":144,"context_line":"    cfg.IntOpt(\u0027agent_filesystem_quiesce_timeout\u0027, default\u003d5,"},{"line_number":145,"context_line":"               help\u003d\"Maximum time (in seconds) to wait for Guest Agent to \""},{"line_number":146,"context_line":"                    \"quiesce the Filesystem\"),"},{"line_number":147,"context_line":"    cfg.IntOpt(\u0027agent_db_quiesce_timeout\u0027, default\u003d10,"},{"line_number":148,"context_line":"               help\u003d\"Maximum time (in seconds) to wait for Guest Agent to \""},{"line_number":149,"context_line":"                    \"quiesce the database\"),"},{"line_number":150,"context_line":"    cfg.IntOpt(\u0027agent_replication_snapshot_timeout\u0027, default\u003d36000,"},{"line_number":151,"context_line":"               help\u003d\u0027Maximum time (in seconds) to wait for taking a Guest \u0027"},{"line_number":152,"context_line":"                    \u0027Agent replication snapshot.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_4244251a","line":149,"range":{"start_line":144,"start_character":0,"end_line":149,"end_character":44},"in_reply_to":"bab6814e_c2b49536","updated":"2016-05-25 18:50:25.000000000","message":"Makes sense, this was something I was thinking about as well.","commit_id":"defe3cff37bd4afe23f201dd9012db6b4bb21c4b"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6b8c2ba1cf23b9bc1a9f1e7cebccc5fff761d818","unresolved":false,"context_lines":[{"line_number":639,"context_line":"               deprecated_name\u003d\u0027default_password_length\u0027,"},{"line_number":640,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":641,"context_line":"    cfg.IntOpt(\u0027agent_filesystem_quiesce_timeout\u0027, default\u003d5,"},{"line_number":642,"context_line":"               help\u003d\"Maximum time (in seconds) to wait for Guest Agent to \""},{"line_number":643,"context_line":"                    \"quiesce the Filesystem\"),"},{"line_number":644,"context_line":"    cfg.IntOpt(\u0027agent_db_quiesce_timeout\u0027, default\u003d10,"},{"line_number":645,"context_line":"               help\u003d\"Maximum time (in seconds) to wait for Guest Agent to \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_577d3b6d","line":642,"range":{"start_line":642,"start_character":21,"end_line":642,"end_character":46},"updated":"2016-06-06 21:34:25.000000000","message":"Maximum time implies the timeout can be less than or equal to what the option\u0027s value is. I think you want \"The time in seconds\"","commit_id":"691117c654209d9fbca5e7e6b08986fea0a1d4ab"}],"trove/guestagent/api.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6b8c2ba1cf23b9bc1a9f1e7cebccc5fff761d818","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                          self.version_cap, module\u003dmodule)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def quiesce_db(self, manager):"},{"line_number":467,"context_line":"        LOG.debug(\"Quiescing the DB on instance %s.\" % self.id)"},{"line_number":468,"context_line":"        agent_db_quiesce_timeout \u003d CONF.get(manager).agent_db_quiesce_timeout"},{"line_number":469,"context_line":"        return self._call(\"quiesce_db\", agent_db_quiesce_timeout,"},{"line_number":470,"context_line":"                          self.version_cap)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_1c9c7abf","line":467,"range":{"start_line":467,"start_character":19,"end_line":467,"end_character":35},"updated":"2016-06-06 21:34:25.000000000","message":"It\u0027s weird how you change from \"Quiescing the DB\" to \"Quescing database\", between api.py and manager.py","commit_id":"691117c654209d9fbca5e7e6b08986fea0a1d4ab"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6b8c2ba1cf23b9bc1a9f1e7cebccc5fff761d818","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        return self._call(\"unquiesce_db\", agent_db_quiesce_timeout,"},{"line_number":476,"context_line":"                          self.version_cap)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def quiesce_filesystem(self, device_path, mount_point, manager):"},{"line_number":479,"context_line":"        LOG.debug(\"Quiescing the filesystem on instance %s.\" % self.id)"},{"line_number":480,"context_line":"        agent_fs_quiesce_timeout \u003d CONF.get(manager).\\"},{"line_number":481,"context_line":"            agent_filesystem_quiesce_timeout"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_12d4611e","line":478,"range":{"start_line":478,"start_character":16,"end_line":478,"end_character":26},"updated":"2016-06-06 21:34:25.000000000","message":"fs would be better to stay consistent. See resize_fs in this file.","commit_id":"691117c654209d9fbca5e7e6b08986fea0a1d4ab"}]}