)]}'
{"trove/common/cfg.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"d4b00dcab1ff4cf7f3022496285afb415f050f63","unresolved":false,"context_lines":[{"line_number":913,"context_line":"cassandra_22_group \u003d cfg.OptGroup("},{"line_number":914,"context_line":"    \u0027cassandra_22\u0027, title\u003d\u0027Cassandra 2.2 options\u0027,"},{"line_number":915,"context_line":"    help\u003d\"Oslo option group designed for Cassandra 2.2 datastore\")"},{"line_number":916,"context_line":"cassandra_22_opts \u003d _update_options(cassandra_3_opts)"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"# Couchbase"},{"line_number":919,"context_line":"couchbase_group \u003d cfg.OptGroup("}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_564fc46a","line":916,"updated":"2016-06-23 15:45:27.000000000","message":"Shouldn\u0027t the ordering here follow the Manager class ordering with both groups deriving from the base group, as the Manager class does?  It certainly seems odd to have the 22 options derive from the 3 options.","commit_id":"c026288c731724c65d975f2896952529adc91750"}],"trove/guestagent/datastore/experimental/cassandra/manager.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"d4b00dcab1ff4cf7f3022496285afb415f050f63","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            # we assume it is not going to and proceed with configuration"},{"line_number":100,"context_line":"            # right away."},{"line_number":101,"context_line":"            LOG.debug(\"Waiting for database first boot.\")"},{"line_number":102,"context_line":"            if (self.app.status.wait_for_real_status_to_change_to("},{"line_number":103,"context_line":"                    trove_instance.ServiceStatuses.RUNNING,"},{"line_number":104,"context_line":"                    CONF.state_change_wait_time,"},{"line_number":105,"context_line":"                    False)):"},{"line_number":106,"context_line":"                LOG.debug(\"Stopping database prior to initial configuration.\")"},{"line_number":107,"context_line":"                self.app.stop_db()"},{"line_number":108,"context_line":"                self.app._remove_system_tables()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            LOG.debug(\"Starting initial configuration.\")"},{"line_number":111,"context_line":"            if config_contents:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_508a2c1c","side":"PARENT","line":108,"range":{"start_line":102,"start_character":1,"end_line":108,"end_character":48},"updated":"2016-06-23 15:45:27.000000000","message":"If you expect the database to come up, but it doesn\u0027t, you can\u0027t just time out and move on.  You don\u0027t know what state the instance is, and you could be leading the user down the path to corrupting their data.  If it doesn\u0027t come up in the time you expect, just fail.","commit_id":"dbc9e4881ad321dff544c77eef9ec1b354a6e27e"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"d4b00dcab1ff4cf7f3022496285afb415f050f63","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                device.unmount_device(device_path)"},{"line_number":131,"context_line":"                device.format()"},{"line_number":132,"context_line":"                if os.path.exists(mount_point):"},{"line_number":133,"context_line":"                    # rsync exiting data"},{"line_number":134,"context_line":"                    LOG.debug(\"Migrating existing data.\")"},{"line_number":135,"context_line":"                    device.migrate_data(mount_point)"},{"line_number":136,"context_line":"                # mount the volume"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_50334c14","side":"PARENT","line":133,"updated":"2016-06-23 15:45:27.000000000","message":"Is it helpful here to make an assumption about a method you are calling, and to duplicate what the LOG message below does better?","commit_id":"dbc9e4881ad321dff544c77eef9ec1b354a6e27e"}]}
