)]}'
{"reddwarf/instance/models.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"15482b75f3cab7aaba6de41c7d987362dbfa064c","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @ephemeral_total.setter"},{"line_number":249,"context_line":"    def ephemeral_total(self, value):"},{"line_number":250,"context_line":"        self._ephemeral_total \u003d value"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"def get_db_info(context, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FxQU%3D","line":250,"updated":"2013-06-21 17:14:01.000000000","message":"These properties aren\u0027t necessary, since we don\u0027t care to return the total size of the volume.","commit_id":"7738ee8c54d1a46a54d25774d7346313226f2b70"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"faa327320382b4f24fd2e585ff7d356909f16c4a","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        guest \u003d create_guest_client(context, id)"},{"line_number":317,"context_line":"        try:"},{"line_number":318,"context_line":"            instance.volume_used \u003d guest.get_volume_info()[\u0027used\u0027]"},{"line_number":319,"context_line":"            instance.ephemeral_total \u003d guest.get_volume_info()[\u0027total\u0027]"},{"line_number":320,"context_line":"        except Exception as e:"},{"line_number":321,"context_line":"            LOG.error(e)"},{"line_number":322,"context_line":"    return instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FysI%3D","line":319,"updated":"2013-06-21 06:15:17.000000000","message":"Oh no don\u0027t make another call to the guest to get the volume info.","commit_id":"7738ee8c54d1a46a54d25774d7346313226f2b70"}],"reddwarf/instance/views.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"faa327320382b4f24fd2e585ff7d356909f16c4a","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"            else:"},{"line_number":107,"context_line":"                # otherwise, get the ephemeral size"},{"line_number":108,"context_line":"                if (isinstance(self.instance, models.DetailInstance) and"},{"line_number":109,"context_line":"                        self.instance.volume_used):"},{"line_number":110,"context_line":"                    total \u003d self._to_gb(self.instance.ephemeral_total)"},{"line_number":111,"context_line":"                    result[\u0027instance\u0027][\u0027volume\u0027][\u0027size\u0027] \u003d total"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FysQ%3D","line":108,"updated":"2013-06-21 06:15:17.000000000","message":"Looks like this is already a models.DetailInstance  class.","commit_id":"7738ee8c54d1a46a54d25774d7346313226f2b70"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"15482b75f3cab7aaba6de41c7d987362dbfa064c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                if (isinstance(self.instance, models.DetailInstance) and"},{"line_number":109,"context_line":"                        self.instance.volume_used):"},{"line_number":110,"context_line":"                    total \u003d self._to_gb(self.instance.ephemeral_total)"},{"line_number":111,"context_line":"                    result[\u0027instance\u0027][\u0027volume\u0027][\u0027size\u0027] \u003d total"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        return result"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FxRs%3D","line":111,"updated":"2013-06-21 17:14:01.000000000","message":"Why are we returning the total?  I think the goal is to inform the user how much has been used.","commit_id":"7738ee8c54d1a46a54d25774d7346313226f2b70"}],"trove/instance/models.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7d4c76b25a78de3eb80af0eb6cd04847cee2d1ff","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        try:"},{"line_number":318,"context_line":"            volume_info \u003d guest.get_volume_info()"},{"line_number":319,"context_line":"            instance.volume_used \u003d volume_info[\u0027used\u0027]"},{"line_number":320,"context_line":"            instance.ephemeral_total \u003d volume_info[\u0027total\u0027]"},{"line_number":321,"context_line":"        except Exception as e:"},{"line_number":322,"context_line":"            LOG.error(e)"},{"line_number":323,"context_line":"    return instance"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPn%2F%2FqSw%3D","line":320,"updated":"2013-06-25 19:02:43.000000000","message":"To be consistent, we should name this property \u0027local_storage_total\u0027, since we have the case where there is no volume and no ephemeral","commit_id":"6ea4daa53edf98fbba42483a938761e92cc4cb50"}],"trove/instance/views.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"7d4c76b25a78de3eb80af0eb6cd04847cee2d1ff","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                used \u003d self._to_gb(self.instance.volume_used)"},{"line_number":110,"context_line":"                result[\u0027instance\u0027][\u0027volume\u0027] \u003d {\u0027used\u0027: used}"},{"line_number":111,"context_line":"                total \u003d self._to_gb(self.instance.ephemeral_total)"},{"line_number":112,"context_line":"                result[\u0027instance\u0027][\u0027volume\u0027][\u0027size\u0027] \u003d total"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        return result"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPn%2F%2FqS0%3D","line":112,"updated":"2013-06-25 19:02:43.000000000","message":"Let\u0027s change the ephemeral case to show \u0027local_storage\u0027 : \u0027used\u0027 to remain consistent with how flavor details are shown","commit_id":"6ea4daa53edf98fbba42483a938761e92cc4cb50"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c00658e37a72e2f05bcb3bd49f1e38f6ab40f37c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                self.instance.volume_used):"},{"line_number":109,"context_line":"                used \u003d self._to_gb(self.instance.volume_used)"},{"line_number":110,"context_line":"                result[\u0027instance\u0027][\u0027local_storage\u0027] \u003d {\u0027used\u0027: used}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        return result"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAPn%2F%2FiUg%3D","line":111,"updated":"2013-06-28 09:56:59.000000000","message":"Can we refactor this to remove duplicate code, please?\nHow about something like:\n\nif (isinstance(self.instance, models.DetailInstance) and self.instance.volume_used):\n    storage_type \u003d \u0027volume\u0027 if CONF.trove_volume_support else \u0027local_storage\u0027\n    used \u003d self._to_gb(self.instance.volume_used)\n    result[\u0027instance\u0027][storage_type][\u0027used\u0027] \u003d used","commit_id":"748cc438848ec61c01b5139ecc8c3bf7b9f3ee6f"}],"trove/tests/api/instances.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"12e6e0b177f873a5162b192a48eaaffd079c2f9a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"EPHEMERAL_SUPPORT \u003d not VOLUME_SUPPORT and CONFIG.get(\u0027device_path\u0027,"},{"line_number":119,"context_line":"                                                      \u0027/dev/vdb\u0027) is not None"},{"line_number":120,"context_line":"ROOT_PARTITION \u003d not VOLUME_SUPPORT and CONFIG.get(\u0027device_path\u0027,"},{"line_number":121,"context_line":"                                                   \u0027/dev/vdb\u0027) is None"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# This is like a cheat code which allows the tests to skip creating a new"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2FphQ%3D","line":121,"updated":"2013-06-25 23:54:47.000000000","message":"CONFIG.get(\u0027device_path\u0027, \u0027/dev/vdb\u0027) can never return None","commit_id":"2f57e2f438936dbff85709238c9a3f720ed9a2f2"}]}