)]}'
{"trove/tests/unittests/guestagent/test_dbaas.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"685433b34367dd43606727b51ec3f8908c4dec05","unresolved":false,"context_lines":[{"line_number":103,"context_line":"           \"_collate\": \"latin2_general_ci\"}"},{"line_number":104,"context_line":"FAKE_DB_2 \u003d {\"_name\": \"testDB2\", \"_character_set\": \"latin2\","},{"line_number":105,"context_line":"             \"_collate\": \"latin2_general_ci\"}"},{"line_number":106,"context_line":"FAKE_USER \u003d [{\"_name\": \"random\", \"_password\": \"guesswhat\","},{"line_number":107,"context_line":"              \"_host\": \"%\", \"_databases\": [FAKE_DB]}]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_afa29a98","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":9},"updated":"2016-08-31 14:59:57.000000000","message":"Maybe this too?","commit_id":"44662d6a9b8fb959171dcf017e146c777430f166"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"685433b34367dd43606727b51ec3f8908c4dec05","unresolved":false,"context_lines":[{"line_number":476,"context_line":"    def test_change_passwords(self):"},{"line_number":477,"context_line":"        user \u003d [{\"name\": self.user.name, \"host\": self.user.host,"},{"line_number":478,"context_line":"                 \"password\": \"password\"}]"},{"line_number":479,"context_line":"        expected \u003d (\"SET PASSWORD FOR \u0027test_user\u0027@\u0027%\u0027 \u003d PASSWORD(\u0027password\u0027);\")"},{"line_number":480,"context_line":"        with patch.object(self.mock_client, \u0027execute\u0027) as mock_execute:"},{"line_number":481,"context_line":"            self.mySqlAdmin.change_passwords(user)"},{"line_number":482,"context_line":"            self._assert_execute_call(expected, mock_execute)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_ec9d8d5a","line":479,"range":{"start_line":479,"start_character":39,"end_line":479,"end_character":52},"updated":"2016-08-31 14:59:57.000000000","message":"self.user.name and self.user.host can be inserted here.","commit_id":"44662d6a9b8fb959171dcf017e146c777430f166"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"685433b34367dd43606727b51ec3f8908c4dec05","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def test_update_attributes_name(self):"},{"line_number":496,"context_line":"        user_attrs \u003d {\"name\": \"new_name\"}"},{"line_number":497,"context_line":"        expected \u003d (\"RENAME USER \u0027%s\u0027@\u0027%s\u0027 TO \u0027new_name\u0027@\u0027%s\u0027;\" %"},{"line_number":498,"context_line":"                    (self.user.name, self.user.host, self.user.host))"},{"line_number":499,"context_line":"        with patch.object(self.mock_client, \u0027execute\u0027) as mock_execute:"},{"line_number":500,"context_line":"            with patch.object(self.mySqlAdmin, \u0027_get_user\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_2ccbf573","line":497,"range":{"start_line":497,"start_character":46,"end_line":497,"end_character":56},"updated":"2016-08-31 14:59:57.000000000","message":"This can be replaced by user_attrs[\"name\"]","commit_id":"44662d6a9b8fb959171dcf017e146c777430f166"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"685433b34367dd43606727b51ec3f8908c4dec05","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def test_update_attributes_host(self):"},{"line_number":507,"context_line":"        user_attrs \u003d {\"host\": \"new_host\"}"},{"line_number":508,"context_line":"        expected \u003d (\"RENAME USER \u0027%s\u0027@\u0027%s\u0027 TO \u0027%s\u0027@\u0027new_host\u0027;\" %"},{"line_number":509,"context_line":"                    (self.user.name, self.user.host, self.user.name))"},{"line_number":510,"context_line":"        with patch.object(self.mock_client, \u0027execute\u0027) as mock_execute:"},{"line_number":511,"context_line":"            with patch.object(self.mySqlAdmin, \u0027_get_user\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_ccaa8985","line":508,"range":{"start_line":508,"start_character":51,"end_line":508,"end_character":61},"updated":"2016-08-31 14:59:57.000000000","message":"user_attrs[\"host\"]","commit_id":"44662d6a9b8fb959171dcf017e146c777430f166"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"685433b34367dd43606727b51ec3f8908c4dec05","unresolved":false,"context_lines":[{"line_number":2806,"context_line":"                    alter_user_password_arguments \u003d ("},{"line_number":2807,"context_line":"                        vertica_system.exec_vsql_command.call_args_list[0])"},{"line_number":2808,"context_line":"                    expected_alter_user_cmd \u003d ("},{"line_number":2809,"context_line":"                        vertica_system.ALTER_USER_PASSWORD % (\u0027root\u0027,"},{"line_number":2810,"context_line":"                                                              \u0027root_password\u0027"},{"line_number":2811,"context_line":"                                                              ))"},{"line_number":2812,"context_line":"                    alter_user_password_arguments.assert_called_with("},{"line_number":2813,"context_line":"                        \u0027some_password\u0027, expected_alter_user_cmd)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_0f4b86b1","line":2810,"range":{"start_line":2809,"start_character":62,"end_line":2810,"end_character":76},"updated":"2016-08-31 14:59:57.000000000","message":"root_user maybe?","commit_id":"44662d6a9b8fb959171dcf017e146c777430f166"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"685433b34367dd43606727b51ec3f8908c4dec05","unresolved":false,"context_lines":[{"line_number":2996,"context_line":"                    (vertica_system.VERTICA_AGENT_SERVICE_COMMAND % \u0027start\u0027)]"},{"line_number":2997,"context_line":"                db_expected_cmd \u003d ["},{"line_number":2998,"context_line":"                    \u0027sudo\u0027, \u0027su\u0027, \u0027-\u0027, \u0027dbadmin\u0027, \u0027-c\u0027,"},{"line_number":2999,"context_line":"                    (vertica_system.START_DB % (\u0027db_srvr\u0027, \u0027some_password\u0027))]"},{"line_number":3000,"context_line":"                self.assertTrue(mock_status.end_restart.called)"},{"line_number":3001,"context_line":"                agent_start.assert_called_with(agent_expected_command)"},{"line_number":3002,"context_line":"                db_start.assert_called_with(db_expected_cmd)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_2f620a17","line":2999,"range":{"start_line":2999,"start_character":60,"end_line":2999,"end_character":73},"updated":"2016-08-31 14:59:57.000000000","message":"Passwords like this could be any string so no need for storing this.","commit_id":"44662d6a9b8fb959171dcf017e146c777430f166"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"685433b34367dd43606727b51ec3f8908c4dec05","unresolved":false,"context_lines":[{"line_number":3663,"context_line":"        self.assertEqual(1, self.MariaDBApp.start_mysql.call_count)"},{"line_number":3664,"context_line":""},{"line_number":3665,"context_line":"    def test_install_cluster_with_bootstrap(self):"},{"line_number":3666,"context_line":"        repl_user \u003d {"},{"line_number":3667,"context_line":"            \u0027name\u0027: \u0027test-user\u0027,"},{"line_number":3668,"context_line":"            \u0027password\u0027: \u0027test-user-password\u0027,"},{"line_number":3669,"context_line":"        }"},{"line_number":3670,"context_line":"        apply_mock \u003d Mock()"},{"line_number":3671,"context_line":"        self.MariaDBApp.configuration_manager.apply_system_override \u003d \\"},{"line_number":3672,"context_line":"            apply_mock"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_8f807648","line":3669,"range":{"start_line":3666,"start_character":8,"end_line":3669,"end_character":9},"updated":"2016-08-31 14:59:57.000000000","message":"repl_user maybe?","commit_id":"44662d6a9b8fb959171dcf017e146c777430f166"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"578c3409903d75f5650f7f99d65203f68971ff2d","unresolved":false,"context_lines":[{"line_number":3636,"context_line":"    @patch.object(mariadb_service.MariaDBApp, \u0027get_engine\u0027,"},{"line_number":3637,"context_line":"                  return_value\u003dMagicMock(name\u003d\u0027get_engine\u0027))"},{"line_number":3638,"context_line":"    def test__grant_cluster_replication_privilege(self, mock_engine):"},{"line_number":3639,"context_line":"        repl_user \u003d {"},{"line_number":3640,"context_line":"            \u0027name\u0027: \u0027test-user\u0027,"},{"line_number":3641,"context_line":"            \u0027password\u0027: \u0027test-user-password\u0027,"},{"line_number":3642,"context_line":"        }"},{"line_number":3643,"context_line":"        with patch.object(mariadb_service.MariaDBApp, \u0027local_sql_client\u0027,"},{"line_number":3644,"context_line":"                          return_value\u003dself.mock_client):"},{"line_number":3645,"context_line":"            self.MariaDBApp._grant_cluster_replication_privilege(repl_user)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_8e5d8e7b","line":3642,"range":{"start_line":3639,"start_character":8,"end_line":3642,"end_character":9},"updated":"2016-09-01 14:48:45.000000000","message":"here","commit_id":"f319a4ba9d373debd160bf956169d84efff4f132"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"578c3409903d75f5650f7f99d65203f68971ff2d","unresolved":false,"context_lines":[{"line_number":3660,"context_line":"            timeout\u003d20)"},{"line_number":3661,"context_line":""},{"line_number":3662,"context_line":"    def test_install_cluster(self):"},{"line_number":3663,"context_line":"        repl_user \u003d {"},{"line_number":3664,"context_line":"            \u0027name\u0027: \u0027test-user\u0027,"},{"line_number":3665,"context_line":"            \u0027password\u0027: \u0027test-user-password\u0027,"},{"line_number":3666,"context_line":"        }"},{"line_number":3667,"context_line":"        apply_mock \u003d Mock()"},{"line_number":3668,"context_line":"        self.MariaDBApp.configuration_manager.apply_system_override \u003d \\"},{"line_number":3669,"context_line":"            apply_mock"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_8ed4aebd","line":3666,"range":{"start_line":3663,"start_character":8,"end_line":3666,"end_character":9},"updated":"2016-09-01 14:48:45.000000000","message":"here","commit_id":"f319a4ba9d373debd160bf956169d84efff4f132"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"578c3409903d75f5650f7f99d65203f68971ff2d","unresolved":false,"context_lines":[{"line_number":3680,"context_line":"        self.assertEqual(1, self.MariaDBApp.start_mysql.call_count)"},{"line_number":3681,"context_line":""},{"line_number":3682,"context_line":"    def test_install_cluster_with_bootstrap(self):"},{"line_number":3683,"context_line":"        repl_user \u003d {"},{"line_number":3684,"context_line":"            \u0027name\u0027: \u0027test-user\u0027,"},{"line_number":3685,"context_line":"            \u0027password\u0027: \u0027test-user-password\u0027,"},{"line_number":3686,"context_line":"        }"},{"line_number":3687,"context_line":"        apply_mock \u003d Mock()"},{"line_number":3688,"context_line":"        self.MariaDBApp.configuration_manager.apply_system_override \u003d \\"},{"line_number":3689,"context_line":"            apply_mock"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_ced6b6c2","line":3686,"range":{"start_line":3683,"start_character":8,"end_line":3686,"end_character":9},"updated":"2016-09-01 14:48:45.000000000","message":"here","commit_id":"f319a4ba9d373debd160bf956169d84efff4f132"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"29b7f374c73034970941ab331d0eb5a923c47092","unresolved":false,"context_lines":[{"line_number":2990,"context_line":"                app.start_db()"},{"line_number":2991,"context_line":"                agent_start, db_start \u003d subprocess.Popen.call_args_list"},{"line_number":2992,"context_line":"                agent_expected_command \u003d ["},{"line_number":2993,"context_line":"                    \u0027sudo\u0027, \u0027su\u0027, \u0027-\u0027, self.root_user.name, \u0027-c\u0027,"},{"line_number":2994,"context_line":"                    (vertica_system.VERTICA_AGENT_SERVICE_COMMAND % \u0027start\u0027)]"},{"line_number":2995,"context_line":"                db_expected_cmd \u003d ["},{"line_number":2996,"context_line":"                    \u0027sudo\u0027, \u0027su\u0027, \u0027-\u0027, \u0027dbadmin\u0027, \u0027-c\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_ef2e7ef9","line":2993,"range":{"start_line":2993,"start_character":39,"end_line":2993,"end_character":58},"updated":"2016-09-19 15:33:10.000000000","message":"ditto","commit_id":"7d0ef70f0d4d7b0f8edd83efe49eed7b7db0ac18"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"29b7f374c73034970941ab331d0eb5a923c47092","unresolved":false,"context_lines":[{"line_number":3178,"context_line":"            \u0027sudo\u0027, \u0027su\u0027, \u0027-\u0027, \u0027dbadmin\u0027, \u0027-c\u0027,"},{"line_number":3179,"context_line":"            (vertica_system.SET_RESTART_POLICY % (\u0027db_srvr\u0027, \u0027always\u0027))]"},{"line_number":3180,"context_line":"        expected_agent_enable \u003d ["},{"line_number":3181,"context_line":"            \u0027sudo\u0027, \u0027su\u0027, \u0027-\u0027, self.root_user.name, \u0027-c\u0027,"},{"line_number":3182,"context_line":"            (vertica_system.VERTICA_AGENT_SERVICE_COMMAND % \u0027enable\u0027)]"},{"line_number":3183,"context_line":""},{"line_number":3184,"context_line":"        self.assertEqual(2, subprocess.Popen.call_count)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_6fe34e06","line":3181,"range":{"start_line":3181,"start_character":31,"end_line":3181,"end_character":50},"updated":"2016-09-19 15:33:10.000000000","message":"Just wondering if the \u0027root\u0027 string here points to the system user \u0027root\u0027 rather than the database \u0027root\u0027","commit_id":"7d0ef70f0d4d7b0f8edd83efe49eed7b7db0ac18"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"29b7f374c73034970941ab331d0eb5a923c47092","unresolved":false,"context_lines":[{"line_number":3205,"context_line":"        self.assertEqual(2, vertica_system.shell_execute.call_count)"},{"line_number":3206,"context_line":"        restart_policy.assert_called_with(expected_restart_policy, \u0027dbadmin\u0027)"},{"line_number":3207,"context_line":"        agent_disable.assert_called_with(expected_agent_disable,"},{"line_number":3208,"context_line":"                                         self.root_user.name)"},{"line_number":3209,"context_line":""},{"line_number":3210,"context_line":"    @patch(\u0027trove.guestagent.datastore.experimental.vertica.service.LOG\u0027)"},{"line_number":3211,"context_line":"    def test_failure__disable_db_on_boot(self, *args):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_efb91ecd","line":3208,"range":{"start_line":3208,"start_character":41,"end_line":3208,"end_character":60},"updated":"2016-09-19 15:33:10.000000000","message":"ditto","commit_id":"7d0ef70f0d4d7b0f8edd83efe49eed7b7db0ac18"}],"trove/tests/unittests/trove_testtools.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"0ea0d742e7d7978376556bf8cf4993a09581e299","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Default manager used by all unittsest unless explicitly overriden."},{"line_number":102,"context_line":"        self.patch_datastore_manager(\u0027mysql\u0027)"},{"line_number":103,"context_line":"        self.user \u003d mock.MagicMock()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def tearDown(self):"},{"line_number":106,"context_line":"        # yes, this is gross and not thread aware."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_6353996d","line":103,"updated":"2016-08-02 15:01:47.000000000","message":"I don\u0027t think this is needed for every single Trove test. Probably not even for majority of them. I would personally prefer to avoid creating stuff here that is not required by majority of tests.\nIt\u0027s kind of far from the usage scope and will mostly be unused anyways... :/","commit_id":"ef23d0a9fa2476dfde9ff831a52a7e65d13210fd"},{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"27c6cdf792e9bdf8c44e3fcb935d02f5664afee3","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Default manager used by all unittsest unless explicitly overriden."},{"line_number":102,"context_line":"        self.patch_datastore_manager(\u0027mysql\u0027)"},{"line_number":103,"context_line":"        self.user \u003d mock.MagicMock()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def tearDown(self):"},{"line_number":106,"context_line":"        # yes, this is gross and not thread aware."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8eb50d33","line":103,"in_reply_to":"bacf61ea_6353996d","updated":"2016-08-02 16:47:34.000000000","message":"Good point and duly noted! While looking into how to fix this, I found the same line under the MySqlAdminTest class, which is accomplishing the refactoring but at a more appropriate usage scope, so I\u0027ll just remove this line.","commit_id":"ef23d0a9fa2476dfde9ff831a52a7e65d13210fd"}]}