)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"85f92ea6342e4994fb42608e800ac2a92e6f75b7","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    ALT_PRIVATE_SUBNET_NAME\u003d${ALT_PRIVATE_NETWORK_NAME}-subnet"},{"line_number":320,"context_line":"    ALT_PRIVATE_IPV6_SUBNET_NAME\u003dipv6-${ALT_PRIVATE_NETWORK_NAME}-subnet"},{"line_number":321,"context_line":"    ALT_NET_ID\u003d$(neutron --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" net-create --tenant-id ${ALT_TENANT_ID} \"$ALT_PRIVATE_NETWORK_NAME\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":322,"context_line":"    ALT_SUBNET_ID\u003d$(_neutron_create_private_subnet_v4 ${ALT_TENANT_ID} ${ALT_NET_ID} ${ALT_PRIVATE_SUBNET_NAME} ${ADMIN_ALT_DEMO_CLOUD})"},{"line_number":323,"context_line":"    ALT_IPV6_SUBNET_ID\u003d$(_neutron_create_private_subnet_v6 ${ALT_TENANT_ID} ${ALT_NET_ID} ${ALT_PRIVATE_IPV6_SUBNET_NAME} ${ADMIN_ALT_DEMO_CLOUD})"},{"line_number":324,"context_line":"    neutron --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" router-interface-add $ROUTER_ID $ALT_SUBNET_ID"},{"line_number":325,"context_line":"    neutron --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" router-interface-add $ROUTER_ID $ALT_IPV6_SUBNET_ID"}],"source_content_type":"text/x-sh","patch_set":5,"id":"1ac06dbe_e97c2d74","line":322,"updated":"2016-08-25 16:20:58.000000000","message":"_neutron_* methods that you are calling are private methods. We don\u0027t provide any guarantee about their safety or compatibility. I would prefer that you not call any method prefixed with a _ from a plugin.","commit_id":"9bbcc5c649d4cd099dcf6e8bb54fd87b34498ea0"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"85f92ea6342e4994fb42608e800ac2a92e6f75b7","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    ALT_PRIVATE_IPV6_SUBNET_NAME\u003dipv6-${ALT_PRIVATE_NETWORK_NAME}-subnet"},{"line_number":321,"context_line":"    ALT_NET_ID\u003d$(neutron --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" net-create --tenant-id ${ALT_TENANT_ID} \"$ALT_PRIVATE_NETWORK_NAME\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":322,"context_line":"    ALT_SUBNET_ID\u003d$(_neutron_create_private_subnet_v4 ${ALT_TENANT_ID} ${ALT_NET_ID} ${ALT_PRIVATE_SUBNET_NAME} ${ADMIN_ALT_DEMO_CLOUD})"},{"line_number":323,"context_line":"    ALT_IPV6_SUBNET_ID\u003d$(_neutron_create_private_subnet_v6 ${ALT_TENANT_ID} ${ALT_NET_ID} ${ALT_PRIVATE_IPV6_SUBNET_NAME} ${ADMIN_ALT_DEMO_CLOUD})"},{"line_number":324,"context_line":"    neutron --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" router-interface-add $ROUTER_ID $ALT_SUBNET_ID"},{"line_number":325,"context_line":"    neutron --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" router-interface-add $ROUTER_ID $ALT_IPV6_SUBNET_ID"},{"line_number":326,"context_line":"    echo \"Using network ${ALT_PRIVATE_NETWORK_NAME} (${ALT_NET_ID})\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"1ac06dbe_e958adfc","line":323,"updated":"2016-08-25 16:20:58.000000000","message":"ditto","commit_id":"9bbcc5c649d4cd099dcf6e8bb54fd87b34498ea0"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"449a1bcb27a0f19782a9a60471465eff6bcb5802","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    fi"},{"line_number":312,"context_line":"}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"# Create private IPv4 subnet"},{"line_number":315,"context_line":"# Note: This was taken from devstack:lib/neutron_plugins/services/l3 and will need to be maintained"},{"line_number":316,"context_line":"function _create_private_subnet_v4 {"},{"line_number":317,"context_line":"    local project_id\u003d$1"}],"source_content_type":"text/x-sh","patch_set":21,"id":"7a77a97e_f7eb56ae","line":314,"updated":"2016-11-16 15:31:54.000000000","message":"We can avoid all of this mess by setting the default devstack private network to \"shared\". The result being that all tenants can then use the private network and its subnets. I vote we go that route instead of trying to maintain the code below.","commit_id":"0be3bf58c499fde63e9c5b92588a02aba32fad26"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"312d437f2cadc6fbefffe67d6a9a62f0b8762c9e","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    fi"},{"line_number":312,"context_line":"}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"# Create private IPv4 subnet"},{"line_number":315,"context_line":"# Note: This was taken from devstack:lib/neutron_plugins/services/l3 and will need to be maintained"},{"line_number":316,"context_line":"function _create_private_subnet_v4 {"},{"line_number":317,"context_line":"    local project_id\u003d$1"}],"source_content_type":"text/x-sh","patch_set":21,"id":"7a77a97e_dd1038ab","line":314,"in_reply_to":"7a77a97e_2c1f4060","updated":"2016-11-16 16:44:10.000000000","message":"Well, the reason we\u0027d have to maintain it is that the devstack guys don\u0027t want to expose this function (that was the original plan - enhance their function to allow us to call it).  I also think this is a more realistic test env, but at this point I just want to get it to work.  On the bright side, I think the networking issues have been solved - it looks like ipv6 support (in tests at least) is a bit lacking.","commit_id":"0be3bf58c499fde63e9c5b92588a02aba32fad26"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"0010c363ff0c99f52637f713fcf925d8b530c7c6","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    fi"},{"line_number":312,"context_line":"}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"# Create private IPv4 subnet"},{"line_number":315,"context_line":"# Note: This was taken from devstack:lib/neutron_plugins/services/l3 and will need to be maintained"},{"line_number":316,"context_line":"function _create_private_subnet_v4 {"},{"line_number":317,"context_line":"    local project_id\u003d$1"}],"source_content_type":"text/x-sh","patch_set":21,"id":"7a77a97e_5764f947","line":314,"in_reply_to":"7a77a97e_dd1038ab","updated":"2016-11-16 21:11:32.000000000","message":"Unfortunately devstack doesn\u0027t expose a var to toggle the network shared status. The default network that we want shared is the \"private\" network belonging to \"demo\". To get the same result:\n\nopenstack --os-cloud $os_cloud --os-region \"$REGION_NAME\" --os-project-name demo network set --share private","commit_id":"0be3bf58c499fde63e9c5b92588a02aba32fad26"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"69c4c60e993a3206707f363b14a67a58b3acfae3","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    fi"},{"line_number":312,"context_line":"}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"# Create private IPv4 subnet"},{"line_number":315,"context_line":"# Note: This was taken from devstack:lib/neutron_plugins/services/l3 and will need to be maintained"},{"line_number":316,"context_line":"function _create_private_subnet_v4 {"},{"line_number":317,"context_line":"    local project_id\u003d$1"}],"source_content_type":"text/x-sh","patch_set":21,"id":"7a77a97e_2c1f4060","line":314,"in_reply_to":"7a77a97e_f7eb56ae","updated":"2016-11-16 15:57:41.000000000","message":"I\u0027m torn by this for a couple of reasons.\n\nFirst, this code is ipv4 only, there\u0027s other ipv6 stuff below. it is a mess to maintain, and yes if we made the network shared, life would be good.\n\nBut, what\u0027s the recommended deployment in practice going to look like? How much like that do we want our tests to be?\n\nLet\u0027s see if this fixes the problem. If it doesn\u0027t, the discussion is moot.","commit_id":"0be3bf58c499fde63e9c5b92588a02aba32fad26"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"be5c430d94b4045c4b37b868f88866898c253071","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    fi"},{"line_number":312,"context_line":"}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"# Create private IPv4 subnet"},{"line_number":315,"context_line":"# Note: This was taken from devstack:lib/neutron_plugins/services/l3 and will need to be maintained"},{"line_number":316,"context_line":"function _create_private_subnet_v4 {"},{"line_number":317,"context_line":"    local project_id\u003d$1"}],"source_content_type":"text/x-sh","patch_set":21,"id":"7a77a97e_ddb838e8","line":314,"in_reply_to":"7a77a97e_f7eb56ae","updated":"2016-11-16 16:41:32.000000000","message":"Sure, I can test that.  What variable do we have to set to make the private network shared?","commit_id":"0be3bf58c499fde63e9c5b92588a02aba32fad26"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"9c55858b13688a592a845e0230b64bef1b47d347","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    fi"},{"line_number":312,"context_line":"}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"# Create private IPv4 subnet"},{"line_number":315,"context_line":"# Note: This was taken from devstack:lib/neutron_plugins/services/l3 and will need to be maintained"},{"line_number":316,"context_line":"function _create_private_subnet_v4 {"},{"line_number":317,"context_line":"    local project_id\u003d$1"}],"source_content_type":"text/x-sh","patch_set":30,"id":"7a77a97e_b51cfe6a","line":314,"updated":"2016-11-18 19:20:44.000000000","message":"I\u0027m still against these two functions. Just set the demo tenant\u0027s \"private\" network to shared.","commit_id":"75142db86d45d060b5c42a2a38fe83fbbc221ce4"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"ba94b8c77e1bf6f7f5aa7fe16f2f500bb1efc5b0","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    fi"},{"line_number":312,"context_line":"}"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"# Create private IPv4 subnet"},{"line_number":315,"context_line":"# Note: This was taken from devstack:lib/neutron_plugins/services/l3 and will need to be maintained"},{"line_number":316,"context_line":"function _create_private_subnet_v4 {"},{"line_number":317,"context_line":"    local project_id\u003d$1"}],"source_content_type":"text/x-sh","patch_set":30,"id":"7a77a97e_a7ae8c2b","line":314,"in_reply_to":"7a77a97e_b51cfe6a","updated":"2016-11-18 23:32:44.000000000","message":"See https://review.openstack.org/#/c/399763/ for a \u0027shared network\u0027 attemp","commit_id":"75142db86d45d060b5c42a2a38fe83fbbc221ce4"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"9c55858b13688a592a845e0230b64bef1b47d347","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    iniset $TROVE_CONF DEFAULT network_label_regex .*"},{"line_number":394,"context_line":"    iniset $TROVE_CONF DEFAULT ip_regex .*"},{"line_number":395,"context_line":"    iniset $TROVE_CONF DEFAULT black_list_regex ^10.0.1.*"},{"line_number":396,"context_line":"    iniset $TROVE_CONF DEFAULT default_neutron_networks ${ALT_NET_ID}"},{"line_number":397,"context_line":"    iniset $TROVE_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT network_label_regex .*"}],"source_content_type":"text/x-sh","patch_set":30,"id":"7a77a97e_126948f9","line":396,"updated":"2016-11-18 19:20:44.000000000","message":"The recommended production setup is for this to point to the network used by rabbit. Typically that would be an operator owned shared network.","commit_id":"75142db86d45d060b5c42a2a38fe83fbbc221ce4"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"9c55858b13688a592a845e0230b64bef1b47d347","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT network_label_regex .*"},{"line_number":400,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT ip_regex .*"},{"line_number":401,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT black_list_regex ^10.0.1.*"},{"line_number":402,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT default_neutron_networks ${ALT_NET_ID}"},{"line_number":403,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":404,"context_line":"}"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-sh","patch_set":30,"id":"7a77a97e_351f0e5c","line":402,"updated":"2016-11-18 19:20:44.000000000","message":"ditto","commit_id":"75142db86d45d060b5c42a2a38fe83fbbc221ce4"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d13c8c4576fa6c2fcec494a7a2288fc080447807","unresolved":false,"context_lines":[{"line_number":385,"context_line":"    ALT_PRIVATE_SUBNET_NAME\u003d${TROVE_PRIVATE_SUBNET_NAME}"},{"line_number":386,"context_line":"    ALT_PRIVATE_IPV6_SUBNET_NAME\u003dipv6-${ALT_PRIVATE_SUBNET_NAME}"},{"line_number":387,"context_line":"    ALT_NET_ID\u003d$(openstack --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" network create --project ${ALT_TENANT_ID} \"$ALT_PRIVATE_NETWORK_NAME\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":388,"context_line":"    if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"},{"line_number":389,"context_line":"        ALT_SUBNET_ID\u003d$(_create_private_subnet_v4 ${ALT_TENANT_ID} ${ALT_NET_ID} ${ALT_PRIVATE_SUBNET_NAME} ${ADMIN_ALT_DEMO_CLOUD})"},{"line_number":390,"context_line":"        openstack --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" router add subnet $ROUTER_ID $ALT_SUBNET_ID"},{"line_number":391,"context_line":"        echo \"Created network ${ALT_PRIVATE_NETWORK_NAME} (${ALT_NET_ID}): ${ALT_PRIVATE_SUBNET_NAME} (${ALT_SUBNET_ID})\""}],"source_content_type":"text/x-sh","patch_set":54,"id":"5a74a57a_bb020f08","line":388,"updated":"2016-11-29 16:25:24.000000000","message":"since we only support IP_VERSION\u003d4, shouldn\u0027t this check now read:\n\nif [[ \"${IP_VERSION}\" !\u003d \"4\" ]]; then","commit_id":"c666032b099838c1584538aa79bdf57036c0a329"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8b89585cdb15ed19da86b5d290baff7a4fb98346","unresolved":false,"context_lines":[{"line_number":385,"context_line":"    ALT_PRIVATE_SUBNET_NAME\u003d${TROVE_PRIVATE_SUBNET_NAME}"},{"line_number":386,"context_line":"    ALT_PRIVATE_IPV6_SUBNET_NAME\u003dipv6-${ALT_PRIVATE_SUBNET_NAME}"},{"line_number":387,"context_line":"    ALT_NET_ID\u003d$(openstack --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" network create --project ${ALT_TENANT_ID} \"$ALT_PRIVATE_NETWORK_NAME\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":388,"context_line":"    if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"},{"line_number":389,"context_line":"        ALT_SUBNET_ID\u003d$(_create_private_subnet_v4 ${ALT_TENANT_ID} ${ALT_NET_ID} ${ALT_PRIVATE_SUBNET_NAME} ${ADMIN_ALT_DEMO_CLOUD})"},{"line_number":390,"context_line":"        openstack --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" router add subnet $ROUTER_ID $ALT_SUBNET_ID"},{"line_number":391,"context_line":"        echo \"Created network ${ALT_PRIVATE_NETWORK_NAME} (${ALT_NET_ID}): ${ALT_PRIVATE_SUBNET_NAME} (${ALT_SUBNET_ID})\""}],"source_content_type":"text/x-sh","patch_set":54,"id":"5a74a57a_1edcd173","line":388,"in_reply_to":"5a74a57a_9efd410b","updated":"2016-11-29 16:39:20.000000000","message":"I was pretty sure we removed to hardcode to \u00274\u0027 - in my tests I typically saw the v6 subnet set up so I wanted to remove it from the equation right now.  I could remember it wrong though ...","commit_id":"c666032b099838c1584538aa79bdf57036c0a329"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"af0ec11bc511b77c5a75fa2289e57efcb5c4e47c","unresolved":false,"context_lines":[{"line_number":385,"context_line":"    ALT_PRIVATE_SUBNET_NAME\u003d${TROVE_PRIVATE_SUBNET_NAME}"},{"line_number":386,"context_line":"    ALT_PRIVATE_IPV6_SUBNET_NAME\u003dipv6-${ALT_PRIVATE_SUBNET_NAME}"},{"line_number":387,"context_line":"    ALT_NET_ID\u003d$(openstack --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" network create --project ${ALT_TENANT_ID} \"$ALT_PRIVATE_NETWORK_NAME\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":388,"context_line":"    if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"},{"line_number":389,"context_line":"        ALT_SUBNET_ID\u003d$(_create_private_subnet_v4 ${ALT_TENANT_ID} ${ALT_NET_ID} ${ALT_PRIVATE_SUBNET_NAME} ${ADMIN_ALT_DEMO_CLOUD})"},{"line_number":390,"context_line":"        openstack --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" router add subnet $ROUTER_ID $ALT_SUBNET_ID"},{"line_number":391,"context_line":"        echo \"Created network ${ALT_PRIVATE_NETWORK_NAME} (${ALT_NET_ID}): ${ALT_PRIVATE_SUBNET_NAME} (${ALT_SUBNET_ID})\""}],"source_content_type":"text/x-sh","patch_set":54,"id":"5a74a57a_dbcfcb27","line":388,"in_reply_to":"5a74a57a_bb020f08","updated":"2016-11-29 16:32:47.000000000","message":"But then this code wouldn\u0027t run, and we wouldn\u0027t set up the alt-private subnet ...","commit_id":"c666032b099838c1584538aa79bdf57036c0a329"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7de1dc84ed4c2c8a13cb744f5b0c6ffe89ca9835","unresolved":false,"context_lines":[{"line_number":385,"context_line":"    ALT_PRIVATE_SUBNET_NAME\u003d${TROVE_PRIVATE_SUBNET_NAME}"},{"line_number":386,"context_line":"    ALT_PRIVATE_IPV6_SUBNET_NAME\u003dipv6-${ALT_PRIVATE_SUBNET_NAME}"},{"line_number":387,"context_line":"    ALT_NET_ID\u003d$(openstack --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" network create --project ${ALT_TENANT_ID} \"$ALT_PRIVATE_NETWORK_NAME\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":388,"context_line":"    if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"},{"line_number":389,"context_line":"        ALT_SUBNET_ID\u003d$(_create_private_subnet_v4 ${ALT_TENANT_ID} ${ALT_NET_ID} ${ALT_PRIVATE_SUBNET_NAME} ${ADMIN_ALT_DEMO_CLOUD})"},{"line_number":390,"context_line":"        openstack --os-cloud ${ADMIN_ALT_DEMO_CLOUD} --os-region \"$REGION_NAME\" router add subnet $ROUTER_ID $ALT_SUBNET_ID"},{"line_number":391,"context_line":"        echo \"Created network ${ALT_PRIVATE_NETWORK_NAME} (${ALT_NET_ID}): ${ALT_PRIVATE_SUBNET_NAME} (${ALT_SUBNET_ID})\""}],"source_content_type":"text/x-sh","patch_set":54,"id":"5a74a57a_9efd410b","line":388,"in_reply_to":"5a74a57a_dbcfcb27","updated":"2016-11-29 16:35:47.000000000","message":"don\u0027t we hardcode this to \"4\"? or is it running with the default of 4+6? I assume that it is the latter based on your comment.","commit_id":"c666032b099838c1584538aa79bdf57036c0a329"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d13c8c4576fa6c2fcec494a7a2288fc080447807","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT network_label_regex .*"},{"line_number":425,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT ip_regex .*"},{"line_number":426,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT black_list_regex ^10.0.1.*"},{"line_number":427,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT default_neutron_networks ${NET_ID}"},{"line_number":428,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":429,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":54,"id":"5a74a57a_5b61fbd2","line":426,"range":{"start_line":426,"start_character":60,"end_line":426,"end_character":69},"updated":"2016-11-29 16:25:24.000000000","message":"I assume that this would also need to be customizable if the network isn\u0027t the 10.0.1.x that we expect?","commit_id":"c666032b099838c1584538aa79bdf57036c0a329"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"af0ec11bc511b77c5a75fa2289e57efcb5c4e47c","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT network_label_regex .*"},{"line_number":425,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT ip_regex .*"},{"line_number":426,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT black_list_regex ^10.0.1.*"},{"line_number":427,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT default_neutron_networks ${NET_ID}"},{"line_number":428,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT network_driver trove.network.neutron.NeutronDriver"},{"line_number":429,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":54,"id":"5a74a57a_1bf7838d","line":426,"range":{"start_line":426,"start_character":60,"end_line":426,"end_character":69},"in_reply_to":"5a74a57a_5b61fbd2","updated":"2016-11-29 16:32:47.000000000","message":"Yes, there are a number of things that still need to be sorted out, but this should get the ball rolling.","commit_id":"c666032b099838c1584538aa79bdf57036c0a329"}],"integration/scripts/trovestack.rc":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"fa524464a2092da348f91ee6160153ca3cb7a5ed","unresolved":false,"context_lines":[{"line_number":11,"context_line":"REGION_NAME\u003d${REGION_NAME:-${OS_REGION_NAME:-RegionOne}}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Enable Neutron"},{"line_number":14,"context_line":"ENABLE_NEUTRON\u003d$(get_bool ENABLE_NEUTRON true)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Enable osprofiler - note: Enables Ceilometer as well"},{"line_number":17,"context_line":"ENABLE_PROFILER\u003d$(get_bool ENABLE_PROFILER false)"}],"source_content_type":"application/octet-stream","patch_set":30,"id":"7a77a97e_72299ce5","line":14,"updated":"2016-11-18 19:11:35.000000000","message":"this may be pointless; may as well just make it true, period.","commit_id":"75142db86d45d060b5c42a2a38fe83fbbc221ce4"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"ba94b8c77e1bf6f7f5aa7fe16f2f500bb1efc5b0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"REGION_NAME\u003d${REGION_NAME:-${OS_REGION_NAME:-RegionOne}}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Enable Neutron"},{"line_number":14,"context_line":"ENABLE_NEUTRON\u003d$(get_bool ENABLE_NEUTRON true)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Enable osprofiler - note: Enables Ceilometer as well"},{"line_number":17,"context_line":"ENABLE_PROFILER\u003d$(get_bool ENABLE_PROFILER false)"}],"source_content_type":"application/octet-stream","patch_set":30,"id":"7a77a97e_758c26da","line":14,"in_reply_to":"7a77a97e_72299ce5","updated":"2016-11-18 23:32:44.000000000","message":"I agree - leaving it in for a cycle just in case we need to test nova-net again probably won\u0027t hurt.","commit_id":"75142db86d45d060b5c42a2a38fe83fbbc221ce4"}],"trove/tests/scenario/runners/test_runners.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"5b7e9b322b77348f9d51af2a1e376a29a9f6d6c9","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        return client.instances.get(instance_id)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def extract_ipv4s(self, ips):"},{"line_number":632,"context_line":"        ipv4s \u003d [str(ip) for ip in ips if \u0027.\u0027 in ip]"},{"line_number":633,"context_line":"        if not ipv4s:"},{"line_number":634,"context_line":"            self.fail(\"No IPV4 ip found\")"},{"line_number":635,"context_line":"        return ipv4s"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a77a97e_a502766d","line":632,"updated":"2016-11-16 20:37:22.000000000","message":"You could also use \u0027netaddr.valid_ipv4(ip)\u0027\nI think that ipv6 may possibly contain \u0027.\u0027 as well: https://tools.ietf.org/html/rfc7371#section-2","commit_id":"0be3bf58c499fde63e9c5b92588a02aba32fad26"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"ddc82ee0a2b404050a8a79387df58dd8e2bc831f","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        return client.instances.get(instance_id)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def extract_ipv4s(self, ips):"},{"line_number":632,"context_line":"        ipv4s \u003d [str(ip) for ip in ips if \u0027.\u0027 in ip]"},{"line_number":633,"context_line":"        if not ipv4s:"},{"line_number":634,"context_line":"            self.fail(\"No IPV4 ip found\")"},{"line_number":635,"context_line":"        return ipv4s"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a77a97e_37a21daf","line":632,"in_reply_to":"7a77a97e_a502766d","updated":"2016-11-16 21:01:27.000000000","message":"Yeah we require netaddr already so use it.","commit_id":"0be3bf58c499fde63e9c5b92588a02aba32fad26"}]}