)]}'
{"trove/cluster/models.py":[{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"89d0bccf4dcf86425b6ddea69913b4cd1c5b7198","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        elif action \u003d\u003d \u0027upgrade\u0027:"},{"line_number":315,"context_line":"            context.notification \u003d DBaaSClusterUpgrade(context, request\u003dreq)"},{"line_number":316,"context_line":"            dv_id \u003d param[\u0027datastore_version\u0027]"},{"line_number":317,"context_line":"            dv \u003d datastore_models.DatastoreVersion.load(self.datastore, dv_id)"},{"line_number":318,"context_line":"            with StartNotification(context, cluster_id\u003dself.id,"},{"line_number":319,"context_line":"                                   datastore_version\u003ddv.id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_ce46f822","line":316,"range":{"start_line":316,"start_character":12,"end_line":316,"end_character":46},"updated":"2016-10-05 14:55:06.000000000","message":"Could just put the param[\u0027datastore_version\u0027] in the load() call","commit_id":"bea853a4cb82be718f6779a8db81f5750ca39fff"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"50fdd5e0bcae05c1603736c936651a3c2bc5f5e2","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            dv \u003d datastore_models.DatastoreVersion.load(self.datastore, dv_id)"},{"line_number":318,"context_line":"            with StartNotification(context, cluster_id\u003dself.id,"},{"line_number":319,"context_line":"                                   datastore_version\u003ddv.id):"},{"line_number":320,"context_line":"                return self.upgrade(dv)"},{"line_number":321,"context_line":"        else:"},{"line_number":322,"context_line":"            raise exception.BadRequest(_(\"Action %s not supported\") % action)"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_024e10c1","line":320,"updated":"2016-11-14 16:02:53.000000000","message":"We need to update the Trove database after this call to save this new datastore version id. My recommendation:\n\n\u003c\u003c                return self.upgrade(dv)\n\u003e\u003e                self.upgrade(dv)\n\u003e\u003e            self.update_db(datastore_version_id\u003ddv.id)","commit_id":"bea853a4cb82be718f6779a8db81f5750ca39fff"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"24771f335ed347ff7d70224bd8938772ffc80f93","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            dv \u003d datastore_models.DatastoreVersion.load(self.datastore, dv_id)"},{"line_number":318,"context_line":"            with StartNotification(context, cluster_id\u003dself.id,"},{"line_number":319,"context_line":"                                   datastore_version\u003ddv.id):"},{"line_number":320,"context_line":"                return self.upgrade(dv)"},{"line_number":321,"context_line":"        else:"},{"line_number":322,"context_line":"            raise exception.BadRequest(_(\"Action %s not supported\") % action)"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_9c25200c","line":320,"in_reply_to":"9a629dbe_024e10c1","updated":"2016-11-14 17:10:36.000000000","message":"Good point, but it should go on the datastore specific call where the database is updated with the status (as is done for single instance upgrade).  I\u0027ve added a comment to the PXC upgrade change.","commit_id":"bea853a4cb82be718f6779a8db81f5750ca39fff"}],"trove/tests/unittests/cluster/test_cluster.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d73291e980d337687c4bb14d1f07486b9abd9f49","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        mock_task_api.mongodb_add_shard_cluster.assert_called_with("},{"line_number":223,"context_line":"            self.cluster.id, \u0027new-shard-id\u0027, \u0027rs2\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @patch(\u0027trove.cluster.models.LOG\u0027)"},{"line_number":226,"context_line":"    def test_upgrade_not_implemented(self, mock_logging):"},{"line_number":227,"context_line":"        self.assertRaises(exception.BadRequest, self.cluster.upgrade, \"foo\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_cd0e668b","line":225,"updated":"2016-11-03 01:27:12.000000000","message":"thank you!","commit_id":"bea853a4cb82be718f6779a8db81f5750ca39fff"}]}