)]}'
{"trove/cmd/fakemode.py":[{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"c63c2004ddc3852fba9d81101fe59a5482cf7cf6","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"opts \u003d ["},{"line_number":24,"context_line":"    openstack_cfg.BoolOpt(\u0027fork\u0027, short\u003d\u0027f\u0027, default\u003dFalse, dest\u003d\u0027fork\u0027),"},{"line_number":25,"context_line":"    openstack_cfg.StrOpt(\u0027pid_file\u0027, default\u003d\u0027.pid\u0027),"},{"line_number":26,"context_line":"    openstack_cfg.StrOpt(\u0027override-logfile\u0027, default\u003dNone),"},{"line_number":27,"context_line":"]"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_baec0af4","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":53},"updated":"2016-09-07 18:55:58.000000000","message":"I just noticed that registered a pid_file above,maybe we should use this ,but it is not same name when use...Perhaps for this reason, I have amended the...","commit_id":"8b067998d332d9041ea1eb0b57b0b6dada1fd49f"},{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"c63c2004ddc3852fba9d81101fe59a5482cf7cf6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            start_server(conf)"},{"line_number":42,"context_line":"        else:"},{"line_number":43,"context_line":"            print(\"Starting server:%s\" % pid)"},{"line_number":44,"context_line":"            pid_file \u003d CONF.pid_file"},{"line_number":45,"context_line":"            with open(pid_file, \u0027w\u0027) as f:"},{"line_number":46,"context_line":"                f.write(str(pid))"},{"line_number":47,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_5ad05e1f","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":36},"updated":"2016-09-07 18:55:58.000000000","message":"is pid_file ,not pid-file","commit_id":"8b067998d332d9041ea1eb0b57b0b6dada1fd49f"},{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"896cd8802d584bfea70e7125d727b720ef208322","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        conf.log_file \u003d conf.override_logfile"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@with_initialize(extra_opts\u003dopts, pre_logging\u003dsetup_logging)"},{"line_number":35,"context_line":"def main(conf):"},{"line_number":36,"context_line":"    if conf.fork:"},{"line_number":37,"context_line":"        pid \u003d os.fork()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_7a7c30ec","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":60},"updated":"2016-09-08 05:51:35.000000000","message":"It seem that, here we are registered opts, so we should reference under the conf","commit_id":"06c6be70140cba1f83124308f051b538202dd06c"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"d41db1d88518ee21e5e9a725376018ec7036be23","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        conf.log_file \u003d conf.override_logfile"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@with_initialize(extra_opts\u003dopts, pre_logging\u003dsetup_logging)"},{"line_number":35,"context_line":"def main(conf):"},{"line_number":36,"context_line":"    if conf.fork:"},{"line_number":37,"context_line":"        pid \u003d os.fork()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_774a4629","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":60},"in_reply_to":"9a89bdaa_7a7c30ec","updated":"2016-09-09 05:59:41.000000000","message":"yes, it registered it in this decorator","commit_id":"06c6be70140cba1f83124308f051b538202dd06c"}],"trove/common/cfg.py":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"99021bfb9d9b328d0728fe94a5ac3a3ab939190d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               default\u003dos.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":35,"context_line":"                                                    \u0027../\u0027)),"},{"line_number":36,"context_line":"               help\u003d\u0027Directory where the Trove python module is installed.\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027pid_file\u0027,"},{"line_number":38,"context_line":"               default\u003dos.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":39,"context_line":"                                                    \u0027../pid_file\u0027)),"},{"line_number":40,"context_line":"               help\u003d\u0027Directory of pid_file.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_4b137fb8","line":37,"updated":"2016-09-06 16:10:51.000000000","message":"How do we know the PID file is here. The PID file location is generally platform-dependent. Is this property actually being used anywhere outside the tests?","commit_id":"cd967e1420c42ab2403b6856976f59a33805c649"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"efad60ff2d8c77b989f6069a0f83d35ea88acb72","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                                    \u0027../\u0027)),"},{"line_number":36,"context_line":"               help\u003d\u0027Directory where the Trove python module is installed.\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027pid_file\u0027,"},{"line_number":38,"context_line":"               default\u003dos.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":39,"context_line":"                                                    \u0027../pid_file\u0027)),"},{"line_number":40,"context_line":"               help\u003d\u0027Directory of pid_file.\u0027),"},{"line_number":41,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_ff05a410","line":38,"updated":"2016-09-07 18:24:16.000000000","message":"why have a default?","commit_id":"cd967e1420c42ab2403b6856976f59a33805c649"}]}