)]}'
{"tools/trove-pylint.README":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"bc788f86cd3b70bdc45512d6b9517b402623d398","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Using trove-pylint"},{"line_number":12,"context_line":"------------------"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"You should be able to run the tool directly through tox with the"},{"line_number":15,"context_line":"command:"},{"line_number":16,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"7a8ec9b2_2b102101","line":13,"updated":"2016-09-14 17:40:04.000000000","message":"This is repeated in line 106","commit_id":"072f212136bedf568c9026125d12807d8dacb741"}],"tools/trove-pylint.config":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"63bc2960eb59913f5d1a51bd24d676889061ccfb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"ignored_file_code_messages\": ["},{"line_number":3,"context_line":"    ["},{"line_number":4,"context_line":"      \"trove/db/sqlalchemy/migrate_repo/versions/008_add_instance_fields.py\", "},{"line_number":5,"context_line":"      \"E1101\", "},{"line_number":6,"context_line":"      \"Instance of \u0027Table\u0027 has no \u0027drop_column\u0027 member\", "},{"line_number":7,"context_line":"      \"40\", "},{"line_number":8,"context_line":"      \"downgrade\""},{"line_number":9,"context_line":"    ], "},{"line_number":10,"context_line":"    ["},{"line_number":11,"context_line":"      \"trove/common/extensions.py\", "},{"line_number":12,"context_line":"      \"E1101\", "}],"source_content_type":"text/x-ini","patch_set":4,"id":"9a89bdaa_6d735ce8","line":9,"range":{"start_line":4,"start_character":78,"end_line":9,"end_character":7},"updated":"2016-09-09 04:35:37.000000000","message":"nit: lots of end-of-line spaces in the whole document","commit_id":"6aef088e970ea4272ed5bb87dc52f82cd8fb3157"}],"tox.ini":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"63bc2960eb59913f5d1a51bd24d676889061ccfb","unresolved":false,"context_lines":[{"line_number":96,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":97,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":98,"context_line":"       astroid\u003d\u003d1.3.8"},{"line_number":99,"context_line":"       pylint\u003d\u003d1.4.5"},{"line_number":100,"context_line":"commands \u003d {[testenv]commands}"},{"line_number":101,"context_line":"           python tools/trove-pylint.py check"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"9a89bdaa_cd48e88d","line":99,"range":{"start_line":99,"start_character":5,"end_line":99,"end_character":20},"updated":"2016-09-09 04:35:37.000000000","message":"why not add both to test-requirements? It has:\n\nastroid\u003c1.4.0  # LGPLv2.1 # breaks pylint 1.4.4\npylint\u003d\u003d1.4.5  # GPLv2","commit_id":"6aef088e970ea4272ed5bb87dc52f82cd8fb3157"}],"trove/datastore/models.py":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"63bc2960eb59913f5d1a51bd24d676889061ccfb","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from trove.common import cfg"},{"line_number":21,"context_line":"from trove.common import exception"},{"line_number":22,"context_line":"from trove.common.i18n import _"},{"line_number":23,"context_line":"from trove.common.remote import create_nova_client"},{"line_number":24,"context_line":"from trove.common import utils"},{"line_number":25,"context_line":"from trove.db import get_db_api"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_2d487487","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":31},"updated":"2016-09-09 04:35:37.000000000","message":"can\u0027t we make pylint ignore this?","commit_id":"6aef088e970ea4272ed5bb87dc52f82cd8fb3157"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"15e7a30227b13ef70322bfa0118b7f3976b8cc61","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from trove.common import cfg"},{"line_number":21,"context_line":"from trove.common import exception"},{"line_number":22,"context_line":"from trove.common.i18n import _"},{"line_number":23,"context_line":"from trove.common.remote import create_nova_client"},{"line_number":24,"context_line":"from trove.common import utils"},{"line_number":25,"context_line":"from trove.db import get_db_api"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_2494f7e6","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":31},"in_reply_to":"9a89bdaa_152000f7","updated":"2016-09-09 12:42:23.000000000","message":"Indeed - I thought we were not doing this. Doublechecking http://docs.openstack.org/developer/oslo.i18n/usage.html this change is fine","commit_id":"6aef088e970ea4272ed5bb87dc52f82cd8fb3157"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"50b000a228d75b160b3286178c075fda2a2f5295","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from trove.common import cfg"},{"line_number":21,"context_line":"from trove.common import exception"},{"line_number":22,"context_line":"from trove.common.i18n import _"},{"line_number":23,"context_line":"from trove.common.remote import create_nova_client"},{"line_number":24,"context_line":"from trove.common import utils"},{"line_number":25,"context_line":"from trove.db import get_db_api"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_152000f7","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":31},"in_reply_to":"9a89bdaa_2d487487","updated":"2016-09-09 12:35:16.000000000","message":"This is something called out specifically as always a failure in the code, see line 32 of trove-pylint.py. I did this because it is a pattern that pylint determines which has a low false positive rate. See line 220 of this file, _ is in fact used and this is a missing import.\n\nSo this is something that should, in fact, be fixed.","commit_id":"6aef088e970ea4272ed5bb87dc52f82cd8fb3157"}]}