)]}'
{"trove/tests/unittests/configuration/test_configuration_controller.py":[{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"e1a332590aa6acd8d63fbc6365eaa0a3f9736c3d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        super(TestConfigurationController, self).setUp()"},{"line_number":54,"context_line":"        self.controller \u003d ConfigurationsController()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _test_validate_configurationa_with_action(self, body, action):"},{"line_number":57,"context_line":"        schema \u003d self.controller.get_schema(action, body)"},{"line_number":58,"context_line":"        self.assertIsNotNone(schema)"},{"line_number":59,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_4d8a651c","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":49},"updated":"2016-09-13 14:39:14.000000000","message":"I think this should be _test_validate_configuration_with_action (there\u0027s an extra a after configuration, typo?)\n\nAlso a potential suggestion: this function could be made more versatile and allow for similar code blocks (see marked below). However, this may be for another commit.","commit_id":"3f8b84317d6a6a627a9d2f12b6fdd28ca69c7b7a"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f3cad62b70c7f4d73fe3d64e821bf322539f5050","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        super(TestConfigurationController, self).setUp()"},{"line_number":54,"context_line":"        self.controller \u003d ConfigurationsController()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _test_validate_configurationa_with_action(self, body, action):"},{"line_number":57,"context_line":"        schema \u003d self.controller.get_schema(action, body)"},{"line_number":58,"context_line":"        self.assertIsNotNone(schema)"},{"line_number":59,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_73d2a35d","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":49},"in_reply_to":"9a89bdaa_4d8a651c","updated":"2016-09-13 15:27:13.000000000","message":"good comments Samuel!","commit_id":"3f8b84317d6a6a627a9d2f12b6fdd28ca69c7b7a"},{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"e1a332590aa6acd8d63fbc6365eaa0a3f9736c3d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                }"},{"line_number":93,"context_line":"            }"},{"line_number":94,"context_line":"        }"},{"line_number":95,"context_line":"        schema \u003d self.controller.get_schema(\u0027create\u0027, body)"},{"line_number":96,"context_line":"        self.assertIsNotNone(schema)"},{"line_number":97,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":98,"context_line":"        self.assertFalse(validator.is_valid(body))"},{"line_number":99,"context_line":"        errors \u003d sorted(validator.iter_errors(body), key\u003dlambda e: e.path)"},{"line_number":100,"context_line":"        error_messages \u003d [error.message for error in errors]"},{"line_number":101,"context_line":"        self.assertIn(\"\u0027\u0027 is not of type \u0027object\u0027\", error_messages)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_validate_create_invalid_name_param(self):"},{"line_number":104,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_16c30a39","line":101,"range":{"start_line":95,"start_character":8,"end_line":101,"end_character":67},"updated":"2016-09-13 14:39:14.000000000","message":"Here","commit_id":"3f8b84317d6a6a627a9d2f12b6fdd28ca69c7b7a"},{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"e1a332590aa6acd8d63fbc6365eaa0a3f9736c3d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                }"},{"line_number":112,"context_line":"            }"},{"line_number":113,"context_line":"        }"},{"line_number":114,"context_line":"        schema \u003d self.controller.get_schema(\u0027create\u0027, body)"},{"line_number":115,"context_line":"        self.assertIsNotNone(schema)"},{"line_number":116,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":117,"context_line":"        self.assertFalse(validator.is_valid(body))"},{"line_number":118,"context_line":"        errors \u003d sorted(validator.iter_errors(body), key\u003dlambda e: e.path)"},{"line_number":119,"context_line":"        error_messages \u003d [error.message for error in errors]"},{"line_number":120,"context_line":"        self.assertIn(\"\u0027\u0027 is too short\", error_messages)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_validate_edit_configuration(self):"},{"line_number":123,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_10195222","line":120,"range":{"start_line":114,"start_character":8,"end_line":120,"end_character":56},"updated":"2016-09-13 14:39:14.000000000","message":"Here","commit_id":"3f8b84317d6a6a627a9d2f12b6fdd28ca69c7b7a"},{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"e1a332590aa6acd8d63fbc6365eaa0a3f9736c3d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                \u0027max\u0027: \u0027255\u0027"},{"line_number":194,"context_line":"            }"},{"line_number":195,"context_line":"        }"},{"line_number":196,"context_line":"        schema \u003d self.controller.get_schema(\u0027create\u0027, body)"},{"line_number":197,"context_line":"        self.assertIsNotNone(schema)"},{"line_number":198,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":199,"context_line":"        self.assertTrue(validator.is_valid(body))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_validate_create_invalid_restart_required(self):"},{"line_number":202,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_f0ff8e31","line":199,"range":{"start_line":196,"start_character":8,"end_line":199,"end_character":49},"updated":"2016-09-13 14:39:14.000000000","message":"Same as call to _test_validate_configurationa_with_action but different class. Maybe another class function, or just ignore this","commit_id":"3f8b84317d6a6a627a9d2f12b6fdd28ca69c7b7a"},{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"e1a332590aa6acd8d63fbc6365eaa0a3f9736c3d","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                \u0027max\u0027: 255"},{"line_number":209,"context_line":"            }"},{"line_number":210,"context_line":"        }"},{"line_number":211,"context_line":"        schema \u003d self.controller.get_schema(\u0027create\u0027, body)"},{"line_number":212,"context_line":"        self.assertIsNotNone(schema)"},{"line_number":213,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":214,"context_line":"        self.assertFalse(validator.is_valid(body))"},{"line_number":215,"context_line":"        errors \u003d sorted(validator.iter_errors(body), key\u003dlambda e: e.path)"},{"line_number":216,"context_line":"        error_messages \u003d [error.message for error in errors]"},{"line_number":217,"context_line":"        self.assertIn(\"5 is greater than the maximum of 1\", error_messages)"},{"line_number":218,"context_line":"        self.assertIn(\"0 is not of type \u0027string\u0027\", error_messages)"},{"line_number":219,"context_line":"        self.assertIn(\"255 is not of type \u0027string\u0027\", error_messages)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_validate_create_invalid_restart_required_2(self):"},{"line_number":222,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_5084ba5c","line":219,"range":{"start_line":211,"start_character":8,"end_line":219,"end_character":68},"updated":"2016-09-13 14:39:14.000000000","message":"Here","commit_id":"3f8b84317d6a6a627a9d2f12b6fdd28ca69c7b7a"},{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"e1a332590aa6acd8d63fbc6365eaa0a3f9736c3d","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                \u0027max\u0027: \u0027255\u0027"},{"line_number":229,"context_line":"            }"},{"line_number":230,"context_line":"        }"},{"line_number":231,"context_line":"        schema \u003d self.controller.get_schema(\u0027create\u0027, body)"},{"line_number":232,"context_line":"        self.assertIsNotNone(schema)"},{"line_number":233,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":234,"context_line":"        self.assertFalse(validator.is_valid(body))"},{"line_number":235,"context_line":"        errors \u003d sorted(validator.iter_errors(body), key\u003dlambda e: e.path)"},{"line_number":236,"context_line":"        error_messages \u003d [error.message for error in errors]"},{"line_number":237,"context_line":"        self.assertIn(\"-1 is less than the minimum of 0\", error_messages)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_validate_create_invalid_restart_required_3(self):"},{"line_number":240,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_10e6b243","line":237,"range":{"start_line":231,"start_character":8,"end_line":237,"end_character":73},"updated":"2016-09-13 14:39:14.000000000","message":"Here","commit_id":"3f8b84317d6a6a627a9d2f12b6fdd28ca69c7b7a"},{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"e1a332590aa6acd8d63fbc6365eaa0a3f9736c3d","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                \u0027max\u0027: \u0027255\u0027"},{"line_number":247,"context_line":"            }"},{"line_number":248,"context_line":"        }"},{"line_number":249,"context_line":"        schema \u003d self.controller.get_schema(\u0027create\u0027, body)"},{"line_number":250,"context_line":"        self.assertIsNotNone(schema)"},{"line_number":251,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":252,"context_line":"        self.assertFalse(validator.is_valid(body))"},{"line_number":253,"context_line":"        errors \u003d sorted(validator.iter_errors(body), key\u003dlambda e: e.path)"},{"line_number":254,"context_line":"        error_messages \u003d [error.message for error in errors]"},{"line_number":255,"context_line":"        self.assertIn(\"\u0027yes\u0027 is not of type \u0027integer\u0027\", error_messages)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_f0da2e77","line":255,"range":{"start_line":249,"start_character":8,"end_line":255,"end_character":71},"updated":"2016-09-13 14:39:14.000000000","message":"Here","commit_id":"3f8b84317d6a6a627a9d2f12b6fdd28ca69c7b7a"},{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"d20e9a86974afed51fc162d34ae3a363af4038f9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                }"},{"line_number":100,"context_line":"            }"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        test \u003d self._test_validate_configuration_with_action"},{"line_number":103,"context_line":"        error_messages \u003d test(body,"},{"line_number":104,"context_line":"                              action\u003d\u0027create\u0027,"},{"line_number":105,"context_line":"                              invlid\u003dTrue)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.assertIn(\"\u0027\u0027 is not of type \u0027object\u0027\", error_messages)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_db2501af","line":105,"range":{"start_line":102,"start_character":8,"end_line":105,"end_character":42},"updated":"2016-09-14 03:21:27.000000000","message":"I have two change the way，one is like this","commit_id":"b2ccab991c9717057bcc0e9a2b59686472051e51"},{"author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"change_message_id":"d20e9a86974afed51fc162d34ae3a363af4038f9","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                \u0027max\u0027: \u0027255\u0027"},{"line_number":239,"context_line":"            }"},{"line_number":240,"context_line":"        }"},{"line_number":241,"context_line":"        error_messages \u003d self._test_validate_configuration_with_action(body, action\u003d\u0027create\u0027, invalid\u003dTrue)  # noqa"},{"line_number":242,"context_line":"        self.assertIn(\"-1 is less than the minimum of 0\", error_messages)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def test_validate_create_invalid_restart_required_3(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_3b2505ab","line":241,"range":{"start_line":241,"start_character":8,"end_line":241,"end_character":115},"updated":"2016-09-14 03:21:27.000000000","message":"another is like this","commit_id":"b2ccab991c9717057bcc0e9a2b59686472051e51"},{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"2fe0a3427e6523aea4ab589f3aa6597d3ac7866a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                }"},{"line_number":100,"context_line":"            }"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        test \u003d self._test_validate_configuration_with_action"},{"line_number":103,"context_line":"        error_messages \u003d test(body,"},{"line_number":104,"context_line":"                              action\u003d\u0027create\u0027,"},{"line_number":105,"context_line":"                              invalid\u003dTrue)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.assertIn(\"\u0027\u0027 is not of type \u0027object\u0027\", error_messages)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_25e5be08","line":105,"range":{"start_line":102,"start_character":8,"end_line":105,"end_character":43},"updated":"2016-09-14 14:16:27.000000000","message":"I do not prefer this because it seems like an unnecessary additional line of code.","commit_id":"00f0a3df291e8a826cd3f3b3b3829af5fb06a436"},{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"2fe0a3427e6523aea4ab589f3aa6597d3ac7866a","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                \u0027max\u0027: \u0027255\u0027"},{"line_number":239,"context_line":"            }"},{"line_number":240,"context_line":"        }"},{"line_number":241,"context_line":"        error_messages \u003d self._test_validate_configuration_with_action(body, action\u003d\u0027create\u0027, invalid\u003dTrue)  # noqa"},{"line_number":242,"context_line":"        self.assertIn(\"-1 is less than the minimum of 0\", error_messages)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def test_validate_create_invalid_restart_required_3(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_e573d6af","line":241,"range":{"start_line":241,"start_character":8,"end_line":241,"end_character":115},"updated":"2016-09-14 14:16:27.000000000","message":"I prefer this way, but I would wait for others\u0027 input on this. Also make sure to take out the #noqa\u0027s and format for PEP8.","commit_id":"00f0a3df291e8a826cd3f3b3b3829af5fb06a436"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a3dbd942cd07c53f7ba93945c64fb6cc3e3c8af9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                }"},{"line_number":100,"context_line":"            }"},{"line_number":101,"context_line":"        }"},{"line_number":102,"context_line":"        error_messages \u003d \\"},{"line_number":103,"context_line":"            self._test_validate_configuration_with_action(body,"},{"line_number":104,"context_line":"                                                          action\u003d\u0027create\u0027,"},{"line_number":105,"context_line":"                                                          invalid\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_11755397","line":102,"updated":"2016-09-14 18:49:25.000000000","message":"I believe that the recommended way would be\n\n        error_messages \u003d (\n            self._test_validate_configuration_with_action(body,\n                                                          action\u003d\u0027create\u0027,\n                                                          invalid\u003dTrue))","commit_id":"faacd9b3ea9cc2be713eb0c4567e2f575e9d1f76"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"0406b905c084dae9914499ba81399cf789caf0ce","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.controller \u003d ConfigurationsController()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _test_validate_configuration_with_action(self, body, action,"},{"line_number":57,"context_line":"                                                 invalid\u003dFalse):"},{"line_number":58,"context_line":"        schema \u003d self.controller.get_schema(action, body)"},{"line_number":59,"context_line":"        self.assertIsNotNone(schema)"},{"line_number":60,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_c0c7b743","line":57,"updated":"2016-09-22 17:22:02.000000000","message":"I think a better name for the variable is is_valid instead of invalid.","commit_id":"ec07e044b25f0bfa23e08a43027753c139bd5c35"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"0406b905c084dae9914499ba81399cf789caf0ce","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        schema \u003d self.controller.get_schema(action, body)"},{"line_number":59,"context_line":"        self.assertIsNotNone(schema)"},{"line_number":60,"context_line":"        validator \u003d jsonschema.Draft4Validator(schema)"},{"line_number":61,"context_line":"        if(invalid is False):"},{"line_number":62,"context_line":"            self.assertTrue(validator.is_valid(body))"},{"line_number":63,"context_line":"        else:"},{"line_number":64,"context_line":"            self.assertFalse(validator.is_valid(body))"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_a0954b41","line":61,"updated":"2016-09-22 17:22:02.000000000","message":"I think it is better to use:\nif not invalid:\n\nto test false","commit_id":"ec07e044b25f0bfa23e08a43027753c139bd5c35"}]}