)]}'
{"CONTRIBUTING.rst":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"19d6239511519a9d25cfd197d5efe87baea984e5","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. code-block:: bash"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    $ tox -e pylint-rebuild"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Warning: trove-pylint is very sensitive to the version(s) of pylint"},{"line_number":190,"context_line":"and astroid that are installed on your system and for this reason, a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a8ec9b2_8cf89ac6","line":187,"range":{"start_line":187,"start_character":6,"end_line":187,"end_character":27},"updated":"2016-09-19 19:22:38.000000000","message":"Sorry, didn\u0027t see this.  You\u0027ll have to change it to:\n\n  tox -e pylint -- rebuild","commit_id":"5f252695a12a0c8b85f7631a067a3d6050ec48b4"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f46bed2f0bf9247648bbde2fe39f9f5f604d772d","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. code-block:: bash"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    $ tox -e pylint-rebuild"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Warning: trove-pylint is very sensitive to the version(s) of pylint"},{"line_number":190,"context_line":"and astroid that are installed on your system and for this reason, a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a8ec9b2_e7edb7f0","line":187,"range":{"start_line":187,"start_character":6,"end_line":187,"end_character":27},"in_reply_to":"7a8ec9b2_8cf89ac6","updated":"2016-09-19 19:49:19.000000000","message":"checked, don\u0027t need the --","commit_id":"5f252695a12a0c8b85f7631a067a3d6050ec48b4"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"32a730f42e79f3fba496f4b36c87b8a70fa17b4c","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":".. code-block:: bash"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    $ tox -e pylint-rebuild"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Warning: trove-pylint is very sensitive to the version(s) of pylint"},{"line_number":190,"context_line":"and astroid that are installed on your system and for this reason, a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a8ec9b2_27c07fe0","line":187,"range":{"start_line":187,"start_character":6,"end_line":187,"end_character":27},"in_reply_to":"7a8ec9b2_e7edb7f0","updated":"2016-09-19 20:06:25.000000000","message":"Excellent - even easier to remember the syntax!","commit_id":"5f252695a12a0c8b85f7631a067a3d6050ec48b4"}],"tools/trove-pylint.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"18abe71934124c95cf58de1f9d28ca4f13769f7d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            else:"},{"line_number":66,"context_line":"                sorted_config[k] \u003d v"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        return OrderedDict(sorted_config)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def save(self, filename\u003dDEFAULT_CONFIG_FILE):"},{"line_number":71,"context_line":"        if os.path.isfile(filename):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_09d2bc34","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":41},"updated":"2016-09-19 18:59:47.000000000","message":"-1 - I think there\u0027s still an issue with the ordering.  I suspect it\u0027s because the OrderedDict is being created from an un-ordered one, hence bringing back the uncertainty of ordering.  I believe you\u0027d need to start out with an OrderedDict.  For example, I\u0027ve been testing this code and it seems to fix the problem:\n\n    def sort_config(self):\n        sorted_config \u003d OrderedDict()\n        for key in sorted(self.config.keys()):\n            value \u003d self.config[key]\n            if (isinstance(value, list) and\n                    not isinstance(value, six.string_types)):\n                sorted_config[key] \u003d sorted(value)\n            else:\n                sorted_config[key] \u003d value\n\n        return sorted_config\n\n(plus \u0027import six\u0027 at the beginning of course)","commit_id":"04b1d15a164f0ce3746af4c127a1faeb640a65bf"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"63ea37e43e2e2764a05bb1e7a98a2ebfb12ff65d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            else:"},{"line_number":66,"context_line":"                sorted_config[k] \u003d v"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        return OrderedDict(sorted_config)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def save(self, filename\u003dDEFAULT_CONFIG_FILE):"},{"line_number":71,"context_line":"        if os.path.isfile(filename):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_89532c6c","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":41},"in_reply_to":"7a8ec9b2_09d2bc34","updated":"2016-09-19 19:57:28.000000000","message":"Will fix","commit_id":"04b1d15a164f0ce3746af4c127a1faeb640a65bf"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ce6fa4026ea0c1db2cd618c7ca6081c1681c3d47","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        for key in sorted(self.config.keys()):"},{"line_number":64,"context_line":"            value \u003d self.get(key)"},{"line_number":65,"context_line":"            if isinstance(value, list) and not isinstance(value,"},{"line_number":66,"context_line":"                                                          six.string_types):"},{"line_number":67,"context_line":"                sorted_config[key] \u003d sorted(value)"},{"line_number":68,"context_line":"            else:"},{"line_number":69,"context_line":"                sorted_config[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_485d97eb","line":66,"updated":"2016-09-19 22:49:00.000000000","message":"One thing I don\u0027t understand: Why are we checking for both types here against value - list \u0026 string?","commit_id":"a2d336de2a2275b6abd6e7933347af72363bcc03"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f22dcbee29f91ce5844eae35c089b369bb43ebfb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        for key in sorted(self.config.keys()):"},{"line_number":64,"context_line":"            value \u003d self.get(key)"},{"line_number":65,"context_line":"            if isinstance(value, list) and not isinstance(value,"},{"line_number":66,"context_line":"                                                          six.string_types):"},{"line_number":67,"context_line":"                sorted_config[key] \u003d sorted(value)"},{"line_number":68,"context_line":"            else:"},{"line_number":69,"context_line":"                sorted_config[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_9157cac9","line":66,"in_reply_to":"7a8ec9b2_485d97eb","updated":"2016-09-20 01:27:22.000000000","message":"Mariam,\n\nThe folder variable (which says just \u0027trove\u0027) also returns as list and is a base string type. We want to exclude that from the sorting.","commit_id":"a2d336de2a2275b6abd6e7933347af72363bcc03"}],"tox.ini":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"18abe71934124c95cf58de1f9d28ca4f13769f7d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":97,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":98,"context_line":"commands \u003d {[testenv]commands}"},{"line_number":99,"context_line":"           python tools/trove-pylint.py check"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"[testenv:pylint-rebuild]"},{"line_number":102,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a8ec9b2_06be2cd4","line":99,"range":{"start_line":99,"start_character":40,"end_line":99,"end_character":45},"updated":"2016-09-19 18:59:47.000000000","message":"+0 - Would it make sense to change this to:\n\n  python tools/trove-pylint.py {posargs:check}\n\n?\n\nThat way you could run it as \u0027tox -epylint -- rebuild\u0027 and\nit would work for other options as well (if they become necessary).  It would also mean not having to build a new test env for tox (pylint-rebuild vs. just using pylint again).","commit_id":"04b1d15a164f0ce3746af4c127a1faeb640a65bf"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"63ea37e43e2e2764a05bb1e7a98a2ebfb12ff65d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":97,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":98,"context_line":"commands \u003d {[testenv]commands}"},{"line_number":99,"context_line":"           python tools/trove-pylint.py check"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"[testenv:pylint-rebuild]"},{"line_number":102,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a8ec9b2_e973d013","line":99,"range":{"start_line":99,"start_character":40,"end_line":99,"end_character":45},"in_reply_to":"7a8ec9b2_06be2cd4","updated":"2016-09-19 19:57:28.000000000","message":"did not know you could do that :\u003e","commit_id":"04b1d15a164f0ce3746af4c127a1faeb640a65bf"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"18abe71934124c95cf58de1f9d28ca4f13769f7d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"           python tools/trove-pylint.py check"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"[testenv:pylint-rebuild]"},{"line_number":102,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":103,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":104,"context_line":"commands \u003d {[testenv]commands}"},{"line_number":105,"context_line":"           python tools/trove-pylint.py rebuild"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a8ec9b2_26afa87e","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":42},"updated":"2016-09-19 18:59:47.000000000","message":"+0 - If you prefer two commands, then we should at least reference the deps from above:\n\n deps \u003d {[testenv:pylint]deps}","commit_id":"04b1d15a164f0ce3746af4c127a1faeb640a65bf"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"63ea37e43e2e2764a05bb1e7a98a2ebfb12ff65d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"           python tools/trove-pylint.py check"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"[testenv:pylint-rebuild]"},{"line_number":102,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":103,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":104,"context_line":"commands \u003d {[testenv]commands}"},{"line_number":105,"context_line":"           python tools/trove-pylint.py rebuild"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a8ec9b2_2964d847","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":42},"in_reply_to":"7a8ec9b2_26afa87e","updated":"2016-09-19 19:57:28.000000000","message":"don\u0027t need two commands as you said","commit_id":"04b1d15a164f0ce3746af4c127a1faeb640a65bf"}]}