)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8d2a82dddf1deb2aa304cf64209e70519121c8a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     mariam john \u003cmariamj@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-03 17:09:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: initial chkin of all of trove integration elements into trove."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the first of a string of commits that will get rid of"},{"line_number":10,"context_line":"trove-integration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a95cdbc_1ae57e08","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2016-10-05 14:28:41.000000000","message":"Is this still a WIP?  I tend to not review things in this state ...","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f4b6af29392615cc50aac7f66c43780f4d23ba29","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     mariam john \u003cmariamj@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-03 17:09:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: initial chkin of all of trove integration elements into trove."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the first of a string of commits that will get rid of"},{"line_number":10,"context_line":"trove-integration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a95cdbc_6e37a4b0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"1a95cdbc_1ae57e08","updated":"2016-10-05 14:59:47.000000000","message":"Done","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8d2a82dddf1deb2aa304cf64209e70519121c8a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"trove-integration."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit moves the image elements into Trove and provides an image"},{"line_number":13,"context_line":"builder tool (see image/trove-image-builder.bash)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I13af9ae6d7f90438dd411f0b96ec618621dcac65"},{"line_number":16,"context_line":"Partially-Implements: eliminate-trove-integration-and-redstack"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a95cdbc_10ad5fe9","line":13,"range":{"start_line":13,"start_character":18,"end_line":13,"end_character":48},"updated":"2016-10-05 14:28:41.000000000","message":"this file is in bin","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f4b6af29392615cc50aac7f66c43780f4d23ba29","unresolved":false,"context_lines":[{"line_number":10,"context_line":"trove-integration."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit moves the image elements into Trove and provides an image"},{"line_number":13,"context_line":"builder tool (see image/trove-image-builder.bash)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I13af9ae6d7f90438dd411f0b96ec618621dcac65"},{"line_number":16,"context_line":"Partially-Implements: eliminate-trove-integration-and-redstack"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a95cdbc_6e5ec4ea","line":13,"range":{"start_line":13,"start_character":18,"end_line":13,"end_character":48},"in_reply_to":"1a95cdbc_10ad5fe9","updated":"2016-10-05 14:59:47.000000000","message":"Done","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"}],"image/bin/trove-image-builder.README":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"3733e911679e1aa638cb41a80f089af9597e2b01","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"--datastore"},{"line_number":9,"context_line":"   Specify the name of the datastore that you wish to build"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"--datastore-pkg-location"},{"line_number":12,"context_line":"   For datastores that require a downloaded binary (or a URL)"},{"line_number":13,"context_line":"   you can specify that here."}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a98d1f4_4f5acf51","line":10,"updated":"2016-09-29 16:44:40.000000000","message":"Aren\u0027t we specifying the datastore in the command argument \u0027trove-image-builder.bash [options] datastore\u0027. Why is this specified in the optional list again. Also don\u0027t we need a parameter for the datastore version.","commit_id":"2db73345a1915925bffa592d04296690fab853fb"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"17b11edf0280fa3b62e447e93eb0b7535e317f0e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"--datastore"},{"line_number":9,"context_line":"   Specify the name of the datastore that you wish to build"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"--datastore-pkg-location"},{"line_number":12,"context_line":"   For datastores that require a downloaded binary (or a URL)"},{"line_number":13,"context_line":"   you can specify that here."}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a98d1f4_3873f24e","line":10,"in_reply_to":"3a98d1f4_4f5acf51","updated":"2016-09-30 01:14:52.000000000","message":"Done","commit_id":"2db73345a1915925bffa592d04296690fab853fb"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e85e3427d4d13f0493a87b525f7d8a4fe273101c","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"--datastore"},{"line_number":9,"context_line":"   Specify the name of the datastore that you wish to build"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"--datastore-pkg-location"},{"line_number":12,"context_line":"   For datastores that require a downloaded binary (or a URL)"},{"line_number":13,"context_line":"   you can specify that here."}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a98d1f4_c0d30c5e","line":10,"in_reply_to":"3a98d1f4_4f5acf51","updated":"2016-09-29 16:49:06.000000000","message":"Yes, this is a mistake and has to be fixed. datastore is only with this option. The command line above is wrong.","commit_id":"2db73345a1915925bffa592d04296690fab853fb"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8d2a82dddf1deb2aa304cf64209e70519121c8a","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"--datastore"},{"line_number":9,"context_line":"   Specify the name of the datastore that you wish to build"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"--datastore-pkg-location"},{"line_number":12,"context_line":"   For datastores that require a downloaded binary (or a URL)"},{"line_number":13,"context_line":"   you can specify that here."}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_5ac2a634","line":10,"updated":"2016-10-05 14:28:41.000000000","message":"I don\u0027t see the addition of datastore version option.  Are we taking the opportunity to add that now (since we badly need that functionality)?  Also, should we call this datastore or database?  We\u0027re actually building an image of a database (maybe we need to revisit the datastore/database/manager issue, since we\u0027re hitting the limitations of the current architecture pretty hard).","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f4b6af29392615cc50aac7f66c43780f4d23ba29","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"--datastore"},{"line_number":9,"context_line":"   Specify the name of the datastore that you wish to build"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"--datastore-pkg-location"},{"line_number":12,"context_line":"   For datastores that require a downloaded binary (or a URL)"},{"line_number":13,"context_line":"   you can specify that here."}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_ae0fecdf","line":10,"in_reply_to":"1a95cdbc_5ac2a634","updated":"2016-10-05 14:59:47.000000000","message":"not part of the present redstack, I\u0027m trying to do the minimum possible to get this over to trove for now.","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8d2a82dddf1deb2aa304cf64209e70519121c8a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"--datastore"},{"line_number":9,"context_line":"   Specify the name of the datastore that you wish to build"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"--datastore-pkg-location"},{"line_number":12,"context_line":"   For datastores that require a downloaded binary (or a URL)"},{"line_number":13,"context_line":"   you can specify that here."},{"line_number":14,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_7a2be2eb","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":24},"updated":"2016-10-05 14:28:41.000000000","message":"These are handled by env variables at the moment.  Do we document that here as well?  If we accept both, should we have env vars for all the parameters?","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f4b6af29392615cc50aac7f66c43780f4d23ba29","unresolved":false,"context_lines":[{"line_number":8,"context_line":"--datastore"},{"line_number":9,"context_line":"   Specify the name of the datastore that you wish to build"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"--datastore-pkg-location"},{"line_number":12,"context_line":"   For datastores that require a downloaded binary (or a URL)"},{"line_number":13,"context_line":"   you can specify that here."},{"line_number":14,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_aeab6c88","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":24},"in_reply_to":"1a95cdbc_7a2be2eb","updated":"2016-10-05 14:59:47.000000000","message":"again, good question. the env var is used if present.","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8d2a82dddf1deb2aa304cf64209e70519121c8a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"   you can specify that here."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"--dib-cloud-init-etc-hosts"},{"line_number":16,"context_line":"   Specify True, T, False, or F to specify whether this"},{"line_number":17,"context_line":"   option should be specified. Default (true)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"--distro"},{"line_number":20,"context_line":"   Specify the distro for which an image is being built."}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_5a1e26bb","line":17,"range":{"start_line":16,"start_character":32,"end_line":17,"end_character":29},"updated":"2016-10-05 14:28:41.000000000","message":"Still no idea what this option does, besides specifying the option.","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f4b6af29392615cc50aac7f66c43780f4d23ba29","unresolved":false,"context_lines":[{"line_number":13,"context_line":"   you can specify that here."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"--dib-cloud-init-etc-hosts"},{"line_number":16,"context_line":"   Specify True, T, False, or F to specify whether this"},{"line_number":17,"context_line":"   option should be specified. Default (true)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"--distro"},{"line_number":20,"context_line":"   Specify the distro for which an image is being built."}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_ce87d80d","line":17,"range":{"start_line":16,"start_character":32,"end_line":17,"end_character":29},"in_reply_to":"1a95cdbc_5a1e26bb","updated":"2016-10-05 14:59:47.000000000","message":"it is passed through to dib, I\u0027ll remove the commandline option.","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8d2a82dddf1deb2aa304cf64209e70519121c8a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   Specify True, T, False, or F to specify whether this"},{"line_number":17,"context_line":"   option should be specified. Default (true)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"--distro"},{"line_number":20,"context_line":"   Specify the distro for which an image is being built."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"--release"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_5a7546f7","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":8},"updated":"2016-10-05 14:28:41.000000000","message":"any default for this?","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f4b6af29392615cc50aac7f66c43780f4d23ba29","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   Specify True, T, False, or F to specify whether this"},{"line_number":17,"context_line":"   option should be specified. Default (true)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"--distro"},{"line_number":20,"context_line":"   Specify the distro for which an image is being built."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"--release"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_aefe0c69","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":8},"in_reply_to":"1a95cdbc_5a7546f7","updated":"2016-10-05 14:59:47.000000000","message":"Done","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8d2a82dddf1deb2aa304cf64209e70519121c8a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"--distro"},{"line_number":20,"context_line":"   Specify the distro for which an image is being built."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"--release"},{"line_number":23,"context_line":"   Specify the distro release you wish to use."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"--output-format"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_7dff5c01","line":22,"range":{"start_line":22,"start_character":2,"end_line":22,"end_character":9},"updated":"2016-10-05 14:28:41.000000000","message":"ditto","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8d2a82dddf1deb2aa304cf64209e70519121c8a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"--release"},{"line_number":23,"context_line":"   Specify the distro release you wish to use."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"--output-format"},{"line_number":26,"context_line":"   Specify the output format which will be passed to"},{"line_number":27,"context_line":"   diskimage-create."},{"line_number":28,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_9d042816","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":15},"updated":"2016-10-05 14:28:41.000000000","message":"ditto","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f4b6af29392615cc50aac7f66c43780f4d23ba29","unresolved":false,"context_lines":[{"line_number":22,"context_line":"--release"},{"line_number":23,"context_line":"   Specify the distro release you wish to use."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"--output-format"},{"line_number":26,"context_line":"   Specify the output format which will be passed to"},{"line_number":27,"context_line":"   diskimage-create."},{"line_number":28,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a95cdbc_eef8147f","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":15},"in_reply_to":"1a95cdbc_9d042816","updated":"2016-10-05 14:59:47.000000000","message":"Done","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"}],"image/bin/trove-image-builder.bash":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"da3898212fa6e23c5cf45f52fe8771e2ca6da859","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    host_iface\u003d$(ip route | grep default | awk \u0027{print $5}\u0027 | head -1)"},{"line_number":37,"context_line":"    echo `LC_ALL\u003dC ip -f inet addr show ${host_iface} | awk \u0027/inet/ {split($2,parts,\"/\");  print parts[1]}\u0027 | head -1`"},{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# to run this tool, we need DIB. so let\u0027s make sure we get one"},{"line_number":42,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3a98d1f4_befc1c73","line":39,"updated":"2016-09-30 17:43:05.000000000","message":"function check_and_clone_tripleo() {\n    if [ ! -d ${PATH_TRIPLEO_ELEMENT} ]; then\n        git clone http://git.openstack.org/openstack/tripleo-image-elements \\\n            ${PATH_TRIPLEO_ELEMENT}\n    fi\n}","commit_id":"72152d3aa0452033b6555dc751690274046abc52"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"da3898212fa6e23c5cf45f52fe8771e2ca6da859","unresolved":false,"context_lines":[{"line_number":123,"context_line":"function _setup_environment() {"},{"line_number":124,"context_line":"    export CONTROLLER_IP\u003d${CONTROLLER_IP:-$(get_default_host_ip)}"},{"line_number":125,"context_line":"    export PATH_DISKIMAGE_BUILDER\u003d${PATH_DISKIMAGE_BUILDER:-${BASEPATH}/diskimage-builder}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # there are things in elements that just don\u0027t work well if we are"},{"line_number":128,"context_line":"    # root. Some elements used to check for that. Seems pointless when we"},{"line_number":129,"context_line":"    # should really be checking at the top level."}],"source_content_type":"text/x-sh","patch_set":10,"id":"3a98d1f4_1e3fd024","line":126,"updated":"2016-09-30 17:43:05.000000000","message":"export PATH_TRIPLEO_ELEMENT\u003d${PATH_TRIPLEO_ELEMENT:-${BASEPATH}/tripleo-image-elements}","commit_id":"72152d3aa0452033b6555dc751690274046abc52"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"da3898212fa6e23c5cf45f52fe8771e2ca6da859","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    if [ -z \"${ELEMENTS_PATH}\" ]; then"},{"line_number":186,"context_line":"        _add_element_path \"${TIB_ELEMENTS_PATH}\""},{"line_number":187,"context_line":"        _add_element_path \"/opt/stack/diskimage-builder/elements\""},{"line_number":188,"context_line":"        _add_element_path \"/opt/stack/tripleo-image-elements/elements\""},{"line_number":189,"context_line":"    fi"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    export SSH_DIR\u003d${SSH_DIR:-$(readlink -f ~/.ssh)}"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3a98d1f4_ded488be","line":188,"updated":"2016-09-30 17:43:05.000000000","message":"Instead of the above 2 lines, use this:\n _add_element_path \"${PATH_DISKIMAGE_BUILDER}/elements\"\n _add_element_path \"${BASEPATH}/tripleo-image-elements/elements\"","commit_id":"72152d3aa0452033b6555dc751690274046abc52"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8d2a82dddf1deb2aa304cf64209e70519121c8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Copyright 2016 Tesora, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a95cdbc_bd83a4cb","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"updated":"2016-10-05 14:28:41.000000000","message":"Is this ever going to be run from within a venv?  If so, it might be better to start with:\n\n  #!/usr/bin/env bash\n\nthe way stack.sh does.","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c8d2a82dddf1deb2aa304cf64209e70519121c8a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# We expect to be in trove/image/bin/trove-image-builder.bash."},{"line_number":25,"context_line":"# Use this to setup all our useful path locations ..."},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a95cdbc_7d959ce2","line":24,"range":{"start_line":24,"start_character":36,"end_line":24,"end_character":62},"updated":"2016-10-05 14:28:41.000000000","message":"This is a file, not a dir","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"}],"image/bin/trove-load-image.bash":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"52bad31f06e5a20513f12dd10dca7c323a8e20ca","unresolved":false,"context_lines":[{"line_number":188,"context_line":"fi"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"load_image ${datastore} ${datastore_version} ${image_format} \\"},{"line_number":191,"context_line":"    ${container_format} ${image}"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"register_trove_image ${datastore} ${datastore_version} ${manager} ${newid} \\"},{"line_number":194,"context_line":"    \"${packages}\" ${template}"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3a98d1f4_5c003966","line":191,"updated":"2016-10-03 19:25:00.000000000","message":"In the old redstack code, the above 2 operations - delete_image and load_image is performed using the admin tenant whereas the operation below - register_trove_image is done using the tenant \u0027demo\u0027. Would that be an issue here?","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4c7377e5c481a4aecebb7092ca03266a19de58c9","unresolved":false,"context_lines":[{"line_number":188,"context_line":"fi"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"load_image ${datastore} ${datastore_version} ${image_format} \\"},{"line_number":191,"context_line":"    ${container_format} ${image}"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"register_trove_image ${datastore} ${datastore_version} ${manager} ${newid} \\"},{"line_number":194,"context_line":"    \"${packages}\" ${template}"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a95cdbc_cfd46d49","line":191,"in_reply_to":"3a98d1f4_5c003966","updated":"2016-10-04 14:56:13.000000000","message":"It is done using whatever tenant you source using \n\n/opt/stack/devstack/openrc \u003c...\u003e \u003c...\u003e\n\nI believe that this should be fine.","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"e237a24e916c473c43074e52d68b9bea17bfd2f5","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    glance image-create --name ${image_name} --disk-format ${format} \\"},{"line_number":35,"context_line":"        --container-format ${container_format} \\"},{"line_number":36,"context_line":"       \u003c ${image_file}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    newid\u003d$(glance image-list | grep ${image_name} | sed \u0027s/|//g\u0027 | awk \u0027{print $1}\u0027)"},{"line_number":39,"context_line":"    echo \"New image created with glance ID ${newid}\""}],"source_content_type":"text/x-sh","patch_set":14,"id":"1a95cdbc_a8827792","line":36,"updated":"2016-10-05 17:40:56.000000000","message":"amrith, I believe we need to set the following parameter also: --visibility public.\n\nI tested the above change with \u0027source devstack/openrc demo demo\u0027 and it through an exception \u0027You are not authorized to complete publicize_image action\u0027. This worked with the admin tenant. \n\nWithout the visibility parameter, even though the image wwas created with the admin tenant, it wasnt available to other tenants to create instances.","commit_id":"154a72dd45f2f4ec8be365828d707a9e3d89a26f"}],"image/configuration/trove-guest.upstart.conf":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"3733e911679e1aa638cb41a80f089af9597e2b01","unresolved":false,"context_lines":[{"line_number":25,"context_line":"end script"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"script"},{"line_number":28,"context_line":"    # For backwards compatibility until https://review.openstack.org/#/c/100381 merges"},{"line_number":29,"context_line":"    TROVE_CONFIG\u003d\"--config-dir\u003d/etc/trove/conf.d\""},{"line_number":30,"context_line":"    if [ ! -f /etc/trove/conf.d/guest_info ] \u0026\u0026 [ ! -f /etc/trove/conf.d/trove-guestagent.conf ]; then"},{"line_number":31,"context_line":""}],"source_content_type":"text/plain","patch_set":9,"id":"3a98d1f4_ba98ef1c","line":28,"updated":"2016-09-29 16:44:40.000000000","message":"100381 already merged","commit_id":"2db73345a1915925bffa592d04296690fab853fb"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e85e3427d4d13f0493a87b525f7d8a4fe273101c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"end script"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"script"},{"line_number":28,"context_line":"    # For backwards compatibility until https://review.openstack.org/#/c/100381 merges"},{"line_number":29,"context_line":"    TROVE_CONFIG\u003d\"--config-dir\u003d/etc/trove/conf.d\""},{"line_number":30,"context_line":"    if [ ! -f /etc/trove/conf.d/guest_info ] \u0026\u0026 [ ! -f /etc/trove/conf.d/trove-guestagent.conf ]; then"},{"line_number":31,"context_line":""}],"source_content_type":"text/plain","patch_set":9,"id":"3a98d1f4_60915899","line":28,"in_reply_to":"3a98d1f4_ba98ef1c","updated":"2016-09-29 16:49:06.000000000","message":"This is literally copied from the trove-integration branch and as few changes as possible have been made. Could I make this cleanup in a later patch set?","commit_id":"2db73345a1915925bffa592d04296690fab853fb"}],"image/elements/fedora-guest/extra-data.d/15-reddwarf-dep":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"3733e911679e1aa638cb41a80f089af9597e2b01","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -e"},{"line_number":4,"context_line":"set -o xtrace"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a98d1f4_55633cdc","line":1,"updated":"2016-09-29 16:44:40.000000000","message":"wonder if renaming this file would be a good idea - since we are starting clean and moved away from reddwarf days and redstack days.","commit_id":"2db73345a1915925bffa592d04296690fab853fb"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e85e3427d4d13f0493a87b525f7d8a4fe273101c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -e"},{"line_number":4,"context_line":"set -o xtrace"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a98d1f4_c085cc59","line":1,"in_reply_to":"3a98d1f4_55633cdc","updated":"2016-09-29 16:49:06.000000000","message":"I was trying to stage the changes with the minimal changes first, so as to be able to relate these files with the ones in trove-integration; there are still changes going into both places and wanted to be able to retain common names for a while.\n\nI have a follow-on patch set to change the names.\n\nBut, overall, YES! name changes are coming.","commit_id":"2db73345a1915925bffa592d04296690fab853fb"}],"tools/trove-setup.bash":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"0e6669db6596f93db57427640d17ff726a7daf45","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    PATH_KEYSTONE\u003d$DEST/keystone"},{"line_number":107,"context_line":"    PATH_GLANCE\u003d$DEST/glance"},{"line_number":108,"context_line":"    PATH_SWIFT\u003d$DEST/swift"},{"line_number":109,"context_line":"    PATH_TROVE\u003d$DEST/trove"},{"line_number":110,"context_line":"    PATH_PYTHON_NOVACLIENT\u003d$DEST/python-novaclient"},{"line_number":111,"context_line":"    PATH_KEYSTONECLIENT\u003d$DEST/python-keystoneclient"},{"line_number":112,"context_line":"    PATH_OPENSTACKCLIENT\u003d$DEST/python-openstackclient"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3a98d1f4_3759c68e","line":109,"updated":"2016-10-03 20:02:51.000000000","message":"Shouldn\u0027t this path really be with respect to the current directory.","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4c7377e5c481a4aecebb7092ca03266a19de58c9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    PATH_KEYSTONE\u003d$DEST/keystone"},{"line_number":107,"context_line":"    PATH_GLANCE\u003d$DEST/glance"},{"line_number":108,"context_line":"    PATH_SWIFT\u003d$DEST/swift"},{"line_number":109,"context_line":"    PATH_TROVE\u003d$DEST/trove"},{"line_number":110,"context_line":"    PATH_PYTHON_NOVACLIENT\u003d$DEST/python-novaclient"},{"line_number":111,"context_line":"    PATH_KEYSTONECLIENT\u003d$DEST/python-keystoneclient"},{"line_number":112,"context_line":"    PATH_OPENSTACKCLIENT\u003d$DEST/python-openstackclient"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a95cdbc_6f1a7919","line":109,"in_reply_to":"3a98d1f4_3759c68e","updated":"2016-10-04 14:56:13.000000000","message":"Good point. I should comment this.\n\nI did it this way for the reason that I wanted this to be a mechanism to bootstrap trove; clone this repo, run this tool and it will put your devstack based setup in a deterministic place.\n\ni.e. you can clone trove in your home dir and it will use one in /opt/stack.\n\nThat\u0027s what I intended and hence did this.\n\nIs that not a good idea?","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"0e6669db6596f93db57427640d17ff726a7daf45","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    GIT_OPENSTACK\u003d${GIT_OPENSTACK:-${GIT_BASE}/openstack}"},{"line_number":122,"context_line":"    DEVSTACK_REPO\u003d${DEVSTACK_REPO:-${GIT_BASE}/openstack-dev/devstack.git}"},{"line_number":123,"context_line":"    TROVE_REPO\u003d${TROVE_REPO:-${GIT_OPENSTACK}/trove.git}"},{"line_number":124,"context_line":"    TROVE_DIR\u003d${TROVE_DIR:-${PATH_TROVE}}"},{"line_number":125,"context_line":"    TROVE_CLIENT_REPO\u003d${TROVE_CLIENT_REPO:-${TROVECLIENT_REPO:-${GIT_OPENSTACK}/python-troveclient.git}}"},{"line_number":126,"context_line":"    TROVE_CLIENT_DIR\u003d${TROVE_CLIENT_DIR:-${TROVECLIENT_DIR:-${PATH_PYTHON_TROVECLIENT}}}"},{"line_number":127,"context_line":"    TROVE_CLIENT_BRANCH\u003d${TROVE_CLIENT_BRANCH:-${TROVECLIENT_BRANCH:-master}}"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3a98d1f4_f7f03e69","line":124,"updated":"2016-10-03 20:02:51.000000000","message":"What if I clone trove into a different directory and try to run devstack. It would download trove to /opt/stack again.","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4c7377e5c481a4aecebb7092ca03266a19de58c9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    GIT_OPENSTACK\u003d${GIT_OPENSTACK:-${GIT_BASE}/openstack}"},{"line_number":122,"context_line":"    DEVSTACK_REPO\u003d${DEVSTACK_REPO:-${GIT_BASE}/openstack-dev/devstack.git}"},{"line_number":123,"context_line":"    TROVE_REPO\u003d${TROVE_REPO:-${GIT_OPENSTACK}/trove.git}"},{"line_number":124,"context_line":"    TROVE_DIR\u003d${TROVE_DIR:-${PATH_TROVE}}"},{"line_number":125,"context_line":"    TROVE_CLIENT_REPO\u003d${TROVE_CLIENT_REPO:-${TROVECLIENT_REPO:-${GIT_OPENSTACK}/python-troveclient.git}}"},{"line_number":126,"context_line":"    TROVE_CLIENT_DIR\u003d${TROVE_CLIENT_DIR:-${TROVECLIENT_DIR:-${PATH_PYTHON_TROVECLIENT}}}"},{"line_number":127,"context_line":"    TROVE_CLIENT_BRANCH\u003d${TROVE_CLIENT_BRANCH:-${TROVECLIENT_BRANCH:-master}}"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a95cdbc_cfd70d22","line":124,"in_reply_to":"3a98d1f4_f7f03e69","updated":"2016-10-04 14:56:13.000000000","message":"That was the intention, see comment above.","commit_id":"71e0a47036ebd2a9b42aa6bf3659557cbb95102d"}]}