)]}'
{"trove/cmd/guest.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"1805c72b8bfed425c234d63d8f39b6236ecb862f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    server \u003d rpc_service.RpcService("},{"line_number":62,"context_line":"        topic\u003d\"guestagent.%s\" % CONF.guest_id,"},{"line_number":63,"context_line":"        manager\u003dmanager, host\u003dCONF.guest_id,"},{"line_number":64,"context_line":"        rpc_api_version\u003drpc_version.RPCVersion.get_guestagent_api())"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    launcher \u003d openstack_service.launch(CONF, server)"},{"line_number":67,"context_line":"    launcher.wait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_71fb5e79","line":64,"updated":"2016-10-03 19:00:52.000000000","message":"Doesn\u0027t this mean that we only accept connections from clients that have exactly the same version that we do?  This is different from what Nova does.","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"c5000a9d7340486b585876966bcc390f655ab5aa","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    server \u003d rpc_service.RpcService("},{"line_number":62,"context_line":"        topic\u003d\"guestagent.%s\" % CONF.guest_id,"},{"line_number":63,"context_line":"        manager\u003dmanager, host\u003dCONF.guest_id,"},{"line_number":64,"context_line":"        rpc_api_version\u003drpc_version.RPCVersion.get_guestagent_api())"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    launcher \u003d openstack_service.launch(CONF, server)"},{"line_number":67,"context_line":"    launcher.wait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_5c0bd923","line":64,"in_reply_to":"3a98d1f4_71fb5e79","updated":"2016-10-03 19:08:02.000000000","message":"I don\u0027t believe so. This is the implemented version in the service. Any API that is requested and has a lower or equal version should work; I think. In point of fact, the result of this code is to use the same \u00271.0\u0027 that the old code did by referencing rpc_version.RPC_API_VERSION so I don\u0027t think in practical terms this does any different from earlier.","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"}],"trove/common/rpc/version.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"1805c72b8bfed425c234d63d8f39b6236ecb862f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    API_CONDUCTOR \u003d \u0027conductor\u0027"},{"line_number":47,"context_line":"    API_GUESTAGENT \u003d \u0027guestagent\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":50,"context_line":"        # this is the default in trove/common/cfg.py"},{"line_number":51,"context_line":"        \u0027master\u0027: {"},{"line_number":52,"context_line":"            API_TASKMANAGER: API_CURRENT_TASKMANAGER_VERSION,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_3198f669","line":49,"updated":"2016-10-03 19:00:52.000000000","message":"What is the benefit of putting this in a central hot file?","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3958fc1a1be7e9f65b19c44a072b8f2977bac7c8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    API_CONDUCTOR \u003d \u0027conductor\u0027"},{"line_number":47,"context_line":"    API_GUESTAGENT \u003d \u0027guestagent\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":50,"context_line":"        # this is the default in trove/common/cfg.py"},{"line_number":51,"context_line":"        \u0027master\u0027: {"},{"line_number":52,"context_line":"            API_TASKMANAGER: API_CURRENT_TASKMANAGER_VERSION,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_dc5c491b","line":49,"in_reply_to":"3a98d1f4_3198f669","updated":"2016-10-03 19:11:07.000000000","message":"the central part with the recognition that it also gives us the hot part.","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5a9b06518e1d45cffad6cca34d0c97fee4e98f52","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    API_CONDUCTOR \u003d \u0027conductor\u0027"},{"line_number":47,"context_line":"    API_GUESTAGENT \u003d \u0027guestagent\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":50,"context_line":"        # this is the default in trove/common/cfg.py"},{"line_number":51,"context_line":"        \u0027master\u0027: {"},{"line_number":52,"context_line":"            API_TASKMANAGER: API_CURRENT_TASKMANAGER_VERSION,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_5759f233","line":49,"in_reply_to":"3a98d1f4_3c252d5b","updated":"2016-10-03 19:41:32.000000000","message":"unless two change sets are attempting to both rev one of these API versions, I don\u0027t see a manual resolution being required for the conflict.\n\nHaving this be the one place where the names are mapped to numbers means that you wouldn\u0027t have to change the other place (where the name is used).","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"f9f68ff0608585ee1741382420e4ce18f5ed231c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    API_CONDUCTOR \u003d \u0027conductor\u0027"},{"line_number":47,"context_line":"    API_GUESTAGENT \u003d \u0027guestagent\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":50,"context_line":"        # this is the default in trove/common/cfg.py"},{"line_number":51,"context_line":"        \u0027master\u0027: {"},{"line_number":52,"context_line":"            API_TASKMANAGER: API_CURRENT_TASKMANAGER_VERSION,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_3c252d5b","line":49,"in_reply_to":"3a98d1f4_dc5c491b","updated":"2016-10-03 19:23:15.000000000","message":"Right, but they are completely independent of each other and putting them together like this does nothing more than to make people edit a second file, potentially adding more merge conflicts for no gain.","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"},{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"change_message_id":"1f64be65561e39dea8adfe46cb67e733b1efca7e","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":50,"context_line":"        # this is the default in trove/common/cfg.py"},{"line_number":51,"context_line":"        \u0027master\u0027: {"},{"line_number":52,"context_line":"            API_TASKMANAGER: API_CURRENT_TASKMANAGER_VERSION,"},{"line_number":53,"context_line":"            API_GUESTAGENT: API_CURRENT_GUESTAGENT_VERSION,"},{"line_number":54,"context_line":"            API_CONDUCTOR: API_CURRENT_CONDUCTOR_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_d1ec32bd","line":51,"updated":"2016-10-03 18:56:39.000000000","message":"I think having the versions based on release names is adding an extra level of indirection that isn\u0027t required. Instead we could just have the version numbers in the conf file e.g. taskmanager \u003d 1.0\nThat way we wont need to keep adding an extra section to this list every time we branch and add a new release","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3958fc1a1be7e9f65b19c44a072b8f2977bac7c8","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":50,"context_line":"        # this is the default in trove/common/cfg.py"},{"line_number":51,"context_line":"        \u0027master\u0027: {"},{"line_number":52,"context_line":"            API_TASKMANAGER: API_CURRENT_TASKMANAGER_VERSION,"},{"line_number":53,"context_line":"            API_GUESTAGENT: API_CURRENT_GUESTAGENT_VERSION,"},{"line_number":54,"context_line":"            API_CONDUCTOR: API_CURRENT_CONDUCTOR_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_5c7039a4","line":51,"in_reply_to":"3a98d1f4_11505a31","updated":"2016-10-03 19:11:07.000000000","message":"I think Andrew\u0027s proposed solution is in fact a better one than the one that the rest of OpenStack uses.\n\nConsider that for each release we have to update this dictionary. If we went with just numbers, it would be easier. I\u0027m assuming that the rest of openstack services don\u0027t version each component independently so this is easy for them? maybe?","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"f9f68ff0608585ee1741382420e4ce18f5ed231c","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":50,"context_line":"        # this is the default in trove/common/cfg.py"},{"line_number":51,"context_line":"        \u0027master\u0027: {"},{"line_number":52,"context_line":"            API_TASKMANAGER: API_CURRENT_TASKMANAGER_VERSION,"},{"line_number":53,"context_line":"            API_GUESTAGENT: API_CURRENT_GUESTAGENT_VERSION,"},{"line_number":54,"context_line":"            API_CONDUCTOR: API_CURRENT_CONDUCTOR_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_bc54ddc9","line":51,"in_reply_to":"3a98d1f4_5c7039a4","updated":"2016-10-03 19:23:15.000000000","message":"Well, no, and I assumed the reason they did the whole \"release\" approach was precisely because they version each component independently, and as Nova etc. implement it it supports selecting versions either by release or by version number.  Using numbers forces users to look up the specific version of each component whenever they do an upgrade - I imagine this was felt to be too onerous on the user.","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"5a9b06518e1d45cffad6cca34d0c97fee4e98f52","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":50,"context_line":"        # this is the default in trove/common/cfg.py"},{"line_number":51,"context_line":"        \u0027master\u0027: {"},{"line_number":52,"context_line":"            API_TASKMANAGER: API_CURRENT_TASKMANAGER_VERSION,"},{"line_number":53,"context_line":"            API_GUESTAGENT: API_CURRENT_GUESTAGENT_VERSION,"},{"line_number":54,"context_line":"            API_CONDUCTOR: API_CURRENT_CONDUCTOR_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_57a7320a","line":51,"in_reply_to":"3a98d1f4_bc54ddc9","updated":"2016-10-03 19:41:32.000000000","message":"then I don\u0027t see the point of the translation (andrew\u0027s point). I have the code because it seems to be the way it was done, but I have to agree that the indirection \n\nnewton --\u003e version 1.3\n\nis meaningless. Why not just put 1.3 in the conf file?\n\nThis mapping means we have to create a new element in the dictionary for each release.","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"8a61fd8b78288ae6e387ca28c1f675ff79c27c53","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":50,"context_line":"        # this is the default in trove/common/cfg.py"},{"line_number":51,"context_line":"        \u0027master\u0027: {"},{"line_number":52,"context_line":"            API_TASKMANAGER: API_CURRENT_TASKMANAGER_VERSION,"},{"line_number":53,"context_line":"            API_GUESTAGENT: API_CURRENT_GUESTAGENT_VERSION,"},{"line_number":54,"context_line":"            API_CONDUCTOR: API_CURRENT_CONDUCTOR_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_11505a31","line":51,"in_reply_to":"3a98d1f4_d1ec32bd","updated":"2016-10-03 19:03:51.000000000","message":"This is done to be similar to the rest of Openstack.","commit_id":"6db61b3e7fd15ee8b735746f0bb095cd080137fe"}]}