)]}'
{"id":"openstack%2Ftrove~388406","triplet_id":"openstack%2Ftrove~master~I0f6052b037ab62644b5e036ddf925b7e24636ba5","project":"openstack/trove","branch":"master","topic":"bug/1634755","hashtags":[],"change_id":"I0f6052b037ab62644b5e036ddf925b7e24636ba5","subject":"Fix an error about line_terminator","status":"ABANDONED","created":"2016-10-19 06:18:56.000000000","updated":"2016-12-28 03:37:27.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"068005503beff0e2197a2b983ca65c40e67bb080","_number":388406,"virtual_id_number":388406,"owner":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2016-12-28 03:37:27.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":1,"date":"2016-10-19 08:36:15.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-10-19 18:31:16.000000000","_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":-1,"date":"2016-10-19 18:26:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-19 08:36:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-10-19 18:26:02.000000000","updated_by":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"reviewer":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"state":"REVIEWER"},{"updated":"2016-12-28 03:37:27.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"}],"messages":[{"id":"b3b52613597e495d3056df41165a1cc1fdff26fb","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-10-19 06:18:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"70145a6e92344644101b3951a35a91572948b22a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-19 08:36:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-trove-docs-ubuntu-xenial http://docs-draft.openstack.org/06/388406/1/check/gate-trove-docs-ubuntu-xenial/bcde3f6//doc/build/html/ : SUCCESS in 2m 25s\n- gate-trove-pep8-ubuntu-xenial http://logs.openstack.org/06/388406/1/check/gate-trove-pep8-ubuntu-xenial/8f2e54e/ : SUCCESS in 2m 17s\n- gate-trove-python27-db-ubuntu-xenial http://logs.openstack.org/06/388406/1/check/gate-trove-python27-db-ubuntu-xenial/2e466b8/ : SUCCESS in 5m 40s\n- gate-trove-python34-db http://logs.openstack.org/06/388406/1/check/gate-trove-python34-db/d509e6b/ : SUCCESS in 9m 57s\n- gate-trove-python35-db http://logs.openstack.org/06/388406/1/check/gate-trove-python35-db/17d2a42/ : SUCCESS in 10m 31s\n- gate-trove-legacy-functional-dsvm-mysql http://logs.openstack.org/06/388406/1/check/gate-trove-legacy-functional-dsvm-mysql/2a770cb/ : SUCCESS in 1h 01m 41s\n- gate-tempest-dsvm-trove http://logs.openstack.org/06/388406/1/check/gate-tempest-dsvm-trove/1288db8/ : SUCCESS in 15m 38s (non-voting)\n- gate-trove-legacy-scenario-functional-dsvm-mariadb-nv http://logs.openstack.org/06/388406/1/check/gate-trove-legacy-scenario-functional-dsvm-mariadb-nv/caf516e/ : FAILURE in 2h 17m 06s (non-voting)\n- gate-trove-legacy-scenario-functional-dsvm-mysql http://logs.openstack.org/06/388406/1/check/gate-trove-legacy-scenario-functional-dsvm-mysql/19f4b6c/ : SUCCESS in 1h 17m 22s\n- gate-trove-legacy-scenario-functional-dsvm-postgresql http://logs.openstack.org/06/388406/1/check/gate-trove-legacy-scenario-functional-dsvm-postgresql/cc13ee7/ : SUCCESS in 1h 15m 40s\n- gate-trove-legacy-scenario-functional-dsvm-pxc http://logs.openstack.org/06/388406/1/check/gate-trove-legacy-scenario-functional-dsvm-pxc/dbc8931/ : SUCCESS in 1h 18m 35s\n- gate-trove-legacy-scenario-functional-dsvm-redis http://logs.openstack.org/06/388406/1/check/gate-trove-legacy-scenario-functional-dsvm-redis/dc29f47/ : SUCCESS in 1h 05m 12s\n- gate-trove-tox-db-fakemodetests-ubuntu-xenial http://logs.openstack.org/06/388406/1/check/gate-trove-tox-db-fakemodetests-ubuntu-xenial/a036066/ : SUCCESS in 5m 13s\n- gate-trove-tox-db-apiexamples-ubuntu-xenial http://logs.openstack.org/06/388406/1/check/gate-trove-tox-db-apiexamples-ubuntu-xenial/20de30d/ : SUCCESS in 3m 53s\n- gate-trove-tox-pylint-ubuntu-xenial http://logs.openstack.org/06/388406/1/check/gate-trove-tox-pylint-ubuntu-xenial/e92621d/ : SUCCESS in 5m 30s","accounts_in_message":[],"_revision_number":1},{"id":"150745d811f801be0331e697a0b8dd8d05082c87","author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"date":"2016-10-19 18:26:02.000000000","message":"Patch Set 1: Code-Review-1\n\nThe idea is good, but this will change the behaviour of the callers that use the default value.  Have a look in trove/guestagent/module/drivers/new_relic_license_driver.py and trove/guestagent/module/drivers/ping_driver.py, they should be both updated to use the old default value.","accounts_in_message":[],"_revision_number":1},{"id":"47116c89b593138260d649aea524ecaf4b91a372","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-10-19 18:31:16.000000000","message":"Patch Set 1:\n\n\u003e The idea is good, but this will change the behaviour of the callers\n \u003e that use the default value.  Have a look in trove/guestagent/module/drivers/new_relic_license_driver.py\n \u003e and trove/guestagent/module/drivers/ping_driver.py, they should be\n \u003e both updated to use the old default value.\n\nthx,I\u0027ll take a look","accounts_in_message":[],"_revision_number":1},{"id":"239d37512e805bd2e3915b0a6f3bf3b35ec2b945","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-10-19 18:55:26.000000000","message":"Patch Set 1: Workflow-1\n\nWaiting for the modified complete test tomorrow...","accounts_in_message":[],"_revision_number":1},{"id":"e3845c791588d61c7fac1ef1faf1af0918241cfd","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-10-20 05:23:25.000000000","message":"Patch Set 1: -Workflow\n\n\u003e The idea is good, but this will change the behaviour of the callers\n \u003e that use the default value.  Have a look in trove/guestagent/module/drivers/new_relic_license_driver.py\n \u003e and trove/guestagent/module/drivers/ping_driver.py, they should be\n \u003e both updated to use the old default value.\n\nI carefully wanted to think... If under Linux, use \"\\ n\" as a parameter is enough... Because all the tests have been passed... Not quite understand why the \\r\\n in operating_system error reasons but in the other\u0027s pass test...","accounts_in_message":[],"_revision_number":1},{"id":"44e6bc85aeb62445994bf30fe9ff40c9198a65d1","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-12-28 03:37:27.000000000","message":"Patch Set 1:\n\n\"abandoned for inactivity, over 3 weeks old, has a negative review comment and is not currently marked as a WIP or WF-1. please restore the change if you wish to work on it.\"","accounts_in_message":[],"_revision_number":1},{"id":"432af2f71fa290982360d9cc60364d56a389e3a4","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-12-28 03:37:27.000000000","message":"Abandoned\n\n\"abandoned for inactivity, over 3 weeks old, has a negative review comment and is not currently marked as a WIP or WF-1. please restore the change if you wish to work on it.\"","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0bf19863c71bad4797c50cdfc393834a29a85064","revisions":{"0bf19863c71bad4797c50cdfc393834a29a85064":{"kind":"REWORK","_number":1,"created":"2016-10-19 06:18:56.000000000","uploader":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"ref":"refs/changes/06/388406/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/trove","ref":"refs/changes/06/388406/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/trove refs/changes/06/388406/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/trove refs/changes/06/388406/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/trove refs/changes/06/388406/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/trove refs/changes/06/388406/1"}}},"commit":{"parents":[{"commit":"a8adac9456521f8498898d6abc3a3b291bf5f773","subject":"Merge \"PostgreSQL guest_log test fails intermittently\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/a8adac9456521f8498898d6abc3a3b291bf5f773"}]}],"author":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-10-19 06:04:37.000000000","tz":-420},"committer":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-10-19 06:04:37.000000000","tz":-420},"subject":"Fix an error about line_terminator","message":"Fix an error about line_terminator\n\nIn Linux /n as a newline, and Windows is /r/n, so I will be the\ndefault value is set to/n line_terminator, in fact, the most intuitive\nis solved test_operating_system.TestOperatingSystem.test_key_value_file\n_codec problem.\n\nbefore change:http://paste.openstack.org/show/585902/\nafter change:http://paste.openstack.org/show/586319/\n\nCloses-Bug #1634755\n\nChange-Id: I0f6052b037ab62644b5e036ddf925b7e24636ba5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/0bf19863c71bad4797c50cdfc393834a29a85064"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/0bf19863c71bad4797c50cdfc393834a29a85064"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}